Commit Graph

1189 Commits

Author SHA1 Message Date
csoler
1ebcc6006b Merge pull request #861 from RetroShare/v0.6-GxsTransport
V0.6 gxs transport
2017-05-30 22:22:06 +02:00
csoler
0868b64436 fixed uninitialized memory read in GxsTrans msg Id 2017-05-28 22:49:07 +02:00
sehraf
a3ee85a30d Add I2P BOB support to libretroashare and RetroShare GUI 2017-05-24 19:40:01 +02:00
Enno Boland
2046d9eaae fix building with libressl 2017-05-21 10:48:58 +02:00
csoler
c0c5cc52db Merge branch 'master' into gxs_mail_experiments 2017-05-13 21:08:16 +02:00
Phenom
4a2f688f14 Fix Windows Compilation:
pqi/authssl.cc: In member function 'virtual X509*
AuthSSLimpl::SignX509ReqWithGPG(X509_REQ*, long int)':
pqi/authssl.cc:929:3: error: jump to label 'err' [-fpermissive]
   err:
   ^
pqi/authssl.cc:872:22: error:   from here [-fpermissive]
                 goto err;
                      ^
pqi/authssl.cc:877:24: error:   crosses initialization of 'unsigned
char* p'
         unsigned char *p=buf_in;
                        ^
pqi/authssl.cc: In member function 'virtual bool
AuthSSLimpl::AuthX509WithGPG(X509*, uint32_t&)':
pqi/authssl.cc:1091:1: error: jump to label 'err' [-fpermissive]
 err:
 ^
pqi/authssl.cc:1027:8: error:   from here [-fpermissive]
   goto err;
        ^
pqi/authssl.cc:1035:17: error:   crosses initialization of 'unsigned
char* p'
  unsigned char *p=buf_in;
                 ^
2017-05-08 13:01:34 +02:00
Phenom
91e3cc3e5f Fix Warnings: variable ‘p’ set but not used
warning: variable ‘p’ set but not used [-Wunused-but-set-variable]
  unsigned char *p,*buf_in=NULL;
                 ^
2017-05-08 12:11:48 +02:00
Phenom
ca291b7ee6 Fix Warnings: warning: unused variable ‘i2d’
warning: unused variable ‘i2d’ [-Wunused-variable]
  int (*i2d)(X509_CINF*, unsigned char**) = i2d_X509_CINF;
        ^~~
2017-05-08 12:05:58 +02:00
Phenom
9021609a6b Fix Warnings: unused variable ‘p’
warning: unused variable ‘p’ [-Wunused-variable]
         unsigned char *p,*buf_in=NULL;
                        ^
2017-05-08 12:04:08 +02:00
Gioacchino Mazzurco
5159e326c7 Merge branch 'master' into gxs_mail_experiments 2017-05-05 15:44:22 +02:00
csoler
4bee52c406 removed old unused serialization code 2017-05-02 22:34:45 +02:00
csoler
99d8b7d5d8 switched service control items to new serialization 2017-05-01 21:23:34 +02:00
csoler
cecd9a3368 merged upstream/master 2017-04-30 20:14:23 +02:00
csoler
24c7c38016 removed old file rssrviceserialiser.h/cc 2017-04-30 20:08:30 +02:00
csoler
14076de1e0 moved code of rsservicerserialiser into rsserializer.h/cc and renamed it into RsRawSerializer 2017-04-30 19:17:44 +02:00
csoler
77c2e6da8c improved error handlign in pqistore 2017-04-26 18:14:10 +02:00
csoler
9c610a736d cleaned the hierarchy of serialization classes 2017-04-26 11:40:46 +02:00
csoler
77e809ea4b switched GRouter to new serialization 2017-04-25 21:21:46 +02:00
Phenom
3592d5bf5d Fix GCC warnings: unused parameter ‘names’
/libretroshare/src/pqi/pqiservice.h:80: warning: unused parameter
‘names’ [-Wunused-parameter]
     virtual void getItemNames(std::map<uint8_t,std::string>& names)
const {} // This does nothing by default. Service should derive it in
order to give info for the UI
                                                              ^~~~~
2017-04-25 09:53:06 +02:00
csoler
0d7df568b4 moved rsconfigitems and rshistoryitems to rsitems/ 2017-04-24 22:47:08 +02:00
csoler
fcabe6359f switch RsConfigItems to new serialization 2017-04-24 18:51:51 +02:00
csoler
f6aaee7382 converted RTT items to new serialization 2017-04-24 11:01:45 +02:00
csoler
5f8bf03dfe added mechanism to allow services to document the names of their items, and improved bandwidth graph to show names for GXS services. Other services still need to supply their own names 2017-04-20 20:54:51 +02:00
csoler
e2d9152b22 moved converted serialisation files into new directory rsitems/, leaving serialiser/ for the serialisation classes 2017-04-18 21:11:37 +02:00
Phenom
e83104ee0f Fix Clang warnings: Add author and date to #warning 2017-04-17 21:32:14 +02:00
Phenom
22043094b5 Fix Clang warnings: extraneous parentheses
warning: equality comparison with extraneous parentheses [-Wparentheses-
equality]
                else if ((err == ECONNREFUSED))
                          ~~~~^~~~~~~~~~~~~~~
2017-04-17 21:26:50 +02:00
Phenom
dc533b1346 Fix Clang warnings: private field not used
warning: private field 'lastGroupId' is not used [-Wunused-private-
field]
    uint32_t lastGroupId;
warning: private field 'waittimes' is not used [-Wunused-private-field]
        int waittimes;
warning: private field 'listen_checktime' is not used [-Wunused-private-
field]
        long listen_checktime;
2017-04-17 21:26:09 +02:00
Phenom
65321501e4 Fix Clang warnings: Overloaded vf hide in p3dhtmgr
warning: 'p3DhtMgr::findPeer' hides overloaded virtual function [-
Woverloaded-virtual]
virtual bool    findPeer(std::string id);
warning: 'p3DhtMgr::dropPeer' hides overloaded virtual function [-
Woverloaded-virtual]
virtual bool    dropPeer(std::string id);
warning: 'p3DhtMgr::getPeerStatus' hides overloaded virtual function [-
Woverloaded-virtual]
virtual bool    getPeerStatus(std::string id,
2017-04-17 21:24:45 +02:00
Phenom
6fecac5f7b Fix Clang warnings: Overloaded vf hide
warning: 'pqiconnect::connect_parameter' hides overloaded virtual
function [-Woverloaded-virtual]
        virtual bool connect_parameter(uint32_t type, std::string value)
{ return ni->connect_parameter(type, value);}
                     ^
2017-04-17 21:15:52 +02:00
Phenom
105840ab98 Fix Clang Warning: Overloaded vf hide
warning: 'pqiConnectCbDummy::peerConnectRequest' hides overloaded
virtual function [-Woverloaded-virtual]
virtual void    peerConnectRequest(const RsPeerId& id,
                ^
2017-04-17 21:10:22 +02:00
Gioacchino Mazzurco
2630ed4573 Merge branch 'master' into gxs_mail_experiments 2017-03-13 22:57:33 +01:00
cyril soler
69c3df6dff fixed bug in total item size estimation in pqiqosstreamer due to item slicing 2017-03-10 15:36:50 +01:00
cyril soler
fd84639a45 removed some debug info 2017-03-10 15:05:41 +01:00
csoler
ee9fbefd76 added signal blockign trick for widgets, and fixed the bug causing wrong values to be displayed in server settings 2017-02-27 22:29:01 +01:00
Gioacchino Mazzurco
9a3af092eb Merge branch 'master' into gxs_mail_experiments 2017-02-27 08:43:29 +01:00
csoler
99cf69a98c Merge pull request #703 from RetroShare/v0.6-ImprovedGUI
V0.6 improved gui
2017-02-26 20:14:34 +01:00
csoler
eb817af9b8 Merge pull request #689 from csoler/v0.6-SSL110Fix
fixing compilation with openssl-1.1.0 (part 1)
2017-02-26 20:12:52 +01:00
csoler
e75487e48a suppressed a few warnings (suggested by Phenom) 2017-02-25 23:16:43 +01:00
Gioacchino Mazzurco
748e75d3e1 Fix pqiSSLstore::encryptedSendItems empty list
RsTemporaryMemory was complaining of being initialized with size 0 in
case of empty list was passed to the method, this is a legitimate use
case when one want have an empty list as state, so in this case pass 1
as argument to RsTemporaryMemory constructor
2017-02-25 23:09:46 +01:00
Gioacchino Mazzurco
828792f2b5 p3Config improved coding style 2017-02-23 13:20:07 +01:00
csoler
0e57874ad3 fixed loading of settings::Server page 2017-02-22 22:22:50 +01:00
csoler
8c3f553579 fixed compilation with openssl1.0.1 broken by previous commits 2017-02-20 22:54:25 +01:00
csoler
5c95b88095 compilation fix for openssl-1.1.0 (pqissl+authssl part) 2017-02-19 22:38:02 +01:00
csoler
ccacba797f added pgp passphrase temporary caching in order to avoid re-asking for password at location creation time 2017-02-12 15:27:13 +01:00
jolavillette
1b8de7b30e Attempt to reduce BW bursts 2017-01-18 13:25:45 +01:00
csoler
d3051eff1a added display of usage statistics for GXS identities 2016-12-21 00:34:07 +01:00
Phenom
674b6de381 Fix Some gcc warnings 383 to 208 lines
Left explicit #warning and deprecated.
Some lines are wrong indented and produce mal formed code.
2016-11-30 22:01:01 +01:00
Gio
8ab3c7de26 Merge branch 'master' into android 2016-11-07 14:37:23 +01:00
BuildTools
78d6735b52 Create 2 #define in pqistreamer to easily disable packet slicing/grouping 2016-11-05 19:58:06 +01:00
BuildTools
192cbe1eda Create two #define in pqistreamer.cc to easily disable packet slicing and/or grouping 2016-11-05 14:57:39 +01:00
Gio
ea42d822c2 Merge branch 'master' into android 2016-10-26 13:43:24 +02:00
csoler
e42dae8f78 continue sending packet slicing probes in case the peer has restarted 2016-10-04 21:34:23 +02:00
csoler
b08a62afc9 restored delay between location cleaning to 5 mins 2016-10-04 21:25:56 +02:00
csoler
133676fdee simplified the code to remove old locations and fixed bug that in some situation would let a PGP key with no locations 2016-10-04 21:25:56 +02:00
csoler
c968490b43 switched to floating point time for bandwidth estimation in pqistreamer. Helps a lot RTTs since rounding to int prveviously caused packets to be delayed up to 1 sec (improvement by Jollavilette) 2016-10-01 22:15:06 +02:00
cyril soler
7bddd4bcd4 removed call to exit causing the software to stop when local network interfaces are not ready 2016-09-23 13:19:19 +02:00
Gio
48a9be0ccc Use Qt to read the local addresses on android
getifaddrs is not present on android and an alternative implementation
crashed, use QNetworkInterface::allAddresses() to retrieve local
addresses list instead

This
2016-09-21 12:46:55 +02:00
Gio
9d83d56811 Merge branch 'master' into android 2016-09-04 15:16:57 +02:00
Gio
7a2ae6e979 Remove some clutter from libretroshare
Removed SearchInterface that was an historical remain that make no sense anymore
Fixed some clang warning
Fix includes on some files
2016-08-25 11:39:15 +02:00
Gio
68a00138d2 Avoid usage of deprecated function RSA_generate_key that make android
compiler mad
2016-08-23 12:15:28 +02:00
Gio
9a980def2c libretroshare now compiles for Android, instruction on how to do it included 2016-08-23 12:15:28 +02:00
dimqua
613ce25209 Change I2P proxy default port to 4447 2016-08-19 09:47:52 +04:00
Phenom
275c47eff9 Add Title when ask for password. 2016-08-09 01:22:14 +02:00
Phenom
d59f7a09db Fix NAT Status LED
Fix the PR#426 4d2d825d
2016-08-08 21:59:12 +02:00
csoler
a69629cf73 added missing own id from group list, and removed possible duplicates in random group ids 2016-07-06 22:16:05 -04:00
csoler
269f9457be fixed load/save of new group ids and backward compatibility with FriendList 2016-07-06 22:02:56 -04:00
csoler
01c0d2f0f1 finished conversion to RsNodeGroupId for file transfer and GUI 2016-07-05 23:49:43 -04:00
csoler
4ee9effc4e changed internal storage of groups of friend nodes so as to use an abstract ID instead of a string (phase 1 of local circles) 2016-07-04 23:55:48 -04:00
Cyril Soler
c15c979851 Merge pull request #426 from sehraf/pr-disable-dht-stunner
This patch set adds an option to use the DHT stunner to qmake
2016-06-27 17:17:28 +01:00
csoler
ff8667834b clear error queue before calling SSL_read()/SSL_write(), to avoid remaining errors to corrupt the next connection attempts and cause disconnections 2016-06-26 23:14:01 -04:00
csoler
31089d7a91 added auto-clean of pending data in pqistreamer after connection is closed, to avoid confusing the peer after re-connecting (probably not the cause of the SSL errors we see) 2016-06-25 19:12:47 +01:00
sehraf
5d962682e1 removed unused variable warnings 2016-06-21 14:02:52 +02:00
sehraf
4d2d825d5b add new option to qmake to enable dht stunner
removed dht stunner code when option is not set
2016-06-21 13:55:23 +02:00
Cyril Soler
90a27f4e81 Merge pull request #418 from sehraf/pr-improve-debug
This is the first set of patches to improve RS' logging functionality
2016-06-18 15:33:10 -04:00
sehraf
09afbbed5d switched to new rslog method 2016-06-18 13:00:15 +02:00
csoler
dbd78d2401 merged with upstream/master 2016-06-16 20:19:03 -04:00
csoler
6b74a8a1b6 added missing call to ssl_pendign in pqissludp. 2016-06-14 21:54:24 -04:00
csoler
8c44e69012 added output of items which doesnot serialise correctly in pqisslstore 2016-06-14 21:54:24 -04:00
csoler
972de42864 converted static variable to class member in pqihandler 2016-06-11 18:07:57 -04:00
Cyril Soler
248d0c42d3 Merge pull request #412 from csoler/v0.6-MaxUpRate
V0.6 max up rate
2016-06-11 17:58:08 -04:00
csoler
ef4455ac9c cleaned the MaxUpRate branch from unused code 2016-06-11 17:54:11 -04:00
csoler
8e75185060 made avgReadCount and avgSendCound to be uint32_t instead of floats, since they count bytes. Changes kb to 1024 instead of 1000 2016-06-11 17:21:04 -04:00
csoler
373d41bc63 added missing variable def after previous commit 2016-06-11 14:11:21 -04:00
csoler
23e8e932be added mutex proteciton around mAvgLastUpdate to avoid it being changed by the constructor 2016-06-11 09:50:22 -04:00
csoler
0d1d31a25f added mutex protection around pqistreamer::getRates, since float r/w are not necessarily atomic 2016-06-11 09:33:16 -04:00
csoler
83a143476e fixed bug in setting MaxRate values 2016-06-09 23:23:51 -04:00
csoler
f5ad8b49be moved node-wide options to node details 2016-06-09 23:13:07 -04:00
csoler
a4931edee0 fixed setting/getting maxrates using pgp id 2016-06-09 20:51:09 -04:00
csoler
a07805be1d moved bandwidth limits to the pgp level 2016-06-09 20:41:27 -04:00
csoler
38b86c37ab improved debug output for early address rejection 2016-06-09 18:12:04 -04:00
csoler
6b78275677 fixed bug in loading config file to set max rates 2016-06-08 22:54:40 -04:00
csoler
5a0fa66ac0 added proper talking between pqihandler and GUI for maxrates fixing 2016-06-08 22:44:28 -04:00
csoler
509266a25b removed some dead code 2016-06-07 22:38:24 -04:00
csoler
20b6745f70 added GUI and storage for max up/dn rates per peer 2016-06-07 21:48:22 -04:00
csoler
927f782bef pass over compiler warnings 2016-06-05 10:43:57 -04:00
csoler
53eb4dfb12 fixed compilation errors due to last merge operation 2016-06-02 21:21:18 -04:00
csoler
e2b5785eec merged PR403 with trunk 2016-06-02 21:15:51 -04:00
csoler
10e0254317 fixed a few things to correct PR403 2016-06-02 20:38:33 -04:00
Cyril Soler
2f4f44ee48 added early discarding of incoming connection attempt (before SSL handshake) for blacklisted IPs 2016-06-02 09:37:01 -04:00
sehraf
4f60c8cc9b libretroshare: fix comparison between signed and unsigned integer 2016-06-02 14:54:23 +02:00
sehraf
8b788b2aa8 libretroshare: fix member initialisation order 2016-06-02 14:54:16 +02:00
sehraf
cfc0e7071a libretroshare: remove unused variables 2016-06-02 14:54:07 +02:00
sehraf
bc23c2f7b9 add thread names for peers 2016-06-01 16:33:13 +02:00
sehraf
f16ee97093 add static thread names 2016-06-01 16:21:55 +02:00
Phenom
af5129c26d Fix Mutex in pqipersongrp for pqilistener by adding local Mutex. 2016-05-18 19:15:37 +02:00
Cyril Soler
f3aed813af added test over signature size to avoid possible memory corruption (Anonymous source) 2016-05-17 10:39:56 -04:00
Phenom
a1ece16f35 Fix uninitialized variables netsize, rsnetsize in p3netmgr.cc 2016-05-12 20:00:44 +02:00
Cyril Soler
e891e2be2e added missing check for ssl_connection that would cause crash when the ssl connection gets closed by another thread 2016-05-11 10:00:20 -04:00
csoler
b5ace406b9 attempt to fix socket problem on 32bits/64bits windows, by using the proper SOCKET type instead of int 2016-05-05 21:40:29 -04:00
csoler
ca003c5f9e added missing initialisation of deleted memory before calling realloc 2016-05-03 20:55:50 -04:00
csoler
aec8b4d27c fixed bug in counting of incoming data size for sliced packets 2016-05-02 18:10:39 -04:00
csoler
01605e5a59 updated description f packet slicing in comments section of pqistreamer 2016-04-30 11:19:21 -04:00
csoler
1f7a94d49e fixed bug causing crash in pqistreamer 2016-04-30 11:13:51 -04:00
csoler
4bdd464861 removed a few debug output and timer measurement 2016-04-29 18:53:25 -04:00
csoler
3bc3989e79 removed debug info for pqistreamer 2016-04-29 18:41:10 -04:00
csoler
654e0fc1d8 added missing call to SSL_pending, which caused decrypted data to wait in the SSL buffer when the bio is not receiving anything more 2016-04-29 17:53:21 -04:00
csoler
87764abe4c removed debug info in pqistreamer 2016-04-26 21:23:19 -04:00
csoler
153db5ca64 added on/off mechanism for packet slicing to ensure packward compatibility 2016-04-26 09:22:24 -04:00
csoler
3b685851d2 improved/simplified slicing protocol 2016-04-25 23:37:02 -04:00
csoler
dd81ce3bf3 using BinToHex to display mem blocks in pqistreamer debug 2016-04-25 22:50:41 -04:00
csoler
18e9e1c2db moerged with upstream/master 2016-04-24 21:29:55 -04:00
csoler
f62957534e fixed a few bugs in packet slicing in pqiQoS 2016-04-24 21:18:44 -04:00
csoler
a2c11f97c2 added packet reconstruction and deserialising 2016-04-24 13:43:34 -04:00
csoler
cad8c89746 added packet slicing in pqistreamer 2016-04-23 17:10:25 -04:00
csoler
10230dff6e added missing SSL shutdown when replacing existing connection 2016-04-22 16:50:43 -04:00
csoler
e82c217cd2 half-implemented packet slicing (QoS part done) 2016-04-20 22:42:09 -04:00
csoler
057249225e severely reduced packet grouping, which limited the effectiveness of QoS 2016-04-20 21:20:47 -04:00
csoler
fc725b03a8 added some debug info to pqistreamer 2016-04-19 22:04:30 -04:00
csoler
26af7c900e changed heart beat limit to a larger value. Apparently too tight a value causes disconnections due to packets being stuck sometimes (old bug) 2016-04-17 22:58:48 -04:00
Cyril Soler
a52bd98d4b fixed potential div by 0 in speed estimations. To be tested. 2016-04-11 10:10:10 -04:00
csoler
a5044bd71c improved calculation of speed in pqistreamer (was called before only when sending bytes), and prevented situation where no HB is received by the connection is not reset because last HB is 0, causing ghost connected peers in GUI 2016-04-09 14:48:05 -04:00
csoler
3554e48c7e output packet error with some details (inspired by Phenom-PR289) 2016-04-03 11:38:53 -04:00
csoler
9d9b790a3e exposed un-verified PGP signatures on GXS ids in GUI. Added auto-ban of GXS ids signed by a PGP ids that has already signed a large enough set of GXS ids. Still needs some GUI to change the threshold. 2016-04-02 16:14:18 -04:00
Phenom
c6f1cc4e63 Clear WebAPI when clear chat history in GUI.
Move notifyChatCleared call to p3ChatService
To maintain notify direction.
2016-03-31 22:52:53 +02:00
zeners
aca88308ea compatible to g++11 / QT5
method suggested by cyril
2016-03-29 21:22:14 +02:00
csoler
bb260696ce attempt at fixing negative bw rates in GUI that may pop up when an error is present in the SSL stream (e.g. when a peer disconnects/reconnects) 2016-03-02 19:00:51 -05:00
sehraf
dbdfdcd008 removed unused map lookups 2016-02-22 21:09:10 +01:00
sehraf
77166cbf13 impoved cleanup of unused locations 2016-02-22 16:41:31 +01:00
sehraf
4140969fcb added seperated limit for discovery (30 days) 2016-02-19 16:35:11 +01:00
sehraf
841299d077 discovery: don't remove new added locations too soon
was: removed after 10 min. or less - when no connection is established
now: removed after 1 day - when no connection is established
2016-02-16 20:33:38 +01:00
Cyril Soler
3ab7c89660 Merge pull request #279 from cavebeat/single_dh_op
added openSSL option SSL_OP_SINGLE_DH_USE regarding CVE-2016-0701
2016-02-14 13:33:27 -05:00
cave beat
9843c8381b added openSSL option SSL_OP_SINGLE_DH_USE regarding CVE-2016-0701
tl;dr The OpenSSL 1.0.2 releases suffer from a Key Recovery Attack on DH small subgroups. This issue got assigned CVE-2016-0701 with a severity of High and OpenSSL 1.0.2 users should upgrade to 1.0.2f. If an application is using DH configured with parameters based on primes that are not "safe" or not Lim-Lee (as the one in RFC 5114) and either Static DH ciphersuites are used or DHE ciphersuites with the default OpenSSL configuration (in particular SSL_OP_SINGLE_DH_USE is not set) then is vulnerable to this attack.
2016-02-14 18:49:37 +01:00
electron128
821c14426c remove dead code from RsNotify (old forum and channel read status changed notify) 2016-02-14 12:48:52 +01:00
electron128
63a8260cb9 change RsNotify to use RsGxsId for chat lobby events 2016-02-14 11:53:27 +01:00
csoler
3bc444b087 removed some debug info 2016-01-26 23:00:10 -05:00
csoler
39b3df964a fixed bug causing net reset when closing config 2016-01-25 22:39:20 -05:00
csoler
9b64b96811 fixed potential crash in pqisslstore 2016-01-23 13:04:02 -05:00
thunder2
748147f73b Fixed Windows compile. 2016-01-15 21:41:23 +01:00
Cyril Soler
96f3446aa7 added size limit to packet grouping 2016-01-13 11:13:23 -05:00
Cyril Soler
b56881e6d9 fixed windows compilation 2016-01-13 10:23:21 -05:00