Commit Graph

13276 Commits

Author SHA1 Message Date
Gioacchino Mazzurco
ab80d9a374
Fix compilation, retrocompatibility and enums
Workaround miss-behaviour on old Android phones
Cleanup indentation a bit
Consistent param naming
Introduce default parameter values also for output paramethers
2019-04-05 01:43:23 +02:00
Phenom
5ab75d0308 Fix AppVeyor build 2019-04-04 23:53:05 +02:00
csoler
61aeae67ea
disable auto-ban identities for own IDs 2019-04-04 22:52:25 +02:00
csoler
db9d202ab7
fixed missign read-only flag on identity info display 2019-04-04 22:41:02 +02:00
Phenom
5cb5954882 Fix clang warning for
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
1266:13: warning: function 'recursPrintModel' is not needed and will not
be emitted [-Wunneeded-internal-declaration]
static void recursPrintModel(const std::vector<ForumModelPostEntry>&
entries,ForumModelIndex index,int depth)
            ^
2019-04-04 21:20:25 +02:00
Phenom
d96b9b054b Fix clang warnings for
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
106:53: warning: unused parameter 'parent' [-Wunused-parameter]
int RsGxsForumModel::columnCount(const QModelIndex &parent) const
                                                    ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:245:3:
warning: add explicit braces to avoid dangling else [-Wdangling-else]
                else
                ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
248:12: warning: comparison of integers of different signs: 'int' and
'std::vector::size_type' (aka 'unsigned long') [-Wsign-compare]
    if(row >= mPosts[entry].mChildren.size())
       ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
299:67: warning: unused parameter 'orientation' [-Wunused-parameter]
QVariant RsGxsForumModel::headerData(int section, Qt::Orientation
orientation, int role) const
                                                                  ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
398:77: warning: unused parameter 'column' [-Wunused-parameter]
QVariant RsGxsForumModel::textColorRole(const ForumModelPostEntry&
fmpe,int column) const
                                                                            ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
419:74: warning: unused parameter 'column' [-Wunused-parameter]
QVariant RsGxsForumModel::filterRole(const ForumModelPostEntry& fmpe,int
column) const
                                                                         ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
498:75: warning: unused parameter 'column' [-Wunused-parameter]
QVariant RsGxsForumModel::missingRole(const ForumModelPostEntry&
fmpe,int column) const
                                                                          ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
540:74: warning: unused parameter 'column' [-Wunused-parameter]
QVariant RsGxsForumModel::pinnedRole(const ForumModelPostEntry& fmpe,int
column) const
                                                                         ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
548:78: warning: unused parameter 'column' [-Wunused-parameter]
QVariant RsGxsForumModel::backgroundRole(const ForumModelPostEntry&
fmpe,int column) const
                                                                             ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
806:111: warning: unused parameter 'useChildTS' [-Wunused-parameter]
void RsGxsForumModel::convertMsgToPostEntry(const RsGxsForumGroup&
mForumGroup,const RsMsgMetaData& msg, bool useChildTS,
ForumModelPostEntry& fentry)
                                                                                                              ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:828:7:
warning: unused variable 'redacted' [-Wunused-variable]
        bool redacted = false;
             ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:880:6:
warning: unused variable 'pos' [-Wunused-variable]
        int pos = 0;
            ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:879:6:
warning: unused variable 'count' [-Wunused-variable]
        int count = msgs.size();
            ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:882:6:
warning: unused variable 'step' [-Wunused-variable]
        int step = 0;
            ^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
949:26: warning: comparison of integers of different signs: 'int32_t'
(aka 'int') and 'std::vector::size_type' (aka 'unsigned long') [-Wsign-
compare]
        for(int32_t i=0;i<v.size();++i)
                        ~^~~~~~~~~
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
959:23: warning: comparison of integers of different signs: 'int32_t'
(aka 'int') and 'std::vector::size_type' (aka 'unsigned long') [-Wsign-
compare]
                                        for(int32_t j=0;j<it2-
>second.size();++j)
                                                        ~^~~~~~~~~~~~~~~~~~~
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
991:26: warning: comparison of integers of different signs: 'int32_t'
(aka 'int') and 'std::vector::size_type' (aka 'unsigned long') [-Wsign-
compare]
        for(int32_t i=1;i<it->second.size();++i)
                        ~^~~~~~~~~~~~~~~~~~
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
1005:22: warning: comparison of integers of different signs: 'int' and
'std::vector::size_type' (aka 'unsigned long') [-Wsign-compare]
        for(int i=1;i<it->second.size();++i)
                    ~^~~~~~~~~~~~~~~~~~
../../../trunk/retroshare-gui/src/gui/gxsforums/
GxsForumThreadWidget.cpp:1038:13: warning: unused function
'cleanupItems' [-Wunused-function]
static void cleanupItems (QList<QTreeWidgetItem *> &items)
            ^
2019-04-04 21:20:25 +02:00
Phenom
07a31ee5f5 Fix clang warning for
../../../trunk/retroshare-gui/src/gui/People/IdentityWidget.cpp:111:10:
warning: explicitly assigning value of variable of type 'QImage' to
itself [-Wself-assign-overloaded]
                        image = image;
                        ~~~~~ ^ ~~~~~
2019-04-04 21:20:25 +02:00
Phenom
bc8d2a79c0 Fix clang warning for
../../../trunk/libretroshare/src/gxs/rsgxsutil.cc:150:23: warning:
unused parameter 'serializer' [-Wunused-parameter]
        RsSerialType& serializer, RsGixs* gixs ) :
                      ^
2019-04-04 21:20:25 +02:00
Phenom
78f9bbfd75 Fix clang warning for
../../../trunk/libretroshare/src/pqi/authssl.cc:57:16: warning: unused
variable 'RS_SSL_HANDSHAKE_DIAGNOSTIC_KEY_ALGORITHM_NOT_ACCEPTED' [-
Wunused-const-variable]
const uint32_t RS_SSL_HANDSHAKE_DIAGNOSTIC_KEY_ALGORITHM_NOT_ACCEPTED  =
0x08 ;
               ^
2019-04-04 21:20:25 +02:00
Phenom
b2c5965950 Fix clang warning for
../../../trunk/libretroshare/src/ft/ftserver.cc:1230:23: warning: unused
variable 'ENCRYPTED_FT_INITIALIZATION_VECTOR_SIZE' [-Wunused-const-
variable]
static const uint32_t ENCRYPTED_FT_INITIALIZATION_VECTOR_SIZE = 12 ;
                      ^
../../../trunk/libretroshare/src/ft/ftserver.cc:1231:23: warning: unused
variable 'ENCRYPTED_FT_AUTHENTICATION_TAG_SIZE' [-Wunused-const-
variable]
static const uint32_t ENCRYPTED_FT_AUTHENTICATION_TAG_SIZE    = 16 ;
                      ^
../../../trunk/libretroshare/src/ft/ftserver.cc:1232:23: warning: unused
variable 'ENCRYPTED_FT_HEADER_SIZE' [-Wunused-const-variable]
static const uint32_t ENCRYPTED_FT_HEADER_SIZE                =  4 ;
                      ^
../../../trunk/libretroshare/src/ft/ftserver.cc:1233:23: warning: unused
variable 'ENCRYPTED_FT_EDATA_SIZE' [-Wunused-const-variable]
static const uint32_t ENCRYPTED_FT_EDATA_SIZE                 =  4 ;
                      ^
../../../trunk/libretroshare/src/ft/ftserver.cc:1235:23: warning: unused
variable 'ENCRYPTED_FT_FORMAT_AEAD_CHACHA20_POLY1305' [-Wunused-const-
variable]
static const uint8_t  ENCRYPTED_FT_FORMAT_AEAD_CHACHA20_POLY1305 = 0x01
;
                      ^
../../../trunk/libretroshare/src/ft/ftserver.cc:1236:23: warning: unused
variable 'ENCRYPTED_FT_FORMAT_AEAD_CHACHA20_SHA256' [-Wunused-const-
variable]
static const uint8_t  ENCRYPTED_FT_FORMAT_AEAD_CHACHA20_SHA256   = 0x02
;
                      ^
2019-04-04 21:20:25 +02:00
Phenom
9310be075d Fix clang warning for
../../../trunk/retroshare-gui/src/gui/Posted/PostedDialog.cpp:99:10:
warning: enumeration value 'ICON_SEARCH' not handled in switch [-
Wswitch]
        switch (type) {
                ^
2019-04-04 21:20:25 +02:00
Phenom
e2d64c912e Fix clang warning for
../../../trunk/retroshare-gui/src/gui/FileTransfer/TransfersDialog.cpp:
1104:9: warning: enumeration value 'DownloadTab' not handled in switch
[-Wswitch]
        switch(page)
               ^
2019-04-04 21:20:25 +02:00
Phenom
54b708089f Fix clang warnings for
../../../trunk/libresapi/src/api/FileSearchHandler.cpp:53:66: warning:
unused parameter 'pid' [-Wunused-parameter]
void FileSearchHandler::notifyTurtleSearchResult(const RsPeerId&
pid,uint32_t search_id, const std::list<TurtleFileInfo>& files)
                                                                 ^
In file included from ../../../trunk/libresapi/src/api/
FileSearchHandler.cpp:24:
../../../trunk/libresapi/src/api/FileSearchHandler.h:48:15: warning:
private field 'mTurtle' is not used [-Wunused-private-field]
    RsTurtle* mTurtle;
              ^
2019-04-04 21:06:01 +02:00
Phenom
dd7c658ed1 Fix clang warning for
In file included from ../../../trunk/libretroshare/src/gxs/rsgxsutil.cc:
26:
../../../trunk/libretroshare/src/gxs/rsgxsutil.h:217:16: warning:
private field 'mSerializer' is not used [-Wunused-private-field]
        RsSerialType& mSerializer;
                      ^
2019-04-04 21:06:01 +02:00
Phenom
b46e07191f Fix clang warning for
In file included from ../../../trunk/libretroshare/src/turtle/
p3turtle.cc:30:
In file included from ../../../trunk/libretroshare/src/rsserver/p3face.h:
38:
In file included from ../../../trunk/libretroshare/src/chat/
p3chatservice.h:30:
In file included from ../../../trunk/libretroshare/src/rsitems/
rsmsgitems.h:34:
In file included from ../../../trunk/libretroshare/src/grouter/
grouteritems.h:32:
In file included from ../../../trunk/libretroshare/src/grouter/
groutermatrix.h:29:
In file included from ../../../trunk/libretroshare/src/grouter/
groutertypes.h:28:
../../../trunk/libretroshare/src/turtle/p3turtle.h:447:8: warning:
private field '_force_digg_new_tunnels' is not used [-Wunused-private-
field]
                bool _force_digg_new_tunnels ;
                     ^
2019-04-04 21:06:01 +02:00
Phenom
4bf5bc1274 Fix clang warnings for
../../../trunk/libretroshare/src/services/autoproxy/
rsautoproxymonitor.cc:263:24: warning: pragma diagnostic pop could not
pop, no matching push [-Wunknown-pragmas]
                       ^
../../../trunk/libretroshare/src/services/autoproxy/
rsautoproxymonitor.cc:295:24: warning: pragma diagnostic pop could not
pop, no matching push [-Wunknown-pragmas]
                       ^
./../../trunk/retroshare-gui/src/gui/FileTransfer/TransfersDialog.cpp:
723: warning: pragma diagnostic pop could not pop, no matching push [-
Wunknown-pragmas]
                       ^
2019-04-04 21:06:01 +02:00
zapek
683e3579aa fixed wrong file hash daylight saving time warnings on windows 2019-04-03 21:29:34 +02:00
RetroPooh
7504964899 display session traffic 2019-04-03 17:29:13 +03:00
csoler
44c1f1580f
added other clean API entries for channel: createComment(), createVote() and createPost() 2019-03-31 22:11:09 +02:00
csoler
e0af46eb85
added new method to create a channel with more explicit parameters and JSon API for it 2019-03-30 22:53:14 +01:00
csoler
ef1755d97f
Merge pull request #1493 from csoler/v0.6-Messaging
V0.6 messaging
2019-03-29 22:27:27 +01:00
csoler
5ee86262aa fixed compilation 2019-03-29 09:17:32 +01:00
defnax
a1ca31afa0 fixes from cyril & removed stylesheets from some buttons
fixed size of thumbnail on all screens
fixed aspect ratio
removede the stylsheet for comments,share, notes
2019-03-29 02:00:13 +01:00
csoler
031a717de0
moved column resize after procesSettings() 2019-03-28 20:06:32 +01:00
csoler
da57f80095
Merge pull request #1506 from defnax/subscribe-button-with-count
Count subscribers on the channels subscribe button like Youtube
2019-03-28 20:04:52 +01:00
csoler
8b3f3fe717
Merge pull request #1487 from defnax2k/People-V2-improvements
Added more actions to People V2 Thumbed View
2019-03-28 19:59:59 +01:00
defnax
94997bd0d3 Added infoframe for Posted List Widget
* Added infoframe for Posted List Widget
* Fixed channels infoframe look both same
2019-03-28 02:00:42 +01:00
defnax
c2ebd10aa6 Count subscribers on the channels subscribe button like Youtube 2019-03-27 19:33:10 +01:00
G10h4ck
72e0a9607b
Merge pull request #1491 from hunbernd/fix/jsonapi
Fix jsonapi compilation
2019-03-27 10:23:45 +01:00
hunbernd
d2d336ee01 Made the restbed compile command better 2019-03-26 20:54:36 +01:00
defnax
b658839214 Removed the dummy buttons & added sorting the comments treewidget via combobox 2019-03-26 18:35:10 +01:00
csoler
f404962b51
fixed notification display for msgs 2019-03-26 11:47:11 +01:00
csoler
1d4934b71e
fixed QuickView filtering 2019-03-26 11:32:43 +01:00
csoler
5820364b0d
fixed sorting 2019-03-26 11:21:31 +01:00
csoler
90995f16ce
fixed filter/sort by author name 2019-03-26 10:25:54 +01:00
csoler
d38ad97911
changed order of operation between init and processSettngs because it was messing up the msg list 2019-03-26 10:05:54 +01:00
defnax
1f6589e68e attempting to fix layout isssues
Attempting to fix issues, layout and spacing
2019-03-26 00:01:52 +01:00
csoler
d2c15c2d9e
fixed merge upstream/master 2019-03-24 20:59:23 +01:00
csoler
c7e65a0111
Merge pull request #1504 from csoler/v0.6-ImprovedGUI
removed explicit size on channel feed buttons that causes unbalanced …
2019-03-24 20:42:11 +01:00
csoler
e76ad99f3b
removed explicit size on channel feed buttons that causes unbalanced items in high DPI screens 2019-03-24 19:59:43 +01:00
csoler
ec66ad5b80
Merge pull request #1501 from csoler/v0.6-ImprovedGUI
created a cache for default icons to avoid allocating them everytime …
2019-03-24 19:49:36 +01:00
csoler
db4f8f18b8
fixed sqlcipher version on OS 10.14 2019-03-24 18:58:18 +01:00
csoler
1d09269e42
switched macOS version to 10.14 2019-03-24 16:22:17 +01:00
csoler
e6d86b5b6f
switched macOS version to 10.14 2019-03-24 16:20:12 +01:00
csoler
63ca76167b
removed brew-doctor command 2019-03-24 13:04:23 +01:00
csoler
32729adb5e
attempt #2 to fix MacOS compilation 2019-03-24 12:56:43 +01:00
csoler
364c3917ac
attempt to fix MacOS compilation 2019-03-23 23:48:39 +01:00
csoler
2ad641d908
added a test for QImage::isDetached() in cache to solve the problem of whether a cache image is still used or not 2019-03-23 22:59:37 +01:00
G10h4ck
f4e13975b0
Merge pull request #1478 from G10h4ck/jsonapi
extend JSON API to identities, circles and reputation
2019-03-23 09:11:05 -03:00
defnax
8ee86ea0da Fixed stylesheet color when its a new posted message 2019-03-22 22:31:06 +01:00