Commit Graph

3795 Commits

Author SHA1 Message Date
Cyril Soler
4c5c09cbc8 Merge pull request #390 from PhenomRetroShare/Fix_MutexInPqiPersonGrp
Fix Mutex in pqipersongrp for pqilistener by adding local Mutex.
2016-05-19 10:11:15 -04:00
csoler
3a2b9e881b added some debug info in new circle code 2016-05-18 21:47:34 -04:00
anon tahoe
abe0e02910 replaced mktemp by mkstemp (cherry-picked from anontahoe repository) 2016-05-18 21:29:55 -04:00
csoler
722609a3e6 finished implementing the backend part for the subscription system 2016-05-18 21:13:54 -04:00
Phenom
af5129c26d Fix Mutex in pqipersongrp for pqilistener by adding local Mutex. 2016-05-18 19:15:37 +02:00
Cyril Soler
f3aed813af added test over signature size to avoid possible memory corruption (Anonymous source) 2016-05-17 10:39:56 -04:00
csoler
89472d6502 put some notes and comments in the code for what is to be done 2016-05-17 00:00:15 -04:00
Cyril Soler
5d69072c93 Merge pull request #383 from PhenomRetroShare/Fix_FreeTcpPacketIfPeersUnknown
Free TcpPacket pointer if returns because peer is unknown.
2016-05-14 18:53:57 -04:00
csoler
f44ccbe756 fixed serialisation bug 2016-05-14 11:56:14 -04:00
Phenom
7fd84f28fe Fix Initialisation of Private in RsAccountDetails 2016-05-14 16:50:17 +02:00
Phenom
6f03fa6601 Free TcpPacket pointer if returns because peer is unknown. 2016-05-13 17:58:38 +02:00
Phenom
d7efeb94f9 Move nDir->Files into condition nDir exists.
Thanks AC.
2016-05-13 17:06:00 +02:00
csoler
a3a0b1d312 added proper menus for adding/removing IDs from circles 2016-05-12 22:30:12 -04:00
Cyril Soler
4b8a1d2570 Merge pull request #380 from PhenomRetroShare/Fix_ContentValue
Fix ContentValue::ContentValue if GetAsxxx return false.
2016-05-12 14:42:31 -04:00
Cyril Soler
1c5bcb8466 Merge pull request #379 from PhenomRetroShare/Fix_UninitializedVar
Fix uninitialized variables netsize, rsnetsize in p3netmgr.cc
2016-05-12 14:41:10 -04:00
Phenom
61e5a62b9f Fix ContentValue::ContentValue if GetAsxxx return false. 2016-05-12 20:29:12 +02:00
Phenom
ed567071a8 Fix in case nDir was reset before 2016-05-12 20:14:59 +02:00
Phenom
a1ece16f35 Fix uninitialized variables netsize, rsnetsize in p3netmgr.cc 2016-05-12 20:00:44 +02:00
Cyril Soler
1d476de806 fixed initialisation of semaphores in created thread object 2016-05-12 10:26:38 -04:00
csoler
96012ef81f new attempt to fix thread issues 2016-05-11 22:18:02 -04:00
csoler
d01c61fde8 added items for encoding subscription requests and the logic to create them from GUI calls 2016-05-11 17:59:42 -04:00
Cyril Soler
383e40324d tried to improve the RsSemaphore class to avoid and display more info about the deadlock problem 2016-05-11 12:42:59 -04:00
Cyril Soler
e891e2be2e added missing check for ssl_connection that would cause crash when the ssl connection gets closed by another thread 2016-05-11 10:00:20 -04:00
csoler
2591e3ff25 changed prototype of Radix encoding to take unsigned char* instead of char* 2016-05-10 22:17:48 -04:00
csoler
9a86989060 first version of circle messages 2016-05-10 21:24:31 -04:00
Cyril Soler
8fdf8f81a8 fixed possible crash in rsnet.cc 2016-05-10 09:46:33 -04:00
csoler
74bb3b6a8b replaced deprecated gethostbyname by getaddrinfo. Only linux was using the re-entrant version, possibly causing bugs on windows+apple 2016-05-09 20:54:58 -04:00
csoler
c9846c0dcf added proper context menu for requesting/cancelling circle subscription 2016-05-06 22:12:44 -04:00
csoler
83049259f2 added bullets to show subscription status of circles. Enabled message sync in circles. Changed flags in GxsCirclesDetails to include new subscription flags 2016-05-06 21:37:17 -04:00
Phenom
ceb092c71f Fix preprocessor for MacOS version. 2016-05-06 22:51:25 +02:00
Cyril Soler
48bc31e637 Merge pull request #371 from csoler/v0.6-Threads
V0.6 threads
2016-05-05 23:55:16 -04:00
csoler
67e976057d removed debug output from threads 2016-05-05 22:03:46 -04:00
csoler
b5ace406b9 attempt to fix socket problem on 32bits/64bits windows, by using the proper SOCKET type instead of int 2016-05-05 21:40:29 -04:00
csoler
9847a7a45f implemented a new semaphore class that should be cross plateform 2016-05-05 20:52:10 -04:00
Nyfor
dbd0418971 Fix segfault on shutdown. 2016-05-05 09:36:36 +02:00
csoler
0817aad0f9 improved debugging output of rsthreads.cc (part 3) 2016-05-04 22:51:33 -04:00
csoler
bb00e39972 improved debugging output of rsthreads.cc (part 2) 2016-05-04 22:34:03 -04:00
csoler
2e02a89874 improved debugging output of rsthreads.cc 2016-05-04 22:23:36 -04:00
csoler
e50e686dd2 updated the debug message for incoming data with no registered tunnel 2016-05-04 18:01:23 -04:00
Cyril Soler
40f8313236 Merge pull request #307 from hunbernd/fix/sqlcipher-version
Sqlcipher version fix
2016-05-04 15:32:17 -04:00
csoler
ca003c5f9e added missing initialisation of deleted memory before calling realloc 2016-05-03 20:55:50 -04:00
csoler
aec8b4d27c fixed bug in counting of incoming data size for sliced packets 2016-05-02 18:10:39 -04:00
csoler
70648398e2 merged with upstream/master 2016-05-01 15:22:13 -04:00
csoler
7914aeb60a use RsTemporaryMemory in signature verification 2016-04-30 17:33:47 -04:00
csoler
be7e87cb1e use RsTemporaryMemory in signature verification 2016-04-30 17:25:24 -04:00
csoler
01605e5a59 updated description f packet slicing in comments section of pqistreamer 2016-04-30 11:19:21 -04:00
csoler
1f7a94d49e fixed bug causing crash in pqistreamer 2016-04-30 11:13:51 -04:00
csoler
4bdd464861 removed a few debug output and timer measurement 2016-04-29 18:53:25 -04:00
csoler
6d2bfcf04e restored average kicking rate to a more reasonnable value. To be tested (for too much CPU use). Dynamically changing this value is probably needed for VOIP 2016-04-29 18:52:58 -04:00
csoler
3bc3989e79 removed debug info for pqistreamer 2016-04-29 18:41:10 -04:00
csoler
5ab9aed371 added placeholder service ID for packet slicing probe 2016-04-29 18:40:28 -04:00
csoler
654e0fc1d8 added missing call to SSL_pending, which caused decrypted data to wait in the SSL buffer when the bio is not receiving anything more 2016-04-29 17:53:21 -04:00
csoler
a4430647de various changes to measure RTTs more accurately 2016-04-26 23:42:44 -04:00
csoler
87764abe4c removed debug info in pqistreamer 2016-04-26 21:23:19 -04:00
csoler
153db5ca64 added on/off mechanism for packet slicing to ensure packward compatibility 2016-04-26 09:22:24 -04:00
csoler
3b685851d2 improved/simplified slicing protocol 2016-04-25 23:37:02 -04:00
csoler
dd81ce3bf3 using BinToHex to display mem blocks in pqistreamer debug 2016-04-25 22:50:41 -04:00
csoler
18e9e1c2db moerged with upstream/master 2016-04-24 21:29:55 -04:00
csoler
f62957534e fixed a few bugs in packet slicing in pqiQoS 2016-04-24 21:18:44 -04:00
csoler
a2c11f97c2 added packet reconstruction and deserialising 2016-04-24 13:43:34 -04:00
csoler
cad8c89746 added packet slicing in pqistreamer 2016-04-23 17:10:25 -04:00
Nyfor
5e94c772b3 Fixed compilation for Clang. 2016-04-23 09:50:49 +02:00
csoler
55e80871eb added missing free for public keys used in envelop encryption 2016-04-22 17:30:55 -04:00
csoler
10230dff6e added missing SSL shutdown when replacing existing connection 2016-04-22 16:50:43 -04:00
csoler
5261c3cd73 prevented turtle to not deleting a config item when it is not cast 2016-04-21 22:23:07 -04:00
csoler
e9fa9eb317 removed tricky memory leak in chat lobbies due to handling of partial messages 2016-04-21 22:07:50 -04:00
csoler
7aea6e5bf8 removed some debug info 2016-04-21 22:07:10 -04:00
csoler
eca83fdd62 removed some debug info 2016-04-21 19:54:50 -04:00
csoler
fba3d37126 fixed memory leak after receiving RsNxsItem deserialised from decrypted memory 2016-04-21 19:47:34 -04:00
csoler
0d3ff0e3aa fixed possible uninitialised memory read in memory decryption return 2016-04-21 19:46:47 -04:00
csoler
0c711a4c61 added missing calls to EVP_CIPHER_CTX_cleanup() to release memory after decryption, causing memory leaks 2016-04-21 19:41:21 -04:00
csoler
e82c217cd2 half-implemented packet slicing (QoS part done) 2016-04-20 22:42:09 -04:00
csoler
057249225e severely reduced packet grouping, which limited the effectiveness of QoS 2016-04-20 21:20:47 -04:00
csoler
aba3d2fb35 removed memory leak due to zeroing (on purpose!) a data chunk in GRouter before deleting it 2016-04-20 18:24:02 -04:00
csoler
d017771650 fixed missing sendTime in distant chat, causing inconsistent display in GUI 2016-04-20 18:10:53 -04:00
csoler
fc725b03a8 added some debug info to pqistreamer 2016-04-19 22:04:30 -04:00
csoler
39553a601c removed debug info 2016-04-19 21:58:30 -04:00
csoler
26af7c900e changed heart beat limit to a larger value. Apparently too tight a value causes disconnections due to packets being stuck sometimes (old bug) 2016-04-17 22:58:48 -04:00
csoler
34bd998c8e cleaned the mess in Circles, due to mixing up GxsIds and PgpIds, which is now irrelevant because items for external circles are not sent based on PGP signatures anymore 2016-04-17 17:13:42 -04:00
csoler
c14c240f07 fixed update of circles GUI using a timer. This is not optimal, and should be replaced by a proper notify call 2016-04-17 00:52:01 -04:00
csoler
3000f94999 separated subscribe status from wether we are part of a circle or not. Still needs update of GUI 2016-04-17 00:52:00 -04:00
csoler
fa8a585e20 removed some debug info 2016-04-15 18:25:53 -04:00
csoler
d642934cb5 increased frequency of update for banned PGP nodes 2016-04-15 18:25:41 -04:00
csoler
048192ee9c added mOriginator to CircleCache entry and auto-ask for unknown GXS ids to the friend who supplied the circle group 2016-04-14 23:47:42 -04:00
csoler
ba1a1b2a61 fixed auto-subscribed of circles when some IDs are unknown 2016-04-14 23:09:59 -04:00
Cyril Soler
a52bd98d4b fixed potential div by 0 in speed estimations. To be tested. 2016-04-11 10:10:10 -04:00
csoler
b148239e4f always pass data accept test in distant chat when we are on the client side of the tunnel 2016-04-10 21:09:47 -04:00
csoler
c97f197b7e removed depth obfucation of search results and replaced by 0 always, effectively removing any information about search depth (idea by AC) 2016-04-10 20:39:08 -04:00
csoler
0d5b9ae0d1 fixed last commit 2016-04-10 18:55:05 -04:00
csoler
b8075d65bd skip circle vetting when sending message posts with no author 2016-04-10 18:53:49 -04:00
csoler
a5044bd71c improved calculation of speed in pqistreamer (was called before only when sending bytes), and prevented situation where no HB is received by the connection is not reset because last HB is 0, causing ghost connected peers in GUI 2016-04-09 14:48:05 -04:00
csoler
993d7d4c8f removed debug info in rsgxsnetservice 2016-04-09 14:46:12 -04:00
csoler
0853773079 merged and removed debug output in rsgxsnetservice.cc 2016-04-09 12:51:15 -04:00
Cyril Soler
10a32d3c4e Merge pull request #343 from csoler/v0.6-Circles
V0.6 circles
2016-04-09 11:38:07 -04:00
csoler
ca0f76954e removed warning that would show up too often when a GxsTunnel is down and message cannot be sent 2016-04-08 21:08:22 -04:00
csoler
b90808dca8 changed update of server update TS in subscribeStatusChange from 0 to time(NULL) 2016-04-07 18:26:18 -04:00
Cyril Soler
c8cae4c33c Merge pull request #297 from PhenomRetroShare/Add_AllowOnlyOneIntanceAndPassArg
Allow only one instance. If exists, pass to it arguments.
2016-04-07 00:09:00 -04:00
csoler
4bf9262382 merged with upstream/master 2016-04-06 22:26:34 -04:00
csoler
60ffcd21b7 fixed double item deletion in RsGxsNetService::handleRecvItem() 2016-04-06 22:23:10 -04:00
csoler
c79c9bae5e added encryption of message sync requests for external circles-restricted groups, and verification that properly encrypted requests are sent before sending encrypted msg ID lists 2016-04-06 21:12:54 -04:00
Phenom
10bb542e83 Allow only one instance for useLocalServer option activated. If exists,
pass to it arguments.

For now, only allow to pass RsCollection file and retroshare://
protocol.
2016-04-06 22:04:53 +02:00
csoler
f26348b710 fixed bug in grouter which caused sending of messages to some offline peers, hence wasting some routes, and causing " p3ServiceServer::sendItem() Fails Filtering for packet id=2001810" messages. 2016-04-05 18:09:02 -04:00
csoler
18dd7ee7bd moved "too many routing clues" message to debug output, since it can be caused by normal lobby operation 2016-04-03 11:42:45 -04:00
csoler
3554e48c7e output packet error with some details (inspired by Phenom-PR289) 2016-04-03 11:38:53 -04:00
csoler
a3890ad1c3 added gathering of routing clues from lobbies 2016-04-03 11:00:03 -04:00
csoler
f8639e5486 fixed bug considering null PGP ids in ban list 2016-04-02 16:44:41 -04:00
csoler
5bbaa1e8e5 added people settings page, removed debug output 2016-04-02 16:14:18 -04:00
csoler
9d9b790a3e exposed un-verified PGP signatures on GXS ids in GUI. Added auto-ban of GXS ids signed by a PGP ids that has already signed a large enough set of GXS ids. Still needs some GUI to change the threshold. 2016-04-02 16:14:18 -04:00
Phenom
c6f1cc4e63 Clear WebAPI when clear chat history in GUI.
Move notifyChatCleared call to p3ChatService
To maintain notify direction.
2016-03-31 22:52:53 +02:00
zeners
aca88308ea compatible to g++11 / QT5
method suggested by cyril
2016-03-29 21:22:14 +02:00
electron128
5783c59463 Merge pull request #318 from realityfabric/remove_empty_file
Delete empty BUGS file
2016-03-29 20:16:44 +02:00
zeners
d96a8efb66 Merge branch 'master' 2016-03-26 23:38:18 +01:00
csoler
0c138d70ad moved discarding of banned identities from lobbies before signature checking, so as to avoid to time stamp their GXSId keys 2016-03-26 18:36:52 -04:00
zeners
922644f03e Merge branch 'master' 2016-03-26 23:24:29 +01:00
csoler
ebf54d1340 fixed unit tests 2016-03-26 17:25:15 -04:00
csoler
6c8737c84a merged with upstream/master 2016-03-25 21:09:37 -04:00
csoler
d1b09b93b9 removed some debug info 2016-03-25 18:54:13 -04:00
csoler
44cadc22b2 cleaned debug info and disabled local circles before merge 2016-03-24 19:46:08 -04:00
csoler
40d23509a1 removed deadlock 2016-03-23 21:50:41 -04:00
csoler
981f81deae added anon ids to offline vetting 2016-03-23 20:54:45 -04:00
csoler
57f4463864 fixed potential crash due to using deleted data (found by dimqua) 2016-03-23 18:23:10 -04:00
csoler
1fb1f3ebaf update of groups up to the latest attached circle server update TS. Should re-send groups that depend on a circle when the circle change 2016-03-21 23:21:26 -04:00
zeners
1c94ff743b Merge branch 'master' 2016-03-21 16:41:21 +01:00
Jessie
2fc533b8c3 Delete empty BUGS file 2016-03-21 07:59:00 -07:00
Phenom
b13292bb80 Fix error reported by CppChecker:
/libretroshare/src/gxs/rsgenexchange.cc:2850: erreur : Cppcheck:
Dereferencing 'grp' after it is deallocated / released
/libretroshare/src/gxstunnel/p3gxstunnel.cc:1004: erreur : Cppcheck:
Invalid usage of output stream: '<< std::cerr'.
/libretroshare/src/util/contentvalue.cc:185: erreur : Cppcheck: Memory
leak: dest
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:103: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:122: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:141: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:92: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:111: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/People/PeopleDialog.cpp:774: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/People/PeopleDialog.cpp:864: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/common/AvatarWidget.cpp:225: erreur : Cppcheck:
Uninitialized variable: status
/retroshare-nogui/src/rpc/proto/rpcprotostream.cc:805: erreur :
Cppcheck: Memory leak: buffer
/supportlibs/pegmarkdown/GLibFacade.c:150: erreur : Cppcheck: va_list
'args' was opened but not closed by va_end().
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/tests/unittests/libretroshare/serialiser/rsturtleitem_test.cc:213:
erreur : Cppcheck: Return value of allocation function 'init_item' is
not stored.
2016-03-20 13:12:30 +01:00
csoler
2e9d22c580 used RsTemporaryMemory to avoid memory leak in case of error in GxsTunnels 2016-03-19 18:47:59 -04:00
Cyril Soler
d1bb939344 Merge pull request #312 from PhenomRetroShare/AddPluginsPathForApple
Add Plugins Path for Apple
2016-03-19 17:14:00 -04:00
Phenom
5061046c96 Add Plugins Path for Apple
From Jenster
2016-03-19 18:58:00 +01:00
zeners
ecf8e7f127 Merge remote branch 'origin/master' 2016-03-19 17:39:34 +01:00
csoler
24ba909f41 fixed mixup between in/out bandwidth traffic info 2016-03-19 11:39:58 -04:00
csoler
31356bab96 added reload of grp meta on update 2016-03-16 21:27:46 -04:00
csoler
384131a231 added force reload of cache for circles that are modified 2016-03-15 22:41:59 -04:00
csoler
6466209553 added test to only subscribe/unsubscribe circles when needed, hence avoiding an unnecessary TS update 2016-03-15 22:11:36 -04:00
hunbernd
78f7ca81a9 Make it possible to open databases using SQLCipher v2 that were created with v3 2016-03-15 22:04:56 +01:00
hunbernd
ff5189996c Fixed display of SQLCipher version
RS used to show SQLite's version
2016-03-15 19:02:34 +01:00
csoler
80aaf30a01 fixed potential crash due to bad usage of updates 2016-03-15 00:00:39 -04:00
csoler
bdb326a989 attempt at fixing circle cache loop. Renamed a few variables and fixed logic. Not yet fully working 2016-03-14 23:19:37 -04:00
csoler
9c649aa58c improved debugDump(), showing the subscription status of each grp 2016-03-13 12:08:03 -04:00
csoler
051806227f fixed circle auto-subscribe 2016-03-13 11:29:21 -04:00
csoler
61c7da7e2d unselect all IDs when no circle is selected 2016-03-12 11:02:32 -05:00
zeners
b1da4ed67e Merge branch 'master' 2016-03-12 16:46:33 +01:00
csoler
5d2833fa42 improved one line of debug output in turtle 2016-03-12 09:25:28 -05:00
csoler
9e8a4cdac4 fixed auto-subscribe of circles when unsigned identities are locally owned 2016-03-11 22:36:47 -05:00
csoler
692b549f08 fixing compilation problem 2016-03-11 17:27:40 -05:00
csoler
232dba28ea allow non signature checking for GR message recepts at intermediate peers when key is missing. Should fix return receipt being lost in the way keeping messages in outbox 2016-03-11 17:21:27 -05:00
csoler
4eebe24ee2 disabled auto-sync for messages in GXS circles, while keeping Grp auto-sync 2016-03-09 20:23:33 -05:00
csoler
53f32f2dc8 added missing collection of some peers in p3gxscircles::recipients() 2016-03-04 13:45:35 -05:00
csoler
3c2c1df245 added test against empty circles 2016-03-03 21:37:36 -05:00
csoler
bb260696ce attempt at fixing negative bw rates in GUI that may pop up when an error is present in the SSL stream (e.g. when a peer disconnects/reconnects) 2016-03-02 19:00:51 -05:00
electron128
20fcf635e4 Merge pull request #285 from PhenomRetroShare/Fix_SSGxsChannelGroupLoadNullError
Fix error "(EE) SSGxsChannelGroup::load() asked to load a null string.
2016-02-26 18:13:20 +01:00