Commit Graph

11062 Commits

Author SHA1 Message Date
Phenom
e4616c09bc Fix clang warning: unused variable 'STORE_KEY_TIMEOUT'
/libretroshare/src/pqi/authgpg.cc:51: warning: unused variable
'STORE_KEY_TIMEOUT' [-Wunused-const-variable]
const time_t STORE_KEY_TIMEOUT = 1 * 60 * 60; //store key is call around
every hour
2017-07-16 21:17:52 +02:00
Phenom
0479ec07ab Fix clang warning: unused variable 'MAX_MESSAGES_PER_SECONDS_NUMBER'
/libretroshare/src/chat/distributedchat.cc:57: warning: unused variable
'MAX_MESSAGES_PER_SECONDS_NUMBER' [-Wunused-const-variable]
static const uint32_t MAX_MESSAGES_PER_SECONDS_NUMBER     =  5 ; // max
number of messages from a given peer in a window for duration below
2017-07-16 21:17:06 +02:00
Phenom
80ea4de7be Fix clang warning: unused variable 'ftserverzone'
/libretroshare/src/ft/ftserver.cc:34: warning: unused variable
'ftserverzone' [-Wunused-const-variable]
const int ftserverzone = 29539;
2017-07-16 21:16:30 +02:00
Phenom
8a270af519 fixed merging problem 2017-07-16 21:15:26 +02:00
Phenom
35186c4054 Fix clang warning: unused variable 'res'
/libretroshare/src/crypto/chacha20.cpp:978: warning: unused variable
'res' [-Wunused-variable]
        uint256_32 res(q1) ;
2017-07-16 21:12:09 +02:00
Phenom
7f1e23085d Fix clang warning: unused variable 'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG', ...
/libretroshare/src/ft/fttransfermodule.cc:56: warning: unused variable
'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_MAX_WAIT_PER_GIG = 20; /* 20 seconds per
gigabyte */
/libretroshare/src/ft/fttransfermodule.cc:65: warning: unused variable
'FT_TM_FAST_RTT' [-Wunused-const-variable]
const int32_t FT_TM_FAST_RTT    = 1.0;
/libretroshare/src/ft/fttransfermodule.cc:66: warning: unused variable
'FT_TM_STD_RTT' [-Wunused-const-variable]
const int32_t FT_TM_STD_RTT     = 5.0;
/libretroshare/src/ft/fttransfermodule.cc:67: warning: unused variable
'FT_TM_SLOW_RTT' [-Wunused-const-variable]
const int32_t FT_TM_SLOW_RTT    = 20.0;
/libretroshare/src/ft/fttransfermodule.cc:69: warning: unused variable
'FT_TM_CRC_MAP_STATE_NOCHECK' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_NOCHECK      = 0 ;
/libretroshare/src/ft/fttransfermodule.cc:70: warning: unused variable
'FT_TM_CRC_MAP_STATE_DONT_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_DONT_HAVE = 1 ;
/libretroshare/src/ft/fttransfermodule.cc:71: warning: unused variable
'FT_TM_CRC_MAP_STATE_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_HAVE                 = 2 ;
2017-07-16 21:11:47 +02:00
Phenom
8b99c80e07 Fix clang warning: 'p3GxsTrans' defined as a class here but previously
declared as a struct

/libretroshare/src/gxstrans/p3gxstrans.h:88: warning: 'p3GxsTrans'
defined as a class here but previously declared as a struct [-
Wmismatched-tags]
class p3GxsTrans : public RsGenExchange, public GxsTokenQueue, public
p3Config, public RsGxsTrans
/libretroshare/src/gxstrans/p3gxstrans.h:31: did you mean class here?
struct p3GxsTrans;
2017-07-16 21:11:10 +02:00
Phenom
fd24ef591e Fix warning: comparison between signed and unsigned integer expressions
and misleading-indentation

/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
     for(uint32_t i=0;i<mMessageVersions.size();++i)

/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: this ‘for’
clause does not guard... [-Wmisleading-indentation]
     for(uint32_t i=0;i<mMessageVersions.size();++i)
2017-07-16 21:10:45 +02:00
Phenom
431b56406d Fix warning: unused variable ‘popLimit’
/retroshare-gui/src/gui/gxs/GxsGroupFrameDialog.cpp:831: warning: unused
variable ‘popLimit’ [-Wunused-variable]
  uint32_t popLimit = 0;
2017-07-16 21:09:58 +02:00
Phenom
2444e6e66e Fix warning: this statement may fall through
/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:654: warning: this
statement may fall through [-Wimplicit-fallthrough=]
     case 2: signFlags |=
GXS_SERV::FLAG_AUTHOR_AUTHENTICATION_GPG_KNOWN; // no break below, since
we want *both* flags in this case.
2017-07-16 21:09:33 +02:00
Phenom
dcb8a352df Fix warning: unused variable ‘self’
and misleading-indentation

/retroshare-gui/src/gui/feeds/GxsChannelPostItem.cpp:54: warning: unused
variable ‘self’ [-Wunused-variable]
     bool self = false;

/retroshare-gui/src/gui/feeds/GxsChannelPostItem.cpp:225: warning: this
‘if’ clause does not guard... [-Wmisleading-indentation]
     if(!IS_GROUP_PUBLISHER(mGroup.mMeta.mSubscribeFlags))
2017-07-16 21:07:47 +02:00
Phenom
ca9357cd20 Fix warning: this ‘if’ clause does not guard...
/retroshare-gui/src/gui/gxschannels/CreateGxsChannelMsg.cpp:360:
warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if(assume_file_ready)
2017-07-16 21:06:54 +02:00
Phenom
b5c503a324 Fix warning: unused variable ‘prev_index’
/retroshare-gui/src/gui/gxschannels/GxsChannelPostsWidget.cpp:535:
warning: unused variable ‘prev_index’ [-Wunused-variable]
     uint32_t prev_index = current_index ;
2017-07-16 21:06:01 +02:00
Phenom
3a22c6d302 Fix warning: comparison between signed and unsigned integer expressions
/retroshare-gui/src/gui/gxsforums/GxsForumsFillThread.cpp:286: warning:
comparison between signed and unsigned integer expressions [-Wsign-
compare]
         for(uint32_t i=1;i<(*it).size();++i)
2017-07-16 20:57:19 +02:00
Phenom
6fd03087d2 Fix warning: this statement may fall through
/retroshare-gui/src/gui/statistics/BWGraph.cpp:245: warning: this
statement may fall through [-Wimplicit-fallthrough=]
   case GRAPH_TYPE_ALL: std::cerr << "(WW) Impossible situation. Cannot
draw graph in mode All/All. Reverting to sum." << std::endl;
2017-07-16 20:56:46 +02:00
Phenom
f27ce82e22 Fix warning: comparison between signed and unsigned integer expressions
, misleading-indentation and unused-variable

/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: comparison between signed and unsigned integer expressions [-
Wsign-compare]
     for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)

/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
     for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)

/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:203:
warning: unused variable ‘now’ [-Wunused-variable]
     time_t now = time(NULL) ;
2017-07-16 20:56:18 +02:00
Phenom
15bc9c1c3c Fix warning: this statement may fall through
/retroshare-gui/src/gui/GetStartedDialog.cpp:122: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    ui.firewallCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:124: here
   case RSCONFIG_USER_LEVEL_CASUAL:

/retroshare-gui/src/gui/GetStartedDialog.cpp:125: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    ui.connectCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:127: here
   case RSCONFIG_USER_LEVEL_BASIC:
2017-07-16 20:54:41 +02:00
Phenom
f23c84fd4e Fix warning: this statement may fall through
/retroshare-gui/src/gui/RetroShareLink.cpp:585: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if(!checkSSLId(_SSLid))
/retroshare-gui/src/gui/RetroShareLink.cpp:587: here
   case TYPE_FILE:
2017-07-16 20:54:05 +02:00
Phenom
9a4ed8012c Fix warning: comparison between signed and unsigned integer expressions
and unused variables

/retroshare-nogui/src/TerminalApiClient.cpp:233: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
    while(selected_account_number >= accounts.size())

/retroshare-nogui/src/TerminalApiClient.cpp:243: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
     if(selected_account_number >= accounts.size())

/retroshare-nogui/src/TerminalApiClient.cpp:121: warning: unused
variable ‘IO_POLL_PERIOD’ [-Wunused-variable]
     const int IO_POLL_PERIOD          = 20;

/retroshare-nogui/src/TerminalApiClient.cpp:124: warning: unused
variable ‘last_io_poll’ [-Wunused-variable]
     int last_io_poll  = 0;

/retroshare-nogui/src/TerminalApiClient.cpp:127: warning: unused
variable ‘last_char’ [-Wunused-variable]
     int last_char = 0;

/retroshare-nogui/src/TerminalApiClient.cpp:129: warning: unused
variable ‘enter_was_pressed’ [-Wunused-variable]
     bool enter_was_pressed = false;

/retroshare-nogui/src/TerminalApiClient.cpp:133: warning: variable
‘account_number_typed’ set but not used [-Wunused-but-set-variable]
  int account_number_typed = 0 ;
2017-07-16 20:53:14 +02:00
Phenom
8455adf375 Fix warning: unused parameter ‘type’ and ‘req’
/libresapi/src/api/ChatHandler.cpp:236: warning: unused parameter ‘type’
[-Wunused-parameter]
 void ChatHandler::notifyListChange(int list, int type)

/libresapi/src/api/ChatHandler.cpp:971: warning: unused parameter ‘req’
[-Wunused-parameter]
 void ChatHandler::handleGetInvitationsToLobby(Request& req, Response&
resp)
2017-07-16 20:49:27 +02:00
Phenom
c866bf91c6 Fix warning: unused parameter ‘req’ and ‘resp’
/libresapi/src/api/IdentityHandler.cpp:721: warning: unused parameter
‘req’ [-Wunused-parameter]
 ResponseTask* IdentityHandler::handleDeleteIdentity(Request& req,

/libresapi/src/api/IdentityHandler.cpp:722: warning: unused parameter
‘resp’ [-Wunused-parameter]
                                                     Response& resp)
2017-07-16 20:48:50 +02:00
Phenom
9d4967c0e1 Fix warning: unused parameter ‘req’
/libresapi/src/api/PeersHandler.cpp:670: warning: unused parameter ‘req’
[-Wunused-parameter]
 void PeersHandler::handleGetNetworkOptions(Request& req, Response&
resp)
2017-07-16 20:48:15 +02:00
Phenom
c97269bed6 Fix warning: this statement may fall through
/libretroshare/src/gxstrans/p3gxstrans.cc:870: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.sent_ts = time(NULL) ; //pr.mailItem.meta.mPublishTs = time(NULL);
/libretroshare/src/gxstrans/p3gxstrans.cc:872: here
  case GxsTransSendStatus::PENDING_PREFERRED_GROUP:

/libretroshare/src/gxstrans/p3gxstrans.cc:883: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.group_id = mPreferredGroupId ; //pr.mailItem.meta.mGroupId =
mPreferredGroupId;
/libretroshare/src/gxstrans/p3gxstrans.cc:885: here
  case GxsTransSendStatus::PENDING_RECEIPT_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:906: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.msg.setBinData(&grsrz[0], grsz);
/libretroshare/src/gxstrans/p3gxstrans.cc:908: here
  case GxsTransSendStatus::PENDING_RECEIPT_SIGNATURE:     // (cyril)
This step is never actually used.

/libretroshare/src/gxstrans/p3gxstrans.cc:924: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.meta.setBinData(&srx[0], metaSize);
/libretroshare/src/gxstrans/p3gxstrans.cc:926: here
  case GxsTransSendStatus::PENDING_PAYLOAD_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:938: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   memcpy(&pr.mailItem.payload[offset], &pr.mailData[0], datasize);
/libretroshare/src/gxstrans/p3gxstrans.cc:940: here
  case GxsTransSendStatus::PENDING_PAYLOAD_ENCRYPT:

/libretroshare/src/gxstrans/p3gxstrans.cc:982: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   }
/libretroshare/src/gxstrans/p3gxstrans.cc:984: here
  case GxsTransSendStatus::PENDING_PUBLISH:
2017-07-16 20:47:45 +02:00
Phenom
18139489cf Fix warning: unused parameter ‘grpItem’ and unused debug variables
/libretroshare/src/gxstrans/p3gxstrans.cc:635: warning: unused parameter
‘grpItem’ [-Wunused-parameter]
         RsGxsGrpItem* grpItem, RsTlvSecurityKeySet& /*keySet*/ )

/libretroshare/src/gxstrans/p3gxstrans.cc:681: warning: unused variable
‘msgId’ [-Wunused-variable]
      const RsGxsMessageId& msgId = *vit;

/libretroshare/src/gxstrans/p3gxstrans.cc:676: warning: unused variable
‘grpId’ [-Wunused-variable]
     const RsGxsGroupId& grpId = it->first;
2017-07-16 20:46:55 +02:00
Phenom
e1ea92d733 Fix warning: unused parameter ‘n’
/libretroshare/src/serialiser/rstypeserializer.cc:358: warning: unused
parameter ‘n’ [-Wunused-parameter]
 template<> void RsTypeSerializer::print_data( const std::string& n,
2017-07-16 20:41:24 +02:00
Phenom
f193af2865 Fix warning: unused parameter ‘size’
/libretroshare/src/gxs/rsgenexchange.cc:3079: warning: unused parameter
‘size’ [-Wunused-parameter]
 bool RsGenExchange::acceptNewMessage(const RsGxsMsgMetaData* /
*grpMeta*/,uint32_t size ) { return true; }
2017-07-16 20:41:01 +02:00
Phenom
d8b0b5222b Fix warning: variable ‘it’ set but not used
/libretroshare/src/gxs/rsgxsnetservice.cc:867: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
     std::map<RsGxsGroupId,RsGxsServerMsgUpdate>::iterator it =
mServerMsgUpdateMap.find(grpId) ;

/libretroshare/src/gxs/rsgxsnetservice.cc:2434: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
             ClientGrpMap::iterator it =
mClientGrpUpdateMap.find(peerFrom);
2017-07-16 20:40:31 +02:00
Phenom
b11022a239 Fix warning: this statement may fall through
/libretroshare/src/util/dnsresolver.cc:49: warning: this statement may
fall through [-Wimplicit-fallthrough=]
       case DNSResolver::DNS_LOOKUP_ERROR:  if(it-
>second.last_lookup_time + MAX_TIME_BEFORE_RETRY > now)
/libretroshare/src/util/dnsresolver.cc:52: here
       case DNSResolver::DNS_DONT_HAVE:   next_call = it->first ;
2017-07-16 20:38:43 +02:00
Phenom
0e302e254e Fix warning: this statement may fall through
/libretroshare/src/util/rsnet_ss.cc:1031: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   success = inet_ntop( addr.ss_family, (const void *) &(addrv4p-
>sin_addr), ipStr, INET_ADDRSTRLEN );
/libretroshare/src/util/rsnet_ss.cc:1033: here
  case AF_INET6:
2017-07-16 20:36:16 +02:00
Phenom
7b4d3c5a24 Fix warning: this statement may fall through
/libretroshare/src/util/rscompress.cc:165: warning: this statement may
fall through [-Wimplicit-fallthrough=]
      ret = Z_DATA_ERROR;     /* and fall through */
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/util/rscompress.cc:
166: here
     case Z_DATA_ERROR:
2017-07-16 20:34:38 +02:00
Phenom
476b581506 Fix warning: this statement may fall through
/libretroshare/src/rsserver/p3serverconfig.cc:292: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->getFriendCount(true, false) > MIN_BASIC_FRIENDS)
/libretroshare/src/rsserver/p3serverconfig.cc:297: here
   case RSCONFIG_USER_LEVEL_BASIC:

/libretroshare/src/rsserver/p3serverconfig.cc:300: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->haveOnceConnected())
/libretroshare/src/rsserver/p3serverconfig.cc:306: here
   case RSCONFIG_USER_LEVEL_CASUAL:
2017-07-16 20:33:55 +02:00
Phenom
7bd7c57ff9 Fix warning: variable ‘pgpNameFound’ set but not used
/libretroshare/src/rsserver/rsaccounts.cc:130: warning: variable
‘pgpNameFound’ set but not used [-Wunused-but-set-variable]
  bool pgpNameFound = false;
2017-07-16 20:32:32 +02:00
Phenom
a0506c1a0f Fix warning: this statement may fall through
/libretroshare/src/pqi/pqissl.cc:449: warning: this statement may fall
through [-Wimplicit-fallthrough=]
    sslmode = PQISSL_ACTIVE; /* we're starting this one */
/libretroshare/src/pqi/pqissl.cc:456: here
   case WAITING_DELAY:
2017-07-16 20:31:49 +02:00
Phenom
b9d4651f07 Fix warning: this statement may fall through
/libretroshare/src/pqi/pqisslpersongrp.cc:125: warning: this statement
may fall through [-Wimplicit-fallthrough=]
     std::cerr << " --> falling back to Tor" << std::endl;
/libretroshare/src/pqi/pqisslpersongrp.cc:126: here
    case RS_HIDDEN_TYPE_TOR:
2017-07-16 20:30:41 +02:00
Phenom
e12f51b1be Fix warning: variable ‘peerIt1’ set but not used
/libretroshare/src/pqi/p3peermgr.cc:2619: warning: variable ‘peerIt1’
set but not used [-Wunused-but-set-variable]
                     std::set<RsPgpId>::iterator peerIt1 =
groupItem.peerIds.find(*peerIt);
2017-07-16 20:28:24 +02:00
Phenom
78cfde9b4f Fix warning: this statement may fall through
/libretroshare/src/pgp/pgphandler.cc:62: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE_PREV_WAS_BAD: prev_was_bad =
true ;

/libretroshare/src/pgp/pgphandler.cc:63: here
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE:
2017-07-16 20:27:46 +02:00
Phenom
3a6ad822da Fix warning: this statement may fall through
/libretroshare/src/ft/ftchunkmap.cc:190: warning: this statement may
fall through [-Wimplicit-fallthrough=]
    case FileChunksInfo::CHUNK_CHECKING: _file_is_complete = false ;

/libretroshare/src/ft/ftchunkmap.cc:191: here
    case FileChunksInfo::CHUNK_DONE:   _total_downloaded +=
sizeOfChunk(i) ;
2017-07-16 20:27:09 +02:00
Phenom
635246c462 Fix warning: this statement may fall through
/libretroshare/src/tcponudp/bss_tou.c:246: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   num=0;

/libretroshare/src/tcponudp/bss_tou.c:247: here
  case BIO_C_FILE_SEEK:
2017-07-16 20:25:11 +02:00
Phenom
e718070dbd Fix warning: this statement may fall through
/libbitdht/src/bitdht/bdconnection.cc:1288: warning: this statement may
fall through [-Wimplicit-fallthrough=]
      if (errsrc == BITDHT_CONNECT_ERROR_SOURCE_END)
/libbitdht/src/bitdht/bdconnection.cc:1308: here
     case BITDHT_CONNECT_ERROR_DUPLICATE: // similar attempt. delay/
recycle (ANY/ANY)
2017-07-16 20:23:39 +02:00
Phenom
714f9bba99 Fix warning: this statement may fall through
/openpgpsdk/src/openpgpsdk/packet-parse.c:2482: warning: this statement
may fall through [-Wimplicit-fallthrough=]
         hashes[n].add(&hashes[n],C.secret_key.salt,OPS_SALT_SIZE);
/openpgpsdk/src/openpgpsdk/packet-parse.c:2484: here
      case OPS_S2KS_SIMPLE:
2017-07-16 20:21:38 +02:00
csoler
987c10522a Merge pull request #945 from PhenomRetroShare/Add_RSLinkCreateAsStatic
Change RetroShareLink creation methodes as static
2017-07-16 20:16:31 +02:00
csoler
e40dbe82a4 Merge pull request #947 from csoler/v0.6-ImprovedGUI
fixed filtering for channels when loading  items on the fly
2017-07-16 17:03:37 +02:00
csoler
1e98de76a1 fixed filtering for channels when loading items on the fly 2017-07-16 16:56:23 +02:00
Phenom
59e018e02d Fix GUI AutoLogin 2017-07-16 16:03:56 +02:00
Phenom
82addce867 Change RetroShareLink creation methodes as static
And remove this warning:
2017-07-16 13:12:07 +02:00
csoler
2d5e1d637f fixed last update missing commits 2017-07-16 10:08:33 +02:00
csoler
471812586a updated changelog 2017-07-16 10:06:11 +02:00
csoler
991049d8da Merge pull request #944 from csoler/v0.6-ImprovedGUI
V0.6 improved gui
2017-07-15 22:20:43 +02:00
csoler
08faa3f5d5 fixed p3Gxstunnel so that it sends the data packets in the same order it received them. This fixes the bug in distant chat causing images to not transfer correctly in some cases 2017-07-15 22:16:45 +02:00
csoler
9c391cb015 added an additional param to BinToHex so as to limit the size of the output 2017-07-15 22:15:51 +02:00