csoler
a2f8b5e6e9
Merge pull request #972 from csoler/v0.6.3
...
V0.6.3
2017-07-30 14:42:28 +02:00
csoler
e82b6fc1fe
improved GenCertDialog with small indicator text, and hide location by default
2017-07-30 14:31:52 +02:00
csoler
09faa60005
Merge pull request #967 from csoler/v0.6.3
...
V0.6.3
2017-07-29 23:16:47 +02:00
csoler
e8415c4f03
made RS not to ask for plugin confirmation on first load
2017-07-29 23:12:56 +02:00
csoler
a16220e53e
switched to RC2
2017-07-29 20:24:31 +02:00
csoler
e861f87364
removed unused msg item class that caused aliasing warnings (serialisation of time_t as uint32_t)
2017-07-26 21:44:24 +02:00
csoler
286e7e0b1a
Merge pull request #961 from csoler/v0.6.3
...
V0.6.3
2017-07-26 14:01:28 +02:00
csoler
34ddf71703
Merge pull request #957 from PhenomRetroShare/Fix_CppCheckerError
...
Fix cpp checker error
2017-07-26 13:54:44 +02:00
csoler
1792273cff
Merge pull request #946 from PhenomRetroShare/Fix_GuiAutoLogin
...
Fix GUI AutoLogin
2017-07-26 13:50:21 +02:00
csoler
b0483a0c38
fixed bug in removeDeleteExistingMsgs()
2017-07-26 10:23:18 +02:00
csoler
9881b616ac
cleanup code in RsGenExchange
2017-07-25 22:06:18 +02:00
csoler
a382a0f5ce
fixed memory leak in p3peermgr config load
2017-07-25 21:52:09 +02:00
csoler
041f989f1c
rewrote processRecvdMessages() and processRecvdGroups() in RsGenExchange. Removed mReceivedGrps and mReceivedMsgs, cleaned-up terrible branching and memory management
2017-07-25 21:21:24 +02:00
csoler
461ccf3b84
removed aliasing in storeMessages/storeGroups, removed several memory leaks in unittests, improved auto-delete structures in rsgxsutil, added deletion for members of RsGenExchange, removed shared pointers from unittests (they cause a memory leak and are only used in unittests)
2017-07-25 00:07:53 +02:00
csoler
79779b8056
fixed memory leaks in GxsSecurity
2017-07-24 18:45:24 +02:00
csoler
70f72db0aa
fixed memory leak in GxsSecurity
2017-07-24 18:20:21 +02:00
csoler
bcaafc241d
improved template class naming for temporary Gxs grp data structures
2017-07-24 14:29:30 +02:00
Gioacchino Mazzurco
3b1606ceb9
Remove misguiding if
2017-07-24 11:52:23 +02:00
Gioacchino Mazzurco
03cc2e629d
Remove miguiding if before delete
2017-07-24 10:16:24 +02:00
csoler
02424240a0
reverting last commit that causes crashes
2017-07-22 12:08:28 +02:00
csoler
9e2241a940
attempt to fix memory leak in RsGenExchange. To be tested.
2017-07-21 23:15:50 +02:00
Phenom
8ce10ea6a8
Fix past commit for p3idservice.cc
2017-07-21 15:31:53 +02:00
Phenom
2afc1bf423
Fix CppCheck Error in contentvalue.cc
...
/libretroshare/src/util/contentvalue.cc:189: error: Cppcheck(memleak):
Memory leak: dest
2017-07-21 15:04:34 +02:00
Phenom
e5767431e6
Fix CppCheck Error in p3idservice.cc
...
/libretroshare/src/services/p3idservice.cc:1216: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:1346: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:448: error:
Cppcheck(uninitvar): Uninitialized variable: max_keep_time
2017-07-21 14:57:43 +02:00
csoler
aa471e5b2f
fixed uninitialized memory read in GxsTrans
2017-07-21 10:25:20 +02:00
csoler
baac33d95a
updated revision number
2017-07-20 21:18:57 +02:00
Phenom
cbbc3920fa
Fix Lobby auto-subscribe.
...
Save GxsId for each.
Disallow to auto-subscribe to signed lobby with unsigned id.
2017-07-19 18:33:55 +02:00
csoler
71810e8daa
Merge pull request #950 from PhenomRetroShare/Add_ChatServerFlag
...
Add flag for ChatServer
2017-07-19 18:18:32 +02:00
Phenom
5bbb99aef7
Fix Bad Service Monitor registering.
...
This induce to remove peers in statistics->bandwidth when disc service
is off.
2017-07-18 19:24:32 +02:00
Phenom
3a6bcf5ef8
Add flag for ChatServer
...
append the following assignation to qmake command line "CONFIG
+=rs_chatserver"
2017-07-18 16:34:56 +02:00
csoler
e56340e0a1
Merge pull request #386 from PhenomRetroShare/Add_AbilityToChangeOpModeInCmdLine
...
Add the ability to change OpMode in command line.
2017-07-17 23:12:06 +02:00
csoler
f4aec11b0a
suppressed warning in p3dhtmgr.cc
2017-07-17 22:48:12 +02:00
Phenom
437426429e
Fix clang warning: unused variable 'pqiservicezone'
...
/libretroshare/src/pqi/pqiservice.cc:30: warning: unused variable
'pqiservicezone' [-Wunused-const-variable]
const int pqiservicezone = 60478;
2017-07-17 22:35:01 +02:00
Phenom
300359863e
Fix clang warning: 'p3ChatService' defined as a struct here but
...
previously declared as a class
/libretroshare/src/chat/p3chatservice.h:56: warning: 'p3ChatService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3ChatService :
/libretroshare/src/rsserver/p3msgs.h:33: did you mean struct here?
class p3ChatService;
2017-07-17 22:32:23 +02:00
Phenom
91c526f2b5
Fix clang warning: 'p3MsgService' defined as a struct here but
...
previously declared as a class
/libretroshare/src/services/p3msgservice.h:58: warning: 'p3MsgService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3MsgService :
/libretroshare/src/rsserver/p3msgs.h:32: did you mean struct here?
class p3MsgService;
2017-07-17 22:32:07 +02:00
Phenom
896ed3e992
Fix clang warning: class 'p3Config' was previously declared as a struct
...
/libretroshare/src/retroshare/rsplugin.h:77: warning: class 'p3Config'
was previously declared as a struct [-Wmismatched-tags]
class p3Config;
2017-07-17 22:31:30 +02:00
Phenom
8dbb0d61af
Fix warning: this statement may fall through
...
/libretroshare/src/dht/connectstatebox.cc:394: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:401: here
default:
/libretroshare/src/dht/connectstatebox.cc:406: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:414: here
case CSB_START:
/libretroshare/src/dht/connectstatebox.cc:530: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:540: here
default:
/libretroshare/src/dht/connectstatebox.cc:543: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:551: here
case CSB_START:
2017-07-17 22:29:11 +02:00
Phenom
f888913800
Set Operating Mode in RsInit::InitRetroShare so noGUI could use it.
2017-07-17 15:40:14 +02:00
cyril soler
1491a051dc
fixed deadlock situation in FT causing multiple bugs: lock when DLing from a file list a file that is already being downloaded, and lock when a FT module find a direct source among friends
2017-07-17 11:16:48 +02:00
Phenom
e2fa57dcd7
Fix clang warning: unused variable 'INTERVAL_BETWEEN_DEBUG_DUMP'
...
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP = 10 ;
2017-07-16 21:43:05 +02:00
Phenom
26397d7e4d
Fix clang warning: unused variables 'LOWER_LIMIT', ...
...
/libretroshare/src/services/p3gxsreputation.cc:130: warning: unused
variable 'LOWER_LIMIT' [-Wunused-const-variable]
static const uint32_t LOWER_LIMIT = 0; //
used to filter valid Opinion values from serialized data
/libretroshare/src/services/p3gxsreputation.cc:132: warning: unused
variable 'kMaximumPeerAge' [-Wunused-const-variable]
static const int kMaximumPeerAge = 180; //
half a year.
/libretroshare/src/services/p3gxsreputation.cc:135: warning: unused
variable 'ACTIVE_FRIENDS_ONLINE_DELAY' [-Wunused-const-variable]
static const int ACTIVE_FRIENDS_ONLINE_DELAY = 86400*7 ; //
1 week.
/libretroshare/src/services/p3gxsreputation.cc:138: warning: unused
variable 'REPUTATION_ASSESSMENT_THRESHOLD_X1' [-Wunused-const-variable]
static const float REPUTATION_ASSESSMENT_THRESHOLD_X1 = 0.5f ; //
reputation under which the peer gets killed. Warning there's a 1 shift
with what's shown in GUI. Be careful.
/libretroshare/src/services/p3gxsreputation.cc:139: warning: unused
variable 'PGP_AUTO_BAN_THRESHOLD_DEFAULT' [-Wunused-const-variable]
static const uint32_t PGP_AUTO_BAN_THRESHOLD_DEFAULT = 2 ; //
above this, auto ban any GXS id signed by this node
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP = 10 ;
2017-07-16 21:37:22 +02:00
Phenom
903f875d1d
Fix clang warning: unused variable 'MAX_SERIALIZED_ARRAY_SIZE'
...
/libretroshare/src/serialiser/rstypeserializer.cc:39: warning: unused
variable 'MAX_SERIALIZED_ARRAY_SIZE' [-Wunused-const-variable]
static const uint32_t MAX_SERIALIZED_ARRAY_SIZE = 500 ;
2017-07-16 21:36:35 +02:00
Phenom
d83a9625cc
Fix clang warning: unused variables 'GIXS_CUT_OFF', ...
...
/libretroshare/src/gxs/rsgxsnetservice.cc:247: warning: unused variable
'GIXS_CUT_OFF' [-Wunused-const-variable]
static const uint32_t GIXS_CUT_OFF =
0;
/libretroshare/src/gxs/rsgxsnetservice.cc:251: warning: unused variable
'SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE' [-Wunused-const-variable]
static const uint32_t SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE =
3600; // force re-update if there happens to be a large delay between
our server side TS and the client side TS of friends
2017-07-16 21:36:14 +02:00
Phenom
51fa7a5dda
Fix clang warning: unused variable 'p3facestartupzone'
...
/libretroshare/src/rsserver/rsinit.cc:145: warning: unused variable
'p3facestartupzone' [-Wunused-const-variable]
const int p3facestartupzone = 47238;
2017-07-16 21:35:35 +02:00
Phenom
13220ec414
Fix clang warning: unused variable
...
'MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT'
/libretroshare/src/rsserver/p3peers.cc:52: warning: unused variable
'MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT' [-Wunused-const-variable]
static const int MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT = 30*24*3600 ;
// 30 days.
2017-07-16 21:34:38 +02:00
Phenom
fea1b83b34
Fix clang warning: unused variable 'p3facemsgzone'
...
/libretroshare/src/rsserver/p3face-config.cc:36: warning: unused
variable 'p3facemsgzone' [-Wunused-const-variable]
const int p3facemsgzone = 11453;
/libretroshare/src/rsserver/p3msgs.cc:33: warning: unused variable
'p3facemsgzone' [-Wunused-const-variable]
const int p3facemsgzone = 11453;
2017-07-16 21:34:09 +02:00
Phenom
5a64996304
Fix clang warning: unused variables 'RS_NET_NEEDS_RESET', ...
...
/libretroshare/src/pqi/p3peermgr.cc:53: warning: unused variable
'RS_NET_NEEDS_RESET' [-Wunused-const-variable]
const uint32_t RS_NET_NEEDS_RESET = 0x0000;
/libretroshare/src/pqi/p3peermgr.cc:54: warning: unused variable
'RS_NET_UNKNOWN' [-Wunused-const-variable]
const uint32_t RS_NET_UNKNOWN = 0x0001;
/libretroshare/src/pqi/p3peermgr.cc:55: warning: unused variable
'RS_NET_UPNP_INIT' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_INIT = 0x0002;
/libretroshare/src/pqi/p3peermgr.cc:56: warning: unused variable
'RS_NET_UPNP_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_SETUP = 0x0003;
/libretroshare/src/pqi/p3peermgr.cc:57: warning: unused variable
'RS_NET_EXT_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_EXT_SETUP = 0x0004;
/libretroshare/src/pqi/p3peermgr.cc:58: warning: unused variable
'RS_NET_DONE' [-Wunused-const-variable]
const uint32_t RS_NET_DONE = 0x0005;
/libretroshare/src/pqi/p3peermgr.cc:59: warning: unused variable
'RS_NET_LOOPBACK' [-Wunused-const-variable]
const uint32_t RS_NET_LOOPBACK = 0x0006;
/libretroshare/src/pqi/p3peermgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN = 0x0007;
/libretroshare/src/pqi/p3peermgr.cc:62: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET = 5;
/libretroshare/src/pqi/p3peermgr.cc:64: warning: unused variable
'PEER_IP_CONNECT_STATE_MAX_LIST_SIZE' [-Wunused-const-variable]
const uint32_t PEER_IP_CONNECT_STATE_MAX_LIST_SIZE = 4;
2017-07-16 21:31:41 +02:00
Phenom
4152a46ad8
Fix clang warning: unused variable 'P3CONNMGR_UDP_DEFAULT_DELAY'
...
/libretroshare/src/pqi/p3linkmgr.cc:78: warning: unused variable
'P3CONNMGR_UDP_DEFAULT_DELAY' [-Wunused-const-variable]
const uint32_t P3CONNMGR_UDP_DEFAULT_DELAY = 3; /* 2 Seconds? is it be
enough! */
2017-07-16 21:31:11 +02:00
Phenom
5b1323e31f
Fix clang warning: unused variables 'PQI_HANDLER_NB_PRIORITY_LEVELS',
...
...
/libretroshare/src/pqi/pqihandler.cc:71: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_LEVELS' [-Wunused-const-variable]
static const int PQI_HANDLER_NB_PRIORITY_LEVELS = 10 ;
/libretroshare/src/pqi/pqihandler.cc:72: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_RATIO' [-Wunused-const-variable]
static const float PQI_HANDLER_NB_PRIORITY_RATIO = 2 ;
2017-07-16 21:30:31 +02:00
Phenom
9148fa6645
Fix clang warning: unused variables 'RS_NET_DOWN', ...
...
/libretroshare/src/pqi/p3netmgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN = 0x0007;
/libretroshare/src/pqi/p3netmgr.cc:63: warning: unused variable
'RS_STUN_DHT' [-Wunused-const-variable]
const uint32_t RS_STUN_DHT = 0x0001;
/libretroshare/src/pqi/p3netmgr.cc:64: warning: unused variable
'RS_STUN_DONE' [-Wunused-const-variable]
const uint32_t RS_STUN_DONE = 0x0002;
/libretroshare/src/pqi/p3netmgr.cc:65: warning: unused variable
'RS_STUN_LIST_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_LIST_MIN = 100;
/libretroshare/src/pqi/p3netmgr.cc:66: warning: unused variable
'RS_STUN_FOUND_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_FOUND_MIN = 10;
/libretroshare/src/pqi/p3netmgr.cc:70: warning: unused variable
'MAX_NETWORK_INIT' [-Wunused-const-variable]
const uint32_t MAX_NETWORK_INIT = 70; /* timeout before network
reset */
/libretroshare/src/pqi/p3netmgr.cc:72: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET = 5;
2017-07-16 21:18:22 +02:00