Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2024-12-30 09:56:14 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity
11,173 Commits 63 Branches 22 Tags 196 MiB
9449e3b439
Commit Graph

11173 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Phenom
1f39789f2e Fix clang warning: 'RSGraphWidget::sizeHint' hides overloaded virtual 
function

/retroshare-gui/src/gui/common/RSGraphWidget.h:173: warning:
'RSGraphWidget::sizeHint' hides overloaded virtual function [-
Woverloaded-virtual]
        virtual QSizeF sizeHint( Qt::SizeHint which, const QSizeF &
constraint = QSizeF() ) const;
/usr/include/qt4/QtGui/qframe.h:76: hidden overloaded virtual function
'QFrame::sizeHint' declared here: different number of parameters (0 vs
2)
    QSize sizeHint() const;
 2017-07-17 22:34:32 +02:00
Phenom
300359863e Fix clang warning: 'p3ChatService' defined as a struct here but 
previously declared as a class

/libretroshare/src/chat/p3chatservice.h:56: warning: 'p3ChatService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3ChatService :
/libretroshare/src/rsserver/p3msgs.h:33: did you mean struct here?
class p3ChatService;
 2017-07-17 22:32:23 +02:00
Phenom
91c526f2b5 Fix clang warning: 'p3MsgService' defined as a struct here but 
previously declared as a class

/libretroshare/src/services/p3msgservice.h:58: warning: 'p3MsgService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3MsgService :
/libretroshare/src/rsserver/p3msgs.h:32: did you mean struct here?
class p3MsgService;
 2017-07-17 22:32:07 +02:00
Phenom
896ed3e992 Fix clang warning: class 'p3Config' was previously declared as a struct 
/libretroshare/src/retroshare/rsplugin.h:77: warning: class 'p3Config'
was previously declared as a struct [-Wmismatched-tags]
class p3Config;
 2017-07-17 22:31:30 +02:00
Phenom
8dbb0d61af Fix warning: this statement may fall through 
/libretroshare/src/dht/connectstatebox.cc:394: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:401: here
   default:

/libretroshare/src/dht/connectstatebox.cc:406: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:414: here
   case CSB_START:

/libretroshare/src/dht/connectstatebox.cc:530: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:540: here
   default:

/libretroshare/src/dht/connectstatebox.cc:543: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:551: here
   case CSB_START:
 2017-07-17 22:29:11 +02:00
csoler
7d8b3796d1 Merge pull request #941 from PhenomRetroShare/Add_UnsignedInChatName 
Add [Unsigned] before name in chat for unsigned (anonymous) GxsID.
 2017-07-17 22:18:53 +02:00
Gioacchino Mazzurco
b6731ed0f5 Better naming and doc for warning suppression CONFIG 2017-07-17 16:04:52 +02:00
Phenom
f888913800 Set Operating Mode in RsInit::InitRetroShare so noGUI could use it. 2017-07-17 15:40:14 +02:00
Phenom
8563957591 Add the ability to change OpMode in command line. 
So you can change OpMode while running via ssh to get more bandwidth.
Usage: RetroShare06 --opmode [full|noturtle|gaming|minimal]
 2017-07-17 14:36:51 +02:00
Phenom
c74c865058 Add new Filter by ID in FriendList. 2017-07-17 14:10:26 +02:00
cyril soler
1491a051dc fixed deadlock situation in FT causing multiple bugs: lock when DLing from a file list a file that is already being downloaded, and lock when a FT module find a direct source among friends 2017-07-17 11:16:48 +02:00
csoler
65326d9438 removed DEPRECATED warnings by default 2017-07-16 22:08:07 +02:00
Phenom
e2fa57dcd7 Fix clang warning: unused variable 'INTERVAL_BETWEEN_DEBUG_DUMP' 
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP        = 10 ;
 2017-07-16 21:43:05 +02:00
Phenom
a50c4ca8d2 Fix clang warning: unused variable 'kRecognTagClass_DEVELOPMENT' 
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:62: warning: unused
variable 'kRecognTagClass_DEVELOPMENT' [-Wunused-const-variable]
const int kRecognTagClass_DEVELOPMENT = 1;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:64: warning: unused
variable 'kRecognTagType_Dev_Ambassador' [-Wunused-const-variable]
const int kRecognTagType_Dev_Ambassador         = 1;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:65: warning: unused
variable 'kRecognTagType_Dev_Contributor' [-Wunused-const-variable]
const int kRecognTagType_Dev_Contributor        = 2;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:66: warning: unused
variable 'kRecognTagType_Dev_Translator' [-Wunused-const-variable]
const int kRecognTagType_Dev_Translator         = 3;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:67: warning: unused
variable 'kRecognTagType_Dev_Patcher' [-Wunused-const-variable]
const int kRecognTagType_Dev_Patcher            = 4;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:68: warning: unused
variable 'kRecognTagType_Dev_Developer' [-Wunused-const-variable]
const int kRecognTagType_Dev_Developer          = 5;
 2017-07-16 21:42:41 +02:00
Phenom
f2fb05db58 Fix clang warning: unused variables 'PARTIAL_VIEW_SIZE', ... 
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:67:
warning: unused variable 'PARTIAL_VIEW_SIZE' [-Wunused-const-variable]
static const int PARTIAL_VIEW_SIZE                           =  9 ;
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:68:
warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' [-Wunused-const-
variable]
static const int MAX_TUNNEL_REQUESTS_DISPLAY                 = 10 ;
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:69:
warning: unused variable 'GXSTRANS_STATISTICS_DELAY_BETWEEN_GROUP_REQ'
[-Wunused-const-variable]
static const int GXSTRANS_STATISTICS_DELAY_BETWEEN_GROUP_REQ = 30 ;
// never request more than every 30 secs.
 2017-07-16 21:42:23 +02:00
Phenom
6ee65bc98a Fix clang warning: using floating point absolute value function 'fabsf' 
when argument is of integer type

/retroshare-gui/src/gui/statistics/BWGraph.cpp:83: warning: using
floating point absolute value function 'fabsf' when argument is of
integer type [-Wabsolute-value]
        if(!lst.empty() && fabsf(lst.back().first - ms) >
_update_period_msecs*1.2 )
 2017-07-16 21:42:00 +02:00
Phenom
a0ac6b7ca0 Fix clang warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' 
/retroshare-gui/src/gui/statistics/TurtleRouterStatistics.cpp:36:
warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' [-Wunused-const-
variable]
static const int MAX_TUNNEL_REQUESTS_DISPLAY = 10 ;
/retroshare-gui/src/gui/statistics/GlobalRouterStatistics.cpp:58:
warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' [-Wunused-const-
variable]
static const int MAX_TUNNEL_REQUESTS_DISPLAY = 10 ;
 2017-07-16 21:41:14 +02:00
Phenom
64899e40e8 Fix clang warning: unused variable 'SFI_DEFAULT_PERIOD' 
/retroshare-gui/src/gui/feeds/SubFileItem.cpp:69: warning: unused
variable 'SFI_DEFAULT_PERIOD' [-Wunused-const-variable]
const uint32_t SFI_DEFAULT_PERIOD       = (30 * 3600 * 24); /* 30 Days
*/
 2017-07-16 21:40:29 +02:00
Phenom
b31c812d8d Fix clang warning: unused variable 'NEWSFEED_CHANNELMSGLIST' 
/retroshare-gui/src/gui/NewsFeed.cpp:70: warning: unused variable
'NEWSFEED_CHANNELMSGLIST' [-Wunused-const-variable]
const uint32_t NEWSFEED_CHANNELMSGLIST = 0x0005;
 2017-07-16 21:40:07 +02:00
Phenom
69060f8119 Modify #warning to get author and date. 2017-07-16 21:37:53 +02:00
Phenom
26397d7e4d Fix clang warning: unused variables 'LOWER_LIMIT', ... 
/libretroshare/src/services/p3gxsreputation.cc:130: warning: unused
variable 'LOWER_LIMIT' [-Wunused-const-variable]
static const uint32_t LOWER_LIMIT                         = 0;        //
used to filter valid Opinion values from serialized data
/libretroshare/src/services/p3gxsreputation.cc:132: warning: unused
variable 'kMaximumPeerAge' [-Wunused-const-variable]
static const int      kMaximumPeerAge                     = 180;      //
half a year.
/libretroshare/src/services/p3gxsreputation.cc:135: warning: unused
variable 'ACTIVE_FRIENDS_ONLINE_DELAY' [-Wunused-const-variable]
static const int      ACTIVE_FRIENDS_ONLINE_DELAY         = 86400*7 ; //
1 week.
/libretroshare/src/services/p3gxsreputation.cc:138: warning: unused
variable 'REPUTATION_ASSESSMENT_THRESHOLD_X1' [-Wunused-const-variable]
static const float    REPUTATION_ASSESSMENT_THRESHOLD_X1  = 0.5f ;    //
reputation under which the peer gets killed. Warning there's a 1 shift
with what's shown in GUI. Be careful.
/libretroshare/src/services/p3gxsreputation.cc:139: warning: unused
variable 'PGP_AUTO_BAN_THRESHOLD_DEFAULT' [-Wunused-const-variable]
static const uint32_t PGP_AUTO_BAN_THRESHOLD_DEFAULT      = 2 ;       //
above this, auto ban any GXS id signed by this node
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP        = 10 ;
 2017-07-16 21:37:22 +02:00
Phenom
903f875d1d Fix clang warning: unused variable 'MAX_SERIALIZED_ARRAY_SIZE' 
/libretroshare/src/serialiser/rstypeserializer.cc:39: warning: unused
variable 'MAX_SERIALIZED_ARRAY_SIZE' [-Wunused-const-variable]
static const uint32_t MAX_SERIALIZED_ARRAY_SIZE = 500 ;
 2017-07-16 21:36:35 +02:00
Phenom
d83a9625cc Fix clang warning: unused variables 'GIXS_CUT_OFF', ... 
/libretroshare/src/gxs/rsgxsnetservice.cc:247: warning: unused variable
'GIXS_CUT_OFF' [-Wunused-const-variable]
static const uint32_t GIXS_CUT_OFF                            =
0;
/libretroshare/src/gxs/rsgxsnetservice.cc:251: warning: unused variable
'SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE' [-Wunused-const-variable]
static const uint32_t SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE =
3600; // force re-update if there happens to be a large delay between
our server side TS and the client side TS of friends
 2017-07-16 21:36:14 +02:00
Phenom
51fa7a5dda Fix clang warning: unused variable 'p3facestartupzone' 
/libretroshare/src/rsserver/rsinit.cc:145: warning: unused variable
'p3facestartupzone' [-Wunused-const-variable]
const int p3facestartupzone = 47238;
 2017-07-16 21:35:35 +02:00
Phenom
13220ec414 Fix clang warning: unused variable 
'MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT'

/libretroshare/src/rsserver/p3peers.cc:52: warning: unused variable
'MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT' [-Wunused-const-variable]
static const int MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT = 30*24*3600 ;
// 30 days.
 2017-07-16 21:34:38 +02:00
Phenom
fea1b83b34 Fix clang warning: unused variable 'p3facemsgzone' 
/libretroshare/src/rsserver/p3face-config.cc:36: warning: unused
variable 'p3facemsgzone' [-Wunused-const-variable]
const int p3facemsgzone = 11453;

/libretroshare/src/rsserver/p3msgs.cc:33: warning: unused variable
'p3facemsgzone' [-Wunused-const-variable]
const int p3facemsgzone = 11453;
 2017-07-16 21:34:09 +02:00
Phenom
5a64996304 Fix clang warning: unused variables 'RS_NET_NEEDS_RESET', ... 
/libretroshare/src/pqi/p3peermgr.cc:53: warning: unused variable
'RS_NET_NEEDS_RESET' [-Wunused-const-variable]
const uint32_t RS_NET_NEEDS_RESET =     0x0000;
/libretroshare/src/pqi/p3peermgr.cc:54: warning: unused variable
'RS_NET_UNKNOWN' [-Wunused-const-variable]
const uint32_t RS_NET_UNKNOWN =         0x0001;
/libretroshare/src/pqi/p3peermgr.cc:55: warning: unused variable
'RS_NET_UPNP_INIT' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_INIT =       0x0002;
/libretroshare/src/pqi/p3peermgr.cc:56: warning: unused variable
'RS_NET_UPNP_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_SETUP =      0x0003;
/libretroshare/src/pqi/p3peermgr.cc:57: warning: unused variable
'RS_NET_EXT_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_EXT_SETUP =       0x0004;
/libretroshare/src/pqi/p3peermgr.cc:58: warning: unused variable
'RS_NET_DONE' [-Wunused-const-variable]
const uint32_t RS_NET_DONE =            0x0005;
/libretroshare/src/pqi/p3peermgr.cc:59: warning: unused variable
'RS_NET_LOOPBACK' [-Wunused-const-variable]
const uint32_t RS_NET_LOOPBACK =        0x0006;
/libretroshare/src/pqi/p3peermgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN =            0x0007;
/libretroshare/src/pqi/p3peermgr.cc:62: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET =             5;
/libretroshare/src/pqi/p3peermgr.cc:64: warning: unused variable
'PEER_IP_CONNECT_STATE_MAX_LIST_SIZE' [-Wunused-const-variable]
const uint32_t PEER_IP_CONNECT_STATE_MAX_LIST_SIZE =            4;
 2017-07-16 21:31:41 +02:00
Phenom
4152a46ad8 Fix clang warning: unused variable 'P3CONNMGR_UDP_DEFAULT_DELAY' 
/libretroshare/src/pqi/p3linkmgr.cc:78: warning: unused variable
'P3CONNMGR_UDP_DEFAULT_DELAY' [-Wunused-const-variable]
const uint32_t P3CONNMGR_UDP_DEFAULT_DELAY = 3; /* 2 Seconds? is it be
enough! */
 2017-07-16 21:31:11 +02:00
Phenom
5b1323e31f Fix clang warning: unused variables 'PQI_HANDLER_NB_PRIORITY_LEVELS', 
...

/libretroshare/src/pqi/pqihandler.cc:71: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_LEVELS' [-Wunused-const-variable]
static const int PQI_HANDLER_NB_PRIORITY_LEVELS = 10 ;
/libretroshare/src/pqi/pqihandler.cc:72: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_RATIO' [-Wunused-const-variable]
static const float PQI_HANDLER_NB_PRIORITY_RATIO = 2 ;
 2017-07-16 21:30:31 +02:00
Phenom
9148fa6645 Fix clang warning: unused variables 'RS_NET_DOWN', ... 
/libretroshare/src/pqi/p3netmgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN =            0x0007;
/libretroshare/src/pqi/p3netmgr.cc:63: warning: unused variable
'RS_STUN_DHT' [-Wunused-const-variable]
const uint32_t RS_STUN_DHT =            0x0001;
/libretroshare/src/pqi/p3netmgr.cc:64: warning: unused variable
'RS_STUN_DONE' [-Wunused-const-variable]
const uint32_t RS_STUN_DONE =           0x0002;
/libretroshare/src/pqi/p3netmgr.cc:65: warning: unused variable
'RS_STUN_LIST_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_LIST_MIN =       100;
/libretroshare/src/pqi/p3netmgr.cc:66: warning: unused variable
'RS_STUN_FOUND_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_FOUND_MIN =      10;
/libretroshare/src/pqi/p3netmgr.cc:70: warning: unused variable
'MAX_NETWORK_INIT' [-Wunused-const-variable]
const uint32_t MAX_NETWORK_INIT =       70; /* timeout before network
reset */
/libretroshare/src/pqi/p3netmgr.cc:72: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET =             5;
 2017-07-16 21:18:22 +02:00
Phenom
e4616c09bc Fix clang warning: unused variable 'STORE_KEY_TIMEOUT' 
/libretroshare/src/pqi/authgpg.cc:51: warning: unused variable
'STORE_KEY_TIMEOUT' [-Wunused-const-variable]
const time_t STORE_KEY_TIMEOUT = 1 * 60 * 60; //store key is call around
every hour
 2017-07-16 21:17:52 +02:00
Phenom
0479ec07ab Fix clang warning: unused variable 'MAX_MESSAGES_PER_SECONDS_NUMBER' 
/libretroshare/src/chat/distributedchat.cc:57: warning: unused variable
'MAX_MESSAGES_PER_SECONDS_NUMBER' [-Wunused-const-variable]
static const uint32_t MAX_MESSAGES_PER_SECONDS_NUMBER     =  5 ; // max
number of messages from a given peer in a window for duration below
 2017-07-16 21:17:06 +02:00
Phenom
80ea4de7be Fix clang warning: unused variable 'ftserverzone' 
/libretroshare/src/ft/ftserver.cc:34: warning: unused variable
'ftserverzone' [-Wunused-const-variable]
const int ftserverzone = 29539;
 2017-07-16 21:16:30 +02:00
Phenom
8a270af519 fixed merging problem 2017-07-16 21:15:26 +02:00
Phenom
35186c4054 Fix clang warning: unused variable 'res' 
/libretroshare/src/crypto/chacha20.cpp:978: warning: unused variable
'res' [-Wunused-variable]
        uint256_32 res(q1) ;
 2017-07-16 21:12:09 +02:00
Phenom
7f1e23085d Fix clang warning: unused variable 'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG', ... 
/libretroshare/src/ft/fttransfermodule.cc:56: warning: unused variable
'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_MAX_WAIT_PER_GIG = 20; /* 20 seconds per
gigabyte */
/libretroshare/src/ft/fttransfermodule.cc:65: warning: unused variable
'FT_TM_FAST_RTT' [-Wunused-const-variable]
const int32_t FT_TM_FAST_RTT    = 1.0;
/libretroshare/src/ft/fttransfermodule.cc:66: warning: unused variable
'FT_TM_STD_RTT' [-Wunused-const-variable]
const int32_t FT_TM_STD_RTT     = 5.0;
/libretroshare/src/ft/fttransfermodule.cc:67: warning: unused variable
'FT_TM_SLOW_RTT' [-Wunused-const-variable]
const int32_t FT_TM_SLOW_RTT    = 20.0;
/libretroshare/src/ft/fttransfermodule.cc:69: warning: unused variable
'FT_TM_CRC_MAP_STATE_NOCHECK' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_NOCHECK      = 0 ;
/libretroshare/src/ft/fttransfermodule.cc:70: warning: unused variable
'FT_TM_CRC_MAP_STATE_DONT_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_DONT_HAVE = 1 ;
/libretroshare/src/ft/fttransfermodule.cc:71: warning: unused variable
'FT_TM_CRC_MAP_STATE_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_HAVE                 = 2 ;
 2017-07-16 21:11:47 +02:00
Phenom
8b99c80e07 Fix clang warning: 'p3GxsTrans' defined as a class here but previously 
declared as a struct

/libretroshare/src/gxstrans/p3gxstrans.h:88: warning: 'p3GxsTrans'
defined as a class here but previously declared as a struct [-
Wmismatched-tags]
class p3GxsTrans : public RsGenExchange, public GxsTokenQueue, public
p3Config, public RsGxsTrans
/libretroshare/src/gxstrans/p3gxstrans.h:31: did you mean class here?
struct p3GxsTrans;
 2017-07-16 21:11:10 +02:00
Phenom
fd24ef591e Fix warning: comparison between signed and unsigned integer expressions 
and misleading-indentation

/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
     for(uint32_t i=0;i<mMessageVersions.size();++i)

/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: this ‘for’
clause does not guard... [-Wmisleading-indentation]
     for(uint32_t i=0;i<mMessageVersions.size();++i)
 2017-07-16 21:10:45 +02:00
Phenom
431b56406d Fix warning: unused variable ‘popLimit’ 
/retroshare-gui/src/gui/gxs/GxsGroupFrameDialog.cpp:831: warning: unused
variable ‘popLimit’ [-Wunused-variable]
  uint32_t popLimit = 0;
 2017-07-16 21:09:58 +02:00
Phenom
2444e6e66e Fix warning: this statement may fall through 
/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:654: warning: this
statement may fall through [-Wimplicit-fallthrough=]
     case 2: signFlags |=
GXS_SERV::FLAG_AUTHOR_AUTHENTICATION_GPG_KNOWN; // no break below, since
we want *both* flags in this case.
 2017-07-16 21:09:33 +02:00
Phenom
dcb8a352df Fix warning: unused variable ‘self’ 
and misleading-indentation

/retroshare-gui/src/gui/feeds/GxsChannelPostItem.cpp:54: warning: unused
variable ‘self’ [-Wunused-variable]
     bool self = false;

/retroshare-gui/src/gui/feeds/GxsChannelPostItem.cpp:225: warning: this
‘if’ clause does not guard... [-Wmisleading-indentation]
     if(!IS_GROUP_PUBLISHER(mGroup.mMeta.mSubscribeFlags))
 2017-07-16 21:07:47 +02:00
Phenom
ca9357cd20 Fix warning: this ‘if’ clause does not guard... 
/retroshare-gui/src/gui/gxschannels/CreateGxsChannelMsg.cpp:360:
warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if(assume_file_ready)
 2017-07-16 21:06:54 +02:00
Phenom
b5c503a324 Fix warning: unused variable ‘prev_index’ 
/retroshare-gui/src/gui/gxschannels/GxsChannelPostsWidget.cpp:535:
warning: unused variable ‘prev_index’ [-Wunused-variable]
     uint32_t prev_index = current_index ;
 2017-07-16 21:06:01 +02:00
Phenom
3a22c6d302 Fix warning: comparison between signed and unsigned integer expressions 
/retroshare-gui/src/gui/gxsforums/GxsForumsFillThread.cpp:286: warning:
comparison between signed and unsigned integer expressions [-Wsign-
compare]
         for(uint32_t i=1;i<(*it).size();++i)
 2017-07-16 20:57:19 +02:00
Phenom
6fd03087d2 Fix warning: this statement may fall through 
/retroshare-gui/src/gui/statistics/BWGraph.cpp:245: warning: this
statement may fall through [-Wimplicit-fallthrough=]
   case GRAPH_TYPE_ALL: std::cerr << "(WW) Impossible situation. Cannot
draw graph in mode All/All. Reverting to sum." << std::endl;
 2017-07-16 20:56:46 +02:00
Phenom
f27ce82e22 Fix warning: comparison between signed and unsigned integer expressions 
, misleading-indentation and unused-variable

/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: comparison between signed and unsigned integer expressions [-
Wsign-compare]
     for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)

/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
     for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)

/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:203:
warning: unused variable ‘now’ [-Wunused-variable]
     time_t now = time(NULL) ;
 2017-07-16 20:56:18 +02:00
Phenom
15bc9c1c3c Fix warning: this statement may fall through 
/retroshare-gui/src/gui/GetStartedDialog.cpp:122: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    ui.firewallCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:124: here
   case RSCONFIG_USER_LEVEL_CASUAL:

/retroshare-gui/src/gui/GetStartedDialog.cpp:125: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    ui.connectCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:127: here
   case RSCONFIG_USER_LEVEL_BASIC:
 2017-07-16 20:54:41 +02:00
Phenom
f23c84fd4e Fix warning: this statement may fall through 
/retroshare-gui/src/gui/RetroShareLink.cpp:585: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if(!checkSSLId(_SSLid))
/retroshare-gui/src/gui/RetroShareLink.cpp:587: here
   case TYPE_FILE:
 2017-07-16 20:54:05 +02:00
Phenom
9a4ed8012c Fix warning: comparison between signed and unsigned integer expressions 
and unused variables

/retroshare-nogui/src/TerminalApiClient.cpp:233: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
    while(selected_account_number >= accounts.size())

/retroshare-nogui/src/TerminalApiClient.cpp:243: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
     if(selected_account_number >= accounts.size())

/retroshare-nogui/src/TerminalApiClient.cpp:121: warning: unused
variable ‘IO_POLL_PERIOD’ [-Wunused-variable]
     const int IO_POLL_PERIOD          = 20;

/retroshare-nogui/src/TerminalApiClient.cpp:124: warning: unused
variable ‘last_io_poll’ [-Wunused-variable]
     int last_io_poll  = 0;

/retroshare-nogui/src/TerminalApiClient.cpp:127: warning: unused
variable ‘last_char’ [-Wunused-variable]
     int last_char = 0;

/retroshare-nogui/src/TerminalApiClient.cpp:129: warning: unused
variable ‘enter_was_pressed’ [-Wunused-variable]
     bool enter_was_pressed = false;

/retroshare-nogui/src/TerminalApiClient.cpp:133: warning: variable
‘account_number_typed’ set but not used [-Wunused-but-set-variable]
  int account_number_typed = 0 ;
 2017-07-16 20:53:14 +02:00
Phenom
8455adf375 Fix warning: unused parameter ‘type’ and ‘req’ 
/libresapi/src/api/ChatHandler.cpp:236: warning: unused parameter ‘type’
[-Wunused-parameter]
 void ChatHandler::notifyListChange(int list, int type)

/libresapi/src/api/ChatHandler.cpp:971: warning: unused parameter ‘req’
[-Wunused-parameter]
 void ChatHandler::handleGetInvitationsToLobby(Request& req, Response&
resp)
 2017-07-16 20:49:27 +02:00