Commit Graph

1151 Commits

Author SHA1 Message Date
Phenom
5a64996304 Fix clang warning: unused variables 'RS_NET_NEEDS_RESET', ...
/libretroshare/src/pqi/p3peermgr.cc:53: warning: unused variable
'RS_NET_NEEDS_RESET' [-Wunused-const-variable]
const uint32_t RS_NET_NEEDS_RESET =     0x0000;
/libretroshare/src/pqi/p3peermgr.cc:54: warning: unused variable
'RS_NET_UNKNOWN' [-Wunused-const-variable]
const uint32_t RS_NET_UNKNOWN =         0x0001;
/libretroshare/src/pqi/p3peermgr.cc:55: warning: unused variable
'RS_NET_UPNP_INIT' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_INIT =       0x0002;
/libretroshare/src/pqi/p3peermgr.cc:56: warning: unused variable
'RS_NET_UPNP_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_SETUP =      0x0003;
/libretroshare/src/pqi/p3peermgr.cc:57: warning: unused variable
'RS_NET_EXT_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_EXT_SETUP =       0x0004;
/libretroshare/src/pqi/p3peermgr.cc:58: warning: unused variable
'RS_NET_DONE' [-Wunused-const-variable]
const uint32_t RS_NET_DONE =            0x0005;
/libretroshare/src/pqi/p3peermgr.cc:59: warning: unused variable
'RS_NET_LOOPBACK' [-Wunused-const-variable]
const uint32_t RS_NET_LOOPBACK =        0x0006;
/libretroshare/src/pqi/p3peermgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN =            0x0007;
/libretroshare/src/pqi/p3peermgr.cc:62: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET =             5;
/libretroshare/src/pqi/p3peermgr.cc:64: warning: unused variable
'PEER_IP_CONNECT_STATE_MAX_LIST_SIZE' [-Wunused-const-variable]
const uint32_t PEER_IP_CONNECT_STATE_MAX_LIST_SIZE =            4;
2017-07-16 21:31:41 +02:00
Phenom
4152a46ad8 Fix clang warning: unused variable 'P3CONNMGR_UDP_DEFAULT_DELAY'
/libretroshare/src/pqi/p3linkmgr.cc:78: warning: unused variable
'P3CONNMGR_UDP_DEFAULT_DELAY' [-Wunused-const-variable]
const uint32_t P3CONNMGR_UDP_DEFAULT_DELAY = 3; /* 2 Seconds? is it be
enough! */
2017-07-16 21:31:11 +02:00
Phenom
5b1323e31f Fix clang warning: unused variables 'PQI_HANDLER_NB_PRIORITY_LEVELS',
...

/libretroshare/src/pqi/pqihandler.cc:71: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_LEVELS' [-Wunused-const-variable]
static const int PQI_HANDLER_NB_PRIORITY_LEVELS = 10 ;
/libretroshare/src/pqi/pqihandler.cc:72: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_RATIO' [-Wunused-const-variable]
static const float PQI_HANDLER_NB_PRIORITY_RATIO = 2 ;
2017-07-16 21:30:31 +02:00
Phenom
9148fa6645 Fix clang warning: unused variables 'RS_NET_DOWN', ...
/libretroshare/src/pqi/p3netmgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN =            0x0007;
/libretroshare/src/pqi/p3netmgr.cc:63: warning: unused variable
'RS_STUN_DHT' [-Wunused-const-variable]
const uint32_t RS_STUN_DHT =            0x0001;
/libretroshare/src/pqi/p3netmgr.cc:64: warning: unused variable
'RS_STUN_DONE' [-Wunused-const-variable]
const uint32_t RS_STUN_DONE =           0x0002;
/libretroshare/src/pqi/p3netmgr.cc:65: warning: unused variable
'RS_STUN_LIST_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_LIST_MIN =       100;
/libretroshare/src/pqi/p3netmgr.cc:66: warning: unused variable
'RS_STUN_FOUND_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_FOUND_MIN =      10;
/libretroshare/src/pqi/p3netmgr.cc:70: warning: unused variable
'MAX_NETWORK_INIT' [-Wunused-const-variable]
const uint32_t MAX_NETWORK_INIT =       70; /* timeout before network
reset */
/libretroshare/src/pqi/p3netmgr.cc:72: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET =             5;
2017-07-16 21:18:22 +02:00
Phenom
e4616c09bc Fix clang warning: unused variable 'STORE_KEY_TIMEOUT'
/libretroshare/src/pqi/authgpg.cc:51: warning: unused variable
'STORE_KEY_TIMEOUT' [-Wunused-const-variable]
const time_t STORE_KEY_TIMEOUT = 1 * 60 * 60; //store key is call around
every hour
2017-07-16 21:17:52 +02:00
Phenom
a0506c1a0f Fix warning: this statement may fall through
/libretroshare/src/pqi/pqissl.cc:449: warning: this statement may fall
through [-Wimplicit-fallthrough=]
    sslmode = PQISSL_ACTIVE; /* we're starting this one */
/libretroshare/src/pqi/pqissl.cc:456: here
   case WAITING_DELAY:
2017-07-16 20:31:49 +02:00
Phenom
b9d4651f07 Fix warning: this statement may fall through
/libretroshare/src/pqi/pqisslpersongrp.cc:125: warning: this statement
may fall through [-Wimplicit-fallthrough=]
     std::cerr << " --> falling back to Tor" << std::endl;
/libretroshare/src/pqi/pqisslpersongrp.cc:126: here
    case RS_HIDDEN_TYPE_TOR:
2017-07-16 20:30:41 +02:00
Phenom
e12f51b1be Fix warning: variable ‘peerIt1’ set but not used
/libretroshare/src/pqi/p3peermgr.cc:2619: warning: variable ‘peerIt1’
set but not used [-Wunused-but-set-variable]
                     std::set<RsPgpId>::iterator peerIt1 =
groupItem.peerIds.find(*peerIt);
2017-07-16 20:28:24 +02:00
csoler
a5e0b1c336 fixed -U option in rs-nogui. Removed debug output that would ruin the terminal interface 2017-07-11 23:32:22 +02:00
csoler
5dfbce7e3a fixed Terminal Api Client logic 2017-07-09 21:16:41 +02:00
BabushkaRetroShare
7fb0419c75
Typo fixes 2017-06-04 20:34:10 +02:00
cyril soler
8e7e70035a fixed compilation for windows 2017-06-01 10:16:30 +02:00
csoler
1ebcc6006b Merge pull request #861 from RetroShare/v0.6-GxsTransport
V0.6 gxs transport
2017-05-30 22:22:06 +02:00
csoler
0868b64436 fixed uninitialized memory read in GxsTrans msg Id 2017-05-28 22:49:07 +02:00
sehraf
a3ee85a30d Add I2P BOB support to libretroashare and RetroShare GUI 2017-05-24 19:40:01 +02:00
Enno Boland
2046d9eaae fix building with libressl 2017-05-21 10:48:58 +02:00
csoler
c0c5cc52db Merge branch 'master' into gxs_mail_experiments 2017-05-13 21:08:16 +02:00
Phenom
4a2f688f14 Fix Windows Compilation:
pqi/authssl.cc: In member function 'virtual X509*
AuthSSLimpl::SignX509ReqWithGPG(X509_REQ*, long int)':
pqi/authssl.cc:929:3: error: jump to label 'err' [-fpermissive]
   err:
   ^
pqi/authssl.cc:872:22: error:   from here [-fpermissive]
                 goto err;
                      ^
pqi/authssl.cc:877:24: error:   crosses initialization of 'unsigned
char* p'
         unsigned char *p=buf_in;
                        ^
pqi/authssl.cc: In member function 'virtual bool
AuthSSLimpl::AuthX509WithGPG(X509*, uint32_t&)':
pqi/authssl.cc:1091:1: error: jump to label 'err' [-fpermissive]
 err:
 ^
pqi/authssl.cc:1027:8: error:   from here [-fpermissive]
   goto err;
        ^
pqi/authssl.cc:1035:17: error:   crosses initialization of 'unsigned
char* p'
  unsigned char *p=buf_in;
                 ^
2017-05-08 13:01:34 +02:00
Phenom
91e3cc3e5f Fix Warnings: variable ‘p’ set but not used
warning: variable ‘p’ set but not used [-Wunused-but-set-variable]
  unsigned char *p,*buf_in=NULL;
                 ^
2017-05-08 12:11:48 +02:00
Phenom
ca291b7ee6 Fix Warnings: warning: unused variable ‘i2d’
warning: unused variable ‘i2d’ [-Wunused-variable]
  int (*i2d)(X509_CINF*, unsigned char**) = i2d_X509_CINF;
        ^~~
2017-05-08 12:05:58 +02:00
Phenom
9021609a6b Fix Warnings: unused variable ‘p’
warning: unused variable ‘p’ [-Wunused-variable]
         unsigned char *p,*buf_in=NULL;
                        ^
2017-05-08 12:04:08 +02:00
Gioacchino Mazzurco
5159e326c7 Merge branch 'master' into gxs_mail_experiments 2017-05-05 15:44:22 +02:00
csoler
4bee52c406 removed old unused serialization code 2017-05-02 22:34:45 +02:00
csoler
99d8b7d5d8 switched service control items to new serialization 2017-05-01 21:23:34 +02:00
csoler
cecd9a3368 merged upstream/master 2017-04-30 20:14:23 +02:00
csoler
24c7c38016 removed old file rssrviceserialiser.h/cc 2017-04-30 20:08:30 +02:00
csoler
14076de1e0 moved code of rsservicerserialiser into rsserializer.h/cc and renamed it into RsRawSerializer 2017-04-30 19:17:44 +02:00
csoler
77c2e6da8c improved error handlign in pqistore 2017-04-26 18:14:10 +02:00
csoler
9c610a736d cleaned the hierarchy of serialization classes 2017-04-26 11:40:46 +02:00
csoler
77e809ea4b switched GRouter to new serialization 2017-04-25 21:21:46 +02:00
Phenom
3592d5bf5d Fix GCC warnings: unused parameter ‘names’
/libretroshare/src/pqi/pqiservice.h:80: warning: unused parameter
‘names’ [-Wunused-parameter]
     virtual void getItemNames(std::map<uint8_t,std::string>& names)
const {} // This does nothing by default. Service should derive it in
order to give info for the UI
                                                              ^~~~~
2017-04-25 09:53:06 +02:00
csoler
0d7df568b4 moved rsconfigitems and rshistoryitems to rsitems/ 2017-04-24 22:47:08 +02:00
csoler
fcabe6359f switch RsConfigItems to new serialization 2017-04-24 18:51:51 +02:00
csoler
f6aaee7382 converted RTT items to new serialization 2017-04-24 11:01:45 +02:00
csoler
5f8bf03dfe added mechanism to allow services to document the names of their items, and improved bandwidth graph to show names for GXS services. Other services still need to supply their own names 2017-04-20 20:54:51 +02:00
csoler
e2d9152b22 moved converted serialisation files into new directory rsitems/, leaving serialiser/ for the serialisation classes 2017-04-18 21:11:37 +02:00
Phenom
e83104ee0f Fix Clang warnings: Add author and date to #warning 2017-04-17 21:32:14 +02:00
Phenom
22043094b5 Fix Clang warnings: extraneous parentheses
warning: equality comparison with extraneous parentheses [-Wparentheses-
equality]
                else if ((err == ECONNREFUSED))
                          ~~~~^~~~~~~~~~~~~~~
2017-04-17 21:26:50 +02:00
Phenom
dc533b1346 Fix Clang warnings: private field not used
warning: private field 'lastGroupId' is not used [-Wunused-private-
field]
    uint32_t lastGroupId;
warning: private field 'waittimes' is not used [-Wunused-private-field]
        int waittimes;
warning: private field 'listen_checktime' is not used [-Wunused-private-
field]
        long listen_checktime;
2017-04-17 21:26:09 +02:00
Phenom
65321501e4 Fix Clang warnings: Overloaded vf hide in p3dhtmgr
warning: 'p3DhtMgr::findPeer' hides overloaded virtual function [-
Woverloaded-virtual]
virtual bool    findPeer(std::string id);
warning: 'p3DhtMgr::dropPeer' hides overloaded virtual function [-
Woverloaded-virtual]
virtual bool    dropPeer(std::string id);
warning: 'p3DhtMgr::getPeerStatus' hides overloaded virtual function [-
Woverloaded-virtual]
virtual bool    getPeerStatus(std::string id,
2017-04-17 21:24:45 +02:00
Phenom
6fecac5f7b Fix Clang warnings: Overloaded vf hide
warning: 'pqiconnect::connect_parameter' hides overloaded virtual
function [-Woverloaded-virtual]
        virtual bool connect_parameter(uint32_t type, std::string value)
{ return ni->connect_parameter(type, value);}
                     ^
2017-04-17 21:15:52 +02:00
Phenom
105840ab98 Fix Clang Warning: Overloaded vf hide
warning: 'pqiConnectCbDummy::peerConnectRequest' hides overloaded
virtual function [-Woverloaded-virtual]
virtual void    peerConnectRequest(const RsPeerId& id,
                ^
2017-04-17 21:10:22 +02:00
Gioacchino Mazzurco
2630ed4573 Merge branch 'master' into gxs_mail_experiments 2017-03-13 22:57:33 +01:00
cyril soler
69c3df6dff fixed bug in total item size estimation in pqiqosstreamer due to item slicing 2017-03-10 15:36:50 +01:00
cyril soler
fd84639a45 removed some debug info 2017-03-10 15:05:41 +01:00
csoler
ee9fbefd76 added signal blockign trick for widgets, and fixed the bug causing wrong values to be displayed in server settings 2017-02-27 22:29:01 +01:00
Gioacchino Mazzurco
9a3af092eb Merge branch 'master' into gxs_mail_experiments 2017-02-27 08:43:29 +01:00
csoler
99cf69a98c Merge pull request #703 from RetroShare/v0.6-ImprovedGUI
V0.6 improved gui
2017-02-26 20:14:34 +01:00
csoler
eb817af9b8 Merge pull request #689 from csoler/v0.6-SSL110Fix
fixing compilation with openssl-1.1.0 (part 1)
2017-02-26 20:12:52 +01:00
csoler
e75487e48a suppressed a few warnings (suggested by Phenom) 2017-02-25 23:16:43 +01:00
Gioacchino Mazzurco
748e75d3e1 Fix pqiSSLstore::encryptedSendItems empty list
RsTemporaryMemory was complaining of being initialized with size 0 in
case of empty list was passed to the method, this is a legitimate use
case when one want have an empty list as state, so in this case pass 1
as argument to RsTemporaryMemory constructor
2017-02-25 23:09:46 +01:00
Gioacchino Mazzurco
828792f2b5 p3Config improved coding style 2017-02-23 13:20:07 +01:00
csoler
0e57874ad3 fixed loading of settings::Server page 2017-02-22 22:22:50 +01:00
csoler
8c3f553579 fixed compilation with openssl1.0.1 broken by previous commits 2017-02-20 22:54:25 +01:00
csoler
5c95b88095 compilation fix for openssl-1.1.0 (pqissl+authssl part) 2017-02-19 22:38:02 +01:00
csoler
ccacba797f added pgp passphrase temporary caching in order to avoid re-asking for password at location creation time 2017-02-12 15:27:13 +01:00
jolavillette
1b8de7b30e Attempt to reduce BW bursts 2017-01-18 13:25:45 +01:00
csoler
d3051eff1a added display of usage statistics for GXS identities 2016-12-21 00:34:07 +01:00
Phenom
674b6de381 Fix Some gcc warnings 383 to 208 lines
Left explicit #warning and deprecated.
Some lines are wrong indented and produce mal formed code.
2016-11-30 22:01:01 +01:00
Gio
8ab3c7de26 Merge branch 'master' into android 2016-11-07 14:37:23 +01:00
BuildTools
78d6735b52 Create 2 #define in pqistreamer to easily disable packet slicing/grouping 2016-11-05 19:58:06 +01:00
BuildTools
192cbe1eda Create two #define in pqistreamer.cc to easily disable packet slicing and/or grouping 2016-11-05 14:57:39 +01:00
Gio
ea42d822c2 Merge branch 'master' into android 2016-10-26 13:43:24 +02:00
csoler
e42dae8f78 continue sending packet slicing probes in case the peer has restarted 2016-10-04 21:34:23 +02:00
csoler
b08a62afc9 restored delay between location cleaning to 5 mins 2016-10-04 21:25:56 +02:00
csoler
133676fdee simplified the code to remove old locations and fixed bug that in some situation would let a PGP key with no locations 2016-10-04 21:25:56 +02:00
csoler
c968490b43 switched to floating point time for bandwidth estimation in pqistreamer. Helps a lot RTTs since rounding to int prveviously caused packets to be delayed up to 1 sec (improvement by Jollavilette) 2016-10-01 22:15:06 +02:00
cyril soler
7bddd4bcd4 removed call to exit causing the software to stop when local network interfaces are not ready 2016-09-23 13:19:19 +02:00
Gio
48a9be0ccc Use Qt to read the local addresses on android
getifaddrs is not present on android and an alternative implementation
crashed, use QNetworkInterface::allAddresses() to retrieve local
addresses list instead

This
2016-09-21 12:46:55 +02:00
Gio
9d83d56811 Merge branch 'master' into android 2016-09-04 15:16:57 +02:00
Gio
7a2ae6e979 Remove some clutter from libretroshare
Removed SearchInterface that was an historical remain that make no sense anymore
Fixed some clang warning
Fix includes on some files
2016-08-25 11:39:15 +02:00
Gio
68a00138d2 Avoid usage of deprecated function RSA_generate_key that make android
compiler mad
2016-08-23 12:15:28 +02:00
Gio
9a980def2c libretroshare now compiles for Android, instruction on how to do it included 2016-08-23 12:15:28 +02:00
dimqua
613ce25209 Change I2P proxy default port to 4447 2016-08-19 09:47:52 +04:00
Phenom
275c47eff9 Add Title when ask for password. 2016-08-09 01:22:14 +02:00
Phenom
d59f7a09db Fix NAT Status LED
Fix the PR#426 4d2d825d
2016-08-08 21:59:12 +02:00
csoler
a69629cf73 added missing own id from group list, and removed possible duplicates in random group ids 2016-07-06 22:16:05 -04:00
csoler
269f9457be fixed load/save of new group ids and backward compatibility with FriendList 2016-07-06 22:02:56 -04:00
csoler
01c0d2f0f1 finished conversion to RsNodeGroupId for file transfer and GUI 2016-07-05 23:49:43 -04:00
csoler
4ee9effc4e changed internal storage of groups of friend nodes so as to use an abstract ID instead of a string (phase 1 of local circles) 2016-07-04 23:55:48 -04:00
Cyril Soler
c15c979851 Merge pull request #426 from sehraf/pr-disable-dht-stunner
This patch set adds an option to use the DHT stunner to qmake
2016-06-27 17:17:28 +01:00
csoler
ff8667834b clear error queue before calling SSL_read()/SSL_write(), to avoid remaining errors to corrupt the next connection attempts and cause disconnections 2016-06-26 23:14:01 -04:00
csoler
31089d7a91 added auto-clean of pending data in pqistreamer after connection is closed, to avoid confusing the peer after re-connecting (probably not the cause of the SSL errors we see) 2016-06-25 19:12:47 +01:00
sehraf
5d962682e1 removed unused variable warnings 2016-06-21 14:02:52 +02:00
sehraf
4d2d825d5b add new option to qmake to enable dht stunner
removed dht stunner code when option is not set
2016-06-21 13:55:23 +02:00
Cyril Soler
90a27f4e81 Merge pull request #418 from sehraf/pr-improve-debug
This is the first set of patches to improve RS' logging functionality
2016-06-18 15:33:10 -04:00
sehraf
09afbbed5d switched to new rslog method 2016-06-18 13:00:15 +02:00
csoler
dbd78d2401 merged with upstream/master 2016-06-16 20:19:03 -04:00
csoler
6b74a8a1b6 added missing call to ssl_pendign in pqissludp. 2016-06-14 21:54:24 -04:00
csoler
8c44e69012 added output of items which doesnot serialise correctly in pqisslstore 2016-06-14 21:54:24 -04:00
csoler
972de42864 converted static variable to class member in pqihandler 2016-06-11 18:07:57 -04:00
Cyril Soler
248d0c42d3 Merge pull request #412 from csoler/v0.6-MaxUpRate
V0.6 max up rate
2016-06-11 17:58:08 -04:00
csoler
ef4455ac9c cleaned the MaxUpRate branch from unused code 2016-06-11 17:54:11 -04:00
csoler
8e75185060 made avgReadCount and avgSendCound to be uint32_t instead of floats, since they count bytes. Changes kb to 1024 instead of 1000 2016-06-11 17:21:04 -04:00
csoler
373d41bc63 added missing variable def after previous commit 2016-06-11 14:11:21 -04:00
csoler
23e8e932be added mutex proteciton around mAvgLastUpdate to avoid it being changed by the constructor 2016-06-11 09:50:22 -04:00
csoler
0d1d31a25f added mutex protection around pqistreamer::getRates, since float r/w are not necessarily atomic 2016-06-11 09:33:16 -04:00
csoler
83a143476e fixed bug in setting MaxRate values 2016-06-09 23:23:51 -04:00
csoler
f5ad8b49be moved node-wide options to node details 2016-06-09 23:13:07 -04:00
csoler
a4931edee0 fixed setting/getting maxrates using pgp id 2016-06-09 20:51:09 -04:00