Commit Graph

246 Commits

Author SHA1 Message Date
Phenom
1456bdd641 Fix CppCheck in dir_hierarchy.h and dir_hierarchy.cc
/libretroshare/src/file_sharing/dir_hierarchy.cc:883: warning:
Cppcheck(unreadVariable): Variable 'nunknown' is modified but its new
value is never used.
/libretroshare/src/file_sharing/dir_hierarchy.h:71: warning:
Cppcheck(noExplicitConstructor): Class 'DirEntry' has a constructor with
1 argument that is not explicit.
/libretroshare/src/file_sharing/dir_hierarchy.cc:1056: warning:
Cppcheck(noExplicitConstructor): Class 'read_error' has a constructor
with 1 argument that is not explicit.
2017-11-05 16:22:51 +01:00
csoler
3bb694f439 added display of hashing speed. Changed hashing buffer size to 10MB to improve performance 2017-10-29 21:24:34 +01:00
csoler
edffbc3670 fixed bug in removing top dirs when creating file hierarhies 2017-10-21 18:09:26 +02:00
csoler
32be00614d various improvements to collection links 2017-10-19 10:19:56 +02:00
csoler
9206daca37 fixed up collection link display 2017-10-18 23:20:19 +02:00
csoler
e1d5014288 added copy links from file hierarchy 2017-10-18 22:32:15 +02:00
csoler
f98edd400e added FileTree class to implement a compact representation of file hierarchies 2017-10-18 00:04:04 +02:00
csoler
d61a5cd5ab attempt at fixing the re-hash bug. Now only using canonicalized filenames in hash cache 2017-10-02 22:23:26 +02:00
csoler
22942dc70b fixed bug causing suffix/prefix lists to contain an empty string 2017-10-01 20:20:26 +02:00
csoler
40cda111d2 removed delay when calling forceUpdate() on directories 2017-09-25 21:05:42 +02:00
csoler
d8cb3fe35a fixed not rehashing files that already exist in a different directory pointed by a symlink 2017-09-25 20:56:35 +02:00
csoler
4766a8927a added an additional hard limit to directory depth, just in case 2017-09-24 23:51:47 +02:00
csoler
f497905497 fixed limitation of directory depth when indexing files 2017-09-24 23:43:52 +02:00
csoler
abd7e25a2e added checks for mMaxShareDepth and mIgnoreDuplicates 2017-09-24 18:14:45 +02:00
csoler
2a99df4d48 added UI and parameters for two new options in shared files: max share depth and ignore duplicates 2017-09-24 17:53:06 +02:00
csoler
a2ccf97b82 removed the 4M files limit on 64bits systems 2017-09-20 22:57:32 +02:00
csoler
d8f621e9ec make forceDirectoryCheck() to desactivate the pause, in case it was left activated 2017-09-17 20:14:45 +02:00
Phenom
a0ebddb4eb Fic Gcc warnings:
/libretroshare/src/file_sharing/p3filelists.cc👎 In static member
function ‘static bool p3FileDatabase::convertPointerToEntryIndex(const
void*, p3FileDatabase::EntryIndex&, uint32_t&)’:
/libretroshare/src/file_sharing/p3filelists.cc:624: warning:
dereferencing type-punned pointer will break strict-aliasing rules [-
Wstrict-aliasing]
     e   = EntryIndex(  *reinterpret_cast<uint32_t*>(&p) &
ENTRY_INDEX_BIT_MASK ) ;
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/file_sharing/
p3filelists.cc:625: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
     friend_index = (*reinterpret_cast<uint32_t*>(&p)) >>
NB_ENTRY_INDEX_BITS ;

/libretroshare/src/gxstrans/p3gxstransitems.h:29: In file included from
../../../trunk/libretroshare/src/gxstrans/p3gxstransitems.h:29:0,
/libretroshare/src/gxstrans/p3gxstransitems.cc:19: from ../../../trunk/
libretroshare/src/gxstrans/p3gxstransitems.cc:19:
/libretroshare/src/gxstrans/p3gxstransitems.cc👎 In member function
‘virtual void
OutgoingRecord_deprecated::serial_process(RsGenericSerializer::SerializeJob,
RsGenericSerializer::SerializeContext&)’:
/libretroshare/src/serialiser/rstypeserializer.h:61: warning:
dereferencing type-punned pointer will break strict-aliasing rules [-
Wstrict-aliasing]
  RsTypeSerializer::serial_process<T>(j, ctx, reinterpret_cast<T&>(I),
#I);\

/libretroshare/src/gxstrans/p3gxstransitems.cc:51: in expansion of macro
‘RS_REGISTER_SERIAL_MEMBER_TYPED’
  RS_REGISTER_SERIAL_MEMBER_TYPED(clientService, uint16_t);
/libretroshare/src/gxstrans/p3gxstransitems.cc👎 In member function
‘virtual void
OutgoingRecord::serial_process(RsGenericSerializer::SerializeJob,
RsGenericSerializer::SerializeContext&)’:
/libretroshare/src/serialiser/rstypeserializer.h:61: warning:
dereferencing type-punned pointer will break strict-aliasing rules [-
Wstrict-aliasing]
  RsTypeSerializer::serial_process<T>(j, ctx, reinterpret_cast<T&>(I),
#I);\

/libretroshare/src/gxstrans/p3gxstransitems.cc:65: in expansion of macro
‘RS_REGISTER_SERIAL_MEMBER_TYPED’
  RS_REGISTER_SERIAL_MEMBER_TYPED(clientService, uint16_t);
/retroshare-gui/src/gui/common/RsBanListToolButton.cpp👎 In member
function ‘void RsBanListToolButton::applyIp()’:
/retroshare-gui/src/gui/common/RsBanListToolButton.cpp:163: warning:
‘list_type’ may be used uninitialized in this function [-Wmaybe-
uninitialized]
   changed = rsBanList->removeIpRange(addr, masked_bytes, list_type);
2017-09-13 18:37:32 +02:00
Phenom
cf908674ce Fix unitialized value in LocalDirectoryUpdater. 2017-09-11 21:51:14 +02:00
csoler
551ef63c6e added default ignore list on linux 2017-09-11 19:36:06 +02:00
csoler
0ca0b72a5a moved file ignore test to a more appropriate place 2017-09-11 19:02:07 +02:00
csoler
eff5c5d6ee added pause to file hashing 2017-09-10 22:07:36 +02:00
csoler
ea25d4b5a4 improved update of ignore list 2017-09-10 20:22:17 +02:00
csoler
884b3a6220 added infrastructure to add a ignore list in shared files 2017-09-10 19:58:57 +02:00
csoler
160ab7b4f3 added missing code for remote search by hash, fixing the bug of direct sources not added 2017-09-03 23:32:48 +02:00
csoler
8d146038c2 fixed bug preventing search by hash to be called on own files 2017-09-03 22:52:31 +02:00
csoler
e401b90e02 moved rsserializer and rstypeserializer to serialiser/ 2017-04-30 16:05:37 +02:00
csoler
9c610a736d cleaned the hierarchy of serialization classes 2017-04-26 11:40:46 +02:00
csoler
dc2df071a5 renamed RsSerializer into RsServiceSerializer 2017-04-24 14:14:34 +02:00
csoler
976a80a7af switch rsfilelistitems to new serialization 2017-04-24 13:30:18 +02:00
csoler
e2d9152b22 moved converted serialisation files into new directory rsitems/, leaving serialiser/ for the serialisation classes 2017-04-18 21:11:37 +02:00
cyril soler
c87de3eb77 fixed mistake in pointer handling 2017-03-10 10:48:40 +01:00
csoler
a545481daa fixed memory leak when receving multi-chunk file lists 2017-03-09 22:05:06 +01:00
csoler
dec5c5c4b4 suppressed uninitialised memory leak in LocalDirectoryStorage 2017-03-04 21:13:34 +01:00
csoler
303bc09739 fixed force check directories when auto check is disabled 2017-03-02 23:18:12 +01:00
Phenom
e4dbc46b34 Fiw New Warnings 2017-03-01 19:43:34 +01:00
Phenom
c3c2671db4 Fix LocalDirectoryUpdater to take care if is Enabled in option. 2017-02-26 15:42:32 +01:00
cyril soler
cda3c744af attempt at fixing a bug that can cause a crash in p3filelists.cc 2017-02-17 09:17:33 +01:00
csoler
0a02419a29 fixed a big memory leak in hash cache storage load code, and improved deletion of allocated memory if file reading fails 2017-01-31 20:07:27 +01:00
csoler
8637cfa42f added detection of flag change so that new TS is set on root of hierarchy and changes are made visible to friends at next update 2016-12-15 23:07:40 +01:00
csoler
08294deeba removed unused updateHash() functions in directory_storage. Fixed a bug that caused H(H(F)) to not be recomputed at start, causing e2e encryption to fail in some cases. 2016-12-14 22:58:49 +01:00
csoler
cf8dac2e74 fixed initialisation of random salt in directory updater when no config file is present 2016-12-03 21:00:16 +01:00
csoler
ff271c6732 force recheck of existing files at start, to possibly re-hash files that were not already 2016-12-02 19:02:41 +01:00
csoler
d986216f55 remove non existing shared directories when not found on the disk 2016-12-01 23:27:34 +01:00
Phenom
674b6de381 Fix Some gcc warnings 383 to 208 lines
Left explicit #warning and deprecated.
Some lines are wrong indented and produce mal formed code.
2016-11-30 22:01:01 +01:00
csoler
137d71c0d9 extended the window during which the GUI is told to tell that the update of shared dirs is done from 5 to 15 secs 2016-11-27 20:57:51 +01:00
csoler
f3d7948238 turned one error into a warning in p3filelists.cc when requesting an unexisting ref 2016-11-27 20:57:51 +01:00
csoler
2a758dd880 changed shared files tree header when updating 2016-11-26 19:19:15 +01:00
csoler
aa4ecd7d87 added limit to calls of PreMods() in SharedFilesDialog so as to keep CPU load minimal when updating dirs from friends. Disabled sorting when new data comes. 2016-11-26 18:58:02 +01:00
csoler
3386238f35 improved preservation of directories when updating, and allow to temporarily disable sorting while an update is received 2016-11-26 11:03:53 +01:00
mr-alice
729c05af4f merged with upstream code 2016-11-25 21:09:34 +01:00
csoler
d975a18fd6 added doubling of buffer size in checkSectionSize when missing space. Used 1024 instead of 1000 as start size 2016-11-25 21:06:40 +01:00
mr-alice
2953957e66 added full re-scan when symbolic links are (des)activated, since the directory time stamps will not trigger an update 2016-11-25 20:50:10 +01:00
mr-alice
3f3efca22d removed canonicalize_file_name from MacOS compilation 2016-11-25 20:33:27 +01:00
csoler
5fbc263a36 applied removal of realloc to other files in file_sharing/ directory 2016-11-25 20:05:23 +01:00
csoler
0cb7778ceb removed all calls to realloc causing major slow down on windows where its implementation is extremely inefficient 2016-11-25 18:52:04 +01:00
mr-alice
5f69c9ea1f added an option to follow symbolic links or not, and anti-loop system during directories traversal 2016-11-24 23:42:56 +01:00
csoler
172b513cd3 added change in TS for shared directories when virtual name changes 2016-11-21 16:14:11 +01:00
csoler
9718385333 added missing mutex probably causing crashes when saving directory storage 2016-11-19 20:15:53 +01:00
Phenom
a8782f0612 Fix Crash when checking a big-big file storage.
After check lot of file with errors, error_string become to big and RS
crash.
2016-11-18 23:04:32 +01:00
csoler
bdc8086c2e added missing mChanged=true when removign a directory 2016-11-17 21:27:37 +01:00
csoler
5339e99127 force re-sweep of remote directory that has been updated with new dir content to 10 sec 2016-11-17 21:00:34 +01:00
csoler
36755c4092 added load/save of own file hierarchy 2016-11-17 19:03:53 +01:00
csoler
ba78007cf1 added parameter to disallow hashing files which time is in the future (as they severely perturbate the synchronisation process) 2016-11-16 21:49:27 +01:00
csoler
6272856b5e added param to folderIterator to skip/follow symbolic links 2016-11-16 21:41:32 +01:00
csoler
608d0d0a65 auto-remove remote directories for friends offline for too long (depending on whether the dir is empty or not) and also remove unused dir files 2016-11-15 21:33:39 +01:00
csoler
99860c1eb0 only allocate a remote directory entry if the peer is online, or the file already exists 2016-11-15 20:10:18 +01:00
csoler
8c8cc88503 fixed problems with negative time shifts in DirDetails causing multiple GUI bugs in File Lists and Search 2016-11-14 21:58:58 +01:00
csoler
5ef4e752d9 added count of total number of files and total file isze on top of shared directories 2016-11-11 20:25:11 +01:00
cyril soler
461975f115 generally prevent threads to start twice, and fixed bug causing DirWatcher to be run twice 2016-11-07 10:09:28 +01:00
csoler
e4e366766f fixed bug that caused hierarchies that contain files being hashed to not send updates when the hash is finished 2016-11-05 17:32:40 +01:00
csoler
a97fa1e2cb fixed generation of pseudo-random request ids in p3filelists 2016-11-05 16:07:30 +01:00
csoler
1e919a141c set delay between directory sweep to 60 secs and a-synced sweeps for different friends. Set drop time to 600 for un-answered dir sync requests 2016-11-05 15:30:07 +01:00
csoler
f39272a709 fixed compilation in debug mode for p3filelists.cc 2016-11-04 21:43:09 +01:00
mr-alice
2bb9a87b3b merged and fixed conflict with upstream/master 2016-11-04 13:52:11 +01:00
csoler
8dacb22049 reducing linear cost of allocateNewIndex to constant. Should improve huge lags when receiving big file lists for the first time 2016-11-03 22:32:27 +01:00
mr-alice
8c7c7647b0 fixed conflicts in merging upstream/master to v0.6-FTEncryption 2016-11-01 14:23:13 +01:00
mr-alice
e8e054eeae addednew flag for anonymous search. Merged the two browsable flags in one single flag. 2016-10-31 14:26:01 +01:00
mr-alice
34dcb410b4 fixed a few bugs in ftServer for encrypted tunnel management 2016-10-30 11:36:00 +01:00
mr-alice
9a881619e1 added record for H(H(F)) in LocalDirectoryStorage 2016-10-29 18:35:48 +02:00
mr-alice
babc126be3 added default encryption policy variable and GUI to change it 2016-10-29 17:59:03 +02:00
mr-alice
0387a28e78 added methods to get files from hash(hash) in directory_storage and ftServer 2016-10-25 00:08:27 +02:00
hunbernd
54ba617229 Fix: unable to upload files on Windows
Caused by multiple unneeded / character in file path.
2016-10-23 20:42:59 +02:00
Gio
8de054812b Merge branch 'master' into less_warning 2016-10-13 00:09:53 +02:00
Gio
633a6cf8c2 Fixed a bunch of warnings in safe ways 2016-10-13 00:01:33 +02:00
csoler
10c269ec5a removed warning when friend directory list cannot be found 2016-10-12 23:31:32 +02:00
csoler
bd9a464d11 added deterministic but unredictable hash generation for dir hashes, which should be preserved accross reboots. Should fix the msg from friends sending requests for the "wrong" dir hashes. 2016-10-12 23:20:38 +02:00
cyril soler
7cd31aa788 fixed bug preventign update of subdirs after last commit 2016-10-05 14:15:12 +02:00
cyril soler
854eebb2cb only update subfiles and subdirs list during dir watching sweep when the TS of the dir has changed. Greatly improve cost of regular directory watching process 2016-10-05 11:00:01 +02:00
csoler
20cd123e55 removed annoying ERROR output that is more a debug info than a real error, in p3filelists 2016-10-04 21:41:38 +02:00
csoler
ebfc82cc1e save/restore selection in shared dir list tree view 2016-10-03 21:44:34 +02:00
csoler
ed8d78660f added missing mChanged=false that caused remote directories to save far too often 2016-10-03 20:49:49 +02:00
Bryon Gloden, CISSP®
9ae05112be uninitialized variable: size
[libretroshare/src/file_sharing/hash_cache.cc:182]: (error) Uninitialized variable: size

Found by https://github.com/bryongloden/cppcheck
2016-10-01 12:01:09 -04:00
csoler
a75115585b do not send un-hashed files to friends, and allow to re-send the directory content when all files are hashed 2016-10-01 15:46:32 +02:00
csoler
e185bcdab4 fixed removal of directory when removing a friend 2016-09-28 23:02:24 +02:00
csoler
6e4ba76bbb improved display of shared directories for friends with no update info 2016-09-28 21:55:13 +02:00
Phenom
9672fe33d0 Fix InternalFileHierarchyStorage::check, error_string will never be
shown as always return true.
2016-09-28 11:35:44 +02:00
csoler
bf0777fd9e fixed update of DirHash list and FileHash list when files and dirs are removed, while keeping the cost low 2016-09-27 23:13:59 +02:00
csoler
37a4e7750c removed debug info in directory_storage.cc 2016-09-27 21:10:18 +02:00
sehraf
9d72b064e1 add thread names & remove some warnings 2016-09-27 09:50:59 +02:00