Commit Graph

11606 Commits

Author SHA1 Message Date
Phenom
f81c6aea03 Fix CppCheck in p3grouter
/libretroshare/src/grouter/p3grouter.cc:2295: warning:
Cppcheck(cstyleCast): C-style pointer casting
/libretroshare/src/grouter/p3grouter.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterDataInfo::last_activity_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/p3grouter.cc:206: warning:
Cppcheck(uninitMemberVar): Member variable 'p3GRouter::mTurtle' is not
initialized in the constructor.
/libretroshare/src/grouter/p3grouter.cc:206: warning:
Cppcheck(uninitMemberVar): Member variable 'p3GRouter::mLinkMgr' is not
initialized in the constructor.
2017-11-05 16:41:11 +01:00
Phenom
10721945a3 Fix CppCheck in grouteritems.h
/libretroshare/src/grouter/grouteritems.h:93: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterAbstractMsgItem::flags' is not initialized in the constructor.
/libretroshare/src/grouter/grouteritems.h:106: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterGenericDataItem::data_size' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:106: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterGenericDataItem::data_bytes' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:106: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterGenericDataItem::duplication_factor' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::chunk_start' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::chunk_size' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::total_size' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::chunk_data' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:220: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterMatrixTrackItem::time_stamp' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:62: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterItem' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/grouter/grouteritems.h:93: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterAbstractMsgItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/grouter/grouteritems.h:147: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterTransactionItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/grouter/grouteritems.h:274: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterSerialiser' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:39:44 +01:00
Phenom
10233ef1cc Fix CppCheck in groutertypes.h
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::data_status' is not initialized in the constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::tunnel_status' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::received_time_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::last_sent_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::last_tunnel_request_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::sending_attempts' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::routing_flags' is not initialized in the
constructor.
2017-11-05 16:38:50 +01:00
csoler
5dbefc529d
Merge pull request #1098 from csoler/v0.6-PRTest
V0.6 pr test
2017-11-05 16:36:49 +01:00
Phenom
a622194c2d Fix CppCheck in ftturtlefiletransferitem.h
/libretroshare/src/ft/ftturtlefiletransferitem.h:36: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileRequestItem::chunk_offset' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:36: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileRequestItem::chunk_size' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:52: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileDataItem::chunk_offset' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:52: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileDataItem::chunk_size' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:52: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileDataItem::chunk_data' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:102: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleChunkCrcRequestItem::chunk_number' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:116: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleChunkCrcItem::chunk_number' is not initialized in the
constructor.
2017-11-05 16:36:01 +01:00
Phenom
edfd2ad232 Fix CppCheck in fttransfermodule
/libretroshare/src/ft/fttransfermodule.cc:158: warning:
Cppcheck(unreadVariable): Variable 'mit' is assigned a value that is
never used.
/libretroshare/src/ft/fttransfermodule.h:59: warning:
Cppcheck(noExplicitConstructor): Class 'peerInfo' has a constructor with
1 argument that is not explicit.
/libretroshare/src/ft/fttransfermodule.h:114: warning:
Cppcheck(noExplicitConstructor): Class 'ftFileStatus' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/ft/fttransfermodule.cc:548: warning:
Cppcheck(noExplicitConstructor): Class 'HashThread' has a constructor
with 1 argument that is not explicit.
2017-11-05 16:34:45 +01:00
Phenom
c8548b2a2d Fix CppCheck in ftserver.cc
/libretroshare/src/ft/ftserver.cc:134: warning:
Cppcheck(unreadVariable): Variable 'localcachedir' is assigned a value
that is never used.
/libretroshare/src/ft/ftserver.cc:135: warning:
Cppcheck(unreadVariable): Variable 'remotecachedir' is assigned a value
that is never used.
2017-11-05 16:33:56 +01:00
Phenom
51ed0324f6 Fix CppCheck ftfilecreator.cc
/libretroshare/src/ft/ftfilecreator.cc:86: warning:
Cppcheck(unusedVariable): Unused variable: it
/libretroshare/src/ft/ftfilecreator.cc:545: warning:
Cppcheck(unreadVariable): Variable 'chunks_for_this_peer' is modified
but its new value is never used.
2017-11-05 16:33:16 +01:00
Phenom
68934499d4 Fix CppCheck in ftchunkmap.h
/libretroshare/src/ft/ftchunkmap.h:37: warning:
Cppcheck(uninitMemberVar): Member variable 'ftChunk::id' is not
initialized in the constructor.
2017-11-05 16:28:37 +01:00
Phenom
f8d4d6cb21 Fix CppCheck in p3filelists.h
/libretroshare/src/file_sharing/p3filelists.h:86: warning:
Cppcheck(noExplicitConstructor): Class 'p3FileDatabase' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:28:06 +01:00
Phenom
0d5b1ed40b Fix CppCheck in rsfilelistitems.h
/libretroshare/src/file_sharing/rsfilelistitems.h:78: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncRequestItem::flags' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:78: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncRequestItem::last_known_recurs_modf_TS' is not
initialized in the constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:78: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncRequestItem::request_id' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:94: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncResponseItem::flags' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:94: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncResponseItem::last_known_recurs_modf_TS' is not
initialized in the constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:94: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncResponseItem::request_id' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:52: warning:
Cppcheck(noExplicitConstructor): Class 'RsFileListsItem' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:27:45 +01:00
Phenom
0e014d6632 Fix CppCheck in p3filelists.cc
/libretroshare/src/file_sharing/hash_cache.h:57: warning:
Cppcheck(noExplicitConstructor): Class 'HashStorage' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/file_sharing/p3filelists.cc:375: warning:
Cppcheck(unusedVariable): Unused variable: mit
/libretroshare/src/file_sharing/p3filelists.cc:1530: warning:
Cppcheck(unreadVariable): Variable 'indent' is assigned a value that is
never used.
2017-11-05 16:26:56 +01:00
Phenom
d9965acf1d Fix CppCheck in hash_cache.h
/libretroshare/src/file_sharing/hash_cache.h:57: warning:
Cppcheck(noExplicitConstructor): Class 'HashStorage' has a constructor
with 1 argument that is not explicit.
2017-11-05 16:26:02 +01:00
Phenom
f18a842d9d Fix CppCheck in directory_storage.h and directory_storage.cc
/libretroshare/src/file_sharing/directory_storage.h💯 warning:
Cppcheck(noExplicitConstructor): Class 'FileIterator' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/file_sharing/directory_storage.cc:579: warning:
Cppcheck(unusedVariable): Unused variable: peers
2017-11-05 16:23:47 +01:00
Phenom
1456bdd641 Fix CppCheck in dir_hierarchy.h and dir_hierarchy.cc
/libretroshare/src/file_sharing/dir_hierarchy.cc:883: warning:
Cppcheck(unreadVariable): Variable 'nunknown' is modified but its new
value is never used.
/libretroshare/src/file_sharing/dir_hierarchy.h:71: warning:
Cppcheck(noExplicitConstructor): Class 'DirEntry' has a constructor with
1 argument that is not explicit.
/libretroshare/src/file_sharing/dir_hierarchy.cc:1056: warning:
Cppcheck(noExplicitConstructor): Class 'read_error' has a constructor
with 1 argument that is not explicit.
2017-11-05 16:22:51 +01:00
csoler
b42694165a
Merge pull request #1086 from PhenomRetroShare/Fix_SpeedQueuePositionSorting
Fix Speed/Queue Position column sorting
2017-11-05 13:57:31 +01:00
csoler
8a4c1bddc5
Merge pull request #1097 from PhenomRetroShare/Add_MoveFixedColorToQss
Move some Fixed Color to Qss files
2017-11-05 13:56:39 +01:00
Phenom
f27d312885 Move some Fixed Color to Qss files 2017-11-04 23:37:02 +01:00
Phenom
8072d245f3 Use macro for priority values instead of constants. 2017-11-04 13:58:13 +01:00
Phenom
c5c406bb98 Fix Speed/Queue Position column sorting 2017-11-04 13:58:13 +01:00
csoler
37f6e7e13b
Merge pull request #1064 from PhenomRetroShare/Fix_OpModeRestore
Fix OpMode Restore
2017-11-03 23:49:30 +01:00
defnax
1bcebb8dd5 attempt to fix 2017-11-03 13:26:51 +01:00
defnax
fc26ebcdc4 Fixed one Emojione icon 2017-11-03 13:04:38 +01:00
defnax
eb6bc792c5 reorder the main people emoticons 2017-11-03 03:02:40 +01:00
csoler
48bd1517fc removed useless root item in RsCollection dialog 2017-11-02 23:16:30 +01:00
csoler
2d18335da4 added tool button to choose DL directory in rscollection dialog 2017-11-02 22:52:30 +01:00
csoler
638160833c remove filename field in RsCollectionDialog when downloading a collection of links 2017-11-02 22:46:53 +01:00
csoler
aa4c2090cf fixed formula to compute score based on up/dn votes in comments 2017-11-02 22:20:49 +01:00
csoler
42c720fe6e
Merge pull request #1082 from RetroPooh/forumoptsimagescb
fix saving of forum options checkbox for load images
2017-11-01 20:36:57 +01:00
csoler
1a01181ef4
Merge pull request #1063 from PhenomRetroShare/Fix_BlankPageWhenClearLobbyInWebInterface
Fix Blank Page When Clear Lobby in Web Interface
2017-11-01 20:35:29 +01:00
csoler
d8c4f88b27
Merge pull request #1094 from PhenomRetroShare/Add_HideFileLabelInChannelPost
Hide zero File Label (size) in channel post.
2017-11-01 20:34:35 +01:00
csoler
2d8e9d5bc8
Merge pull request #1090 from csoler/v0.6-DHT
tried to improve DHT size estimation code
2017-11-01 20:33:54 +01:00
csoler
a9c43627ab removed debug info. Added explaination about the new method 2017-11-01 20:31:49 +01:00
Gioacchino Mazzurco
fe5dd00c4d Add context to debug message 2017-11-01 14:34:01 +01:00
Gioacchino
346d5c15a4
Merge pull request #1087 from Emotyco/libresapilocal_debug
Added: Debug output in Android app of callback functions
2017-11-01 14:13:04 +01:00
defnax
f409e8efe2 Update to Emojione 3.0 2017-11-01 00:24:03 +01:00
Phenom
a4eedf7287 Hide zero File Label (size) in channel post. 2017-10-30 18:35:56 +01:00
csoler
69278e6e87 only print non empty buckets 2017-10-30 11:07:36 +01:00
csoler
9f9c34ca13 tried to improve DHT size estimation code 2017-10-30 10:58:48 +01:00
csoler
b77e895691
Merge pull request #1084 from csoler/v0.6-Links2
added sorting of channels to push to, and auto-fill of channel subject
2017-10-29 21:31:10 +01:00
csoler
337980e433
Merge pull request #1088 from csoler/v0.6-FileLists
added display of hashing speed. Changed hashing buffer size to 10MB t…
2017-10-29 21:28:12 +01:00
csoler
3bb694f439 added display of hashing speed. Changed hashing buffer size to 10MB to improve performance 2017-10-29 21:24:34 +01:00
csoler
9ad635a665 added post into forum menu entry in SharedFilesDialog 2017-10-29 20:33:56 +01:00
Konrad
c41f6a29a5 Added: Debug output in Android app of callback functions 2017-10-29 19:40:37 +01:00
csoler
0c97d5bc3c added sorting of channels to push to, and auto-fill of channel subject 2017-10-27 22:03:42 +02:00
csoler
2e9f5202e0 fixed compilation 2017-10-26 19:41:13 +02:00
csoler
299d0b6d75 added missing test for subscribed channels in share-on-channel menu 2017-10-26 19:40:36 +02:00
Gioacchino
0c3fc05491 Merge pull request #1066 from Emotyco/libresapi_filesharing
Added a few filesharing handlers in libresapi
2017-10-26 08:18:30 +02:00
RetroPooh
54d49f1e33 friendlist - hide id column by default 2017-10-26 00:05:45 +03:00
RetroPooh
f8fca19e1b removed wrong tooltip for hidden node in options 2017-10-25 23:07:34 +03:00