../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.cpp:
1266:13: warning: function 'recursPrintModel' is not needed and will not
be emitted [-Wunneeded-internal-declaration]
static void recursPrintModel(const std::vector<ForumModelPostEntry>&
entries,ForumModelIndex index,int depth)
^
../../../trunk/retroshare-gui/src/gui/People/IdentityWidget.cpp:111:10:
warning: explicitly assigning value of variable of type 'QImage' to
itself [-Wself-assign-overloaded]
image = image;
~~~~~ ^ ~~~~~
../../../trunk/retroshare-gui/src/gui/Posted/PostedDialog.cpp:99:10:
warning: enumeration value 'ICON_SEARCH' not handled in switch [-
Wswitch]
switch (type) {
^
../../../trunk/retroshare-gui/src/gui/FileTransfer/TransfersDialog.cpp:
1104:9: warning: enumeration value 'DownloadTab' not handled in switch
[-Wswitch]
switch(page)
^
../../../trunk/libretroshare/src/services/autoproxy/
rsautoproxymonitor.cc:263:24: warning: pragma diagnostic pop could not
pop, no matching push [-Wunknown-pragmas]
^
../../../trunk/libretroshare/src/services/autoproxy/
rsautoproxymonitor.cc:295:24: warning: pragma diagnostic pop could not
pop, no matching push [-Wunknown-pragmas]
^
./../../trunk/retroshare-gui/src/gui/FileTransfer/TransfersDialog.cpp:
723: warning: pragma diagnostic pop could not pop, no matching push [-
Wunknown-pragmas]
^
Added action for send invite
Added action for add to contacts
Added action for person details view
Added menu for circles
Added to display votes on Identity widget
struct
In file included from ../../../trunk/retroshare-gui/src/gui/gxschannels/
GxsChannelPostsWidget.cpp:27:
In file included from temp/ui/ui_GxsChannelPostsWidget.h:31:
../../../trunk/retroshare-gui/src/gui/gxschannels/
GxsChannelFilesWidget.h:28:1: warning: class 'RsGxsChannelPost' was
previously declared as a struct [-Wmismatched-tags]
class RsGxsChannelPost;
^
../../../trunk/libretroshare/src/retroshare/rsgxschannels.h:65:8: note:
previous use is here
struct RsGxsChannelPost : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/gxschannels/
GxsChannelFilesWidget.h:28:1: note: did you mean struct here?
class RsGxsChannelPost;
^~~~~
struct
previously declared as a class
In file included from ../../../trunk/retroshare-gui/src/gui/gxsforums/
GxsForumThreadWidget.cpp:31:
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumModel.h:34:1:
warning: 'ForumModelPostEntry' defined as a struct here but previously
declared as a class [-Wmismatched-tags]
struct ForumModelPostEntry
^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumThreadWidget.h:
39:1: note: did you mean struct here?
class ForumModelPostEntry;
^~~~~
struct
struct
In file included from ../../../trunk/retroshare-gui/src/gui/gxsforums/
GxsForumsDialog.cpp:23:
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumThreadWidget.h:
33:1: warning: class 'RsGxsForumMsg' was previously declared as a struct
[-Wmismatched-tags]
class RsGxsForumMsg;
^
../../../trunk/libretroshare/src/retroshare/rsgxsforums.h:83:8: note:
previous use is here
struct RsGxsForumMsg : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/gxsforums/GxsForumThreadWidget.h:
33:1: note: did you mean struct here?
class RsGxsForumMsg;
^~~~~
struct
In file included from ../../../trunk/retroshare-gui/src/gui/FileTransfer/
TransfersDialog.cpp:31:
../../../trunk/retroshare-gui/src/gui/FileTransfer/
FileTransferInfoWidget.h:31:1: warning: class 'FileInfo' was previously
declared as a struct [-Wmismatched-tags]
class FileInfo ;
^
../../../trunk/libretroshare/src/retroshare/rstypes.h:188:8: note:
previous use is here
struct FileInfo : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/FileTransfer/
FileTransferInfoWidget.h:31:1: note: did you mean struct here?
class FileInfo ;
^~~~~
struct
struct
In file included from ../../../trunk/retroshare-gui/src/gui/FileTransfer/
TransfersDialog.cpp:29:
../../../trunk/retroshare-gui/src/gui/FileTransfer/DetailsDialog.h:28:1:
warning: class 'FileChunksInfo' was previously declared as a struct [-
Wmismatched-tags]
class FileChunksInfo ;
^
../../../trunk/libretroshare/src/retroshare/rstypes.h:398:8: note:
previous use is here
struct FileChunksInfo : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/FileTransfer/DetailsDialog.h:28:1:
note: did you mean struct here?
class FileChunksInfo ;
^~~~~
struct
a struct
In file included from ../../../trunk/retroshare-gui/src/gui/
RetroShareLink.cpp:33:
In file included from ../../../trunk/retroshare-gui/src/gui/gxschannels/
GxsChannelDialog.h:24:
../../../trunk/retroshare-gui/src/gui/gxs/GxsGroupFrameDialog.h:44:1:
warning: class 'RsGxsCommentService' was previously declared as a struct
[-Wmismatched-tags]
class RsGxsCommentService;
^
../../../trunk/libretroshare/src/retroshare/rsgxscommon.h:161:8: note:
previous use is here
struct RsGxsCommentService
^
../../../trunk/retroshare-gui/src/gui/gxs/GxsGroupFrameDialog.h:44:1:
note: did you mean struct here?
class RsGxsCommentService;
^~~~~
struct
declared as a class
In file included from ../../../trunk/retroshare-gui/src/gui/
RemoteDirModel.cpp:30:
../../../trunk/libretroshare/src/retroshare/rspeers.h:339:1: warning:
'RsGroupInfo' defined as a struct here but previously declared as a class
[-Wmismatched-tags]
struct RsGroupInfo : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/common/GroupDefs.h:24:1: note: did
you mean struct here?
class RsGroupInfo;
^~~~~
struct
In file included from ../../../trunk/retroshare-gui/src/gui/
RemoteDirModel.cpp:21:
../../../trunk/retroshare-gui/src/gui/RemoteDirModel.h:43:1: warning:
class 'DirDetails' was previously declared as a struct [-Wmismatched-
tags]
class DirDetails;
^
../../../trunk/libretroshare/src/retroshare/rstypes.h:311:8: note:
previous use is here
struct DirDetails : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/RemoteDirModel.h:43:1: note: did
you mean struct here?
class DirDetails;
^~~~~
struct
declared as a class
In file included from ../../../trunk/retroshare-gui/src/gui/
MessengerWindow.cpp:29:
../../../trunk/libretroshare/src/retroshare/rspeers.h:207:1: warning:
'RsPeerDetails' defined as a struct here but previously declared as a
class [-Wmismatched-tags]
struct RsPeerDetails : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/common/StatusDefs.h:27:1: note:
did you mean struct here?
class RsPeerDetails;
^~~~~
struct
struct
../../../trunk/retroshare-gui/src/gui/msgs/MessageComposer.h:40:1:
warning: class 'RsGxsForumGroup' was previously declared as a struct [-
Wmismatched-tags]
class RsGxsForumGroup;
^
../../../trunk/libretroshare/src/retroshare/rsgxsforums.h:55:8: note:
previous use is here
struct RsGxsForumGroup : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/msgs/MessageComposer.h:40:1: note:
did you mean struct here?
class RsGxsForumGroup;
^~~~~
struct
struct
In file included from ../../../trunk/retroshare-gui/src/gui/feeds/
SecurityItem.cpp:28:
../../../trunk/retroshare-gui/src/gui/msgs/MessageComposer.h:39:1:
warning: class 'RsGxsChannelGroup' was previously declared as a struct
[-Wmismatched-tags]
class RsGxsChannelGroup;
^
../../../trunk/libretroshare/src/retroshare/rsgxschannels.h:46:8: note:
previous use is here
struct RsGxsChannelGroup : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/msgs/MessageComposer.h:39:1: note:
did you mean struct here?
class RsGxsChannelGroup;
^~~~~
struct
struct
In file included from ../../../trunk/retroshare-gui/src/gui/
NetworkDialog.cpp:36:
../../../trunk/retroshare-gui/src/gui/msgs/MessageComposer.h:33:1:
warning: class 'RsIdentityDetails' was previously declared as a struct
[-Wmismatched-tags]
class RsIdentityDetails;
^
../../../trunk/libretroshare/src/retroshare/rsidentity.h:294:8: note:
previous use is here
struct RsIdentityDetails : RsSerializable
^
../../../trunk/retroshare-gui/src/gui/msgs/MessageComposer.h:33:1: note:
did you mean struct here?
class RsIdentityDetails;
^~~~~
struct
previously declared as a class
In file included from ../../../trunk/retroshare-gui/src/main.cpp:66:
In file included from ../../../trunk/libretroshare/src/retroshare/
rsidentity.h:31:
../../../trunk/libretroshare/src/retroshare/rsgxsifacehelper.h:43:1:
warning: 'RsGxsIfaceHelper' defined as a struct here but previously
declared as a class [-Wmismatched-tags]
struct RsGxsIfaceHelper
^
../../../trunk/retroshare-gui/src/util/RsGxsUpdateBroadcast.h:28:1:
note: did you mean struct here?
class RsGxsIfaceHelper;
^~~~~
struct
declared as a class
In file included from ../../../trunk/retroshare-gui/src/main.cpp:66:
In file included from ../../../trunk/libretroshare/src/retroshare/
rsidentity.h:31:
In file included from ../../../trunk/libretroshare/src/retroshare/
rsgxsifacehelper.h:30:
../../../trunk/libretroshare/src/retroshare/rsgxsiface.h:76:1: warning:
'RsGxsChanges' defined as a struct here but previously declared as a
class [-Wmismatched-tags]
struct RsGxsChanges
^
../../../trunk/retroshare-gui/src/util/RsGxsUpdateBroadcast.h:29:1:
note: did you mean struct here?
class RsGxsChanges;
^~~~~
struct
'RsGxsChannels::createVote' hides overloaded virtual function
In file included from temp/moc/moc_GxsChannelGroupItem.cpp:9:
In file included from temp/moc/../../../../../trunk/retroshare-gui/src/
gui/feeds/GxsChannelGroupItem.h:24:
../../../trunk/libretroshare/src/retroshare/rsgxschannels.h:116:15:
warning: 'RsGxsChannels::createComment' hides overloaded virtual
function [-Woverloaded-virtual]
virtual bool createComment(RsGxsComment& comment) = 0;
^
../../../trunk/libretroshare/src/retroshare/rsgxscommon.h:172:15: note:
hidden overloaded virtual function 'RsGxsCommentService::createComment'
declared here: different number of parameters (2 vs 1)
virtual bool createComment(uint32_t &token, RsGxsComment
&comment) = 0;
^
In file included from temp/moc/moc_GxsChannelGroupItem.cpp:9:
In file included from temp/moc/../../../../../trunk/retroshare-gui/src/
gui/feeds/GxsChannelGroupItem.h:24:
../../../trunk/libretroshare/src/retroshare/rsgxschannels.h:132:15:
warning: 'RsGxsChannels::createVote' hides overloaded virtual function
[-Woverloaded-virtual]
virtual bool createVote(RsGxsVote& vote) = 0;
^
../../../trunk/libretroshare/src/retroshare/rsgxscommon.h:173:15: note:
hidden overloaded virtual function 'RsGxsCommentService::createVote'
declared here: different number of parameters (2 vs 1)
virtual bool createVote(uint32_t &token, RsGxsVote &vote) = 0;
^
In file included from temp/moc/moc_GxsChannelPostItem.cpp:9:
In file included from temp/moc/../../../../../trunk/retroshare-gui/src/
gui/feeds/GxsChannelPostItem.h:26:
../../../trunk/libretroshare/src/retroshare/rsgxschannels.h:116:15:
warning: 'RsGxsChannels::createComment' hides overloaded virtual
function [-Woverloaded-virtual]
virtual bool createComment(RsGxsComment& comment) = 0;
^
../../../trunk/libretroshare/src/retroshare/rsgxscommon.h:172:15: note:
hidden overloaded virtual function 'RsGxsCommentService::createComment'
declared here: different number of parameters (2 vs 1)
virtual bool createComment(uint32_t &token, RsGxsComment
&comment) = 0;
^
In file included from temp/moc/moc_GxsChannelPostItem.cpp:9:
In file included from temp/moc/../../../../../trunk/retroshare-gui/src/
gui/feeds/GxsChannelPostItem.h:26:
../../../trunk/libretroshare/src/retroshare/rsgxschannels.h:132:15:
warning: 'RsGxsChannels::createVote' hides overloaded virtual function
[-Woverloaded-virtual]
virtual bool createVote(RsGxsVote& vote) = 0;
^
../../../trunk/libretroshare/src/retroshare/rsgxscommon.h:173:15: note:
hidden overloaded virtual function 'RsGxsCommentService::createVote'
declared here: different number of parameters (2 vs 1)
virtual bool createVote(uint32_t &token, RsGxsVote &vote) = 0;
^
Added for Channel Message composer a Image Attach button
Added a Combobox for Sort in Posted links easyer with new icons
Messengerwindow changed the button icons & display on status the status icon too.
*Improved Create comment dialog for channel/posted comment replies
*Update forum icons use the new flat one green/black
*Changed the context menu icon for Pin post
*Fixed for "new thread" dialog the title icon
*Added new circle icons for later to use
* Improved Author & Moderator labels display as link
* Improved display of moderator selection box display on right side
* Added own tree item "My Circles" to see your own circles easyer then before when you are admin.
* Profile generation dialog moved node type box to advanced section.
* Fixed icon size of the group tree to display icon complete.
Added for channel adminstrator clickable to contact easy.
* Format Channel Description when contains links or emote
* Added setting for disable Emoteicon
* Fixed the size problem of the group tree
* Added to format the Administrator as rs link for easyer contact admin.
* Format the Channel Description on the Channel posts widget for clickable links
according to G10h4ck the warning to stay under 40 trusted nodes (friends) is no longer needed because this was useful when multiple system calls reached gpg tools; but not now that a c++ pgp library is used
Deprecated old method which exposed interna async mechanism to the API
users, making their and out life difficult
Things that really need to be async like turtle search/requests now accept
callbacks, so the caller can be notified everytime some result is got
back
Implement RsThread::async commodity wrapper to execute blocking API
calls without blocking the caller, this could be optimized
trasparently using a thread pool if necessary
Added hints into some retroshare-gui files on how to use RsThread::async
thoghether with QMetaObject::invokeMethod and blocking RetroShare API
to simplyfy interaction between GUI and libretroshare
/retroshare-gui/src/gui/RetroShareLink.cpp:1556: warning: this statement
may fall through [-Wimplicit-fallthrough=]
/retroshare-gui/src/gui/RetroShareLink.cpp:400: warning: implicit
conversion loses integer precision: 'qulonglong' (aka 'unsigned long
long') to 'uint32_t' (aka 'unsigned int')
/retroshare-gui/src/gui/RetroShareLink.cpp:736: warning: use of old-
style cast
/retroshare-gui/src/gui/RetroShareLink.cpp:733: warning: unannotated
fall-through between switch labels
/retroshare-gui/src/gui/RetroShareLink.cpp:1175: warning: implicit
conversion changes signedness: 'char' to 'unsigned char'
/retroshare-gui/src/gui/RetroShareLink.cpp:1193: warning: implicit
conversion changes signedness: 'char' to 'unsigned char'
/retroshare-gui/src/gui/RetroShareLink.cpp:1208: warning: implicit
conversion changes signedness: 'char' to 'unsigned char'
/retroshare-gui/src/gui/RetroShareLink.cpp:1228: warning: implicit
conversion changes signedness: 'char' to 'unsigned char'
/retroshare-gui/src/gui/RetroShareLink.cpp:1261: warning: implicit
conversion changes signedness: 'int' to 'unsigned int'
/retroshare-gui/src/gui/RetroShareLink.cpp:1507: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1621: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1696: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1698: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1742: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1775: warning: implicit
conversion changes signedness: 'int' to 'unsigned int'
/retroshare-gui/src/gui/RetroShareLink.cpp:1779: warning: implicit
conversion changes signedness: 'int' to 'unsigned int'
/retroshare-gui/src/gui/RetroShareLink.cpp:1559: warning: unannotated
fall-through between switch labels
/retroshare-gui/src/gui/settings/MessagePage.cpp:62:19: warning:
deleting object of polymorphic class type 'Rs::Msgs::MsgTagType' which
has non-virtual destructor might cause undefined behavior [-Wdelete-non-
virtual-dtor]
/retroshare-gui/src/gui/settings/MessagePage.cpp:62: warning: delete
called on non-final 'Rs::Msgs::MsgTagType' that has virtual functions
but non-virtual destructor
/retroshare-gui/src/gui/settings/MessagePage.cpp:86: warning: use of
old-style cast
/retroshare-gui/src/gui/settings/MessagePage.cpp:172: warning: zero as
null pointer constant
/retroshare-gui/src/gui/settings/MessagePage.cpp:176: warning: implicit
conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int')
/retroshare-gui/src/gui/settings/MessagePage.cpp:203: warning: zero as
null pointer constant
/retroshare-gui/src/gui/settings/MessagePage.cpp:207: warning: implicit
conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int')
/retroshare-gui/src/gui/settings/MessagePage.cpp:261: warning: implicit
conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int')
/libretroshare/src/retroshare/rsmsgs.h:168: warning:
'Rs::Msgs::MessageInfo' has virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:168: warning: 'MessageInfo' has
no out-of-line virtual method definitions; its vtable will be emitted in
every translation unit
/libretroshare/src/retroshare/rsmsgs.h:234: warning:
'Rs::Msgs::MsgInfoSummary' has virtual functions but non-virtual
destructor
/libretroshare/src/retroshare/rsmsgs.h:234: warning: 'MsgInfoSummary'
has no out-of-line virtual method definitions; its vtable will be
emitted in every translation unit
/libretroshare/src/retroshare/rsmsgs.h:261: warning:
'Rs::Msgs::MsgTagInfo' has virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:328: warning: 'ChatId' has
virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:400: warning: 'ChatLobbyInvite'
has virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:420: warning:
'VisibleChatLobbyRecord' has virtual functions but non-virtual
destructor
/libretroshare/src/retroshare/rsmsgs.h:420: warning:
'VisibleChatLobbyRecord' has no out-of-line virtual method definitions;
its vtable will be emitted in every translation unit
/libretroshare/src/retroshare/rsmsgs.h:449: warning: 'ChatLobbyInfo' has
virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:486: warning: 'RsMsgs' has no
out-of-line virtual method definitions; its vtable will be emitted in
every translation unit
About vtable:
https://stackoverflow.com/questions/23746941/what-is-the-meaning-of-
clangs-wweak-vtables
https://stackoverflow.com/questions/50463374/avoid-weak-vtable-warnings-
for-classes-only-defined-in-a-source-file
/retroshare-gui/src/util/MouseEventFilter.cpp:56: warning: catching
polymorphic type 'class std::bad_cast' by value [-Wcatch-value=]
/retroshare-gui/src/util/MouseEventFilter.cpp:77: warning: catching
polymorphic type 'class std::bad_cast' by value [-Wcatch-value=]
