Commit Graph

76 Commits

Author SHA1 Message Date
Gioacchino Mazzurco
329050a9c2
Use safer rstime_t instead of time_t
Avoid problems to serialization on different platforms, without breaking
nested STL containers serialization.

The conversion have been made with sed, and checked with grep, plus
kdiff3 visual ispection, plus rutime tests, so it should be fine.
2018-10-07 13:07:06 +02:00
Gioacchino Mazzurco
8f7bacbb35
Remove #pragma once in .cc file
It was probably introduced by copy paste error on license cleanup
2018-08-22 17:00:22 +02:00
csoler
2bab688dec
fixed merge with upstream/master 2018-07-19 23:22:24 +02:00
csoler
5b9666855d
fixed merge with upstream 2018-06-22 23:38:31 +02:00
csoler
84194b6234
sereral fixes to GXS distant search 2018-06-16 22:39:35 +02:00
csoler
7caf06b57d
added structures for generic turtle search and access functions in Gxs objects 2018-06-06 23:15:29 +02:00
csoler
bc63726c4c
fixed compilation 2018-05-30 21:35:29 +02:00
csoler
ff8c37f169
fixed license in retroshare/ 2018-05-28 22:28:51 +02:00
csoler
b3277824eb
license fix in pqi 2018-05-28 22:03:39 +02:00
csoler
1fee544db7
re-licensed gxstrans, gxstunnel, pgp, plugins and half pqi 2018-05-26 14:45:43 +02:00
Gioacchino Mazzurco
f3ae61b462
Merge branch 'json_experiments' 2018-04-27 18:17:09 +02:00
csoler
076309133b
basic structure of GxsNetTunnelService 2018-03-15 17:46:21 +01:00
csoler
aad9397ef8
fixed memory leak in p3GxsTunnel 2018-02-26 23:38:13 +01:00
Gioacchino Mazzurco
ba6f2d7e81 Remove default template for to/from_JSON
This way the compiler will complain if a type is added directly to
RsTypeSerializer without specify all needed serial operations
2018-01-26 17:18:05 +01:00
Phenom
722d98e43e Fix CppCheck in rsgxstunnelitems.h
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:75: warning:
Cppcheck(uninitMemberVar): Member variable 'RsGxsTunnelDataItem::flags'
is not initialized in the constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDataItem::unique_item_counter' is not initialized in the
constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(uninitMemberVar): Member variable 'RsGxsTunnelDataItem::flags'
is not initialized in the constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDataItem::service_id' is not initialized in the constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:111: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDataAckItem::unique_item_counter' is not initialized in the
constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:128: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDHPublicKeyItem::public_key' is not initialized in the
constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:145: warning:
Cppcheck(operatorEqVarError): Member variable
'RsGxsTunnelDHPublicKeyItem::public_key' is not assigned a value in
'RsGxsTunnelDHPublicKeyItem::operator='.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:56: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsTunnelItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsTunnelDataItem' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:55:48 +01:00
Phenom
4ed663a5c1 Fix CppCheck in p3gxstunnel.h
/libretroshare/src/gxstunnel/p3gxstunnel.h:127: warning:
Cppcheck(noExplicitConstructor): Class 'p3GxsTunnelService' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:53:37 +01:00
Phenom
e2fa57dcd7 Fix clang warning: unused variable 'INTERVAL_BETWEEN_DEBUG_DUMP'
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP        = 10 ;
2017-07-16 21:43:05 +02:00
csoler
08faa3f5d5 fixed p3Gxstunnel so that it sends the data packets in the same order it received them. This fixes the bug in distant chat causing images to not transfer correctly in some cases 2017-07-15 22:16:45 +02:00
BabushkaRetroShare
7fb0419c75
Typo fixes 2017-06-04 20:34:10 +02:00
csoler
1ebcc6006b Merge pull request #861 from RetroShare/v0.6-GxsTransport
V0.6 gxs transport
2017-05-30 22:22:06 +02:00
Enno Boland
2046d9eaae fix building with libressl 2017-05-21 10:48:58 +02:00
Gioacchino Mazzurco
5159e326c7 Merge branch 'master' into gxs_mail_experiments 2017-05-05 15:44:22 +02:00
csoler
4bee52c406 removed old unused serialization code 2017-05-02 22:34:45 +02:00
csoler
cecd9a3368 merged upstream/master 2017-04-30 20:14:23 +02:00
csoler
e401b90e02 moved rsserializer and rstypeserializer to serialiser/ 2017-04-30 16:05:37 +02:00
csoler
4f92f483fa dwicthed GxsTunnel items to new serialization 2017-04-29 23:02:44 +02:00
csoler
9c610a736d cleaned the hierarchy of serialization classes 2017-04-26 11:40:46 +02:00
csoler
e2d9152b22 moved converted serialisation files into new directory rsitems/, leaving serialiser/ for the serialisation classes 2017-04-18 21:11:37 +02:00
Phenom
4ac3b3f5bf Fix Clang warnings: implicit conversion of NULL to bool
warning: implicit conversion of NULL constant to 'bool' [-Wnull-
conversion]
        return NULL ;
        ~~~~~~ ^~~~
               false
2017-04-17 21:33:39 +02:00
Gioacchino Mazzurco
953b70fbe4 Improve async distant chat, fix chat msg receiving
DistantChatService::initiateDistantChatConnexion(...) made notification
  message optional (enabled by default)
p3ChatService removed duplicion avoidance as it is not necessary
p3ChatService::sendStatusString(...) send status only if peer is online
protect p3ChatService::mDistantGxsMap with mutex as operation on it may
  be done by different threads
p3ChatService::receiveGxsMai(...) set chat message item peer id with
  distant tunnel id, so it is recognized as a distant message later
made p3GxsTunnelService::makeGxsTunnelId(...) static as it need no
  access to this, now it can be used easier by other components
rename RsGxsMailItem::recipientsHint to recipientHint as for now only
  one recipient is possible (TODO: update documentation too)
GxsMailsClient::receiveGxsMail(...) changed paramethers for better
  abstracion, now destination id is passed too because it is usually a
  very useful information
ChatWidget some adaptation to async chat, a couple of method have been
  deprecated too
PopupDistantChatDialog::updateDisplay(...) adapt message shown to the
  user to the new async chat paradigm (TODO: need review)
2017-03-01 23:31:13 +01:00
csoler
c3b49855e0 compilation fix for openssl-1.1.0 (gxssecurity+gxstunnel part) 2017-02-20 21:44:48 +01:00
csoler
a9670a569a Second stage in abstracting GXS identities usage cases (almost done) 2017-01-02 23:53:39 +01:00
csoler
ef0850e65b added recording system for usage cases of GXS ids 2016-12-19 20:44:15 +01:00
Gio
9eef412b44 Expose libresapi for distant chat
Added macro to deprecate symbols usage in a crossplatform way.
Deprecated Request::mMethod and related stuff that make implementation
 more complex without advantage.
Added /chat/{initiate_distant_chat, distant_chat_status,
 close_distant_chat} to libresapi.
Solved subtle bug in ChatId::ChatId(std::string str) that caused zeroed
 DistantChatPeerId being created.
2016-12-07 20:29:33 +01:00
csoler
c2ae4fc904 merged upstream/master 2016-06-05 10:06:11 -04:00
sehraf
0d106032de fix build errors (return typ is a pointer and not boolean) 2016-06-03 09:02:19 +02:00
csoler
590be092e5 separated RsTlvSecurityKey into two incompatible classes to enforce the correct usage of private vs. public keys 2016-06-02 23:47:57 -04:00
csoler
53eb4dfb12 fixed compilation errors due to last merge operation 2016-06-02 21:21:18 -04:00
csoler
e2b5785eec merged PR403 with trunk 2016-06-02 21:15:51 -04:00
csoler
10e0254317 fixed a few things to correct PR403 2016-06-02 20:38:33 -04:00
sehraf
cfc0e7071a libretroshare: remove unused variables 2016-06-02 14:54:07 +02:00
csoler
b148239e4f always pass data accept test in distant chat when we are on the client side of the tunnel 2016-04-10 21:09:47 -04:00
csoler
ca0f76954e removed warning that would show up too often when a GxsTunnel is down and message cannot be sent 2016-04-08 21:08:22 -04:00
Phenom
b13292bb80 Fix error reported by CppChecker:
/libretroshare/src/gxs/rsgenexchange.cc:2850: erreur : Cppcheck:
Dereferencing 'grp' after it is deallocated / released
/libretroshare/src/gxstunnel/p3gxstunnel.cc:1004: erreur : Cppcheck:
Invalid usage of output stream: '<< std::cerr'.
/libretroshare/src/util/contentvalue.cc:185: erreur : Cppcheck: Memory
leak: dest
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:103: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:122: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:141: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:92: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:111: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/People/PeopleDialog.cpp:774: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/People/PeopleDialog.cpp:864: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/common/AvatarWidget.cpp:225: erreur : Cppcheck:
Uninitialized variable: status
/retroshare-nogui/src/rpc/proto/rpcprotostream.cc:805: erreur :
Cppcheck: Memory leak: buffer
/supportlibs/pegmarkdown/GLibFacade.c:150: erreur : Cppcheck: va_list
'args' was opened but not closed by va_end().
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/tests/unittests/libretroshare/serialiser/rsturtleitem_test.cc:213:
erreur : Cppcheck: Return value of allocation function 'init_item' is
not stored.
2016-03-20 13:12:30 +01:00
csoler
2e9d22c580 used RsTemporaryMemory to avoid memory leak in case of error in GxsTunnels 2016-03-19 18:47:59 -04:00
csoler
59d4c2c829 removed some compilation warnings 2016-01-30 20:27:27 -05:00
csoler
55d0a213dd added cache of latest GXS tunnel data items for the last 10 minutes in order to avoid replays of messages caused by the conservative message transmition system. Removed the global item counter for a purely random uint64_t 2016-01-21 21:19:40 -05:00
csoler
d55993d1e4 removed two instances of malloc(0) captured by new rs_malloc funtion 2016-01-12 21:43:04 -05:00
csoler
d13526facd added a new method rs_malloc that checks its arguments and prints a stacktrace on error/weird call. Changed the code everywhere to use this instead of malloc. Removed some mallocs and replaced with RsTemporaryMemory 2016-01-12 21:10:11 -05:00
csoler
9c6e7dfc13 added checks after mallocs in several files 2016-01-11 23:49:00 -05:00