and misleading-indentation
/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
for(uint32_t i=0;i<mMessageVersions.size();++i)
/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: this ‘for’
clause does not guard... [-Wmisleading-indentation]
for(uint32_t i=0;i<mMessageVersions.size();++i)
/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:654: warning: this
statement may fall through [-Wimplicit-fallthrough=]
case 2: signFlags |=
GXS_SERV::FLAG_AUTHOR_AUTHENTICATION_GPG_KNOWN; // no break below, since
we want *both* flags in this case.
/retroshare-gui/src/gui/gxschannels/CreateGxsChannelMsg.cpp:360:
warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if(assume_file_ready)
/retroshare-gui/src/gui/gxsforums/GxsForumsFillThread.cpp:286: warning:
comparison between signed and unsigned integer expressions [-Wsign-
compare]
for(uint32_t i=1;i<(*it).size();++i)
/retroshare-gui/src/gui/statistics/BWGraph.cpp:245: warning: this
statement may fall through [-Wimplicit-fallthrough=]
case GRAPH_TYPE_ALL: std::cerr << "(WW) Impossible situation. Cannot
draw graph in mode All/All. Reverting to sum." << std::endl;
, misleading-indentation and unused-variable
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: comparison between signed and unsigned integer expressions [-
Wsign-compare]
for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:203:
warning: unused variable ‘now’ [-Wunused-variable]
time_t now = time(NULL) ;
/retroshare-gui/src/gui/GetStartedDialog.cpp:122: warning: this
statement may fall through [-Wimplicit-fallthrough=]
ui.firewallCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:124: here
case RSCONFIG_USER_LEVEL_CASUAL:
/retroshare-gui/src/gui/GetStartedDialog.cpp:125: warning: this
statement may fall through [-Wimplicit-fallthrough=]
ui.connectCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:127: here
case RSCONFIG_USER_LEVEL_BASIC:
/retroshare-gui/src/gui/RetroShareLink.cpp:585: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if(!checkSSLId(_SSLid))
/retroshare-gui/src/gui/RetroShareLink.cpp:587: here
case TYPE_FILE:
/libretroshare/src/gxstrans/p3gxstrans.cc:870: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.sent_ts = time(NULL) ; //pr.mailItem.meta.mPublishTs = time(NULL);
/libretroshare/src/gxstrans/p3gxstrans.cc:872: here
case GxsTransSendStatus::PENDING_PREFERRED_GROUP:
/libretroshare/src/gxstrans/p3gxstrans.cc:883: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.group_id = mPreferredGroupId ; //pr.mailItem.meta.mGroupId =
mPreferredGroupId;
/libretroshare/src/gxstrans/p3gxstrans.cc:885: here
case GxsTransSendStatus::PENDING_RECEIPT_CREATE:
/libretroshare/src/gxstrans/p3gxstrans.cc:906: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.presignedReceipt.msg.setBinData(&grsrz[0], grsz);
/libretroshare/src/gxstrans/p3gxstrans.cc:908: here
case GxsTransSendStatus::PENDING_RECEIPT_SIGNATURE: // (cyril)
This step is never actually used.
/libretroshare/src/gxstrans/p3gxstrans.cc:924: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.presignedReceipt.meta.setBinData(&srx[0], metaSize);
/libretroshare/src/gxstrans/p3gxstrans.cc:926: here
case GxsTransSendStatus::PENDING_PAYLOAD_CREATE:
/libretroshare/src/gxstrans/p3gxstrans.cc:938: warning: this statement
may fall through [-Wimplicit-fallthrough=]
memcpy(&pr.mailItem.payload[offset], &pr.mailData[0], datasize);
/libretroshare/src/gxstrans/p3gxstrans.cc:940: here
case GxsTransSendStatus::PENDING_PAYLOAD_ENCRYPT:
/libretroshare/src/gxstrans/p3gxstrans.cc:982: warning: this statement
may fall through [-Wimplicit-fallthrough=]
}
/libretroshare/src/gxstrans/p3gxstrans.cc:984: here
case GxsTransSendStatus::PENDING_PUBLISH:
/libretroshare/src/gxs/rsgxsnetservice.cc:867: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
std::map<RsGxsGroupId,RsGxsServerMsgUpdate>::iterator it =
mServerMsgUpdateMap.find(grpId) ;
/libretroshare/src/gxs/rsgxsnetservice.cc:2434: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
ClientGrpMap::iterator it =
mClientGrpUpdateMap.find(peerFrom);
/libretroshare/src/util/dnsresolver.cc:49: warning: this statement may
fall through [-Wimplicit-fallthrough=]
case DNSResolver::DNS_LOOKUP_ERROR: if(it-
>second.last_lookup_time + MAX_TIME_BEFORE_RETRY > now)
/libretroshare/src/util/dnsresolver.cc:52: here
case DNSResolver::DNS_DONT_HAVE: next_call = it->first ;
/libretroshare/src/util/rsnet_ss.cc:1031: warning: this statement may
fall through [-Wimplicit-fallthrough=]
success = inet_ntop( addr.ss_family, (const void *) &(addrv4p-
>sin_addr), ipStr, INET_ADDRSTRLEN );
/libretroshare/src/util/rsnet_ss.cc:1033: here
case AF_INET6:
/libretroshare/src/util/rscompress.cc:165: warning: this statement may
fall through [-Wimplicit-fallthrough=]
ret = Z_DATA_ERROR; /* and fall through */
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/util/rscompress.cc:
166: here
case Z_DATA_ERROR:
/libretroshare/src/rsserver/p3serverconfig.cc:292: warning: this
statement may fall through [-Wimplicit-fallthrough=]
if (mPeerMgr->getFriendCount(true, false) > MIN_BASIC_FRIENDS)
/libretroshare/src/rsserver/p3serverconfig.cc:297: here
case RSCONFIG_USER_LEVEL_BASIC:
/libretroshare/src/rsserver/p3serverconfig.cc:300: warning: this
statement may fall through [-Wimplicit-fallthrough=]
if (mPeerMgr->haveOnceConnected())
/libretroshare/src/rsserver/p3serverconfig.cc:306: here
case RSCONFIG_USER_LEVEL_CASUAL:
/libretroshare/src/rsserver/rsaccounts.cc:130: warning: variable
‘pgpNameFound’ set but not used [-Wunused-but-set-variable]
bool pgpNameFound = false;
/libretroshare/src/pqi/pqissl.cc:449: warning: this statement may fall
through [-Wimplicit-fallthrough=]
sslmode = PQISSL_ACTIVE; /* we're starting this one */
/libretroshare/src/pqi/pqissl.cc:456: here
case WAITING_DELAY:
/libretroshare/src/pqi/pqisslpersongrp.cc:125: warning: this statement
may fall through [-Wimplicit-fallthrough=]
std::cerr << " --> falling back to Tor" << std::endl;
/libretroshare/src/pqi/pqisslpersongrp.cc:126: here
case RS_HIDDEN_TYPE_TOR:
/libretroshare/src/pqi/p3peermgr.cc:2619: warning: variable ‘peerIt1’
set but not used [-Wunused-but-set-variable]
std::set<RsPgpId>::iterator peerIt1 =
groupItem.peerIds.find(*peerIt);
/libretroshare/src/pgp/pgphandler.cc:62: warning: this statement may
fall through [-Wimplicit-fallthrough=]
case OPS_PARSER_CMD_GET_SK_PASSPHRASE_PREV_WAS_BAD: prev_was_bad =
true ;
/libretroshare/src/pgp/pgphandler.cc:63: here
case OPS_PARSER_CMD_GET_SK_PASSPHRASE:
/libretroshare/src/ft/ftchunkmap.cc:190: warning: this statement may
fall through [-Wimplicit-fallthrough=]
case FileChunksInfo::CHUNK_CHECKING: _file_is_complete = false ;
/libretroshare/src/ft/ftchunkmap.cc:191: here
case FileChunksInfo::CHUNK_DONE: _total_downloaded +=
sizeOfChunk(i) ;
/libretroshare/src/tcponudp/bss_tou.c:246: warning: this statement may
fall through [-Wimplicit-fallthrough=]
num=0;
/libretroshare/src/tcponudp/bss_tou.c:247: here
case BIO_C_FILE_SEEK:
/libbitdht/src/bitdht/bdconnection.cc:1288: warning: this statement may
fall through [-Wimplicit-fallthrough=]
if (errsrc == BITDHT_CONNECT_ERROR_SOURCE_END)
/libbitdht/src/bitdht/bdconnection.cc:1308: here
case BITDHT_CONNECT_ERROR_DUPLICATE: // similar attempt. delay/
recycle (ANY/ANY)
/openpgpsdk/src/openpgpsdk/packet-parse.c:2482: warning: this statement
may fall through [-Wimplicit-fallthrough=]
hashes[n].add(&hashes[n],C.secret_key.salt,OPS_SALT_SIZE);
/openpgpsdk/src/openpgpsdk/packet-parse.c:2484: here
case OPS_S2KS_SIMPLE:
In case the login was made manually by the user via the grafical
interface when the autologin managaer has already started but not logged
in yet, the password attempt timer was looping to infinite causing
unnecessary load and log spamming, this commit attempt to prevent that
from happening
