Commit Graph

5609 Commits

Author SHA1 Message Date
Gioacchino Mazzurco
828251cc18
Solve vtable warnings in gxschannels 2019-10-26 01:22:47 +02:00
Gioacchino Mazzurco
bc3596047a
Remove unused class in rsmsg 2019-10-26 00:07:56 +02:00
Gioacchino Mazzurco
f2c90ba3c6
RS mail post event when receiving a mail
+ delete some deadcode
2019-10-26 00:07:55 +02:00
Gioacchino Mazzurco
04d3325fbd
Provide usable API to send RS mails
Return trackid to sendmail caller
Post RsEvents when sent mail change status
Deprecate old MessageSend
2019-10-26 00:07:51 +02:00
G10h4ck
584918388c
Merge pull request #1691 from G10h4ck/fixup_brodcastdiscovery
Fix some bugs in broadcast discovery
2019-10-25 23:06:13 +02:00
G10h4ck
63861ba942
Merge pull request #1659 from G10h4ck/netmgr_calmer
Calm down p3netmgr at least when internet connection is not available
2019-10-25 18:42:45 +02:00
Gioacchino Mazzurco
7f2bfae104
Fix broadcast discovery in Android
On Android and potencially other mobile platforms, WiFi drivers are configured
  by default to discard any packet that is not directed to the unicast mac
  address of the interface, this way they could save some battery but breaks
  anything that is not unicast, such as broadcast discovery. To solve this
  problem On such platforms provide methods to handle low level multicast
  listening so we can receive advertisement from same broadcast domain nodes.
2019-10-25 18:08:50 +02:00
csoler
f78b591214 fixed compilation 2019-10-23 18:16:31 +00:00
csoler
578a514007
fixed bug causing option -p to not allow to change listenning port 2019-10-23 20:11:30 +02:00
Gioacchino Mazzurco
48267eb659
Fix fingerprint assignation in broadcastdiscovery
This bug was causing null fingerprint reported on peer discovered by
  broadcastdicovery effectively rendering it unfunctional
2019-10-18 23:09:16 +02:00
csoler
438966979b
Merge pull request #1674 from G10h4ck/pqissludp_fixup
Fix double free crash in ~pqissludp()
2019-10-15 08:39:49 +02:00
csoler
98c1a34ab9
Merge pull request #1683 from defnax/distant-chat-settings
added distant chat settings for store/load
2019-10-14 13:41:52 +02:00
csoler
52b675fb6d
Merge pull request #1680 from csoler/v0.6-DistantChat
enabled buffering for distant chat, so that msgs are sent when the tu…
2019-10-14 13:39:08 +02:00
defnax
cbfe49f0f3 added distant chat settings 2019-10-14 02:29:20 +02:00
csoler
b3156223af
fixed load/save of chat history for distant chat 2019-10-14 00:07:11 +02:00
csoler
09343e9179
enabled buffering for distant chat, so that msgs are sent when the tunnel is ok 2019-10-12 21:05:27 +02:00
Gioacchino Mazzurco
f86d20d4cd
Improve readibility of terrible if 2019-10-09 15:22:24 +02:00
Gioacchino Mazzurco
63b787a504
Fix double free crash in ~pqissludp()
Use POD type member intitialization for sockaddr_storage
Cleanup a bunch of clutter
2019-10-09 14:59:46 +02:00
Gioacchino Mazzurco
93bfbb6ede
Fix addSslOnlyFriend when adding with already known PGP
If the PGP key is available add as full friend.
Without this change when the PGP key of a non-friend is available
  the SSL-id is added in peer list but the PGP-id is not added as PGP
  friend, at same time skip_pgp_signature_validation is false, because
  we have the full PGP, so the connection attempt is refused, when it
  should be verified with PGP and accepted.
2019-10-09 02:06:55 +02:00
Gioacchino Mazzurco
1b071d106f
Fix p3GxsChannels::createCommentV2 2019-10-07 18:37:44 +02:00
Gioacchino Mazzurco
ab93d31d17
Remove some RsPeers related dead code 2019-10-06 23:20:18 +02:00
Gioacchino Mazzurco
563260d012
Merge branch 'master' of github.com:RetroShare/RetroShare 2019-10-06 23:05:11 +02:00
Gioacchino Mazzurco
89819dd945
Add JSON API to list PGP friends 2019-10-06 23:03:14 +02:00
csoler
c0e8aa1024
Merge pull request #1596 from hunbernd/feature/risechatlenght
Rise public chat message size
2019-10-06 22:16:09 +02:00
Gioacchino Mazzurco
db3aefcd0b
Improve error reporting in createChannelV2 2019-10-05 15:53:46 +02:00
Phenom
5c46a8fd4d Fix implicitly-declared operator= warnings
/libretroshare/src/gxs/rsgds.h:54: warning: implicitly-declared
'ContentValue& ContentValue::operator=(const ContentValue&)' is
deprecated [-Wdeprecated-copy]
   54 |     MsgLocMetaData(const MsgLocMetaData& meta){ msgId =
meta.msgId; val = meta.val;}

/libretroshare/src/gxs/rsgds.h:69: warning: implicitly-declared
'ContentValue& ContentValue::operator=(const ContentValue&)' is
deprecated [-Wdeprecated-copy]
   69 |     GrpLocMetaData(const GrpLocMetaData& meta){ grpId =
meta.grpId; val = meta.val;}

From 248 to 146 warnings.
2019-10-04 17:28:50 +02:00
csoler
b539ebe826
Merge pull request #1646 from G10h4ck/fixup_channels_api
Avoid crash when subscribeToChannel is fed with invalid channel id
2019-10-03 20:31:31 +02:00
csoler
423f20231c
Merge pull request #1661 from G10h4ck/short_invites_fixup
Fix setting port when adding from short invite with dyndns
2019-10-03 09:40:28 +02:00
Gioacchino Mazzurco
b77924b368
Fix setting port when adding from short invite with dyndns 2019-10-01 17:43:52 +02:00
G10h4ck
1732177669
Merge pull request #1645 from G10h4ck/short_invites_fixes
Allow friend information  update from short invite
2019-09-30 23:37:55 +02:00
csoler
f04b32eef8
Merge pull request #1650 from csoler/v0.6-ShortInvites
fixed error handling when you enter your own certificate in connect f…
2019-09-30 21:46:52 +02:00
Gioacchino Mazzurco
6b71c57a54
Calm down p3netmgr at least when internet connection is not available
Solve compiler warnings, delete tons of cruft and deadcode
2019-09-29 17:59:32 +02:00
csoler
e41b64d938
added checksum section to short certificate format 2019-09-29 17:37:52 +02:00
Gioacchino Mazzurco
6788ea041a
Avoid netReset() if no network address is available 2019-09-28 18:42:13 +02:00
Gioacchino Mazzurco
1e9adc1e23
Add some documentation and fix some compiler warnings 2019-09-28 14:34:07 +02:00
Gioacchino Mazzurco
4e3ac4a9f4
Make SSL-only friend criteria stricter 2019-09-28 14:15:12 +02:00
Gioacchino Mazzurco
c07f93992c
Merge branch 'master' of github.com:RetroShare/RetroShare 2019-09-28 13:57:28 +02:00
Gioacchino Mazzurco
a169250e1c
Add support to build with miniupnpc on Android
Necessary to workaroud issues:
  https://github.com/RetroShare/RetroShare/issues/1649
  https://github.com/mrjimenez/pupnp/issues/119
2019-09-28 13:54:16 +02:00
Gioacchino Mazzurco
5660c73175
Allow friend information update from short invite
Add comments explaining security of addSslOnlyFriend
2019-09-28 10:36:33 +02:00
Gioacchino Mazzurco
3b8f6997bb
Avoid crash when subscribeToChannel is fed with invaled channel id
Fix a couple compiler warning too
2019-09-28 00:12:56 +02:00
G10h4ck
1480e6d0b5
Merge pull request #1644 from G10h4ck/broadcast_discovery_fingerprint
Send PGP fingerprint in broadcast discovery
2019-09-27 23:48:37 +02:00
Gioacchino Mazzurco
86957c9843
Fail gracefully when requesting membership on an unknown circle 2019-09-27 16:57:07 +02:00
Gioacchino Mazzurco
ce3e2a2c9d
Fixup missing parametersin circle creation 2019-09-27 14:19:20 +02:00
Gioacchino Mazzurco
1705a930d4
getLocalAddresses should not need Qt for android >= 24 2019-09-25 22:15:07 +02:00
Gioacchino Mazzurco
a887d205e9
Relax RsEvent loop 2019-09-25 22:12:04 +02:00
Gioacchino Mazzurco
2aade543f3
Send PGP full fingerprint in broadcast discovery 2019-09-25 16:33:13 +02:00
csoler
24781a71f5
removed unused mOthersList from PeerMgr 2019-09-23 21:32:28 +02:00
csoler
282d2d324d
added missing notifications when adding friends 2019-09-22 20:42:49 +02:00
csoler
9b78447109
used RsInfo instead of std::cerr in authssl.cc 2019-09-22 17:36:08 +02:00
csoler
19ced52a02
fixed bug caused by wrong reading of disc flag 2019-09-22 17:05:22 +02:00
csoler
9c7edffc21
fixed bug caused by shadowing a variable 2019-09-22 16:34:01 +02:00
csoler
6919711f48
restricted check for matching PGP ids to short invites only, since otherwise the call to isGPGAccepted() will rule out wrong IDs anyway 2019-09-21 22:20:33 +02:00
csoler
ed864f9470
removed some debug info about PGP signature validation, and added the ability to accept fingerprint instead of ID in the handshake 2019-09-21 19:00:52 +02:00
csoler
4fabf3deb1
renamed skip_signature_validation into more appropriate skip_pgp_signature_validation 2019-09-19 21:14:57 +02:00
csoler
654d760d84
fixed comments from review of PR 2019-09-19 20:59:35 +02:00
csoler
18db1fb6bb
Merge pull request #1642 from csoler/v0.6-ImprovedGUI
V0.6 improved gui
2019-09-18 23:24:27 +02:00
csoler
af9b3647dd
fixed bug causing local port to randomly change at start 2019-09-18 23:02:15 +02:00
csoler
9bf86e0e66
suppressed two uninitialized memory reads 2019-09-18 22:36:56 +02:00
csoler
44d6cb7be2
finished documentation/review of discovery 2019-09-17 22:43:37 +02:00
csoler
32b4312725
improved security checks in authssl by verifying that the supplied PGP id is the one the peer has been registered with 2019-09-17 22:14:32 +02:00
csoler
8be49b2d65
Merge pull request #1639 from csoler/v0.6-ImprovedGUI
V0.6 improved gui
2019-09-17 18:50:37 +02:00
csoler
b4fe1d48e5
started documenting p3GossipDiscovery 2019-09-16 23:00:00 +02:00
csoler
1f058f9f22
fixed compilation 2019-09-15 16:49:30 +02:00
csoler
636d477aea
fixed bug causing JSon api server to start twice, and therefore stopping RS because the port was already listen to 2019-09-15 16:21:12 +02:00
Gioacchino Mazzurco
e411b7fb22
Clean some dust 2019-09-15 12:10:37 +02:00
Gioacchino Mazzurco
6862e642e8
Provide more usable method to create GXS circles
Fix some compiler warnings with out of definition default destructors
2019-09-14 20:58:04 +02:00
csoler
bea6769a4e
removed unused code from p3gossipdiscovery 2019-09-14 16:26:24 +02:00
csoler
a20ec1a885
fixed exchange of PGP keys in binary format and update of PGP signature flags on short invites when the key is received 2019-09-14 15:33:43 +02:00
Gioacchino Mazzurco
c2cb63b40c
RsIdentity update own ids cache on creation 2019-09-12 12:02:24 +02:00
csoler
bbf92bd5f3
fixed remanent bug due causing the deletion of rsEvent 2019-09-10 21:59:25 +02:00
Gioacchino Mazzurco
06840b86f5
Fix retroshare-service Android build
Cleanup retroshare-service and build options
2019-09-10 17:10:26 +02:00
csoler
3a58aa468f
add special profile item for not yet validated peer from short invite 2019-09-10 09:52:37 +02:00
csoler
4f4b3bfcdb
Merge pull request #1624 from csoler/v0.6-RetroshareService
V0.6 retroshare service
2019-09-09 10:33:18 +02:00
Gioacchino Mazzurco
6aa85ea292
Fix a couple of warning in JSON serializer 2019-09-09 09:08:00 +02:00
csoler
c8064e1ddc
fixed missing parameter in jsonapi declaration 2019-09-08 20:50:06 +02:00
csoler
dd90314c3d
fixed missing type conversion 2019-09-08 20:49:38 +02:00
csoler
6419b03a2a
merged upstream/master 2019-09-08 20:35:23 +02:00
csoler
5b5ad6e6f6
added missing iostream for windows 2019-09-07 13:40:45 +02:00
csoler
2e5821bf59
fixed compilation without RS_JSONAPI 2019-09-06 23:50:39 +02:00
csoler
ad443ecaa4
fixed compilation without RS_JSONAPI 2019-09-06 23:40:04 +02:00
csoler
ccd8c7186d
fixed compilation without RS_JSONAPI 2019-09-06 23:28:04 +02:00
csoler
4a085cf223
removed termios include causing windows compilation to fail 2019-09-06 23:15:21 +02:00
csoler
f182b358f4
fixed compilation in new getpass method 2019-09-06 22:51:10 +02:00
csoler
c365a96489
moved getpass() method into a cross-plateform file rskbdinput.h/cc 2019-09-05 23:54:48 +02:00
csoler
bd0e4d7fba
fixed initialization of RsConfigOptions 2019-09-05 23:07:07 +02:00
G10h4ck
06a158e677
Merge pull request #1628 from G10h4ck/gxs_sqlite_sqlcipher_compat
Improve SQLCipher/SQLite support
2019-09-02 16:28:26 +02:00
Gioacchino Mazzurco
6edf503ae0
Improve SQLCipher/SQLite support
When compiled with SQLCipher it is now capable of handling databases
  created by SQLite-only versions
Add support for SQLCipher on Android arm64
2019-08-31 16:22:24 +02:00
csoler
b4bfdf2e25
fixed shutdown callback issue in retroshare-service.cc 2019-08-30 22:09:47 +02:00
csoler
1bf07f72c4
added destructor in RsTickingThread calling for fullstop, which prevents the crash due to threads being killed when still running 2019-08-30 21:47:17 +02:00
csoler
7d9db1fc22
added destructor in RsTickingThread calling for fullstop, which prevents the crash due to threads being killed when still running 2019-08-30 21:44:05 +02:00
csoler
ab5da5ebf5
switched to RsLoginHelper for login attempt in rs-service. Moved commandline arguments to main executable using a new struct named RsConfigOptions 2019-08-29 23:15:46 +02:00
Gioacchino Mazzurco
9f04e1c9c2
Update udp-discovery-cpp and android openssl 2019-08-29 15:52:07 +02:00
G10h4ck
76dfa04bb5
Merge pull request #1621 from G10h4ck/jsonapi_async_crash_fix
Fix sporadic crash in JSON API async calls
2019-08-28 23:42:02 +02:00
Gioacchino Mazzurco
85ef0e0940
Protect p3BanList::isAddressAccepted with mutex
This method is called from other threads and apparently caused
  a sporadic crash caought on Android.
See retroshare://forum?name=Got%20crash%20on%20Android%20with%20GDB%20backtrace&id=95de1451952d8c38cb1cdfdb85eed986&msgid=ac8c9d41f2cd0c9e8e290433c7f296fecb2d62b3
2019-08-28 23:29:41 +02:00
csoler
90d0686e88
removed Qt from unix version of retroshare service. Enabled loging at start with option -u 2019-08-27 21:54:17 +02:00
Gioacchino Mazzurco
9b8d0afacb
Fix sporadic crash in JSON API async calls
In Restbed one is not supposed to call session->yield outside the
  threads controlled by Restbed. RetroShare JSON API async call were
  calling session->yield from threads controlled by RetroShare all the
  times, this caused crashes in some cases, like when the JSON API
  socket timed out concurrently with the session->yield call .
  To solve this problem session->yield from async
  calls are now wrapped insto mService->schedule to ensure they are
  executed on the right thread (aka one of the threads controlled by
  Restbed).
While solving this issue I realized also that passing RsEvents as const
  references around was quite limiting in cases where the event need to
  be finally handled in another thread, in that case passing by const
  reference the RsEvent needed to be copied by value into the thread
  that process it, in this copy by value process the information of
  which was the original specific type is lost, and then only the data
  and methods from general RsEvents are available, unless the handler
  does tricky stuff with type coercion etc. To solve this limitation
  pass the events as std::shared_ptr<const RsEvent> seems the safer and
  more elegant solution.
2019-08-27 11:59:38 +02:00
csoler
a84a96e0b7
Merge pull request #1617 from G10h4ck/jsonapi_javascript_sixtyfour_integers
Implement workaround to JavaScript 53bit int issue
2019-08-26 19:08:05 +02:00
csoler
c28c193b7c
Merge pull request #1615 from csoler/v0.6-FriendList
V0.6 friend list
2019-08-26 19:07:11 +02:00
Gioacchino Mazzurco
202cee687e
Implement workaround to JavaScript 53bit int issue
JavaScript represents all numbers in a double like manner thus it
  treats 64 bit integers in an unsafe manner, to workaroud this problem
  provide an alternative strin representation in JSON serialization
  format so JavaScript clients can access the correct value someway.
As JSON have no probles with 64 bits integers keep supporting the integer
  representation too.
See https://stackoverflow.com/a/34989371
2019-08-23 13:41:46 +02:00
Gioacchino Mazzurco
98b9152204
Fix a couple compliler warnings in JSON API 2019-08-23 12:02:25 +02:00