Commit Graph

11983 Commits

Author SHA1 Message Date
Phenom
3a22c6d302 Fix warning: comparison between signed and unsigned integer expressions
/retroshare-gui/src/gui/gxsforums/GxsForumsFillThread.cpp:286: warning:
comparison between signed and unsigned integer expressions [-Wsign-
compare]
         for(uint32_t i=1;i<(*it).size();++i)
2017-07-16 20:57:19 +02:00
Phenom
6fd03087d2 Fix warning: this statement may fall through
/retroshare-gui/src/gui/statistics/BWGraph.cpp:245: warning: this
statement may fall through [-Wimplicit-fallthrough=]
   case GRAPH_TYPE_ALL: std::cerr << "(WW) Impossible situation. Cannot
draw graph in mode All/All. Reverting to sum." << std::endl;
2017-07-16 20:56:46 +02:00
Phenom
f27ce82e22 Fix warning: comparison between signed and unsigned integer expressions
, misleading-indentation and unused-variable

/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: comparison between signed and unsigned integer expressions [-
Wsign-compare]
     for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)

/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
     for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)

/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:203:
warning: unused variable ‘now’ [-Wunused-variable]
     time_t now = time(NULL) ;
2017-07-16 20:56:18 +02:00
Phenom
15bc9c1c3c Fix warning: this statement may fall through
/retroshare-gui/src/gui/GetStartedDialog.cpp:122: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    ui.firewallCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:124: here
   case RSCONFIG_USER_LEVEL_CASUAL:

/retroshare-gui/src/gui/GetStartedDialog.cpp:125: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    ui.connectCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:127: here
   case RSCONFIG_USER_LEVEL_BASIC:
2017-07-16 20:54:41 +02:00
Phenom
f23c84fd4e Fix warning: this statement may fall through
/retroshare-gui/src/gui/RetroShareLink.cpp:585: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if(!checkSSLId(_SSLid))
/retroshare-gui/src/gui/RetroShareLink.cpp:587: here
   case TYPE_FILE:
2017-07-16 20:54:05 +02:00
Phenom
9a4ed8012c Fix warning: comparison between signed and unsigned integer expressions
and unused variables

/retroshare-nogui/src/TerminalApiClient.cpp:233: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
    while(selected_account_number >= accounts.size())

/retroshare-nogui/src/TerminalApiClient.cpp:243: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
     if(selected_account_number >= accounts.size())

/retroshare-nogui/src/TerminalApiClient.cpp:121: warning: unused
variable ‘IO_POLL_PERIOD’ [-Wunused-variable]
     const int IO_POLL_PERIOD          = 20;

/retroshare-nogui/src/TerminalApiClient.cpp:124: warning: unused
variable ‘last_io_poll’ [-Wunused-variable]
     int last_io_poll  = 0;

/retroshare-nogui/src/TerminalApiClient.cpp:127: warning: unused
variable ‘last_char’ [-Wunused-variable]
     int last_char = 0;

/retroshare-nogui/src/TerminalApiClient.cpp:129: warning: unused
variable ‘enter_was_pressed’ [-Wunused-variable]
     bool enter_was_pressed = false;

/retroshare-nogui/src/TerminalApiClient.cpp:133: warning: variable
‘account_number_typed’ set but not used [-Wunused-but-set-variable]
  int account_number_typed = 0 ;
2017-07-16 20:53:14 +02:00
Phenom
8455adf375 Fix warning: unused parameter ‘type’ and ‘req’
/libresapi/src/api/ChatHandler.cpp:236: warning: unused parameter ‘type’
[-Wunused-parameter]
 void ChatHandler::notifyListChange(int list, int type)

/libresapi/src/api/ChatHandler.cpp:971: warning: unused parameter ‘req’
[-Wunused-parameter]
 void ChatHandler::handleGetInvitationsToLobby(Request& req, Response&
resp)
2017-07-16 20:49:27 +02:00
Phenom
c866bf91c6 Fix warning: unused parameter ‘req’ and ‘resp’
/libresapi/src/api/IdentityHandler.cpp:721: warning: unused parameter
‘req’ [-Wunused-parameter]
 ResponseTask* IdentityHandler::handleDeleteIdentity(Request& req,

/libresapi/src/api/IdentityHandler.cpp:722: warning: unused parameter
‘resp’ [-Wunused-parameter]
                                                     Response& resp)
2017-07-16 20:48:50 +02:00
Phenom
9d4967c0e1 Fix warning: unused parameter ‘req’
/libresapi/src/api/PeersHandler.cpp:670: warning: unused parameter ‘req’
[-Wunused-parameter]
 void PeersHandler::handleGetNetworkOptions(Request& req, Response&
resp)
2017-07-16 20:48:15 +02:00
Phenom
c97269bed6 Fix warning: this statement may fall through
/libretroshare/src/gxstrans/p3gxstrans.cc:870: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.sent_ts = time(NULL) ; //pr.mailItem.meta.mPublishTs = time(NULL);
/libretroshare/src/gxstrans/p3gxstrans.cc:872: here
  case GxsTransSendStatus::PENDING_PREFERRED_GROUP:

/libretroshare/src/gxstrans/p3gxstrans.cc:883: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.group_id = mPreferredGroupId ; //pr.mailItem.meta.mGroupId =
mPreferredGroupId;
/libretroshare/src/gxstrans/p3gxstrans.cc:885: here
  case GxsTransSendStatus::PENDING_RECEIPT_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:906: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.msg.setBinData(&grsrz[0], grsz);
/libretroshare/src/gxstrans/p3gxstrans.cc:908: here
  case GxsTransSendStatus::PENDING_RECEIPT_SIGNATURE:     // (cyril)
This step is never actually used.

/libretroshare/src/gxstrans/p3gxstrans.cc:924: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.meta.setBinData(&srx[0], metaSize);
/libretroshare/src/gxstrans/p3gxstrans.cc:926: here
  case GxsTransSendStatus::PENDING_PAYLOAD_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:938: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   memcpy(&pr.mailItem.payload[offset], &pr.mailData[0], datasize);
/libretroshare/src/gxstrans/p3gxstrans.cc:940: here
  case GxsTransSendStatus::PENDING_PAYLOAD_ENCRYPT:

/libretroshare/src/gxstrans/p3gxstrans.cc:982: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   }
/libretroshare/src/gxstrans/p3gxstrans.cc:984: here
  case GxsTransSendStatus::PENDING_PUBLISH:
2017-07-16 20:47:45 +02:00
Phenom
18139489cf Fix warning: unused parameter ‘grpItem’ and unused debug variables
/libretroshare/src/gxstrans/p3gxstrans.cc:635: warning: unused parameter
‘grpItem’ [-Wunused-parameter]
         RsGxsGrpItem* grpItem, RsTlvSecurityKeySet& /*keySet*/ )

/libretroshare/src/gxstrans/p3gxstrans.cc:681: warning: unused variable
‘msgId’ [-Wunused-variable]
      const RsGxsMessageId& msgId = *vit;

/libretroshare/src/gxstrans/p3gxstrans.cc:676: warning: unused variable
‘grpId’ [-Wunused-variable]
     const RsGxsGroupId& grpId = it->first;
2017-07-16 20:46:55 +02:00
Phenom
e1ea92d733 Fix warning: unused parameter ‘n’
/libretroshare/src/serialiser/rstypeserializer.cc:358: warning: unused
parameter ‘n’ [-Wunused-parameter]
 template<> void RsTypeSerializer::print_data( const std::string& n,
2017-07-16 20:41:24 +02:00
Phenom
f193af2865 Fix warning: unused parameter ‘size’
/libretroshare/src/gxs/rsgenexchange.cc:3079: warning: unused parameter
‘size’ [-Wunused-parameter]
 bool RsGenExchange::acceptNewMessage(const RsGxsMsgMetaData* /
*grpMeta*/,uint32_t size ) { return true; }
2017-07-16 20:41:01 +02:00
Phenom
d8b0b5222b Fix warning: variable ‘it’ set but not used
/libretroshare/src/gxs/rsgxsnetservice.cc:867: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
     std::map<RsGxsGroupId,RsGxsServerMsgUpdate>::iterator it =
mServerMsgUpdateMap.find(grpId) ;

/libretroshare/src/gxs/rsgxsnetservice.cc:2434: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
             ClientGrpMap::iterator it =
mClientGrpUpdateMap.find(peerFrom);
2017-07-16 20:40:31 +02:00
Phenom
b11022a239 Fix warning: this statement may fall through
/libretroshare/src/util/dnsresolver.cc:49: warning: this statement may
fall through [-Wimplicit-fallthrough=]
       case DNSResolver::DNS_LOOKUP_ERROR:  if(it-
>second.last_lookup_time + MAX_TIME_BEFORE_RETRY > now)
/libretroshare/src/util/dnsresolver.cc:52: here
       case DNSResolver::DNS_DONT_HAVE:   next_call = it->first ;
2017-07-16 20:38:43 +02:00
Phenom
0e302e254e Fix warning: this statement may fall through
/libretroshare/src/util/rsnet_ss.cc:1031: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   success = inet_ntop( addr.ss_family, (const void *) &(addrv4p-
>sin_addr), ipStr, INET_ADDRSTRLEN );
/libretroshare/src/util/rsnet_ss.cc:1033: here
  case AF_INET6:
2017-07-16 20:36:16 +02:00
Phenom
7b4d3c5a24 Fix warning: this statement may fall through
/libretroshare/src/util/rscompress.cc:165: warning: this statement may
fall through [-Wimplicit-fallthrough=]
      ret = Z_DATA_ERROR;     /* and fall through */
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/util/rscompress.cc:
166: here
     case Z_DATA_ERROR:
2017-07-16 20:34:38 +02:00
Phenom
476b581506 Fix warning: this statement may fall through
/libretroshare/src/rsserver/p3serverconfig.cc:292: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->getFriendCount(true, false) > MIN_BASIC_FRIENDS)
/libretroshare/src/rsserver/p3serverconfig.cc:297: here
   case RSCONFIG_USER_LEVEL_BASIC:

/libretroshare/src/rsserver/p3serverconfig.cc:300: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->haveOnceConnected())
/libretroshare/src/rsserver/p3serverconfig.cc:306: here
   case RSCONFIG_USER_LEVEL_CASUAL:
2017-07-16 20:33:55 +02:00
Phenom
7bd7c57ff9 Fix warning: variable ‘pgpNameFound’ set but not used
/libretroshare/src/rsserver/rsaccounts.cc:130: warning: variable
‘pgpNameFound’ set but not used [-Wunused-but-set-variable]
  bool pgpNameFound = false;
2017-07-16 20:32:32 +02:00
Phenom
a0506c1a0f Fix warning: this statement may fall through
/libretroshare/src/pqi/pqissl.cc:449: warning: this statement may fall
through [-Wimplicit-fallthrough=]
    sslmode = PQISSL_ACTIVE; /* we're starting this one */
/libretroshare/src/pqi/pqissl.cc:456: here
   case WAITING_DELAY:
2017-07-16 20:31:49 +02:00
Phenom
b9d4651f07 Fix warning: this statement may fall through
/libretroshare/src/pqi/pqisslpersongrp.cc:125: warning: this statement
may fall through [-Wimplicit-fallthrough=]
     std::cerr << " --> falling back to Tor" << std::endl;
/libretroshare/src/pqi/pqisslpersongrp.cc:126: here
    case RS_HIDDEN_TYPE_TOR:
2017-07-16 20:30:41 +02:00
Phenom
e12f51b1be Fix warning: variable ‘peerIt1’ set but not used
/libretroshare/src/pqi/p3peermgr.cc:2619: warning: variable ‘peerIt1’
set but not used [-Wunused-but-set-variable]
                     std::set<RsPgpId>::iterator peerIt1 =
groupItem.peerIds.find(*peerIt);
2017-07-16 20:28:24 +02:00
Phenom
78cfde9b4f Fix warning: this statement may fall through
/libretroshare/src/pgp/pgphandler.cc:62: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE_PREV_WAS_BAD: prev_was_bad =
true ;

/libretroshare/src/pgp/pgphandler.cc:63: here
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE:
2017-07-16 20:27:46 +02:00
Phenom
3a6ad822da Fix warning: this statement may fall through
/libretroshare/src/ft/ftchunkmap.cc:190: warning: this statement may
fall through [-Wimplicit-fallthrough=]
    case FileChunksInfo::CHUNK_CHECKING: _file_is_complete = false ;

/libretroshare/src/ft/ftchunkmap.cc:191: here
    case FileChunksInfo::CHUNK_DONE:   _total_downloaded +=
sizeOfChunk(i) ;
2017-07-16 20:27:09 +02:00
Phenom
635246c462 Fix warning: this statement may fall through
/libretroshare/src/tcponudp/bss_tou.c:246: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   num=0;

/libretroshare/src/tcponudp/bss_tou.c:247: here
  case BIO_C_FILE_SEEK:
2017-07-16 20:25:11 +02:00
Phenom
e718070dbd Fix warning: this statement may fall through
/libbitdht/src/bitdht/bdconnection.cc:1288: warning: this statement may
fall through [-Wimplicit-fallthrough=]
      if (errsrc == BITDHT_CONNECT_ERROR_SOURCE_END)
/libbitdht/src/bitdht/bdconnection.cc:1308: here
     case BITDHT_CONNECT_ERROR_DUPLICATE: // similar attempt. delay/
recycle (ANY/ANY)
2017-07-16 20:23:39 +02:00
Phenom
714f9bba99 Fix warning: this statement may fall through
/openpgpsdk/src/openpgpsdk/packet-parse.c:2482: warning: this statement
may fall through [-Wimplicit-fallthrough=]
         hashes[n].add(&hashes[n],C.secret_key.salt,OPS_SALT_SIZE);
/openpgpsdk/src/openpgpsdk/packet-parse.c:2484: here
      case OPS_S2KS_SIMPLE:
2017-07-16 20:21:38 +02:00
csoler
987c10522a Merge pull request #945 from PhenomRetroShare/Add_RSLinkCreateAsStatic
Change RetroShareLink creation methodes as static
2017-07-16 20:16:31 +02:00
csoler
e40dbe82a4 Merge pull request #947 from csoler/v0.6-ImprovedGUI
fixed filtering for channels when loading  items on the fly
2017-07-16 17:03:37 +02:00
csoler
1e98de76a1 fixed filtering for channels when loading items on the fly 2017-07-16 16:56:23 +02:00
Phenom
59e018e02d Fix GUI AutoLogin 2017-07-16 16:03:56 +02:00
Phenom
82addce867 Change RetroShareLink creation methodes as static
And remove this warning:
2017-07-16 13:12:07 +02:00
csoler
2d5e1d637f fixed last update missing commits 2017-07-16 10:08:33 +02:00
csoler
471812586a updated changelog 2017-07-16 10:06:11 +02:00
csoler
991049d8da Merge pull request #944 from csoler/v0.6-ImprovedGUI
V0.6 improved gui
2017-07-15 22:20:43 +02:00
csoler
08faa3f5d5 fixed p3Gxstunnel so that it sends the data packets in the same order it received them. This fixes the bug in distant chat causing images to not transfer correctly in some cases 2017-07-15 22:16:45 +02:00
csoler
9c391cb015 added an additional param to BinToHex so as to limit the size of the output 2017-07-15 22:15:51 +02:00
csoler
6a8b74c965 fixed compilation for computers where qreal is a float 2017-07-15 22:01:18 +02:00
Phenom
a16ff426ae Add [Unsigned] before name in chat for unsigned (anonymous) GxsID. 2017-07-14 19:16:39 +02:00
Gioacchino Mazzurco
cd61797cfb Qml App: Fix QtQuick.Controls version in Btn 2017-07-14 13:22:32 +02:00
Gioacchino Mazzurco
5c7c56ac99 android-notify stop login attempter if coreReady
In case the login was made manually by the user via the grafical
interface when the autologin managaer has already started but not logged
in yet, the password attempt timer was looping to infinite causing
unnecessary load and log spamming, this commit attempt to prevent that
from happening
2017-07-14 12:16:18 +02:00
Gioacchino Mazzurco
ee357298c7 Merge branch 'qml_app_ui_aesthetic' into evaluation-II 2017-07-14 11:09:59 +02:00
csoler
5ffb54929c Merge pull request #930 from myfingerhurt/master
add multi-line text messages, and search function.
2017-07-13 21:49:47 +02:00
csoler
3912118a86 Merge pull request #925 from PhenomRetroShare/Fix_ChannelCommentLineWrap
Fix channel comments line wrap
2017-07-13 21:42:05 +02:00
csoler
98b0585ba4 Merge pull request #937 from csoler/v0.6-ImprovedNoGUI
V0.6 improved no gui
2017-07-13 21:23:13 +02:00
Gioacchino Mazzurco
69aa5b6a09 Clean some garbage from the code 2017-07-13 13:00:32 +02:00
csoler
fd452af088 removed some debut output that perturbated the passwd command line 2017-07-12 23:03:17 +02:00
csoler
00c1a9a7ff fixed autologin 2017-07-12 22:53:35 +02:00
csoler
66268c8267 fixed variable shadowing a parameter 2017-07-12 18:48:06 +02:00
Angela Mazzurco
0494dd7516 Merge remote-tracking branch 'retro/master' into qml_app_avatar_picker 2017-07-12 18:24:29 +02:00