Commit Graph

4675 Commits

Author SHA1 Message Date
Phenom
27bedf8414 Fix Lobby auto-subscribe.
Don't remove auto-subscribe if we cannot get gxsId detail.
But what happens if the id is removed?
2017-08-01 10:16:42 +02:00
csoler
7d5f60185b Merge pull request #978 from G10h4ck/cxx11_comp
Introduce C++11 compatibility macro for gcc < 4.6
2017-07-31 19:22:15 +02:00
Gioacchino Mazzurco
541b1ea498 Introduce C++11 compatibility macro for gcc < 4.6 2017-07-31 18:26:51 +02:00
csoler
2588068775 Merge pull request #953 from PhenomRetroShare/Fix_NewWindowForPassword
Fix Ask Password in new window if wrong in StartDialog.
2017-07-30 21:29:14 +02:00
csoler
a2f8b5e6e9 Merge pull request #972 from csoler/v0.6.3
V0.6.3
2017-07-30 14:42:28 +02:00
csoler
e82b6fc1fe improved GenCertDialog with small indicator text, and hide location by default 2017-07-30 14:31:52 +02:00
Phenom
5dc25e37f7 Fix Ask Password in new window if wrong in StartDialog.
And Fix LineEditClear to show placeholder test even if it has focus
(Like Qt5).
2017-07-30 14:11:34 +02:00
csoler
09faa60005 Merge pull request #967 from csoler/v0.6.3
V0.6.3
2017-07-29 23:16:47 +02:00
csoler
e8415c4f03 made RS not to ask for plugin confirmation on first load 2017-07-29 23:12:56 +02:00
csoler
a16220e53e switched to RC2 2017-07-29 20:24:31 +02:00
csoler
e861f87364 removed unused msg item class that caused aliasing warnings (serialisation of time_t as uint32_t) 2017-07-26 21:44:24 +02:00
csoler
286e7e0b1a Merge pull request #961 from csoler/v0.6.3
V0.6.3
2017-07-26 14:01:28 +02:00
csoler
34ddf71703 Merge pull request #957 from PhenomRetroShare/Fix_CppCheckerError
Fix cpp checker error
2017-07-26 13:54:44 +02:00
csoler
1792273cff Merge pull request #946 from PhenomRetroShare/Fix_GuiAutoLogin
Fix GUI AutoLogin
2017-07-26 13:50:21 +02:00
csoler
b0483a0c38 fixed bug in removeDeleteExistingMsgs() 2017-07-26 10:23:18 +02:00
csoler
9881b616ac cleanup code in RsGenExchange 2017-07-25 22:06:18 +02:00
csoler
a382a0f5ce fixed memory leak in p3peermgr config load 2017-07-25 21:52:09 +02:00
csoler
041f989f1c rewrote processRecvdMessages() and processRecvdGroups() in RsGenExchange. Removed mReceivedGrps and mReceivedMsgs, cleaned-up terrible branching and memory management 2017-07-25 21:21:24 +02:00
csoler
461ccf3b84 removed aliasing in storeMessages/storeGroups, removed several memory leaks in unittests, improved auto-delete structures in rsgxsutil, added deletion for members of RsGenExchange, removed shared pointers from unittests (they cause a memory leak and are only used in unittests) 2017-07-25 00:07:53 +02:00
csoler
79779b8056 fixed memory leaks in GxsSecurity 2017-07-24 18:45:24 +02:00
csoler
70f72db0aa fixed memory leak in GxsSecurity 2017-07-24 18:20:21 +02:00
csoler
bcaafc241d improved template class naming for temporary Gxs grp data structures 2017-07-24 14:29:30 +02:00
Gioacchino Mazzurco
3b1606ceb9 Remove misguiding if 2017-07-24 11:52:23 +02:00
Gioacchino Mazzurco
03cc2e629d Remove miguiding if before delete 2017-07-24 10:16:24 +02:00
csoler
02424240a0 reverting last commit that causes crashes 2017-07-22 12:08:28 +02:00
csoler
9e2241a940 attempt to fix memory leak in RsGenExchange. To be tested. 2017-07-21 23:15:50 +02:00
Phenom
8ce10ea6a8 Fix past commit for p3idservice.cc 2017-07-21 15:31:53 +02:00
Phenom
2afc1bf423 Fix CppCheck Error in contentvalue.cc
/libretroshare/src/util/contentvalue.cc:189: error: Cppcheck(memleak):
Memory leak: dest
2017-07-21 15:04:34 +02:00
Phenom
e5767431e6 Fix CppCheck Error in p3idservice.cc
/libretroshare/src/services/p3idservice.cc:1216: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:1346: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:448: error:
Cppcheck(uninitvar): Uninitialized variable: max_keep_time
2017-07-21 14:57:43 +02:00
csoler
aa471e5b2f fixed uninitialized memory read in GxsTrans 2017-07-21 10:25:20 +02:00
csoler
baac33d95a updated revision number 2017-07-20 21:18:57 +02:00
Phenom
cbbc3920fa Fix Lobby auto-subscribe.
Save GxsId for each.
Disallow to auto-subscribe to signed lobby with unsigned id.
2017-07-19 18:33:55 +02:00
csoler
71810e8daa Merge pull request #950 from PhenomRetroShare/Add_ChatServerFlag
Add flag for ChatServer
2017-07-19 18:18:32 +02:00
Phenom
5bbb99aef7 Fix Bad Service Monitor registering.
This induce to remove peers in statistics->bandwidth when disc service
is off.
2017-07-18 19:24:32 +02:00
Phenom
3a6bcf5ef8 Add flag for ChatServer
append the following assignation to qmake command line "CONFIG
+=rs_chatserver"
2017-07-18 16:34:56 +02:00
csoler
e56340e0a1 Merge pull request #386 from PhenomRetroShare/Add_AbilityToChangeOpModeInCmdLine
Add the ability to change OpMode in command line.
2017-07-17 23:12:06 +02:00
csoler
f4aec11b0a suppressed warning in p3dhtmgr.cc 2017-07-17 22:48:12 +02:00
Phenom
437426429e Fix clang warning: unused variable 'pqiservicezone'
/libretroshare/src/pqi/pqiservice.cc:30: warning: unused variable
'pqiservicezone' [-Wunused-const-variable]
const int pqiservicezone = 60478;
2017-07-17 22:35:01 +02:00
Phenom
300359863e Fix clang warning: 'p3ChatService' defined as a struct here but
previously declared as a class

/libretroshare/src/chat/p3chatservice.h:56: warning: 'p3ChatService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3ChatService :
/libretroshare/src/rsserver/p3msgs.h:33: did you mean struct here?
class p3ChatService;
2017-07-17 22:32:23 +02:00
Phenom
91c526f2b5 Fix clang warning: 'p3MsgService' defined as a struct here but
previously declared as a class

/libretroshare/src/services/p3msgservice.h:58: warning: 'p3MsgService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3MsgService :
/libretroshare/src/rsserver/p3msgs.h:32: did you mean struct here?
class p3MsgService;
2017-07-17 22:32:07 +02:00
Phenom
896ed3e992 Fix clang warning: class 'p3Config' was previously declared as a struct
/libretroshare/src/retroshare/rsplugin.h:77: warning: class 'p3Config'
was previously declared as a struct [-Wmismatched-tags]
class p3Config;
2017-07-17 22:31:30 +02:00
Phenom
8dbb0d61af Fix warning: this statement may fall through
/libretroshare/src/dht/connectstatebox.cc:394: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:401: here
   default:

/libretroshare/src/dht/connectstatebox.cc:406: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:414: here
   case CSB_START:

/libretroshare/src/dht/connectstatebox.cc:530: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:540: here
   default:

/libretroshare/src/dht/connectstatebox.cc:543: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:551: here
   case CSB_START:
2017-07-17 22:29:11 +02:00
Phenom
f888913800 Set Operating Mode in RsInit::InitRetroShare so noGUI could use it. 2017-07-17 15:40:14 +02:00
cyril soler
1491a051dc fixed deadlock situation in FT causing multiple bugs: lock when DLing from a file list a file that is already being downloaded, and lock when a FT module find a direct source among friends 2017-07-17 11:16:48 +02:00
Phenom
e2fa57dcd7 Fix clang warning: unused variable 'INTERVAL_BETWEEN_DEBUG_DUMP'
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP        = 10 ;
2017-07-16 21:43:05 +02:00
Phenom
26397d7e4d Fix clang warning: unused variables 'LOWER_LIMIT', ...
/libretroshare/src/services/p3gxsreputation.cc:130: warning: unused
variable 'LOWER_LIMIT' [-Wunused-const-variable]
static const uint32_t LOWER_LIMIT                         = 0;        //
used to filter valid Opinion values from serialized data
/libretroshare/src/services/p3gxsreputation.cc:132: warning: unused
variable 'kMaximumPeerAge' [-Wunused-const-variable]
static const int      kMaximumPeerAge                     = 180;      //
half a year.
/libretroshare/src/services/p3gxsreputation.cc:135: warning: unused
variable 'ACTIVE_FRIENDS_ONLINE_DELAY' [-Wunused-const-variable]
static const int      ACTIVE_FRIENDS_ONLINE_DELAY         = 86400*7 ; //
1 week.
/libretroshare/src/services/p3gxsreputation.cc:138: warning: unused
variable 'REPUTATION_ASSESSMENT_THRESHOLD_X1' [-Wunused-const-variable]
static const float    REPUTATION_ASSESSMENT_THRESHOLD_X1  = 0.5f ;    //
reputation under which the peer gets killed. Warning there's a 1 shift
with what's shown in GUI. Be careful.
/libretroshare/src/services/p3gxsreputation.cc:139: warning: unused
variable 'PGP_AUTO_BAN_THRESHOLD_DEFAULT' [-Wunused-const-variable]
static const uint32_t PGP_AUTO_BAN_THRESHOLD_DEFAULT      = 2 ;       //
above this, auto ban any GXS id signed by this node
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP        = 10 ;
2017-07-16 21:37:22 +02:00
Phenom
903f875d1d Fix clang warning: unused variable 'MAX_SERIALIZED_ARRAY_SIZE'
/libretroshare/src/serialiser/rstypeserializer.cc:39: warning: unused
variable 'MAX_SERIALIZED_ARRAY_SIZE' [-Wunused-const-variable]
static const uint32_t MAX_SERIALIZED_ARRAY_SIZE = 500 ;
2017-07-16 21:36:35 +02:00
Phenom
d83a9625cc Fix clang warning: unused variables 'GIXS_CUT_OFF', ...
/libretroshare/src/gxs/rsgxsnetservice.cc:247: warning: unused variable
'GIXS_CUT_OFF' [-Wunused-const-variable]
static const uint32_t GIXS_CUT_OFF                            =
0;
/libretroshare/src/gxs/rsgxsnetservice.cc:251: warning: unused variable
'SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE' [-Wunused-const-variable]
static const uint32_t SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE =
3600; // force re-update if there happens to be a large delay between
our server side TS and the client side TS of friends
2017-07-16 21:36:14 +02:00
Phenom
51fa7a5dda Fix clang warning: unused variable 'p3facestartupzone'
/libretroshare/src/rsserver/rsinit.cc:145: warning: unused variable
'p3facestartupzone' [-Wunused-const-variable]
const int p3facestartupzone = 47238;
2017-07-16 21:35:35 +02:00
Phenom
13220ec414 Fix clang warning: unused variable
'MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT'

/libretroshare/src/rsserver/p3peers.cc:52: warning: unused variable
'MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT' [-Wunused-const-variable]
static const int MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT = 30*24*3600 ;
// 30 days.
2017-07-16 21:34:38 +02:00
Phenom
fea1b83b34 Fix clang warning: unused variable 'p3facemsgzone'
/libretroshare/src/rsserver/p3face-config.cc:36: warning: unused
variable 'p3facemsgzone' [-Wunused-const-variable]
const int p3facemsgzone = 11453;

/libretroshare/src/rsserver/p3msgs.cc:33: warning: unused variable
'p3facemsgzone' [-Wunused-const-variable]
const int p3facemsgzone = 11453;
2017-07-16 21:34:09 +02:00
Phenom
5a64996304 Fix clang warning: unused variables 'RS_NET_NEEDS_RESET', ...
/libretroshare/src/pqi/p3peermgr.cc:53: warning: unused variable
'RS_NET_NEEDS_RESET' [-Wunused-const-variable]
const uint32_t RS_NET_NEEDS_RESET =     0x0000;
/libretroshare/src/pqi/p3peermgr.cc:54: warning: unused variable
'RS_NET_UNKNOWN' [-Wunused-const-variable]
const uint32_t RS_NET_UNKNOWN =         0x0001;
/libretroshare/src/pqi/p3peermgr.cc:55: warning: unused variable
'RS_NET_UPNP_INIT' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_INIT =       0x0002;
/libretroshare/src/pqi/p3peermgr.cc:56: warning: unused variable
'RS_NET_UPNP_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_SETUP =      0x0003;
/libretroshare/src/pqi/p3peermgr.cc:57: warning: unused variable
'RS_NET_EXT_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_EXT_SETUP =       0x0004;
/libretroshare/src/pqi/p3peermgr.cc:58: warning: unused variable
'RS_NET_DONE' [-Wunused-const-variable]
const uint32_t RS_NET_DONE =            0x0005;
/libretroshare/src/pqi/p3peermgr.cc:59: warning: unused variable
'RS_NET_LOOPBACK' [-Wunused-const-variable]
const uint32_t RS_NET_LOOPBACK =        0x0006;
/libretroshare/src/pqi/p3peermgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN =            0x0007;
/libretroshare/src/pqi/p3peermgr.cc:62: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET =             5;
/libretroshare/src/pqi/p3peermgr.cc:64: warning: unused variable
'PEER_IP_CONNECT_STATE_MAX_LIST_SIZE' [-Wunused-const-variable]
const uint32_t PEER_IP_CONNECT_STATE_MAX_LIST_SIZE =            4;
2017-07-16 21:31:41 +02:00
Phenom
4152a46ad8 Fix clang warning: unused variable 'P3CONNMGR_UDP_DEFAULT_DELAY'
/libretroshare/src/pqi/p3linkmgr.cc:78: warning: unused variable
'P3CONNMGR_UDP_DEFAULT_DELAY' [-Wunused-const-variable]
const uint32_t P3CONNMGR_UDP_DEFAULT_DELAY = 3; /* 2 Seconds? is it be
enough! */
2017-07-16 21:31:11 +02:00
Phenom
5b1323e31f Fix clang warning: unused variables 'PQI_HANDLER_NB_PRIORITY_LEVELS',
...

/libretroshare/src/pqi/pqihandler.cc:71: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_LEVELS' [-Wunused-const-variable]
static const int PQI_HANDLER_NB_PRIORITY_LEVELS = 10 ;
/libretroshare/src/pqi/pqihandler.cc:72: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_RATIO' [-Wunused-const-variable]
static const float PQI_HANDLER_NB_PRIORITY_RATIO = 2 ;
2017-07-16 21:30:31 +02:00
Phenom
9148fa6645 Fix clang warning: unused variables 'RS_NET_DOWN', ...
/libretroshare/src/pqi/p3netmgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN =            0x0007;
/libretroshare/src/pqi/p3netmgr.cc:63: warning: unused variable
'RS_STUN_DHT' [-Wunused-const-variable]
const uint32_t RS_STUN_DHT =            0x0001;
/libretroshare/src/pqi/p3netmgr.cc:64: warning: unused variable
'RS_STUN_DONE' [-Wunused-const-variable]
const uint32_t RS_STUN_DONE =           0x0002;
/libretroshare/src/pqi/p3netmgr.cc:65: warning: unused variable
'RS_STUN_LIST_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_LIST_MIN =       100;
/libretroshare/src/pqi/p3netmgr.cc:66: warning: unused variable
'RS_STUN_FOUND_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_FOUND_MIN =      10;
/libretroshare/src/pqi/p3netmgr.cc:70: warning: unused variable
'MAX_NETWORK_INIT' [-Wunused-const-variable]
const uint32_t MAX_NETWORK_INIT =       70; /* timeout before network
reset */
/libretroshare/src/pqi/p3netmgr.cc:72: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET =             5;
2017-07-16 21:18:22 +02:00
Phenom
e4616c09bc Fix clang warning: unused variable 'STORE_KEY_TIMEOUT'
/libretroshare/src/pqi/authgpg.cc:51: warning: unused variable
'STORE_KEY_TIMEOUT' [-Wunused-const-variable]
const time_t STORE_KEY_TIMEOUT = 1 * 60 * 60; //store key is call around
every hour
2017-07-16 21:17:52 +02:00
Phenom
0479ec07ab Fix clang warning: unused variable 'MAX_MESSAGES_PER_SECONDS_NUMBER'
/libretroshare/src/chat/distributedchat.cc:57: warning: unused variable
'MAX_MESSAGES_PER_SECONDS_NUMBER' [-Wunused-const-variable]
static const uint32_t MAX_MESSAGES_PER_SECONDS_NUMBER     =  5 ; // max
number of messages from a given peer in a window for duration below
2017-07-16 21:17:06 +02:00
Phenom
80ea4de7be Fix clang warning: unused variable 'ftserverzone'
/libretroshare/src/ft/ftserver.cc:34: warning: unused variable
'ftserverzone' [-Wunused-const-variable]
const int ftserverzone = 29539;
2017-07-16 21:16:30 +02:00
Phenom
8a270af519 fixed merging problem 2017-07-16 21:15:26 +02:00
Phenom
35186c4054 Fix clang warning: unused variable 'res'
/libretroshare/src/crypto/chacha20.cpp:978: warning: unused variable
'res' [-Wunused-variable]
        uint256_32 res(q1) ;
2017-07-16 21:12:09 +02:00
Phenom
7f1e23085d Fix clang warning: unused variable 'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG', ...
/libretroshare/src/ft/fttransfermodule.cc:56: warning: unused variable
'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_MAX_WAIT_PER_GIG = 20; /* 20 seconds per
gigabyte */
/libretroshare/src/ft/fttransfermodule.cc:65: warning: unused variable
'FT_TM_FAST_RTT' [-Wunused-const-variable]
const int32_t FT_TM_FAST_RTT    = 1.0;
/libretroshare/src/ft/fttransfermodule.cc:66: warning: unused variable
'FT_TM_STD_RTT' [-Wunused-const-variable]
const int32_t FT_TM_STD_RTT     = 5.0;
/libretroshare/src/ft/fttransfermodule.cc:67: warning: unused variable
'FT_TM_SLOW_RTT' [-Wunused-const-variable]
const int32_t FT_TM_SLOW_RTT    = 20.0;
/libretroshare/src/ft/fttransfermodule.cc:69: warning: unused variable
'FT_TM_CRC_MAP_STATE_NOCHECK' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_NOCHECK      = 0 ;
/libretroshare/src/ft/fttransfermodule.cc:70: warning: unused variable
'FT_TM_CRC_MAP_STATE_DONT_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_DONT_HAVE = 1 ;
/libretroshare/src/ft/fttransfermodule.cc:71: warning: unused variable
'FT_TM_CRC_MAP_STATE_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_HAVE                 = 2 ;
2017-07-16 21:11:47 +02:00
Phenom
8b99c80e07 Fix clang warning: 'p3GxsTrans' defined as a class here but previously
declared as a struct

/libretroshare/src/gxstrans/p3gxstrans.h:88: warning: 'p3GxsTrans'
defined as a class here but previously declared as a struct [-
Wmismatched-tags]
class p3GxsTrans : public RsGenExchange, public GxsTokenQueue, public
p3Config, public RsGxsTrans
/libretroshare/src/gxstrans/p3gxstrans.h:31: did you mean class here?
struct p3GxsTrans;
2017-07-16 21:11:10 +02:00
Phenom
c97269bed6 Fix warning: this statement may fall through
/libretroshare/src/gxstrans/p3gxstrans.cc:870: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.sent_ts = time(NULL) ; //pr.mailItem.meta.mPublishTs = time(NULL);
/libretroshare/src/gxstrans/p3gxstrans.cc:872: here
  case GxsTransSendStatus::PENDING_PREFERRED_GROUP:

/libretroshare/src/gxstrans/p3gxstrans.cc:883: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.group_id = mPreferredGroupId ; //pr.mailItem.meta.mGroupId =
mPreferredGroupId;
/libretroshare/src/gxstrans/p3gxstrans.cc:885: here
  case GxsTransSendStatus::PENDING_RECEIPT_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:906: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.msg.setBinData(&grsrz[0], grsz);
/libretroshare/src/gxstrans/p3gxstrans.cc:908: here
  case GxsTransSendStatus::PENDING_RECEIPT_SIGNATURE:     // (cyril)
This step is never actually used.

/libretroshare/src/gxstrans/p3gxstrans.cc:924: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.meta.setBinData(&srx[0], metaSize);
/libretroshare/src/gxstrans/p3gxstrans.cc:926: here
  case GxsTransSendStatus::PENDING_PAYLOAD_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:938: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   memcpy(&pr.mailItem.payload[offset], &pr.mailData[0], datasize);
/libretroshare/src/gxstrans/p3gxstrans.cc:940: here
  case GxsTransSendStatus::PENDING_PAYLOAD_ENCRYPT:

/libretroshare/src/gxstrans/p3gxstrans.cc:982: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   }
/libretroshare/src/gxstrans/p3gxstrans.cc:984: here
  case GxsTransSendStatus::PENDING_PUBLISH:
2017-07-16 20:47:45 +02:00
Phenom
18139489cf Fix warning: unused parameter ‘grpItem’ and unused debug variables
/libretroshare/src/gxstrans/p3gxstrans.cc:635: warning: unused parameter
‘grpItem’ [-Wunused-parameter]
         RsGxsGrpItem* grpItem, RsTlvSecurityKeySet& /*keySet*/ )

/libretroshare/src/gxstrans/p3gxstrans.cc:681: warning: unused variable
‘msgId’ [-Wunused-variable]
      const RsGxsMessageId& msgId = *vit;

/libretroshare/src/gxstrans/p3gxstrans.cc:676: warning: unused variable
‘grpId’ [-Wunused-variable]
     const RsGxsGroupId& grpId = it->first;
2017-07-16 20:46:55 +02:00
Phenom
e1ea92d733 Fix warning: unused parameter ‘n’
/libretroshare/src/serialiser/rstypeserializer.cc:358: warning: unused
parameter ‘n’ [-Wunused-parameter]
 template<> void RsTypeSerializer::print_data( const std::string& n,
2017-07-16 20:41:24 +02:00
Phenom
f193af2865 Fix warning: unused parameter ‘size’
/libretroshare/src/gxs/rsgenexchange.cc:3079: warning: unused parameter
‘size’ [-Wunused-parameter]
 bool RsGenExchange::acceptNewMessage(const RsGxsMsgMetaData* /
*grpMeta*/,uint32_t size ) { return true; }
2017-07-16 20:41:01 +02:00
Phenom
d8b0b5222b Fix warning: variable ‘it’ set but not used
/libretroshare/src/gxs/rsgxsnetservice.cc:867: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
     std::map<RsGxsGroupId,RsGxsServerMsgUpdate>::iterator it =
mServerMsgUpdateMap.find(grpId) ;

/libretroshare/src/gxs/rsgxsnetservice.cc:2434: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
             ClientGrpMap::iterator it =
mClientGrpUpdateMap.find(peerFrom);
2017-07-16 20:40:31 +02:00
Phenom
b11022a239 Fix warning: this statement may fall through
/libretroshare/src/util/dnsresolver.cc:49: warning: this statement may
fall through [-Wimplicit-fallthrough=]
       case DNSResolver::DNS_LOOKUP_ERROR:  if(it-
>second.last_lookup_time + MAX_TIME_BEFORE_RETRY > now)
/libretroshare/src/util/dnsresolver.cc:52: here
       case DNSResolver::DNS_DONT_HAVE:   next_call = it->first ;
2017-07-16 20:38:43 +02:00
Phenom
0e302e254e Fix warning: this statement may fall through
/libretroshare/src/util/rsnet_ss.cc:1031: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   success = inet_ntop( addr.ss_family, (const void *) &(addrv4p-
>sin_addr), ipStr, INET_ADDRSTRLEN );
/libretroshare/src/util/rsnet_ss.cc:1033: here
  case AF_INET6:
2017-07-16 20:36:16 +02:00
Phenom
7b4d3c5a24 Fix warning: this statement may fall through
/libretroshare/src/util/rscompress.cc:165: warning: this statement may
fall through [-Wimplicit-fallthrough=]
      ret = Z_DATA_ERROR;     /* and fall through */
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/util/rscompress.cc:
166: here
     case Z_DATA_ERROR:
2017-07-16 20:34:38 +02:00
Phenom
476b581506 Fix warning: this statement may fall through
/libretroshare/src/rsserver/p3serverconfig.cc:292: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->getFriendCount(true, false) > MIN_BASIC_FRIENDS)
/libretroshare/src/rsserver/p3serverconfig.cc:297: here
   case RSCONFIG_USER_LEVEL_BASIC:

/libretroshare/src/rsserver/p3serverconfig.cc:300: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->haveOnceConnected())
/libretroshare/src/rsserver/p3serverconfig.cc:306: here
   case RSCONFIG_USER_LEVEL_CASUAL:
2017-07-16 20:33:55 +02:00
Phenom
7bd7c57ff9 Fix warning: variable ‘pgpNameFound’ set but not used
/libretroshare/src/rsserver/rsaccounts.cc:130: warning: variable
‘pgpNameFound’ set but not used [-Wunused-but-set-variable]
  bool pgpNameFound = false;
2017-07-16 20:32:32 +02:00
Phenom
a0506c1a0f Fix warning: this statement may fall through
/libretroshare/src/pqi/pqissl.cc:449: warning: this statement may fall
through [-Wimplicit-fallthrough=]
    sslmode = PQISSL_ACTIVE; /* we're starting this one */
/libretroshare/src/pqi/pqissl.cc:456: here
   case WAITING_DELAY:
2017-07-16 20:31:49 +02:00
Phenom
b9d4651f07 Fix warning: this statement may fall through
/libretroshare/src/pqi/pqisslpersongrp.cc:125: warning: this statement
may fall through [-Wimplicit-fallthrough=]
     std::cerr << " --> falling back to Tor" << std::endl;
/libretroshare/src/pqi/pqisslpersongrp.cc:126: here
    case RS_HIDDEN_TYPE_TOR:
2017-07-16 20:30:41 +02:00
Phenom
e12f51b1be Fix warning: variable ‘peerIt1’ set but not used
/libretroshare/src/pqi/p3peermgr.cc:2619: warning: variable ‘peerIt1’
set but not used [-Wunused-but-set-variable]
                     std::set<RsPgpId>::iterator peerIt1 =
groupItem.peerIds.find(*peerIt);
2017-07-16 20:28:24 +02:00
Phenom
78cfde9b4f Fix warning: this statement may fall through
/libretroshare/src/pgp/pgphandler.cc:62: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE_PREV_WAS_BAD: prev_was_bad =
true ;

/libretroshare/src/pgp/pgphandler.cc:63: here
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE:
2017-07-16 20:27:46 +02:00
Phenom
3a6ad822da Fix warning: this statement may fall through
/libretroshare/src/ft/ftchunkmap.cc:190: warning: this statement may
fall through [-Wimplicit-fallthrough=]
    case FileChunksInfo::CHUNK_CHECKING: _file_is_complete = false ;

/libretroshare/src/ft/ftchunkmap.cc:191: here
    case FileChunksInfo::CHUNK_DONE:   _total_downloaded +=
sizeOfChunk(i) ;
2017-07-16 20:27:09 +02:00
Phenom
635246c462 Fix warning: this statement may fall through
/libretroshare/src/tcponudp/bss_tou.c:246: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   num=0;

/libretroshare/src/tcponudp/bss_tou.c:247: here
  case BIO_C_FILE_SEEK:
2017-07-16 20:25:11 +02:00
Phenom
59e018e02d Fix GUI AutoLogin 2017-07-16 16:03:56 +02:00
csoler
08faa3f5d5 fixed p3Gxstunnel so that it sends the data packets in the same order it received them. This fixes the bug in distant chat causing images to not transfer correctly in some cases 2017-07-15 22:16:45 +02:00
csoler
9c391cb015 added an additional param to BinToHex so as to limit the size of the output 2017-07-15 22:15:51 +02:00
csoler
98b0585ba4 Merge pull request #937 from csoler/v0.6-ImprovedNoGUI
V0.6 improved no gui
2017-07-13 21:23:13 +02:00
Gioacchino Mazzurco
69aa5b6a09 Clean some garbage from the code 2017-07-13 13:00:32 +02:00
csoler
fd452af088 removed some debut output that perturbated the passwd command line 2017-07-12 23:03:17 +02:00
csoler
00c1a9a7ff fixed autologin 2017-07-12 22:53:35 +02:00
csoler
66268c8267 fixed variable shadowing a parameter 2017-07-12 18:48:06 +02:00
csoler
4cfdef5ff9 do not display auto-login option when software is compiled without autologin 2017-07-11 23:39:04 +02:00
csoler
a5e0b1c336 fixed -U option in rs-nogui. Removed debug output that would ruin the terminal interface 2017-07-11 23:32:22 +02:00
csoler
3e3ee1a34b little improvement to command line help display 2017-07-09 22:12:01 +02:00
csoler
5dfbce7e3a fixed Terminal Api Client logic 2017-07-09 21:16:41 +02:00
csoler
7ee527ecbd removed comments 2017-07-08 17:35:34 +02:00
csoler
b5976e195e fixed message when passphrase is empty 2017-07-08 16:48:24 +02:00
Phenom
54047cd7a7 Fix multi download of same file. 2017-07-06 22:38:08 +02:00
Gioacchino Mazzurco
c630f1fa89 Fix unused warning in gxstokenqueue 2017-07-06 16:28:59 +02:00
Gioacchino Mazzurco
b935bacd99 Add missing break in p3IdService::handleResponse 2017-07-06 16:28:00 +02:00
csoler
141277b131 removed debug info 2017-07-05 22:16:14 +02:00
csoler
c1e18c7fe6 fixed bug causing an infinite subscribe/unsubscribe loop in GxsTrans 2017-07-05 22:12:56 +02:00
csoler
370d50b41a cleaned a bit the code in rsinit.cc 2017-07-05 21:36:00 +02:00
cyril soler
f413433480 removed zeroing of preferred group causing a bug in GxsTrans 2017-07-03 11:25:12 +02:00
csoler
1b4e8a46ed Merge pull request #909 from csoler/v0.6-GxsTransport
V0.6 gxs transport
2017-06-29 18:38:10 +02:00