Phenom
36e3772d59
Fix CppCheck Error in advancedsearchdialog.cpp
...
/retroshare-gui/src/gui/advsearch/advancedsearchdialog.cpp:131: error:
Cppcheck(memleak): Memory leak: wholeExpression
2017-07-21 15:19:17 +02:00
Phenom
145ce6b8b5
Fix CppCheck Error in ChatPage.cpp
...
/retroshare-gui/src/gui/settings/ChatPage.cpp:398: error:
Cppcheck(syntaxError): syntax error
2017-07-21 15:11:55 +02:00
Phenom
5b86f44ef0
Fix Show Author In People Tab at startup
...
In same, save selected Id when list updated.
2017-07-20 14:29:31 +02:00
Phenom
cbbc3920fa
Fix Lobby auto-subscribe.
...
Save GxsId for each.
Disallow to auto-subscribe to signed lobby with unsigned id.
2017-07-19 18:33:55 +02:00
csoler
0d681b149f
Merge pull request #924 from PhenomRetroShare/Fix_retroshare06_case
...
Change RetroShare06 to lower case
2017-07-19 18:26:32 +02:00
Phenom
b8f742d80c
Add :/icons/anonymous_blue_128.png before name for unsigned GxsId
...
Unsigned is added to tooltip.
Double click on name is fixed.
2017-07-18 14:30:31 +02:00
csoler
e56340e0a1
Merge pull request #386 from PhenomRetroShare/Add_AbilityToChangeOpModeInCmdLine
...
Add the ability to change OpMode in command line.
2017-07-17 23:12:06 +02:00
csoler
d39b05ccec
Merge pull request #948 from PhenomRetroShare/Add_FilterIdInFriendList
...
Add new Filter by ID in FriendList.
2017-07-17 22:49:44 +02:00
Phenom
1f39789f2e
Fix clang warning: 'RSGraphWidget::sizeHint' hides overloaded virtual
...
function
/retroshare-gui/src/gui/common/RSGraphWidget.h:173: warning:
'RSGraphWidget::sizeHint' hides overloaded virtual function [-
Woverloaded-virtual]
virtual QSizeF sizeHint( Qt::SizeHint which, const QSizeF &
constraint = QSizeF() ) const;
/usr/include/qt4/QtGui/qframe.h:76: hidden overloaded virtual function
'QFrame::sizeHint' declared here: different number of parameters (0 vs
2)
QSize sizeHint() const;
2017-07-17 22:34:32 +02:00
csoler
7d8b3796d1
Merge pull request #941 from PhenomRetroShare/Add_UnsignedInChatName
...
Add [Unsigned] before name in chat for unsigned (anonymous) GxsID.
2017-07-17 22:18:53 +02:00
Phenom
f888913800
Set Operating Mode in RsInit::InitRetroShare so noGUI could use it.
2017-07-17 15:40:14 +02:00
Phenom
8563957591
Add the ability to change OpMode in command line.
...
So you can change OpMode while running via ssh to get more bandwidth.
Usage: RetroShare06 --opmode [full|noturtle|gaming|minimal]
2017-07-17 14:36:51 +02:00
Phenom
c74c865058
Add new Filter by ID in FriendList.
2017-07-17 14:10:26 +02:00
Phenom
5bf056c7a4
Rename retroshare06 to retroshare
2017-07-17 10:45:18 +02:00
Phenom
b12fd11496
Change RetroShare06 to lower case
...
This is important to comply with linux standards.
2017-07-17 10:45:17 +02:00
Phenom
a50c4ca8d2
Fix clang warning: unused variable 'kRecognTagClass_DEVELOPMENT'
...
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:62: warning: unused
variable 'kRecognTagClass_DEVELOPMENT' [-Wunused-const-variable]
const int kRecognTagClass_DEVELOPMENT = 1;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:64: warning: unused
variable 'kRecognTagType_Dev_Ambassador' [-Wunused-const-variable]
const int kRecognTagType_Dev_Ambassador = 1;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:65: warning: unused
variable 'kRecognTagType_Dev_Contributor' [-Wunused-const-variable]
const int kRecognTagType_Dev_Contributor = 2;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:66: warning: unused
variable 'kRecognTagType_Dev_Translator' [-Wunused-const-variable]
const int kRecognTagType_Dev_Translator = 3;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:67: warning: unused
variable 'kRecognTagType_Dev_Patcher' [-Wunused-const-variable]
const int kRecognTagType_Dev_Patcher = 4;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:68: warning: unused
variable 'kRecognTagType_Dev_Developer' [-Wunused-const-variable]
const int kRecognTagType_Dev_Developer = 5;
2017-07-16 21:42:41 +02:00
Phenom
f2fb05db58
Fix clang warning: unused variables 'PARTIAL_VIEW_SIZE', ...
...
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:67:
warning: unused variable 'PARTIAL_VIEW_SIZE' [-Wunused-const-variable]
static const int PARTIAL_VIEW_SIZE = 9 ;
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:68:
warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' [-Wunused-const-
variable]
static const int MAX_TUNNEL_REQUESTS_DISPLAY = 10 ;
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:69:
warning: unused variable 'GXSTRANS_STATISTICS_DELAY_BETWEEN_GROUP_REQ'
[-Wunused-const-variable]
static const int GXSTRANS_STATISTICS_DELAY_BETWEEN_GROUP_REQ = 30 ;
// never request more than every 30 secs.
2017-07-16 21:42:23 +02:00
Phenom
6ee65bc98a
Fix clang warning: using floating point absolute value function 'fabsf'
...
when argument is of integer type
/retroshare-gui/src/gui/statistics/BWGraph.cpp:83: warning: using
floating point absolute value function 'fabsf' when argument is of
integer type [-Wabsolute-value]
if(!lst.empty() && fabsf(lst.back().first - ms) >
_update_period_msecs*1.2 )
2017-07-16 21:42:00 +02:00
Phenom
a0ac6b7ca0
Fix clang warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY'
...
/retroshare-gui/src/gui/statistics/TurtleRouterStatistics.cpp:36:
warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' [-Wunused-const-
variable]
static const int MAX_TUNNEL_REQUESTS_DISPLAY = 10 ;
/retroshare-gui/src/gui/statistics/GlobalRouterStatistics.cpp:58:
warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' [-Wunused-const-
variable]
static const int MAX_TUNNEL_REQUESTS_DISPLAY = 10 ;
2017-07-16 21:41:14 +02:00
Phenom
64899e40e8
Fix clang warning: unused variable 'SFI_DEFAULT_PERIOD'
...
/retroshare-gui/src/gui/feeds/SubFileItem.cpp:69: warning: unused
variable 'SFI_DEFAULT_PERIOD' [-Wunused-const-variable]
const uint32_t SFI_DEFAULT_PERIOD = (30 * 3600 * 24); /* 30 Days
*/
2017-07-16 21:40:29 +02:00
Phenom
b31c812d8d
Fix clang warning: unused variable 'NEWSFEED_CHANNELMSGLIST'
...
/retroshare-gui/src/gui/NewsFeed.cpp:70: warning: unused variable
'NEWSFEED_CHANNELMSGLIST' [-Wunused-const-variable]
const uint32_t NEWSFEED_CHANNELMSGLIST = 0x0005;
2017-07-16 21:40:07 +02:00
Phenom
fd24ef591e
Fix warning: comparison between signed and unsigned integer expressions
...
and misleading-indentation
/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
for(uint32_t i=0;i<mMessageVersions.size();++i)
/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: this ‘for’
clause does not guard... [-Wmisleading-indentation]
for(uint32_t i=0;i<mMessageVersions.size();++i)
2017-07-16 21:10:45 +02:00
Phenom
431b56406d
Fix warning: unused variable ‘popLimit’
...
/retroshare-gui/src/gui/gxs/GxsGroupFrameDialog.cpp:831: warning: unused
variable ‘popLimit’ [-Wunused-variable]
uint32_t popLimit = 0;
2017-07-16 21:09:58 +02:00
Phenom
2444e6e66e
Fix warning: this statement may fall through
...
/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:654: warning: this
statement may fall through [-Wimplicit-fallthrough=]
case 2: signFlags |=
GXS_SERV::FLAG_AUTHOR_AUTHENTICATION_GPG_KNOWN; // no break below, since
we want *both* flags in this case.
2017-07-16 21:09:33 +02:00
Phenom
dcb8a352df
Fix warning: unused variable ‘self’
...
and misleading-indentation
/retroshare-gui/src/gui/feeds/GxsChannelPostItem.cpp:54: warning: unused
variable ‘self’ [-Wunused-variable]
bool self = false;
/retroshare-gui/src/gui/feeds/GxsChannelPostItem.cpp:225: warning: this
‘if’ clause does not guard... [-Wmisleading-indentation]
if(!IS_GROUP_PUBLISHER(mGroup.mMeta.mSubscribeFlags))
2017-07-16 21:07:47 +02:00
Phenom
ca9357cd20
Fix warning: this ‘if’ clause does not guard...
...
/retroshare-gui/src/gui/gxschannels/CreateGxsChannelMsg.cpp:360:
warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if(assume_file_ready)
2017-07-16 21:06:54 +02:00
Phenom
b5c503a324
Fix warning: unused variable ‘prev_index’
...
/retroshare-gui/src/gui/gxschannels/GxsChannelPostsWidget.cpp:535:
warning: unused variable ‘prev_index’ [-Wunused-variable]
uint32_t prev_index = current_index ;
2017-07-16 21:06:01 +02:00
Phenom
3a22c6d302
Fix warning: comparison between signed and unsigned integer expressions
...
/retroshare-gui/src/gui/gxsforums/GxsForumsFillThread.cpp:286: warning:
comparison between signed and unsigned integer expressions [-Wsign-
compare]
for(uint32_t i=1;i<(*it).size();++i)
2017-07-16 20:57:19 +02:00
Phenom
6fd03087d2
Fix warning: this statement may fall through
...
/retroshare-gui/src/gui/statistics/BWGraph.cpp:245: warning: this
statement may fall through [-Wimplicit-fallthrough=]
case GRAPH_TYPE_ALL: std::cerr << "(WW) Impossible situation. Cannot
draw graph in mode All/All. Reverting to sum." << std::endl;
2017-07-16 20:56:46 +02:00
Phenom
f27ce82e22
Fix warning: comparison between signed and unsigned integer expressions
...
, misleading-indentation and unused-variable
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: comparison between signed and unsigned integer expressions [-
Wsign-compare]
for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:203:
warning: unused variable ‘now’ [-Wunused-variable]
time_t now = time(NULL) ;
2017-07-16 20:56:18 +02:00
Phenom
15bc9c1c3c
Fix warning: this statement may fall through
...
/retroshare-gui/src/gui/GetStartedDialog.cpp:122: warning: this
statement may fall through [-Wimplicit-fallthrough=]
ui.firewallCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:124: here
case RSCONFIG_USER_LEVEL_CASUAL:
/retroshare-gui/src/gui/GetStartedDialog.cpp:125: warning: this
statement may fall through [-Wimplicit-fallthrough=]
ui.connectCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:127: here
case RSCONFIG_USER_LEVEL_BASIC:
2017-07-16 20:54:41 +02:00
Phenom
f23c84fd4e
Fix warning: this statement may fall through
...
/retroshare-gui/src/gui/RetroShareLink.cpp:585: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if(!checkSSLId(_SSLid))
/retroshare-gui/src/gui/RetroShareLink.cpp:587: here
case TYPE_FILE:
2017-07-16 20:54:05 +02:00
csoler
987c10522a
Merge pull request #945 from PhenomRetroShare/Add_RSLinkCreateAsStatic
...
Change RetroShareLink creation methodes as static
2017-07-16 20:16:31 +02:00
csoler
e40dbe82a4
Merge pull request #947 from csoler/v0.6-ImprovedGUI
...
fixed filtering for channels when loading items on the fly
2017-07-16 17:03:37 +02:00
csoler
1e98de76a1
fixed filtering for channels when loading items on the fly
2017-07-16 16:56:23 +02:00
Phenom
82addce867
Change RetroShareLink creation methodes as static
...
And remove this warning:
2017-07-16 13:12:07 +02:00
csoler
6a8b74c965
fixed compilation for computers where qreal is a float
2017-07-15 22:01:18 +02:00
Phenom
a16ff426ae
Add [Unsigned] before name in chat for unsigned (anonymous) GxsID.
2017-07-14 19:16:39 +02:00
csoler
3912118a86
Merge pull request #925 from PhenomRetroShare/Fix_ChannelCommentLineWrap
...
Fix channel comments line wrap
2017-07-13 21:42:05 +02:00
Phenom
54047cd7a7
Fix multi download of same file.
2017-07-06 22:38:08 +02:00
Phenom
dad6abdba3
Fix channel comments line wrap
2017-07-06 12:19:26 +02:00
csoler
8e62a8b1b2
updated tooltip for opinion in People
2017-07-05 22:32:54 +02:00
csoler
5f7df7cb73
update call to notifySettingsChanged() when changing the thread loading of channels
2017-07-04 23:26:57 +02:00
csoler
2aac675f11
merged upstream/master into v0.6-ImprovedGUI
2017-07-04 23:15:09 +02:00
csoler
931ddaef79
set load thread to false for channels on default. Fixed missing () in connect
2017-07-04 23:13:03 +02:00
Gioacchino Mazzurco
a97ba803d8
Fix missing include
...
The missing include was causing compilation error
since d876bb721b
2017-07-04 16:41:14 +02:00
csoler
ee257223d3
Merge pull request #915 from PhenomRetroShare/Add_AlwaysAllowFriendTimeOffsetFeed
...
Always allow Friend Time Offset Feed item.
2017-07-04 10:24:05 +02:00
csoler
d7f0141b3b
Merge pull request #916 from PhenomRetroShare/Add_WarningToDirectDonwloadCheckBox
...
Add a warning to Direct download checkbox depends general setting.
2017-07-04 10:23:30 +02:00
csoler
d876bb721b
fixing async loading of channels. To be tested.
2017-07-03 23:21:31 +02:00
csoler
1dea00d2cb
attempt to fix channel post auto-size by limiting the number of lines from message to display in summary depending on available size
2017-07-03 23:09:17 +02:00