- suppressed an unwanted return in packet treatment
- prevented sending info to a peer about itself
- changed askInfoToAllPeers() such as not to discard info from peers with
NODISC flag (because we especially need info for these)
- enabled receiving p3disc info even if p3discovery is disabled. Indeed,
disabeling p3disc is a measure of protection, so it should limit the
export of p3disc info, not the import.
- removed test discarding info about dummy friends, because it is useless
- don't discard info about peers that have the NODISC flag (meaning that we
especially need info for them)
- added safety check about received GPG keys. Before we relied on this test
being performed by p3ConnMgr::addFriend()
- added some debug info
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.5.0@3102 b45a01b8-16f6-495d-af2f-9b41ad6348cc
This avoids that an attacker that captures a broadcast hash request can also ask for the file.
This needed to add back explicit sources in SearchDialog and private chat transfer. I dynamically search
for sources in file lists just before calling FileRequest.
When RS links anchorClick() will work properly with Qt, we can remove the search flag "EXTRA" from the
tunnel digging in p3turtle.cc, otherwise, people having this bug can't transfer files in private chat by
copy+paste of a RS link.
Also:
- added missing mutexes in search requests into fimonitor.cc
- suppressed some debug info in connect manager
- added check for write fails when dumping config files
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.5.0@3026 b45a01b8-16f6-495d-af2f-9b41ad6348cc
- added a test against the IP 1.0.0.0, which pops up on MacOS (when the peer is not connected to the internet?)
- put some additional debug messages.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.5.0@3017 b45a01b8-16f6-495d-af2f-9b41ad6348cc
Memory leak:
- getLocalInterfaces -> iptable = (MIB_IPADDRTABLE *) malloc(dwSize);
- main -> RshareSettings *_settings = new RshareSettings();
ExtAddrFinder::~ExtAddrFinder - use free for pointer allocated with malloc
Ported trunk commit 2810 (Thunder):
RetroShare stopped responding during signing a key and asking for password.
The QSingleShotTimer of ConfCertDialog wants to update the gui and
stopped in PeerItem::updateItem.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.5.0@2883 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2781:
- fix a gui bug
2786:
- The settings in the settings window are only loaded once.
- Saving the settings without changing the network settings doesn't
shutdown the connections
6788:
- Forwarding a message keep the attached recommended files.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.5.0@2803 b45a01b8-16f6-495d-af2f-9b41ad6348cc
Currently the only way to induce a bug is start rs for an ssl_id which
which does not have a password saved, then try use an ssl id at start
dialog which does or does not have a pword (help_pword:bool enters an
illegal state)
I have fixed it by checking if rsinit::passwd == "" then trying to load for
that ssl_id, if that fails then i set help_pword to false; does not have
password and pass flow to gpg to ask for passwd. (problem was rs thought
user had help/pass file and they didn't).
i have checked it in and tested for
1. starting with ssl_id which has saved pword, and switching ids at start
dialog
2. secondary id may or may not have saved pword.
- added check for the result of fscanf
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.5.0@2802 b45a01b8-16f6-495d-af2f-9b41ad6348cc
- Bug fix: Checkbox for automatic share of the incoming directory doesn't correctly set with setDown, use setChecked
- ShareManager and RSettingsWin doesn't need to be created all the time
- RSettingsWin: Save the last active page for the current runtime
- ShareManager and DirectoryPage: Show changed shared directories direct after the change
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.5.0@2776 b45a01b8-16f6-495d-af2f-9b41ad6348cc
