Commit Graph

166 Commits

Author SHA1 Message Date
Phenom
e718070dbd Fix warning: this statement may fall through
/libbitdht/src/bitdht/bdconnection.cc:1288: warning: this statement may
fall through [-Wimplicit-fallthrough=]
      if (errsrc == BITDHT_CONNECT_ERROR_SOURCE_END)
/libbitdht/src/bitdht/bdconnection.cc:1308: here
     case BITDHT_CONNECT_ERROR_DUPLICATE: // similar attempt. delay/
recycle (ANY/ANY)
2017-07-16 20:23:39 +02:00
Phenom
ff1908eda6 Fix Clang Static Analyser: Undefined allocation of 0 bytes
Unix API: Undefined allocation of 0 bytes (CERT MEM04-C; CWE-131): Call
to 'malloc' has an allocation size of 0 bytes
 1: Loop body executed 0 times in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:223
 2: Calling 'bloomFilter::getFilter' in /home/phenom/GIT/RetroShare/
trunk/libbitdht/src/util/bdbloom.cc:240
 3: 'bytes' initialized to 0 in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:141
 4: Call to 'malloc' has an allocation size of 0 bytes in /home/phenom/
GIT/RetroShare/trunk/libbitdht/src/util/bdbloom.cc:148
2017-04-25 09:47:10 +02:00
Phenom
7d9a80326d Fix Clang warnings: bdnet_inet_ntoa C-linkage
/libbitdht/src/util/bdnet.h:107: warning: 'bdnet_inet_ntoa' has C-
linkage specified, but returns user-defined type 'std::string' (aka
'basic_string<char>') which is incompatible with C [-Wreturn-type-c-
linkage]
std::string bdnet_inet_ntoa(struct in_addr in);
            ^
2017-04-18 11:18:10 +02:00
Phenom
da4b168a04 Fix Clang warnings: mFns is not used
warning: private field 'mFns' is not used [-Wunused-private-field]
        bdDhtFunctions *mFns;
                        ^
2017-04-17 21:09:40 +02:00
dimqua
90abd2fff1 bdboot update 2016-11-29 19:05:02 +03:00
Gio
5274b8aa97 Solve some compiler warnings:
usage of memory after free (false positive)
unused variable (stacked mutex)
malloc parameter type mismatch
2016-08-26 13:10:09 +02:00
csoler
bf28ea7ac7 removed debug info in udpstack.cc 2016-07-03 18:49:02 -04:00
sehraf
3bb03ff89d Added new (optional) callback to libbitdht to ask upper layer if an IP is banned.
In case this callback is implemented it will be used in favour of the built-in ban list.
2016-06-20 22:30:51 +02:00
sehraf
4a07e3cb30 remove compiler warnings libbitdht 2016-06-01 21:20:50 +02:00
Julian Ospald
ed867c52bd
Don't hardcode g++ in the toolchain settings
Although it's already quite ugly that we overwrite QMAKE_CC like this,
hardcoding 'g++' can break the build where prefixed versions of
the toolchain are expected and where QMAKE_CXX is already properly
defined. So we just use QMAKE_CXX variable here.

This fixes build failures on some distributions, e.g.
https://galileo.mailstation.de/jenkins/job/lipidity/36/console
2016-05-27 18:07:28 +02:00
csoler
fa8a585e20 removed some debug info 2016-04-15 18:25:53 -04:00
Cyril Soler
d878334551 Merge pull request #206 from realityfabric/master
Added top level license file for GPL 2.0
2016-02-16 17:45:49 -05:00
Phenom
7d21666098 Fix compilation of bencode.c for C compilator.
Remove C++ in this C file.
2016-02-14 17:40:10 +01:00
csoler
9c6e7dfc13 added checks after mallocs in several files 2016-01-11 23:49:00 -05:00
electron128
22c00fc638 fixed free() in UdpLayer::recv_loop 2016-01-01 14:07:15 +01:00
Jessie RealityFabric
d0a01166a4 Create LICENSE.md 2015-12-16 02:09:35 -08:00
realityfabric
e003f561e3 Made it so that sys/select.h is only included if the operating system is not Windows 2015-12-13 08:27:32 -08:00
Sergei Reznikov
34758be52a Add Haiku support 2015-10-20 20:32:44 +03:00
csoler
7293cd3afa updated ubuntu changelog 2015-09-21 22:58:58 -04:00
AsamK
571336e1f4 Move duplicate common stuff out of platform parts 2015-09-06 22:27:22 +02:00
AsamK
66b9557833 Use PKGCONFIG instead of manually specifying LIBS for Linux
- The advantage is that this method automatically includes additional
  dependencies of LIBS (e.g. libupnp needs -lixml).
- Also if some distribution moves headers to non default locations the
  correct locations get added by PKGCONFIG
2015-09-06 22:27:22 +02:00
AsamK
b66f466c7a Move all INSTALLS to the subproject they belong to
Allows installation of for example only retroshare-nogui, without
installing files only relevant for gui

$ qmake
$ make retroshare-nogui
$ make retroshare-nogui-install_subtargets
2015-08-31 22:49:46 +02:00
AsamK
e135e3441c Create retroshare.pri for common configurations in .pro files
So far it only contains the default values for installation paths
2015-08-31 21:09:28 +02:00
thunder2
5aa8de3e62 Fixed uninitialized members of bdProxyId and bdConnectionRequest.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8515 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-18 10:19:36 +00:00
thunder2
825e723a32 Fixed uninitialised member in bdNodeManager
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8447 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-14 18:43:40 +00:00
csoler
5116042cf0 fixed uninitialised memory in bdfilter
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8444 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-14 15:32:49 +00:00
csoler
1541a2a0ad added missing FilterFlags causing uninitialised memory read
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8374 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-04 20:25:13 +00:00
csoler
047977b645 Started implementation of ban list. For now, just gathers the list of banned IPs from
the DHT and is not used to reject IPs yet (the DHT list is, even if DHT is desactivated).
Next steps: GUI with switch controls, exchange of IP ban lists between friends, handling IP ranges.


git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8297 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-05-26 21:17:09 +00:00
csoler
5b2ba1e81c - added more debug info to p3LinkMgr
- added check for banned IP from DHT at connection time
- added regular removal of banned IPs from friend IP lists
- increased time of banned IP storage to 1 week (previously 6 hours)
- added save for banned IPs to keep them after restart (in bdfilter.cc) to file bdfilter.txt (can be manually updated)
- changed mFiltered into a std::map for increased search efficiency
- added secondary check of cert ID at connection time.-This line, and those below, will be ignored--

M    libretroshare/src/pqi/p3netmgr.cc
M    libretroshare/src/pqi/pqimonitor.h
M    libretroshare/src/pqi/p3peermgr.cc
M    libretroshare/src/pqi/p3linkmgr.h
M    libretroshare/src/pqi/pqissllistener.cc
M    libretroshare/src/pqi/p3peermgr.h
M    libretroshare/src/pqi/p3linkmgr.cc
M    libretroshare/src/pqi/pqiperson.cc
M    libretroshare/src/pqi/pqissl.cc
M    libretroshare/src/rsserver/rsinit.cc
M    libretroshare/src/dht/p3bitdht_relay.cc
M    libretroshare/src/dht/p3bitdht.cc
M    libretroshare/src/dht/p3bitdht.h
M    libretroshare/src/retroshare/rsdht.h
M    libbitdht/src/udp/udpbitdht.h
M    libbitdht/src/udp/udpbitdht.cc
M    libbitdht/src/bitdht/bdmanager.cc
M    libbitdht/src/bitdht/bdmanager.h
M    libbitdht/src/bitdht/bdnode.h
M    libbitdht/src/bitdht/bdfilter.h
M    libbitdht/src/bitdht/bdfilter.cc
M    libbitdht/src/bitdht/bdnode.cc
M    libbitdht/src/bitdht/bdstore.h


git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8289 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-05-25 14:02:45 +00:00
csoler
77a33cd445 removed unnecessary debug output
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8153 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-04-21 20:09:20 +00:00
electron128
d65adeb2ea disabled debug print of DHT requests, disabled debug print in p3Peers::getProxyServer(), added missing newlines in debug prints (modified patch from Hypfer)
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8084 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-03-27 18:41:44 +00:00
thunder2
7b43f53a5e Removed debug info fom bdnet (Patch from electron)
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8002 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-03-08 16:47:24 +00:00
csoler
b7ab9c7e27 debug info removal
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7880 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-01-26 20:08:51 +00:00
thunder2
7f58460e5f Added DEPENDPATH to pro files
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7842 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-01-12 23:14:35 +00:00
defnax
c731525b23 update the windows build bat`s
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7700 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-11-22 13:32:26 +00:00
csoler
47263daa72 fixed saving of bdboot.txt on windows (patch from electron)
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7657 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-11-02 12:47:50 +00:00
drbob
ceb6716ace Add peer version to Ping Message. (improves finding RS peers)
Add local flag to search query - to only find bitdht peers.



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7620 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-10-18 00:40:14 +00:00
defnax
76ecaffccb updated the MinGW build bat files
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7168 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-03-05 22:46:37 +00:00
csoler
158249d66e removed some debug output
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7047 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-01-20 21:13:17 +00:00
thunder2
31fd6f6261 Code maintenance for Qt 5:
- Fixed compile with MinGW-w64 under Windows


git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6866 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-10-21 21:42:15 +00:00
thunder2
ec08eba2c9 Code maintenance for Qt 5:
- Added some more includes needed by MinGW-w64

git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6861 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-10-21 11:11:27 +00:00
thunder2
13e7ac8b43 Fixed compile of the libraries with MinGW 4.8 on Windows.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6814 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-10-07 23:11:10 +00:00
drbob
af229eb9a7 Bugfix to not count QUERYHASH in processed.
Might improve dht responsiveness.



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6685 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-09-04 05:43:12 +00:00
drbob
3544bc30b2 Added Incoming Query History, for future filtering of aggressive peers.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6681 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-09-03 11:09:30 +00:00
drbob
0608f67d71 Expanded DHT history analysis, and ran some more tests on DHT behaviour.
- Tweaked query parameters (quicker discard, longer requery period).

The analysis suggests that in general the DHT is running okay with some minor issues.
 - BitDHT peers respond to ~50% of FIND_NODE queries. This means we drop them, 
   and so  some ONLINE friends, become UNREACHABLE friends.

This appears to be caused by too many FIND_NODE queries reaching BitDHT, and the 
peer starts dropping them. This appears to come from specific peers, which 
are not RS nodes. Proposed solution is to Track and Filter Over-Querying Peers.
(Only one query per peer every 30 seconds).

 - Should be more lenient on the exact query matches.
Allow some dropped messages.

 - Queries appear to run longer than necessary.
A better query completion criteria needs to be established.

 


git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6614 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-08-26 04:29:27 +00:00
csoler
1554e17f48 patch from Stefan Sperling to allow compilation on OpenBSD
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6613 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-08-25 21:06:29 +00:00
drbob
5803a5ab65 Fixed up bootstrap singleshot search function. Now returns parameters.
Not functioning 100% correctly yet - due to libbitdht behaviour (TO FIX)



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6005 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2012-12-17 20:19:27 +00:00
drbob
069b72e0b2 Merged branch v0.5-gxs-b1 into trunk (from -r 5351 -> 5995)
This brings a huge amount of goodness into the trunk,
but there is still a big chunk todo before it can be released.

 * GXS Backend.
 * GXS Services:
	- Identities.
	- Circles
	- Photos
	- Wiki
	- GxsForums
	- Posted.
 * SSH no-gui server.

See branch commits for more info.

To switch on GXS stuff, enable CONFIG += gxs
in both libretroshare.pro and retroshare-gui.pro



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@5996 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2012-12-16 19:17:11 +00:00
drbob
fd992ac813 * add ToolTip to OpModeStatus .... (can't actually view - please correct as necessary)
* disable bitdht printStatus



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@5957 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2012-12-09 22:27:34 +00:00
drbob
62176264d3 added single function to call dht, with thread cleanup.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.5-gxs-b1@5954 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2012-12-09 13:19:28 +00:00