/libbitdht/src/bitdht/bdconnection.cc:1288: warning: this statement may
fall through [-Wimplicit-fallthrough=]
if (errsrc == BITDHT_CONNECT_ERROR_SOURCE_END)
/libbitdht/src/bitdht/bdconnection.cc:1308: here
case BITDHT_CONNECT_ERROR_DUPLICATE: // similar attempt. delay/
recycle (ANY/ANY)
Unix API: Undefined allocation of 0 bytes (CERT MEM04-C; CWE-131): Call
to 'malloc' has an allocation size of 0 bytes
1: Loop body executed 0 times in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:223
2: Calling 'bloomFilter::getFilter' in /home/phenom/GIT/RetroShare/
trunk/libbitdht/src/util/bdbloom.cc:240
3: 'bytes' initialized to 0 in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:141
4: Call to 'malloc' has an allocation size of 0 bytes in /home/phenom/
GIT/RetroShare/trunk/libbitdht/src/util/bdbloom.cc:148
/libbitdht/src/util/bdnet.h:107: warning: 'bdnet_inet_ntoa' has C-
linkage specified, but returns user-defined type 'std::string' (aka
'basic_string<char>') which is incompatible with C [-Wreturn-type-c-
linkage]
std::string bdnet_inet_ntoa(struct in_addr in);
^
Although it's already quite ugly that we overwrite QMAKE_CC like this,
hardcoding 'g++' can break the build where prefixed versions of
the toolchain are expected and where QMAKE_CXX is already properly
defined. So we just use QMAKE_CXX variable here.
This fixes build failures on some distributions, e.g.
https://galileo.mailstation.de/jenkins/job/lipidity/36/console
- The advantage is that this method automatically includes additional
dependencies of LIBS (e.g. libupnp needs -lixml).
- Also if some distribution moves headers to non default locations the
correct locations get added by PKGCONFIG
Allows installation of for example only retroshare-nogui, without
installing files only relevant for gui
$ qmake
$ make retroshare-nogui
$ make retroshare-nogui-install_subtargets
the DHT and is not used to reject IPs yet (the DHT list is, even if DHT is desactivated).
Next steps: GUI with switch controls, exchange of IP ban lists between friends, handling IP ranges.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8297 b45a01b8-16f6-495d-af2f-9b41ad6348cc
- added check for banned IP from DHT at connection time
- added regular removal of banned IPs from friend IP lists
- increased time of banned IP storage to 1 week (previously 6 hours)
- added save for banned IPs to keep them after restart (in bdfilter.cc) to file bdfilter.txt (can be manually updated)
- changed mFiltered into a std::map for increased search efficiency
- added secondary check of cert ID at connection time.-This line, and those below, will be ignored--
M libretroshare/src/pqi/p3netmgr.cc
M libretroshare/src/pqi/pqimonitor.h
M libretroshare/src/pqi/p3peermgr.cc
M libretroshare/src/pqi/p3linkmgr.h
M libretroshare/src/pqi/pqissllistener.cc
M libretroshare/src/pqi/p3peermgr.h
M libretroshare/src/pqi/p3linkmgr.cc
M libretroshare/src/pqi/pqiperson.cc
M libretroshare/src/pqi/pqissl.cc
M libretroshare/src/rsserver/rsinit.cc
M libretroshare/src/dht/p3bitdht_relay.cc
M libretroshare/src/dht/p3bitdht.cc
M libretroshare/src/dht/p3bitdht.h
M libretroshare/src/retroshare/rsdht.h
M libbitdht/src/udp/udpbitdht.h
M libbitdht/src/udp/udpbitdht.cc
M libbitdht/src/bitdht/bdmanager.cc
M libbitdht/src/bitdht/bdmanager.h
M libbitdht/src/bitdht/bdnode.h
M libbitdht/src/bitdht/bdfilter.h
M libbitdht/src/bitdht/bdfilter.cc
M libbitdht/src/bitdht/bdnode.cc
M libbitdht/src/bitdht/bdstore.h
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8289 b45a01b8-16f6-495d-af2f-9b41ad6348cc
- Tweaked query parameters (quicker discard, longer requery period).
The analysis suggests that in general the DHT is running okay with some minor issues.
- BitDHT peers respond to ~50% of FIND_NODE queries. This means we drop them,
and so some ONLINE friends, become UNREACHABLE friends.
This appears to be caused by too many FIND_NODE queries reaching BitDHT, and the
peer starts dropping them. This appears to come from specific peers, which
are not RS nodes. Proposed solution is to Track and Filter Over-Querying Peers.
(Only one query per peer every 30 seconds).
- Should be more lenient on the exact query matches.
Allow some dropped messages.
- Queries appear to run longer than necessary.
A better query completion criteria needs to be established.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6614 b45a01b8-16f6-495d-af2f-9b41ad6348cc
This brings a huge amount of goodness into the trunk,
but there is still a big chunk todo before it can be released.
* GXS Backend.
* GXS Services:
- Identities.
- Circles
- Photos
- Wiki
- GxsForums
- Posted.
* SSH no-gui server.
See branch commits for more info.
To switch on GXS stuff, enable CONFIG += gxs
in both libretroshare.pro and retroshare-gui.pro
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@5996 b45a01b8-16f6-495d-af2f-9b41ad6348cc