Unix API: Undefined allocation of 0 bytes (CERT MEM04-C; CWE-131): Call
to 'malloc' has an allocation size of 0 bytes
1: Loop body executed 0 times in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:223
2: Calling 'bloomFilter::getFilter' in /home/phenom/GIT/RetroShare/
trunk/libbitdht/src/util/bdbloom.cc:240
3: 'bytes' initialized to 0 in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:141
4: Call to 'malloc' has an allocation size of 0 bytes in /home/phenom/
GIT/RetroShare/trunk/libbitdht/src/util/bdbloom.cc:148
/libbitdht/src/util/bdnet.h:107: warning: 'bdnet_inet_ntoa' has C-
linkage specified, but returns user-defined type 'std::string' (aka
'basic_string<char>') which is incompatible with C [-Wreturn-type-c-
linkage]
std::string bdnet_inet_ntoa(struct in_addr in);
^
- changed <malloc.h> => <stdlib.h>
- put #ifdef __cplusplus protection in bdstring.h so it can be used by C modules.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@5231 b45a01b8-16f6-495d-af2f-9b41ad6348cc
Added -Wextra to the Windows compile.
Added new define in libbitdht for snprintf and fprintf to proper handling of "%ll" under Windows.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@4951 b45a01b8-16f6-495d-af2f-9b41ad6348cc
Added Knowledge of Friends, Friends of Friends and Relays.
- Added bdfriendlist class to store information.
- New interface function updateKnownPeer().
- includes IP addresses, if known. (for filtering)
Bad Peer Filtering.
- Check IDs against known peer IP addresses.
- Added checks in checkPotentialPeer().
- Added checks in addPeer().
- Running in TestMode at the moment (Bad Peers are only flagged).
Other Fixes:
- Removed some warning about int/uint comparisons.
- added bdSpace::flagpeer() fn to support above.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.5-dhtmods@4680 b45a01b8-16f6-495d-af2f-9b41ad6348cc
* Compilation for FreeBSD.
* Notes that MT is not cryptographically secure.
* modified sorting of DHT Window.
Only one change that I didn't commit:
bitdht {
- LIBS += ../../libbitdht/src/lib/libbitdht.a
- PRE_TARGETDEPS *= ../../libbitdht/src/lib/libbitdht.a
+ LIBS += ../../libbitdht/src/libbitdht.a
+ PRE_TARGETDEPS *= ../../libbitdht/src/libbitdht.a
}
As this would have broken compilation on the other platforms.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@4619 b45a01b8-16f6-495d-af2f-9b41ad6348cc
Bugfixes and a couple of small improvements to the DHT code.
* fixed up buggy overloading for the udplayer (for testing).
* added processing multiple (5) remote processes per tick.
- (1 wasn't enough in testing, and led to dropped peers)
* removed unused variables from query data structure.
* #defined out debugging in bdSpace, removed old functions.
* More agressive attempts to find proxies for connections.
* made "final query attempt" use exact peer address rather than midid.
- mid id meant that the target wasn't always returned.
* tweaked bdconnection debugging.
* increase CONNECTION_MAX_TIMEOUT from 30 => 45. wasn't enough!
* Limited bdQuery::QueryIdlePeriod to 15min (was unlimited).
* added bdQuery::PotentialPeer cleanup functions - for more robust reporting.
* fixed bdQuery debugging printouts.
* Implemented BITDHT_QFLAGS_UPDATES flag.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@4398 b45a01b8-16f6-495d-af2f-9b41ad6348cc
There are many significant improvements to the DHT here.
See commit logs on v0.5-peernet branch for details.
This is not the final merge, but brings over the majority of expected v0.5-peernet/libbitdht changes
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@4354 b45a01b8-16f6-495d-af2f-9b41ad6348cc
RetroShare crashes on start, when the initial address on port 7812 is in use.
The thread in UdpLayer::openSocket was not started and the member mTid was uninitialized.
Then a call to join in UdpLayer::reset during the load of the configuration crashes.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@3337 b45a01b8-16f6-495d-af2f-9b41ad6348cc
* brought over tou_net / tou_error => bdnet for windoze compatibility.
* updated udplayer to inline with rs changes + win compatibility.
* removed unix only networking #includes, replaced with "util/bdnet.h"
* added subdirectory to #includes.
* made udpbitdht_nettest use a random node id.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@3302 b45a01b8-16f6-495d-af2f-9b41ad6348cc
============================================================
This is intended to be a completely independent library from RS,
(hosted at sf.net/projects/bitdht) hence is being commited at the top level.
As initial further development / testing will be driven by RS integration
it is being added to the RS repository. Equally important is ensuring
that RS can compile without requiring aux libraries.
Once libbitdht is further developed, this section of the repository
is expected to be removed... But that will not be for a while, I expect.
drbob.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@3276 b45a01b8-16f6-495d-af2f-9b41ad6348cc
