Commit Graph

4414 Commits

Author SHA1 Message Date
csoler
08867945f3 fixed bug caused by wrong cast in lobby msg signature validation 2017-04-24 10:29:57 +02:00
csoler
91b04098b6 fixed two memory bugs in serialization code 2017-04-24 10:11:24 +02:00
csoler
31c07f4dfd converted RsMsgItems to new serialization. Added format and flag members to RsSerialiser and used the later to handle signature and config serialization techniques 2017-04-23 22:40:26 +02:00
csoler
63b4b3a1f7 moved discovery2 items to rsitems/ 2017-04-23 19:07:26 +02:00
csoler
9d9ff567bb switched discovery2items to new serialization 2017-04-23 19:02:12 +02:00
csoler
2e7127077d fixed previous file move 2017-04-22 21:36:39 +02:00
csoler
bef6db4b43 moved files 2017-04-22 21:32:57 +02:00
csoler
311f257090 converted GxsReputationItems to new serialization 2017-04-22 21:10:55 +02:00
csoler
782c02744f added names for turtle sub items 2017-04-22 16:00:01 +02:00
electron128
8b9c447063 fixed possible crash and return value in rsGetHostByName(), thanks to Kotyara for reporting this 2017-04-22 10:13:23 +02:00
csoler
5f8bf03dfe added mechanism to allow services to document the names of their items, and improved bandwidth graph to show names for GXS services. Other services still need to supply their own names 2017-04-20 20:54:51 +02:00
csoler
e2d9152b22 moved converted serialisation files into new directory rsitems/, leaving serialiser/ for the serialisation classes 2017-04-18 21:11:37 +02:00
Phenom
37331372c1 Fix Clang warnings: implicit conversion
warning: implicit conversion from 'int' to 'char' changes value from 255
to -1 [-Wconstant-conversion]
                                asctobin()[i] = 255;    /* used to
detect invalid characters */
2017-04-18 11:25:41 +02:00
Phenom
32eeb957b2 Fix Clang warnings: unused private field
warning: private field 'mAutoBanIdentitiesLimit' is not used [-Wunused-
private-field]
    float mAutoBanIdentitiesLimit ;
warning: private field 'mFiles' is not used [-Wunused-private-field]
    RsFiles* mFiles;
2017-04-17 21:35:29 +02:00
Phenom
4ac3b3f5bf Fix Clang warnings: implicit conversion of NULL to bool
warning: implicit conversion of NULL constant to 'bool' [-Wnull-
conversion]
        return NULL ;
        ~~~~~~ ^~~~
               false
2017-04-17 21:33:39 +02:00
Phenom
e83104ee0f Fix Clang warnings: Add author and date to #warning 2017-04-17 21:32:14 +02:00
Phenom
039908b2c6 Fix Clang warnings: private field not used
warning: private field 'mNetMgr' is not used [-Wunused-private-field]
    p3NetMgr *mNetMgr;
2017-04-17 21:29:16 +02:00
Phenom
872f42bcef Fix Clang warnings: Overloaded vf hide in pluginmanager
warning: 'RsPluginManager::loadConfiguration' hides overloaded virtual
function [-Woverloaded-virtual]
                virtual void loadConfiguration() ;
2017-04-17 21:28:24 +02:00
Phenom
22043094b5 Fix Clang warnings: extraneous parentheses
warning: equality comparison with extraneous parentheses [-Wparentheses-
equality]
                else if ((err == ECONNREFUSED))
                          ~~~~^~~~~~~~~~~~~~~
2017-04-17 21:26:50 +02:00
Phenom
dc533b1346 Fix Clang warnings: private field not used
warning: private field 'lastGroupId' is not used [-Wunused-private-
field]
    uint32_t lastGroupId;
warning: private field 'waittimes' is not used [-Wunused-private-field]
        int waittimes;
warning: private field 'listen_checktime' is not used [-Wunused-private-
field]
        long listen_checktime;
2017-04-17 21:26:09 +02:00
Phenom
65321501e4 Fix Clang warnings: Overloaded vf hide in p3dhtmgr
warning: 'p3DhtMgr::findPeer' hides overloaded virtual function [-
Woverloaded-virtual]
virtual bool    findPeer(std::string id);
warning: 'p3DhtMgr::dropPeer' hides overloaded virtual function [-
Woverloaded-virtual]
virtual bool    dropPeer(std::string id);
warning: 'p3DhtMgr::getPeerStatus' hides overloaded virtual function [-
Woverloaded-virtual]
virtual bool    getPeerStatus(std::string id,
2017-04-17 21:24:45 +02:00
Phenom
5bc6558567 Fix Clang warnings: explicitly assigning value to itself
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/util/radix64.h:96:
warning: explicitly assigning value of variable of type 'int' to itself
[-Wself-assign]
                        idx = idx;
                        ~~~ ^ ~~~
2017-04-17 21:19:06 +02:00
Phenom
6fecac5f7b Fix Clang warnings: Overloaded vf hide
warning: 'pqiconnect::connect_parameter' hides overloaded virtual
function [-Woverloaded-virtual]
        virtual bool connect_parameter(uint32_t type, std::string value)
{ return ni->connect_parameter(type, value);}
                     ^
2017-04-17 21:15:52 +02:00
Phenom
cf963c0c73 Fix Clang warnings: struct declared as class
warning: 'RsMsgMetaData' defined as a struct here but previously
declared as a class [-Wmismatched-tags]
struct RsMsgMetaData
^
2017-04-17 21:15:15 +02:00
Phenom
105840ab98 Fix Clang Warning: Overloaded vf hide
warning: 'pqiConnectCbDummy::peerConnectRequest' hides overloaded
virtual function [-Woverloaded-virtual]
virtual void    peerConnectRequest(const RsPeerId& id,
                ^
2017-04-17 21:10:22 +02:00
csoler
f8fc8b40e4 removed old code in turtle serialiser 2017-04-16 20:16:59 +02:00
csoler
2ca46ec636 fixed bug in serialization of data chunks 2017-04-16 20:11:54 +02:00
csoler
121133488c fixed bug in serialization for turtle 2017-04-16 19:59:22 +02:00
csoler
636450f14d moved turtle and FT to new serialization 2017-04-15 18:46:44 +02:00
csoler
3453a3e57d switched FileTransfer items to new serialization 2017-04-11 23:05:27 +02:00
csoler
80e8769ed7 added missign file and converted BW control items 2017-04-11 21:37:35 +02:00
csoler
731e20d0a3 switch BanListItem classes to new serialization system 2017-04-10 22:09:56 +02:00
csoler
691ed8de08 added new template for std::string with type id 2017-04-10 20:34:02 +02:00
csoler
3130ec9041 added GUI async call to ID serialised data. Allows to copy+paste identities. 2017-04-10 20:02:14 +02:00
csoler
d66e653204 fixed bug in deserialisation of group informaiton 2017-04-08 23:39:05 +02:00
csoler
4f5da86aca added method to serialise/deserialise groups to/from memory and export of GxsIdentities to memory chunk in radix format 2017-04-08 19:07:33 +02:00
csoler
8b773885fd removed all chat serialization code 2017-04-05 21:02:17 +02:00
csoler
ae9d0b2ab4 fixed a few bugs in chat serialization 2017-04-05 20:49:32 +02:00
csoler
03c31ceacc fixed serialization test example 2017-04-05 18:27:29 +02:00
csoler
6b4fdb42ae fixed bug in serialization 2017-04-05 18:25:54 +02:00
csoler
a941136c04 fixed a few bugs in new serialization 2017-04-05 18:09:45 +02:00
csoler
5b3e488b42 fixed compilation 2017-04-05 16:53:20 +02:00
csoler
48688eae3f progress in converting chat items to new serialization 2017-04-05 10:27:12 +02:00
csoler
9438d60609 progress in converting Chat items to new serialization model 2017-04-04 22:53:50 +02:00
csoler
f2fa70e395 progress in converting Chat items to new serialization model 2017-04-04 16:37:57 +02:00
csoler
32ce9aea3a started converting rschatitems to new serialization 2017-04-04 15:33:59 +02:00
csoler
f7e396856e added hability to print in the serialization process 2017-04-04 14:01:33 +02:00
csoler
059dfcff47 added hability to print in the serialization process 2017-04-04 14:00:17 +02:00
csoler
75a3cf0f3b fixed compilation in new serialization test code 2017-04-02 15:04:03 +02:00
csoler
ddbe2ef9a1 created .cc files for serialization 2017-04-02 14:48:17 +02:00
csoler
b52071d0c9 removed RsSerializable and merged it into RsItem 2017-04-01 18:05:53 +02:00
csoler
1bc4fe5f28 polished serialisation prototype 2017-03-25 19:01:32 +01:00
csoler
369621f4a4 simplified new serialization prototype 2017-03-20 23:31:04 +01:00
csoler
4f24b95b16 added new serialization code test example 2017-03-19 21:28:28 +01:00
Phenom
5efa8e3f3f Fix Windows Compilation with CONFIG+=no_sqlcipher 2017-03-17 22:14:31 +01:00
csoler
2046dbede9 merged latest fixes from official 0.6.2 release branch 2017-03-15 20:53:01 +01:00
csoler
21143742fd fixed update of Tor proxy address in hidden nodes server page 2017-03-15 19:26:07 +01:00
csoler
44f297156e Merge pull request #682 from csoler/v0.6-EditPosts
V0.6 edit posts
2017-03-14 20:04:22 +01:00
cyril soler
69c3df6dff fixed bug in total item size estimation in pqiqosstreamer due to item slicing 2017-03-10 15:36:50 +01:00
cyril soler
c377bf3efa fixed debug output for groups with no data 2017-03-10 15:12:10 +01:00
cyril soler
fd84639a45 removed some debug info 2017-03-10 15:05:41 +01:00
cyril soler
c87de3eb77 fixed mistake in pointer handling 2017-03-10 10:48:40 +01:00
csoler
cf2edb50b4 fixed memory leak in deleteGroup and removed unnecessary pointer in the functions called below 2017-03-09 22:47:06 +01:00
csoler
a545481daa fixed memory leak when receving multi-chunk file lists 2017-03-09 22:05:06 +01:00
csoler
5b819ebd7a added missing virtual destructor causing a memory leak 2017-03-09 20:59:01 +01:00
csoler
1f8fd95dbf fixed uninitialised memory read in chacha20 test code 2017-03-09 20:48:26 +01:00
csoler
d5f2ae83e5 fixed memory leak recently introduced with openssl-1.1.0 changes 2017-03-09 20:39:12 +01:00
RetroPooh
d3f0f9dde3 router stats - mark active tunnels bold 2017-03-07 17:50:13 +03:00
csoler
88a5c032e4 removed some debug info 2017-03-05 20:10:01 +01:00
thunder2
94c9c94367 updated version number to 0.6.2 in rsversion.in 2017-03-05 14:30:45 +01:00
csoler
b71f4757fe qick fix to allow re-advertising for known forums/channels during the same session. Will be reset at restart (probably best) 2017-03-05 14:14:46 +01:00
csoler
d3cdd15e3f fixed uninitialised memory read in GxsReputation 2017-03-04 21:20:34 +01:00
csoler
dec5c5c4b4 suppressed uninitialised memory leak in LocalDirectoryStorage 2017-03-04 21:13:34 +01:00
csoler
0bd005657d fixed memory leak in RsGxsNetService 2017-03-04 20:52:41 +01:00
csoler
7111579954 fixed memory leak in config of msgService 2017-03-04 20:52:06 +01:00
csoler
c715b03dd5 updated version number to 0.6.2 2017-03-04 11:56:51 +01:00
csoler
8bdf4f3dad fixed sharing of sshfs mounted dirs by allowing files of type DT_UNKNOWN to be explored 2017-03-03 23:28:35 +01:00
csoler
303bc09739 fixed force check directories when auto check is disabled 2017-03-02 23:18:12 +01:00
Phenom
e4dbc46b34 Fiw New Warnings 2017-03-01 19:43:34 +01:00
RetroPooh
d427182e1f fix gxs storage period 1year to 372 days to match old clients 2017-02-28 22:47:38 +01:00
csoler
f70cbbe065 prevent port values to go below 1024 in the backend 2017-02-27 22:37:27 +01:00
csoler
ee9fbefd76 added signal blockign trick for widgets, and fixed the bug causing wrong values to be displayed in server settings 2017-02-27 22:29:01 +01:00
csoler
763f2271a8 merged upstream/master into v0.6-EditPosts branch 2017-02-26 20:39:40 +01:00
csoler
99cf69a98c Merge pull request #703 from RetroShare/v0.6-ImprovedGUI
V0.6 improved gui
2017-02-26 20:14:34 +01:00
csoler
eb817af9b8 Merge pull request #689 from csoler/v0.6-SSL110Fix
fixing compilation with openssl-1.1.0 (part 1)
2017-02-26 20:12:52 +01:00
csoler
b3fadf3d78 Merge pull request #649 from jolavillette/jola_BW_Bursts
Attempt to reduce BW bursts
2017-02-26 18:22:36 +01:00
Phenom
c3c2671db4 Fix LocalDirectoryUpdater to take care if is Enabled in option. 2017-02-26 15:42:32 +01:00
csoler
e75487e48a suppressed a few warnings (suggested by Phenom) 2017-02-25 23:16:43 +01:00
csoler
a531a41c4a fixed recursive call to BIO_set_fd() 2017-02-25 18:21:24 +01:00
csoler
e18cc3eff6 changed reset to cleanup for backward compatibility in EVP_CIPHER_CTX_cleanup call 2017-02-24 23:34:52 +01:00
csoler
d1bf977b15 fixed bug causing decryption of group data to crash 2017-02-24 23:19:47 +01:00
csoler
0e57874ad3 fixed loading of settings::Server page 2017-02-22 22:22:50 +01:00
Phenom
8325c72153 Fix UnitTest Compilation and Travis Error. 2017-02-22 17:46:16 +01:00
csoler
8c3f553579 fixed compilation with openssl1.0.1 broken by previous commits 2017-02-20 22:54:25 +01:00
csoler
c3b49855e0 compilation fix for openssl-1.1.0 (gxssecurity+gxstunnel part) 2017-02-20 21:44:48 +01:00
csoler
5c95b88095 compilation fix for openssl-1.1.0 (pqissl+authssl part) 2017-02-19 22:38:02 +01:00
csoler
57bbd15893 fixing compilation for openssl-1.1.0 (chacha20.cc, HMAC structure, part 2) 2017-02-19 11:10:25 +01:00
csoler
d7bfc3264b fixing compilation for openssl-1.1.0 (chacha20.cc, HMAC structure) 2017-02-19 10:56:33 +01:00
csoler
175664e10e fixing compilation for openssl-1.1.0 (part 12) 2017-02-18 23:58:47 +01:00
csoler
0c77a10224 fixing compilation for openssl-1.1.0 (part 11) 2017-02-18 23:47:53 +01:00
cyril soler
cda3c744af attempt at fixing a bug that can cause a crash in p3filelists.cc 2017-02-17 09:17:33 +01:00
csoler
ccacba797f added pgp passphrase temporary caching in order to avoid re-asking for password at location creation time 2017-02-12 15:27:13 +01:00
csoler
f3824f2348 merged upstream/master 2017-02-11 10:46:51 +01:00
csoler
22f2edb5ad removed debug info and added comment 2017-02-11 10:45:30 +01:00
csoler
ea82d26b75 fixed signature verification bug for versionned messages 2017-02-09 23:35:59 +01:00
csoler
c61ccda431 fixed compilation problem caused by a bug in qtcreator global replace. Warning: always check the result of qtcreator global replace 2017-02-07 22:04:07 +01:00
csoler
37f3e1a62a fixed problem in ID creation code. 2017-02-07 20:15:55 +01:00
csoler
6a9b697e42 made RsReputation::overallReputationLevel() to also return the identity ownership flags so that we dont need to rely on async calls to p3IdService to get them 2017-02-06 23:46:01 +01:00
csoler
013eb93f70 rewrote forum loading method with the proper logarithmic containers 2017-02-06 00:11:26 +01:00
cyril soler
873fbf98ad added 3 missing delete, responsible for small memory leaks 2017-02-01 14:32:51 +01:00
csoler
a357c52124 fixed a few things in options 2017-01-31 21:51:16 +01:00
csoler
deea1b5344 moved temporary GXS object structures into rsgxsutil.h and used them in p3gxscircles to remove a memory leak 2017-01-31 20:59:50 +01:00
csoler
0a02419a29 fixed a big memory leak in hash cache storage load code, and improved deletion of allocated memory if file reading fails 2017-01-31 20:07:27 +01:00
csoler
7327f1a98b fixed deadlock caused by locking the mutex in p3Identity after the one in p3GxsReputation 2017-01-28 15:26:12 +01:00
csoler
f7a1348370 made Accepted option in Transfers to send tunnel requests for both encrypted and clear tunnels 2017-01-23 19:13:50 +01:00
csoler
297907ef81 Merge pull request #662 from csoler/v0.6-ImprovedGUI
V0.6 improved gui
2017-01-22 21:48:48 +01:00
csoler
7da68ff72d improved certificate parsing in Home so that corrupted certs never get accepted 2017-01-22 21:44:26 +01:00
csoler
73d9a48366 update client Grp TS even when friend peer is subscribed to no groups, so as to avoid the friend re-sendign an empty list indefinitly (fix suggested by jo) 2017-01-22 18:36:36 +01:00
Phenom
1f5ef4cc05 Fix Compilation 2017-01-21 17:29:07 +01:00
csoler
e07d6ff6b1 removed debuginfo from PR 654 2017-01-21 17:26:44 +01:00
Phenom
aa05d60894 Fix all warnings in UnitTest 2017-01-21 16:31:45 +01:00
csoler
ee4d722225 fixed cache deletion of GXS grp meta that caused deleted groups to not come back when available 2017-01-20 23:27:18 +01:00
csoler
d1af2e09dc merged with upstream/master 2017-01-20 00:00:47 +01:00
csoler
b52ab0f542 added auto-clean of unused groups when grpAutoSync is enabled (so it does not touch identities) 2017-01-19 23:59:26 +01:00
csoler
410123b976 added warning about consistency error in idservice group flags 2017-01-19 11:16:47 +01:00
csoler
06265f2b54 added consistency check in meta data in publishGroup() and updateGroup() in order to avoid bad data supplied from GXS services 2017-01-19 11:13:06 +01:00
jolavillette
1b8de7b30e Attempt to reduce BW bursts 2017-01-18 13:25:45 +01:00
cyril soler
8568199497 fixed mistake that prevented GXS posts to propagate 2017-01-17 12:40:09 +01:00
csoler
e19711785b fixed last commit because of compilation 2017-01-16 20:57:19 +01:00
csoler
967b85c9bf removed old call to rsIdentity in rsgxsnetservice and removed warning 2017-01-16 20:49:52 +01:00
csoler
c00caa967d Merge pull request #644 from G10h4ck/ccleanup
Some cleanup and deprecation
2017-01-15 21:28:28 +01:00
csoler
5c296b9349 removed warning when peer list is empty in cache_load of identities 2017-01-15 09:57:06 +01:00
Gioacchino Mazzurco
a881441384 Some cleanup and deprecation
RsGxsDataAccess deprecate unused ansType
RsGxsDataAccess::setReq(...) use proper types for params
RsGxsDataAccess::getGroupData(...) print useful information in case of error
GxsRequest proper initialization in constructor
GxsRequest deprecate meaningless ansType
RsGroupMetaData Fix comment to avoid confusion
Deprecated meaningless RS_TOKREQ_ANSTYPE_* common source of confusion
p3GxsCircles::request_CircleIdList() removed unused variable
p3GxsCircles::request_CircleIdList() preper return value
2017-01-14 23:12:50 +01:00
csoler
233c38d8db Merge pull request #641 from csoler/v0.6-Reputations
V0.6 reputations
2017-01-14 20:45:53 +01:00
csoler
df94de9142 disallow to ban your own identity in forums, and make opinions show up as a function ofwhat the ID opinion already is 2017-01-13 18:31:50 +01:00
Gioacchino Mazzurco
cdd39736d4 Documentation and code cleanup
Fix a warning in RsGenExchange::messagePublicationTest(...)
Fix documentation for RsGenExchange::{generatePublicToken(), acknowledgeTokenGrp(...)}
Properly initialize RsGroupMetaData, RsMsgMetaData and p3GxsForums members
Cleanup RsGxsNotify
2017-01-12 22:34:28 +01:00
csoler
19819b9b77 removed debug info 2017-01-12 22:14:41 +01:00
csoler
3c07d50dac set auto-reset of banned nodes to "never" by default 2017-01-12 21:27:02 +01:00
csoler
70a92a1c32 various small fixes in reputation/identity cleaning 2017-01-12 21:14:36 +01:00
csoler
bd7f6aca99 added to parameters in options to fix the time banned ids are kept in list and prevented to re-download 2017-01-12 20:39:49 +01:00
csoler
a7f0fff0f1 made sure reputations are not stamped when requested for debugging/printing 2017-01-10 23:05:00 +01:00
csoler
e329815f33 Merge pull request #621 from G10h4ck/ccleanup
Cleanup rstokenservice defines
2017-01-10 21:59:27 +01:00
csoler
a810ae9a74 use rsReputations instead of rsIdentity for reputation calls. Suspended reputation vetting code which is not needed anymore 2017-01-10 21:44:37 +01:00
csoler
2f1d9073fa removed debug info 2017-01-10 20:10:28 +01:00
csoler
8d8453f9c0 removed the reputation calls through rsIdentity. Improved the logic of updating static identity flags in p3gxsreputations 2017-01-09 23:47:51 +01:00
cyril soler
2ed983026d fixed 2 comments in GXS net service 2017-01-09 15:49:20 +01:00
csoler
2fc8d22cf9 changed cleaning strategy of p3gxsreputations to be based on last activity of the reputation system rather than the identity system 2017-01-08 22:00:54 +01:00
csoler
b6a3f53826 changed the needsUpdate flag so that unset/default needs update, and added code to read old reputation set item class 2017-01-08 11:14:18 +01:00
csoler
0dd3a318ed added last used TS in reputation items 2017-01-08 11:10:33 +01:00
csoler
d631758e8c added hashstream class to hash content of RsIdentityUsage and fix duplication of identity usage statistics 2017-01-05 23:07:59 +01:00