Commit Graph

4566 Commits

Author SHA1 Message Date
Phenom
0479ec07ab Fix clang warning: unused variable 'MAX_MESSAGES_PER_SECONDS_NUMBER'
/libretroshare/src/chat/distributedchat.cc:57: warning: unused variable
'MAX_MESSAGES_PER_SECONDS_NUMBER' [-Wunused-const-variable]
static const uint32_t MAX_MESSAGES_PER_SECONDS_NUMBER     =  5 ; // max
number of messages from a given peer in a window for duration below
2017-07-16 21:17:06 +02:00
Phenom
80ea4de7be Fix clang warning: unused variable 'ftserverzone'
/libretroshare/src/ft/ftserver.cc:34: warning: unused variable
'ftserverzone' [-Wunused-const-variable]
const int ftserverzone = 29539;
2017-07-16 21:16:30 +02:00
Phenom
8a270af519 fixed merging problem 2017-07-16 21:15:26 +02:00
Phenom
35186c4054 Fix clang warning: unused variable 'res'
/libretroshare/src/crypto/chacha20.cpp:978: warning: unused variable
'res' [-Wunused-variable]
        uint256_32 res(q1) ;
2017-07-16 21:12:09 +02:00
Phenom
7f1e23085d Fix clang warning: unused variable 'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG', ...
/libretroshare/src/ft/fttransfermodule.cc:56: warning: unused variable
'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_MAX_WAIT_PER_GIG = 20; /* 20 seconds per
gigabyte */
/libretroshare/src/ft/fttransfermodule.cc:65: warning: unused variable
'FT_TM_FAST_RTT' [-Wunused-const-variable]
const int32_t FT_TM_FAST_RTT    = 1.0;
/libretroshare/src/ft/fttransfermodule.cc:66: warning: unused variable
'FT_TM_STD_RTT' [-Wunused-const-variable]
const int32_t FT_TM_STD_RTT     = 5.0;
/libretroshare/src/ft/fttransfermodule.cc:67: warning: unused variable
'FT_TM_SLOW_RTT' [-Wunused-const-variable]
const int32_t FT_TM_SLOW_RTT    = 20.0;
/libretroshare/src/ft/fttransfermodule.cc:69: warning: unused variable
'FT_TM_CRC_MAP_STATE_NOCHECK' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_NOCHECK      = 0 ;
/libretroshare/src/ft/fttransfermodule.cc:70: warning: unused variable
'FT_TM_CRC_MAP_STATE_DONT_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_DONT_HAVE = 1 ;
/libretroshare/src/ft/fttransfermodule.cc:71: warning: unused variable
'FT_TM_CRC_MAP_STATE_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_HAVE                 = 2 ;
2017-07-16 21:11:47 +02:00
Phenom
8b99c80e07 Fix clang warning: 'p3GxsTrans' defined as a class here but previously
declared as a struct

/libretroshare/src/gxstrans/p3gxstrans.h:88: warning: 'p3GxsTrans'
defined as a class here but previously declared as a struct [-
Wmismatched-tags]
class p3GxsTrans : public RsGenExchange, public GxsTokenQueue, public
p3Config, public RsGxsTrans
/libretroshare/src/gxstrans/p3gxstrans.h:31: did you mean class here?
struct p3GxsTrans;
2017-07-16 21:11:10 +02:00
Phenom
c97269bed6 Fix warning: this statement may fall through
/libretroshare/src/gxstrans/p3gxstrans.cc:870: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.sent_ts = time(NULL) ; //pr.mailItem.meta.mPublishTs = time(NULL);
/libretroshare/src/gxstrans/p3gxstrans.cc:872: here
  case GxsTransSendStatus::PENDING_PREFERRED_GROUP:

/libretroshare/src/gxstrans/p3gxstrans.cc:883: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.group_id = mPreferredGroupId ; //pr.mailItem.meta.mGroupId =
mPreferredGroupId;
/libretroshare/src/gxstrans/p3gxstrans.cc:885: here
  case GxsTransSendStatus::PENDING_RECEIPT_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:906: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.msg.setBinData(&grsrz[0], grsz);
/libretroshare/src/gxstrans/p3gxstrans.cc:908: here
  case GxsTransSendStatus::PENDING_RECEIPT_SIGNATURE:     // (cyril)
This step is never actually used.

/libretroshare/src/gxstrans/p3gxstrans.cc:924: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.meta.setBinData(&srx[0], metaSize);
/libretroshare/src/gxstrans/p3gxstrans.cc:926: here
  case GxsTransSendStatus::PENDING_PAYLOAD_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:938: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   memcpy(&pr.mailItem.payload[offset], &pr.mailData[0], datasize);
/libretroshare/src/gxstrans/p3gxstrans.cc:940: here
  case GxsTransSendStatus::PENDING_PAYLOAD_ENCRYPT:

/libretroshare/src/gxstrans/p3gxstrans.cc:982: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   }
/libretroshare/src/gxstrans/p3gxstrans.cc:984: here
  case GxsTransSendStatus::PENDING_PUBLISH:
2017-07-16 20:47:45 +02:00
Phenom
18139489cf Fix warning: unused parameter ‘grpItem’ and unused debug variables
/libretroshare/src/gxstrans/p3gxstrans.cc:635: warning: unused parameter
‘grpItem’ [-Wunused-parameter]
         RsGxsGrpItem* grpItem, RsTlvSecurityKeySet& /*keySet*/ )

/libretroshare/src/gxstrans/p3gxstrans.cc:681: warning: unused variable
‘msgId’ [-Wunused-variable]
      const RsGxsMessageId& msgId = *vit;

/libretroshare/src/gxstrans/p3gxstrans.cc:676: warning: unused variable
‘grpId’ [-Wunused-variable]
     const RsGxsGroupId& grpId = it->first;
2017-07-16 20:46:55 +02:00
Phenom
e1ea92d733 Fix warning: unused parameter ‘n’
/libretroshare/src/serialiser/rstypeserializer.cc:358: warning: unused
parameter ‘n’ [-Wunused-parameter]
 template<> void RsTypeSerializer::print_data( const std::string& n,
2017-07-16 20:41:24 +02:00
Phenom
f193af2865 Fix warning: unused parameter ‘size’
/libretroshare/src/gxs/rsgenexchange.cc:3079: warning: unused parameter
‘size’ [-Wunused-parameter]
 bool RsGenExchange::acceptNewMessage(const RsGxsMsgMetaData* /
*grpMeta*/,uint32_t size ) { return true; }
2017-07-16 20:41:01 +02:00
Phenom
d8b0b5222b Fix warning: variable ‘it’ set but not used
/libretroshare/src/gxs/rsgxsnetservice.cc:867: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
     std::map<RsGxsGroupId,RsGxsServerMsgUpdate>::iterator it =
mServerMsgUpdateMap.find(grpId) ;

/libretroshare/src/gxs/rsgxsnetservice.cc:2434: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
             ClientGrpMap::iterator it =
mClientGrpUpdateMap.find(peerFrom);
2017-07-16 20:40:31 +02:00
Phenom
b11022a239 Fix warning: this statement may fall through
/libretroshare/src/util/dnsresolver.cc:49: warning: this statement may
fall through [-Wimplicit-fallthrough=]
       case DNSResolver::DNS_LOOKUP_ERROR:  if(it-
>second.last_lookup_time + MAX_TIME_BEFORE_RETRY > now)
/libretroshare/src/util/dnsresolver.cc:52: here
       case DNSResolver::DNS_DONT_HAVE:   next_call = it->first ;
2017-07-16 20:38:43 +02:00
Phenom
0e302e254e Fix warning: this statement may fall through
/libretroshare/src/util/rsnet_ss.cc:1031: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   success = inet_ntop( addr.ss_family, (const void *) &(addrv4p-
>sin_addr), ipStr, INET_ADDRSTRLEN );
/libretroshare/src/util/rsnet_ss.cc:1033: here
  case AF_INET6:
2017-07-16 20:36:16 +02:00
Phenom
7b4d3c5a24 Fix warning: this statement may fall through
/libretroshare/src/util/rscompress.cc:165: warning: this statement may
fall through [-Wimplicit-fallthrough=]
      ret = Z_DATA_ERROR;     /* and fall through */
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/util/rscompress.cc:
166: here
     case Z_DATA_ERROR:
2017-07-16 20:34:38 +02:00
Phenom
476b581506 Fix warning: this statement may fall through
/libretroshare/src/rsserver/p3serverconfig.cc:292: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->getFriendCount(true, false) > MIN_BASIC_FRIENDS)
/libretroshare/src/rsserver/p3serverconfig.cc:297: here
   case RSCONFIG_USER_LEVEL_BASIC:

/libretroshare/src/rsserver/p3serverconfig.cc:300: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->haveOnceConnected())
/libretroshare/src/rsserver/p3serverconfig.cc:306: here
   case RSCONFIG_USER_LEVEL_CASUAL:
2017-07-16 20:33:55 +02:00
Phenom
7bd7c57ff9 Fix warning: variable ‘pgpNameFound’ set but not used
/libretroshare/src/rsserver/rsaccounts.cc:130: warning: variable
‘pgpNameFound’ set but not used [-Wunused-but-set-variable]
  bool pgpNameFound = false;
2017-07-16 20:32:32 +02:00
Phenom
a0506c1a0f Fix warning: this statement may fall through
/libretroshare/src/pqi/pqissl.cc:449: warning: this statement may fall
through [-Wimplicit-fallthrough=]
    sslmode = PQISSL_ACTIVE; /* we're starting this one */
/libretroshare/src/pqi/pqissl.cc:456: here
   case WAITING_DELAY:
2017-07-16 20:31:49 +02:00
Phenom
b9d4651f07 Fix warning: this statement may fall through
/libretroshare/src/pqi/pqisslpersongrp.cc:125: warning: this statement
may fall through [-Wimplicit-fallthrough=]
     std::cerr << " --> falling back to Tor" << std::endl;
/libretroshare/src/pqi/pqisslpersongrp.cc:126: here
    case RS_HIDDEN_TYPE_TOR:
2017-07-16 20:30:41 +02:00
Phenom
e12f51b1be Fix warning: variable ‘peerIt1’ set but not used
/libretroshare/src/pqi/p3peermgr.cc:2619: warning: variable ‘peerIt1’
set but not used [-Wunused-but-set-variable]
                     std::set<RsPgpId>::iterator peerIt1 =
groupItem.peerIds.find(*peerIt);
2017-07-16 20:28:24 +02:00
Phenom
78cfde9b4f Fix warning: this statement may fall through
/libretroshare/src/pgp/pgphandler.cc:62: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE_PREV_WAS_BAD: prev_was_bad =
true ;

/libretroshare/src/pgp/pgphandler.cc:63: here
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE:
2017-07-16 20:27:46 +02:00
Phenom
3a6ad822da Fix warning: this statement may fall through
/libretroshare/src/ft/ftchunkmap.cc:190: warning: this statement may
fall through [-Wimplicit-fallthrough=]
    case FileChunksInfo::CHUNK_CHECKING: _file_is_complete = false ;

/libretroshare/src/ft/ftchunkmap.cc:191: here
    case FileChunksInfo::CHUNK_DONE:   _total_downloaded +=
sizeOfChunk(i) ;
2017-07-16 20:27:09 +02:00
Phenom
635246c462 Fix warning: this statement may fall through
/libretroshare/src/tcponudp/bss_tou.c:246: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   num=0;

/libretroshare/src/tcponudp/bss_tou.c:247: here
  case BIO_C_FILE_SEEK:
2017-07-16 20:25:11 +02:00
csoler
08faa3f5d5 fixed p3Gxstunnel so that it sends the data packets in the same order it received them. This fixes the bug in distant chat causing images to not transfer correctly in some cases 2017-07-15 22:16:45 +02:00
csoler
9c391cb015 added an additional param to BinToHex so as to limit the size of the output 2017-07-15 22:15:51 +02:00
csoler
98b0585ba4 Merge pull request #937 from csoler/v0.6-ImprovedNoGUI
V0.6 improved no gui
2017-07-13 21:23:13 +02:00
Gioacchino Mazzurco
69aa5b6a09 Clean some garbage from the code 2017-07-13 13:00:32 +02:00
csoler
fd452af088 removed some debut output that perturbated the passwd command line 2017-07-12 23:03:17 +02:00
csoler
00c1a9a7ff fixed autologin 2017-07-12 22:53:35 +02:00
csoler
66268c8267 fixed variable shadowing a parameter 2017-07-12 18:48:06 +02:00
csoler
4cfdef5ff9 do not display auto-login option when software is compiled without autologin 2017-07-11 23:39:04 +02:00
csoler
a5e0b1c336 fixed -U option in rs-nogui. Removed debug output that would ruin the terminal interface 2017-07-11 23:32:22 +02:00
csoler
3e3ee1a34b little improvement to command line help display 2017-07-09 22:12:01 +02:00
csoler
5dfbce7e3a fixed Terminal Api Client logic 2017-07-09 21:16:41 +02:00
csoler
7ee527ecbd removed comments 2017-07-08 17:35:34 +02:00
csoler
b5976e195e fixed message when passphrase is empty 2017-07-08 16:48:24 +02:00
Phenom
54047cd7a7 Fix multi download of same file. 2017-07-06 22:38:08 +02:00
Gioacchino Mazzurco
c630f1fa89 Fix unused warning in gxstokenqueue 2017-07-06 16:28:59 +02:00
Gioacchino Mazzurco
b935bacd99 Add missing break in p3IdService::handleResponse 2017-07-06 16:28:00 +02:00
csoler
141277b131 removed debug info 2017-07-05 22:16:14 +02:00
csoler
c1e18c7fe6 fixed bug causing an infinite subscribe/unsubscribe loop in GxsTrans 2017-07-05 22:12:56 +02:00
csoler
370d50b41a cleaned a bit the code in rsinit.cc 2017-07-05 21:36:00 +02:00
cyril soler
f413433480 removed zeroing of preferred group causing a bug in GxsTrans 2017-07-03 11:25:12 +02:00
csoler
1b4e8a46ed Merge pull request #909 from csoler/v0.6-GxsTransport
V0.6 gxs transport
2017-06-29 18:38:10 +02:00
csoler
64e3fc97e8 fixed bug preventing correct subscribe in GxsTrans 2017-06-29 18:37:39 +02:00
csoler
700d114cf4 fixed bug causing failure of group autosubscribe in GxsTrans 2017-06-29 18:27:00 +02:00
Phenom
b4071d158e Add General Direct Download setting.
Yes, No, Per User
2017-06-29 17:18:28 +02:00
csoler
37edcc1e37 fixed subscribe policy to GxsTrans groups as a function of last available post and group usage 2017-06-29 13:44:40 +02:00
csoler
dc605c02f1 added a last modif TS in GrpNetworkStats, that is inited from network Grp statistics, and used to provide a value for unsubscribed groups 2017-06-29 13:15:39 +02:00
csoler
533e2a8b45 added check to fix existing wrong storage time value in GxsTrans 2017-06-28 23:23:27 +02:00
csoler
f37ba83c07 moved msg keep period settings to netService and made the initialisation obei the default settings of the service 2017-06-28 23:12:33 +02:00