414 Commits

Author SHA1 Message Date
AsamK
3cfe69787f Fix subtle bug in tlv deserialization of TLV_TYPE_KEYSIGNATURETYPE
When using -O2, the variable currType is optimized out, so the
signature is added with the wrong sign type. Then when verifying the
data the signature is not found and verification fails.

The main sympton of this bug was receiving no more forum/channel posts.

Wit debug builds (-O0) this worked, that's why not every one was affected
by this.

This bug was introduced in 2012 (19e856c2a8eb56c5e43e977aac27a3dbc79ab2d0)
2015-09-02 02:03:46 +02:00
csoler
168eb45539 removed debug info about missing keys; added debug info about deserialization checking of string 2015-08-05 20:51:34 +02:00
csoler
260da99955 improved filtering method against lol bombs. Thx to ConcernedCitizen for pointing this out 2015-07-31 17:27:42 +02:00
thunder2
c76141ed65 Added missing initialization in
- pqissl
- pqissludp
- PeerConnectStateBox
- RsTlvBanListEntry
- RsServer
- TcpStream
- PGPCertificateInfo
- peerConnectAddress
- AudioInputConfig
- SpeexInputProcessor
- xProgressBar
- TBoard

Removed unused member:
- xProgressBar


git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8611 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-07-13 11:03:18 +00:00
thunder2
090148cea2 Fixed possible crash in RsGxsIdSerialiser by checking return value of dynamic_cast.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8599 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-07-12 01:43:10 +00:00
thunder2
63d85f8077 Fixed possible crash in RsFileTransferSerialiser by checking return value of dynamic_cast.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8592 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-07-12 00:58:05 +00:00
csoler
249c827f95 improved debug info in a few places
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8584 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-07-09 20:55:11 +00:00
electron128
d870b13a49 fixed potential integer problems in de-serialization of different TLV items (patch from Henry)
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8574 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-07-01 12:17:03 +00:00
csoler
8e0b6b95c5 fixed potential integer problem in image de-serialization (reported by HM)
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8568 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-29 12:00:40 +00:00
csoler
e1dcdd78b6 auto-cleaning of strings for types that cannot contain chars < 0x20 by design
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8547 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-23 19:25:13 +00:00
csoler
ab95a6c865 removed debug info
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8503 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-16 19:17:52 +00:00
electron128
f5843faef0 added missing size check in RsGxsRecognSerialiser
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8425 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-13 08:03:58 +00:00
electron128
eb7a52a2a7 fixed bug reporting wrong IP for connection (patch from Cyril)
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8367 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-04 13:25:19 +00:00
csoler
777c915be2 load/save of banlist comments. Removed unused menu entries. Added auto-fill of input fields on sleection
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8343 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-02 13:02:20 +00:00
csoler
bb74d08f33 add/remove from lists. Load/save from user whitelist/blacklist
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8321 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-05-30 20:29:06 +00:00
csoler
20a2d42038 almost done with load/save of BanLists. Changed the item format to include masked_bytes, and changed subitem types. Also disabled code from rsgxsreputationitems.cc wich was a copy of the code from rsbanlistitems.cc
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8316 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-05-29 20:49:37 +00:00
csoler
38aefdf62f first UI prototype for IP ban list system. Not yet usable.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8305 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-05-27 21:30:40 +00:00
csoler
1f759c4004 removed a few redundant return statements
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8276 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-05-19 21:29:50 +00:00
csoler
13ff39429e * Renamed RS_TLVKEY_DISTRIB_PRIVATE into *_PUBLISH, as it is used as such.
* Allow to check signatures and validate groups using private keys in GxsSecurity
* removed inconsistency in key flags when full keys where mixed up with publish keys.

This should fix the following bugs:
* channel owners did not receive posts from other peers who have publish rights
* channels sometimes not gettign through



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8275 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-05-19 21:28:46 +00:00
csoler
90d6ac6697 fixed memory leak and potential crash due to not copying items passed to config saving in messages. Added save/load for map between GRouter and Msg ids which fixes the never removed outgoing messages
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8184 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-04-28 21:46:10 +00:00
csoler
77a33cd445 removed unnecessary debug output
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8153 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-04-21 20:09:20 +00:00
csoler
c9d5c7b3cb turned some std::list<PeerId> into std::set, as it automatically prevents duplicates
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8138 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-04-17 21:36:22 +00:00
csoler
70918e9dcf reduced size of output for buggy RsItems
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8111 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-04-03 21:57:24 +00:00
csoler
ae0603a687 added test to prevent using twice the same config file; changed duplicate config file name causing deserialisation errors and loss of some config files; added printout of hex code for RsItems that fail deserialisation
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8075 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-03-25 22:21:01 +00:00
drbob
7cece484c4 Modify Messages with additional namespace - to allow switching to new Mail.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8066 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-03-22 04:45:01 +00:00
csoler
c4b1b3dfbc fixed serialisation bug likely causing the loss of peers.cfg (Thx G10H4ck for finding this)
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8039 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-03-16 21:27:35 +00:00
csoler
48ea291d95 moved signature validation and encryption one level up into p3IdService. Added timestamp for GXS identities and auto-removal after 7 days. Updated display in IdDialog
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8015 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-03-14 14:33:23 +00:00
csoler
6e8e5efb90 fixed a few bugs in distant chat protocol (allow re-negociation of DH parameters if decryption fails, correct passing of own gxs id for server side), making the system more reactive. Also fixed the issue of avatar not showing up. Changed the tunnel naming system to something specific to distant chat. WARNING: this version cannot distant chat with previous versions.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7943 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-02-14 20:55:05 +00:00
thunder2
8351510841 Receiving a shared key:
- Added notify of the group id and the refresh of the gui
- Added system message (create of message disabled)
- Added possibility to show a news feed item

git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7926 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-02-08 01:01:48 +00:00
csoler
7642ba1c1f added load/save to service permission matrix
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7906 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-02-03 21:28:32 +00:00
csoler
8a8f9fc528 added number of posts at friends to saveList/loadList. Improves visibility of number of posts
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7896 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-01-31 18:06:37 +00:00
csoler
e19d2e3c36 re-enabled anti-svg bomb code before some jerk tries to exploit it. It was used for wide strings. Moved it to std::string deserialisation.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7893 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-01-31 12:30:31 +00:00
csoler
481ee246b5 added avatars to identities.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7875 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-01-25 22:09:12 +00:00
csoler
93f77a0e2c improved network statistics for GXS net service. Added number of available messages for unsubscribed forums in GUI. Should be done as well for channels.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7760 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-12-16 06:54:15 +00:00
csoler
d4dad8328f fixed compilation warnings
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7759 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-12-16 06:49:42 +00:00
csoler
a5bf3b6f3f improved/cleaned debug outputs in in rsgxsnetservice.cc. Performed optimization of transaction system: limited the size of message transactions and allowed a much larger transaction timeout to suppress the transaction cancelling epidemic that caused global bandwidth increase and lack of channel/forum propagation
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7724 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-12-02 20:06:56 +00:00
drbob
6588eafb99 Adding start of new Mail Service.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7723 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-12-02 13:22:48 +00:00
csoler
f6efa2fb92 separated chat items from message items, separated chat into tree components: chat, distant chat and distributed chat (i.e. lobbies). moved all chat components into chat/. Removed deprecated chat items
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7670 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-11-11 16:10:54 +00:00
csoler
9311dc5922 removed unused comparison operators
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7650 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-10-31 21:18:52 +00:00
csoler
d547cb6fdb changed post fixed operator++ into prefixed. More efficient on some systems. Patch from Phenom.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7630 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-10-24 22:07:26 +00:00
csoler
d0469ccfc3 implemented publish key sharing between peers for channels.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7582 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-10-05 19:14:05 +00:00
csoler
9efc43f41c Big progress for People dialog. Phenom work.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7573 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-09-28 20:46:56 +00:00
csoler
789e6ae24e removed some debug info
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7542 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-09-16 19:53:23 +00:00
csoler
80f4401e88 - implemented DH protocol for PFS encryption in distant chat between GXS ids.
- changed format of keyId in rstlvkeys.{h,cc}, but kept the serialisation for backward compatibility (A #define needs to be removed to fix it for good). Updated rsrecogn, rsmsgitems, gxssecurity accordingly
- added "chat peer" in IdDialog to help testing distant chat.

Distant chat works and is now encrypted. The GUI still needs some smoothing: display of correct peer names
in chat window, remove the need to add a message in p3chatservice.cc:3217 to force poping up the chat window.

- added MsgAddress class to handle generic address types while keeping type separation in Messages. Not used yet.



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7403 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-06-12 10:28:23 +00:00
csoler
bfe872118b - fixed a bug in distant message signature checking
- fixed delay problem in not getting uncached GXS Id keys by prior requesting details about the key
- enabled signing by default in MessageComposer
- implemented print() in RsTlvIdSet.



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7373 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-05-17 21:36:07 +00:00
csoler
33abca82e5 - removed LinksCloud from plugins (based on obsolete cache system)
- removed copy constructor of RsGenericId from std::string as it allowed many inconsistencies and double transforms of IDs from/to strings


git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7289 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-04-20 16:34:26 +00:00
csoler
ed198af807 - added notification from global router to client services
- keep distant messages in outbox until they get notified to be received
- cleanup dead code


git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7284 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-04-19 16:02:11 +00:00
chrisparker126
ef8f48ae73 Added rsshared ptr helper object (only use in test for memory management)
Added first nxs_test
modified pserviceserver to allow better dependency injection 

git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7279 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-04-18 21:58:14 +00:00
drbob
9f358c5480 fixed printout of nxs items.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7268 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-04-12 07:25:33 +00:00
drbob
3eb79bbcba Bugfixes to rsmsgitems & rsserial.
removed testing utilites rstlvutil.
fixed up rsgxsiditems printing.



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7232 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-04-05 04:48:52 +00:00