Commit Graph

10664 Commits

Author SHA1 Message Date
Phenom
3592d5bf5d Fix GCC warnings: unused parameter ‘names’
/libretroshare/src/pqi/pqiservice.h:80: warning: unused parameter
‘names’ [-Wunused-parameter]
     virtual void getItemNames(std::map<uint8_t,std::string>& names)
const {} // This does nothing by default. Service should derive it in
order to give info for the UI
                                                              ^~~~~
2017-04-25 09:53:06 +02:00
Phenom
593c0cb7e6 Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: Null pointer value stored to field 'mInternalTokenQueue' in /home/
phenom/GIT/RetroShare/trunk/retroshare-gui/src/gui/gxs/
GxsGroupDialog.cpp:70
 2: Calling 'GxsGroupDialog::init' in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:72
 3: Calling 'GxsGroupDialog::initMode' in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:136
 4: Calling 'GxsGroupDialog::requestGroup' in /home/phenom/GIT/
RetroShare/trunk/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:190
 5: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:866
2017-04-25 09:52:43 +02:00
Phenom
90aaace69c Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: Value assigned to field 'mMainAction' in /home/phenom/GIT/
RetroShare/trunk/retroshare-gui/src/gui/common/UserNotify.cpp:94
 2: Assuming pointer value is null in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/common/UserNotify.cpp:95
 3: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/common/UserNotify.cpp:103
2017-04-25 09:52:01 +02:00
Phenom
1f16f46aad Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: Assuming pointer value is null in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/common/MimeTextEdit.cpp:65
 2: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/common/MimeTextEdit.cpp:83
2017-04-25 09:51:08 +02:00
Phenom
30632dcfeb Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: Calling 'MainWindow::createNotifyIcons' in /home/phenom/GIT/
RetroShare/trunk/retroshare-gui/src/gui/MainWindow.cpp:291
 2: Loop body executed 0 times in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/MainWindow.cpp:600
 3: Calling 'MainWindow::updateTrayCombine' in /home/phenom/GIT/
RetroShare/trunk/retroshare-gui/src/gui/MainWindow.cpp:605
 4: Value assigned to field 'notifyMenu' in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/MainWindow.cpp:654
 5: Assuming pointer value is null in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/MainWindow.cpp:658
 6: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/MainWindow.cpp:679
2017-04-25 09:50:14 +02:00
Phenom
90cd6233d8 Fix CAS warnings: Potential leak of memory pointed to by 'toaster'
Memory Error: Memory leak: Potential leak of memory pointed to by
'toaster'
 1: Memory is allocated in /home/phenom/GIT/RetroShare/trunk/plugins/
VOIP/gui/VOIPToasterNotify.cpp:182
2017-04-25 09:49:40 +02:00
Phenom
b2b7d004cd Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: 'di' initialized here in /home/phenom/GIT/RetroShare/trunk/plugins/
VOIP/gui/VOIPGUIHandler.cpp:157
 2: Assuming 'di' is null in /home/phenom/GIT/RetroShare/trunk/plugins/
VOIP/gui/VOIPGUIHandler.cpp:158
 3: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/plugins/VOIP/gui/VOIPGUIHandler.cpp:161
2017-04-25 09:48:48 +02:00
Phenom
ff1908eda6 Fix Clang Static Analyser: Undefined allocation of 0 bytes
Unix API: Undefined allocation of 0 bytes (CERT MEM04-C; CWE-131): Call
to 'malloc' has an allocation size of 0 bytes
 1: Loop body executed 0 times in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:223
 2: Calling 'bloomFilter::getFilter' in /home/phenom/GIT/RetroShare/
trunk/libbitdht/src/util/bdbloom.cc:240
 3: 'bytes' initialized to 0 in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:141
 4: Call to 'malloc' has an allocation size of 0 bytes in /home/phenom/
GIT/RetroShare/trunk/libbitdht/src/util/bdbloom.cc:148
2017-04-25 09:47:10 +02:00
Phenom
f22dc0f0df Fix Clang warnings: unused variable 'action'
warning: unused variable 'action' [-Wunused-variable]
                                QAction *action = contextMenu-
>addAction(QIcon(":/images/chat_24.png"),tr("Copy identity to
clipboard"),this,SLOT(copyRetroshareLink())) ;
2017-04-25 09:45:57 +02:00
Phenom
490f8d2f54 Fix Clang warnings: 'TYPE_IDENTITY' not handled
warning: enumeration value 'TYPE_IDENTITY' not handled in switch [-
Wswitch]
2017-04-25 09:45:27 +02:00
Phenom
6e42cf4200 Fix Clang warnings: field 'mPassword' will be initialized after field
'mPrevIsBad'

warning: field 'mPassword' will be initialized after field 'mPrevIsBad'
[-Wreorder]
2017-04-25 09:44:59 +02:00
csoler
0d7df568b4 moved rsconfigitems and rshistoryitems to rsitems/ 2017-04-24 22:47:08 +02:00
csoler
f7338d4a3d removed old code 2017-04-24 22:39:05 +02:00
csoler
43b3b87782 fixed a few bugs in config items 2017-04-24 22:36:03 +02:00
csoler
fcabe6359f switch RsConfigItems to new serialization 2017-04-24 18:51:51 +02:00
electron128
be9f126898 Merge pull request #781 from Sonetio/libresapi_requests
Added few requests handling in libresapi
2017-04-24 18:43:17 +02:00
csoler
af4fcf7679 switched rshistoryitems to new serialization 2017-04-24 17:33:30 +02:00
Phenom
1327582096 Fix Relay setting values
Was multiply by 1024 then divide by 1000.
2017-04-24 17:28:25 +02:00
csoler
8ae6541ceb added two new classes for config/service serialisers and a base generic serialiser class 2017-04-24 17:10:01 +02:00
Konrad
8da5e15180 Changed: difference time to absolute time. 2017-04-24 16:00:23 +02:00
csoler
dc2df071a5 renamed RsSerializer into RsServiceSerializer 2017-04-24 14:14:34 +02:00
csoler
976a80a7af switch rsfilelistitems to new serialization 2017-04-24 13:30:18 +02:00
csoler
26e95416d1 moved RTT items to rsitems/ 2017-04-24 11:06:51 +02:00
csoler
f6aaee7382 converted RTT items to new serialization 2017-04-24 11:01:45 +02:00
csoler
5071c4bc7f moved msgitems to rsitems/ 2017-04-24 11:00:57 +02:00
csoler
fc82b20833 removed old serialization code in msgs 2017-04-24 10:36:22 +02:00
csoler
08867945f3 fixed bug caused by wrong cast in lobby msg signature validation 2017-04-24 10:29:57 +02:00
csoler
91b04098b6 fixed two memory bugs in serialization code 2017-04-24 10:11:24 +02:00
defnax
6313d89718 Improved look n feel of Profile Generation Window. 2017-04-24 01:23:05 +02:00
csoler
31c07f4dfd converted RsMsgItems to new serialization. Added format and flag members to RsSerialiser and used the later to handle signature and config serialization techniques 2017-04-23 22:40:26 +02:00
csoler
63b4b3a1f7 moved discovery2 items to rsitems/ 2017-04-23 19:07:26 +02:00
csoler
9d9ff567bb switched discovery2items to new serialization 2017-04-23 19:02:12 +02:00
csoler
190a638cc1 added zesty to ubuntu releases 2017-04-23 17:53:25 +02:00
csoler
06e90e6549 added control file for zesty 2017-04-23 17:49:07 +02:00
csoler
c738026eb8 updated ubuntu changelog 2017-04-23 17:48:39 +02:00
csoler
5b3b903603 added missing line for ubuntu zesty 2017-04-23 17:36:18 +02:00
csoler
73bfc27f47 Merge pull request #784 from PhenomRetroShare/Fix_RelaySettingsPage
Fix Relay setting page.
2017-04-23 17:33:50 +02:00
Phenom
4c326f5e80 Fix Relay setting page. 2017-04-23 10:27:18 +02:00
csoler
2e7127077d fixed previous file move 2017-04-22 21:36:39 +02:00
csoler
bef6db4b43 moved files 2017-04-22 21:32:57 +02:00
csoler
311f257090 converted GxsReputationItems to new serialization 2017-04-22 21:10:55 +02:00
defnax
0e087db807 Fixed to use right icons for context menu actions 2017-04-22 17:32:59 +02:00
csoler
782c02744f added names for turtle sub items 2017-04-22 16:00:01 +02:00
Konrad
f571b05693 Added: Checking if the vector is empty;
Changed: Grouped values into one member
2017-04-22 11:06:56 +02:00
electron128
8b9c447063 fixed possible crash and return value in rsGetHostByName(), thanks to Kotyara for reporting this 2017-04-22 10:13:23 +02:00
Konrad
8c0b7ce776 Fixed: Responds sends now correct time difference 2017-04-21 23:44:00 +02:00
csoler
4ab60219b2 Merge pull request #782 from PhenomRetroShare/Fix_MacOSX_Compilation
Fix MacOSX compilation.
2017-04-21 19:45:30 +02:00
Phenom
936dcbabb3 Fix UnitTest compilation. 2017-04-21 18:50:36 +02:00
Phenom
969b5ce1f1 Fix MacOSX compilation. 2017-04-21 15:57:57 +02:00
csoler
7400a8d768 Merge pull request #780 from csoler/v0.6-ImprovedGUI
added mechanism to allow services to document the names of their item…
2017-04-20 20:59:12 +02:00