From ff1b2ebde495f3bac8726734ca7ed1a0d93e426a Mon Sep 17 00:00:00 2001 From: csoler Date: Mon, 24 Jun 2019 21:12:27 +0200 Subject: [PATCH] fixed uninitialized memory read in calling rsservicehandler registerNewService system --- libretroshare/src/gossipdiscovery/p3gossipdiscovery.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libretroshare/src/gossipdiscovery/p3gossipdiscovery.cc b/libretroshare/src/gossipdiscovery/p3gossipdiscovery.cc index e50073945..d3a6955d5 100644 --- a/libretroshare/src/gossipdiscovery/p3gossipdiscovery.cc +++ b/libretroshare/src/gossipdiscovery/p3gossipdiscovery.cc @@ -110,9 +110,8 @@ p3discovery2::p3discovery2( // Add self into PGP FriendList. mFriendList[AuthGPG::getAuthGPG()->getGPGOwnId()] = DiscPgpInfo(); - rsEvents->registerEventsHandler( - [this](const RsEvent& event){ rsEventsHandler(event); }, - mRsEventsHandle ); + mRsEventsHandle = 0 ; // avoids random behavior if not initialized + rsEvents->registerEventsHandler( [this](const RsEvent& event){ rsEventsHandler(event); }, mRsEventsHandle ); }