Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-06-28 08:07:31 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix CppCheck in rsrttitems.h

Browse source 
/libretroshare/src/rsitems/rsrttitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPingItem::mSeqNo' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPingItem::mPingTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mSeqNo' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mPingTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mPongTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:46: warning:
Cppcheck(noExplicitConstructor): Class 'RsRttItem' has a constructor
with 1 argument that is not explicit.
This commit is contained in:
Phenom 2017-07-28 09:38:24 +02:00 • committed by csoler
parent 7e47be56ea
commit f82ec64d29
1 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

18
libretroshare/src/rsitems/rsrttitems.h
View file

@ -43,17 +43,20 @@ const uint8_t RS_PKT_SUBTYPE_RTT_PONG = 0x02;
class RsRttItem: public RsItem class RsRttItem: public RsItem
{ {
public: public:
RsRttItem(uint8_t subtype) : RsItem(RS_PKT_VERSION_SERVICE,RS_SERVICE_TYPE_RTT,subtype) explicit RsRttItem(uint8_t subtype) : RsItem(RS_PKT_VERSION_SERVICE,RS_SERVICE_TYPE_RTT,subtype)
{ setPriorityLevel(QOS_PRIORITY_RS_RTT_PING) ;} // should be refined later. { setPriorityLevel(QOS_PRIORITY_RS_RTT_PING) ;} // should be refined later.
virtual ~RsRttItem() {}; virtual ~RsRttItem() {}
virtual void clear() {}; virtual void clear() {}
}; };
class RsRttPingItem: public RsRttItem class RsRttPingItem: public RsRttItem
{ {
public: public:
RsRttPingItem() :RsRttItem(RS_PKT_SUBTYPE_RTT_PING) {} RsRttPingItem()
: RsRttItem(RS_PKT_SUBTYPE_RTT_PING)
, mSeqNo(0), mPingTS(0)
{}
virtual ~RsRttPingItem(){} virtual ~RsRttPingItem(){}
virtual void clear(){} virtual void clear(){}
@ -67,7 +70,10 @@ class RsRttPingItem: public RsRttItem
class RsRttPongItem: public RsRttItem class RsRttPongItem: public RsRttItem
{ {
public: public:
RsRttPongItem() :RsRttItem(RS_PKT_SUBTYPE_RTT_PONG) {} RsRttPongItem()
: RsRttItem(RS_PKT_SUBTYPE_RTT_PONG)
, mSeqNo(0), mPingTS(0), mPongTS(0)
{}
virtual ~RsRttPongItem(){} virtual ~RsRttPongItem(){}
virtual void clear(){} virtual void clear(){}