From f26348b71028d3c3d5383d66c9f070fc46efda4e Mon Sep 17 00:00:00 2001
From: csoler <csoler@users.sourceforge.net>
Date: Tue, 5 Apr 2016 18:09:02 -0400
Subject: [PATCH] fixed bug in grouter which caused sending of messages to some
 offline peers, hence wasting some routes, and causing " 
 p3ServiceServer::sendItem() Fails Filtering for packet id=2001810" messages.

---
 libretroshare/src/grouter/p3grouter.cc | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/libretroshare/src/grouter/p3grouter.cc b/libretroshare/src/grouter/p3grouter.cc
index ce69328f6..2770b52dd 100644
--- a/libretroshare/src/grouter/p3grouter.cc
+++ b/libretroshare/src/grouter/p3grouter.cc
@@ -1141,24 +1141,30 @@ void p3GRouter::locked_collectAvailableFriends(const GRouterKeyId& gxs_id,const
 
     for(uint32_t i=0;i<tmp_peers.size();++i)
 	    if(incoming_routes.find(tmp_peers[i]) != incoming_routes.end())
-		 {
+	    {
 #ifdef GROUTER_DEBUG
 		    std::cerr << "  removing " << tmp_peers[i] << " which is an incoming route" << std::endl;
 #endif
-		 }
+	    }
+    	    else if(online_ids.find(tmp_peers[i]) == online_ids.end())
+            {
+#ifdef GROUTER_DEBUG
+		    std::cerr << "  removing " << tmp_peers[i] << " because it is offline now!" << std::endl;
+#endif
+            }
 	    else if(probas[i] < RS_GROUTER_PROBABILITY_THRESHOLD_BEST_PEERS_SELECT*max_probability)
-		 {
+	    {
 #ifdef GROUTER_DEBUG
 		    std::cerr << "  removing " << tmp_peers[i] << " because probability is below best peers threshold" << std::endl;
 #endif
-		 }
+	    }
 	    else
-            {
+	    {
 		    tmp_peers[count] = tmp_peers[i] ;
 		    probas[count] = (max_probability==0.0)? (0.5+0.001*RSRandom::random_f32()) : probas[i] ;
-            		++count ;
-            }
-    
+		    ++count ;
+	    }
+
     tmp_peers.resize(count) ;
     probas.resize(count) ;