Merge pull request #491 from G10h4ck/warnings_cleanup

fix compiler warnings, fix typos and remove unuseful code

libbitdht/src/udp/udplayer.cc

@@ -243,74 +243,66 @@ void UdpLayer::run()
 /* higher level interface */
 void UdpLayer::recv_loop()
 {
-	int maxsize = 16000;
+	size_t maxsize = 16000;
 	void *inbuf = malloc(maxsize);
 
-    	if(inbuf == NULL)
+	if(inbuf == NULL)
-        {
+	{
-            std::cerr << "(EE) Error in memory allocation of size " << maxsize << " in " << __PRETTY_FUNCTION__ << std::endl;
+		std::cerr << "(EE) Error in memory allocation of size " << maxsize
-            return ;
+		          << " in " << __PRETTY_FUNCTION__ << std::endl;
-        }
+		return;
-        
+	}
-        int status;
+
-        struct timeval timeout;
+	int status;
+	struct timeval timeout;
 
 	while(1)
 	{
-                fd_set rset;
+		for(;;)
-                for(;;) 
 		{
 			/* check if we need to stop */
 			bool toStop = false;
 			{
-				bdStackMutex stack(sockMtx);   /********** LOCK MUTEX *********/
+				bdStackMutex stack(sockMtx); (void) stack;
 				toStop = stopThread;
 			}
-			
+
 			if (toStop)
 			{
 #ifdef DEBUG_UDP_LAYER
 				std::cerr << "UdpLayer::recv_loop() stopping thread" << std::endl;
 #endif
-                free(inbuf) ;
+				free(inbuf);
 				stop();
+				return; // Avoid compiler warning about usage of inbuf after free
 			}
 
-                        FD_ZERO(&rset);
+			fd_set rset;
-                        FD_SET(sockfd, &rset);
+			FD_ZERO(&rset);
-                        timeout.tv_sec = 0;
+			FD_SET(sockfd, &rset);
-                        timeout.tv_usec = 500000;       /* 500 ms timeout */
+			timeout.tv_sec = 0;
-                        status = select(sockfd+1, &rset, NULL, NULL, &timeout);
+			timeout.tv_usec = 500000; // 500 ms timeout
-                        if (status > 0)
+			status = select(sockfd+1, &rset, NULL, NULL, &timeout);
-			{
+			if (status > 0) break; // data available, go read it
-                                break;  /* data available, go read it */
-                        } 
-			else if (status < 0) 
-			{
 #ifdef DEBUG_UDP_LAYER
-                                std::cerr << "UdpLayer::recv_loop() Error: " << bdnet_errno() << std::endl;
+			else if (status < 0) std::cerr << "UdpLayer::recv_loop() Error: "
+			                               << bdnet_errno() << std::endl;
 #endif
-                        }
+		};
-                };      
 
-		int nsize = maxsize;
+		int nsize = static_cast<int>(maxsize);
 		struct sockaddr_in from;
 		if (0 < receiveUdpPacket(inbuf, &nsize, from))
 		{
 #ifdef DEBUG_UDP_LAYER
-			std::cerr << "UdpLayer::readPkt()  from : " << from << std::endl;
+			std::cerr << "UdpLayer::readPkt()  from : " << from << std::endl
-			std::cerr << printPkt(inbuf, nsize);
+			          << printPkt(inbuf, nsize);
 #endif
-			// send to reciever.
+			recv->recvPkt(inbuf, nsize, from); // pass to reciever.
-			recv -> recvPkt(inbuf, nsize, from);
 		}
-		else
-		{
 #ifdef DEBUG_UDP_LAYER
-			std::cerr << "UdpLayer::readPkt() not ready" << from;
+		else std::cerr << "UdpLayer::readPkt() not ready" << from << std::endl;
-			std::cerr << std::endl;
 #endif
-		}
 	}
 }
 

libretroshare/src/libretroshare.pro

@@ -276,7 +276,7 @@ mac {
                 DEFINES *= MINIUPNPC_VERSION=13
 
 		CONFIG += upnp_miniupnpc
-		CONFIG += c+11
+                CONFIG += c++11
 
 		# zeroconf disabled at the end of libretroshare.pro (but need the code)
 		#CONFIG += zeroconf

libretroshare/src/serialiser/rsserial.h

@@ -178,32 +178,21 @@ std::ostream &printIndent(std::ostream &out, uint16_t indent);
 
 class RsRawItem: public RsItem
 {
-	public:
+public:
-		RsRawItem(uint32_t t, uint32_t size)
+	RsRawItem(uint32_t t, uint32_t size) : RsItem(t), len(size)
-			:RsItem(t), len(size)
+	{ data = rs_malloc(len); }
-		{ 
+	virtual ~RsRawItem() { free(data); }
-			data = rs_malloc(len);
-		}
 
-		virtual ~RsRawItem()
+	uint32_t getRawLength() { return len; }
-		{
+	void * getRawData() { return data; }
-			if (data)
-				free(data);
-			data = NULL;
-			len = 0;
-		}
 
-		uint32_t	getRawLength() { return len; }
+	virtual void clear() {}
-		void  *getRawData() { return data; }
+	virtual std::ostream &print(std::ostream &out, uint16_t indent = 0);
 
-		virtual void clear() { return; } /* what can it do? */
+private:
-		virtual std::ostream &print(std::ostream &out, uint16_t indent = 0);
+	void *data;
-
+	uint32_t len;
-	private:
-		void *data;
-		uint32_t len;
 };
 
 
-
 #endif /* RS_BASE_SERIALISER_H */

retroshare.pri

@@ -84,7 +84,7 @@ macx {
 		message(***retroshare.pri: No SDK, set it to MacOS 10.10 )
 		QMAKE_MAC_SDK = macosx10.10
 	}
-	CONFIG += c+11
+        CONFIG += c++11
 }
 
 unfinished {