Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-06-29 08:37:36 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed uninitialized memory read and inconsistent initialization of mReputationScore in GxsReputation

Browse source
This commit is contained in:
csoler 2019-12-23 11:52:32 +01:00
parent 71149935f9
commit dc3624945f
No known key found for this signature in database
GPG key ID: 7BCA522266C0804C
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
libretroshare/src/services/p3gxsreputation.h
View file

@ -65,12 +65,14 @@ class Reputation
{ {
public: public:
Reputation() : Reputation() :
mOwnOpinion(static_cast<int32_t>(RsOpinion::NEUTRAL)), mOwnOpinionTs(0), mOwnOpinion(static_cast<int32_t>(RsOpinion::NEUTRAL)),
mOwnOpinionTs(0),
mFriendAverage(1.0f), mFriendAverage(1.0f),
/* G10h4ck: TODO shouln't this be initialized with mFriendsPositive(0),
* RsReputation::NEUTRAL or UNKOWN? */ mFriendsNegative(0),
mReputationScore(static_cast<float>(RsOpinion::NEUTRAL)), mReputationScore(1.0f),
mIdentityFlags(0) {} mIdentityFlags(0),
mLastUsedTS(0) {}
void updateReputation(); void updateReputation();