* Fixed up various memory leaks (mainly serialiser cleanup).

* Added pthread_detach() to allow proper thread cleanup (affected ony Linux!)



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@460 b45a01b8-16f6-495d-af2f-9b41ad6348cc

libretroshare/src/dht/dht_bootstrap.cc

@@ -217,6 +217,7 @@ void	stunPeer(std::string id, struct sockaddr_in peeraddr)
 
         void *data = (void *) pub;
         pthread_create(&tid, 0, &doStunPeer, data);
+	pthread_detach(tid);
 
         return;
 
@@ -361,6 +362,7 @@ int main(int argc, char **argv)
 
 #endif
 
+	srand(time(NULL)); /* randomise! */
 
 	if (!setOwnId)
 	{

libretroshare/src/dht/opendhtmgr.cc

@@ -179,6 +179,7 @@ bool OpenDHTMgr::publishDHT(std::string key, std::string value, uint32_t ttl)
 
         void *data = (void *) pub;
 	pthread_create(&tid, 0, &doDhtPublish, data);
+	pthread_detach(tid); /* so memory is reclaimed in linux */
 
 	return true;
 }
@@ -195,6 +196,7 @@ bool OpenDHTMgr::searchDHT(std::string key)
 
         void *data = (void *) dht;
 	pthread_create(&tid, 0, &doDhtSearch, data);
+	pthread_detach(tid); /* so memory is reclaimed in linux */
 
 	return true;
 }

libretroshare/src/pqi/p3cfgmgr.cc

@@ -185,6 +185,8 @@ void	p3ConfigMgr::saveConfiguration()
 #endif
 	}
 
+	delete signbio;
+
 
 }
 
@@ -332,6 +334,7 @@ void	p3ConfigMgr::loadConfiguration()
 		}
 	}
 
+	delete item;
 
 #ifdef CONFIG_DEBUG 
 	std::cerr << "p3ConfigMgr::loadConfiguration() Done!";

libretroshare/src/pqi/pqiarchive.cc

@@ -113,6 +113,9 @@ pqiarchive::~pqiarchive()
 	  delete bio;
 	}
 
+	if (rsSerialiser)
+		delete rsSerialiser;
+
 	if (nextPkt)
 	{
 		delete nextPkt;

libretroshare/src/pqi/pqibin.cc

@@ -88,6 +88,11 @@ BinFileInterface::~BinFileInterface()
 	{
 		fclose(buf);
 	}
+
+	if (hash)
+	{
+		delete hash;
+	}
 }
 
 int BinFileInterface::close()
@@ -183,11 +188,14 @@ BinMemInterface::BinMemInterface(const void *data, const int defsize, int flags)
 	}
 
 BinMemInterface::~BinMemInterface() 
-	{ 
-		if (buf)
-			free(buf);
-		return; 
-	}
+{ 
+	if (buf)
+		free(buf);
+
+	if (hash)
+		delete hash;
+	return; 
+}
 
 int BinMemInterface::close()
 {

libretroshare/src/pqi/pqihash.h

@@ -40,6 +40,13 @@ class pqihash
 	doHash = true;
 }
 
+	~pqihash()
+{
+	delete[] sha_hash;
+	delete sha_ctx;
+}
+
+
 void    addData(void *data, uint32_t len)
 {
 	if (doHash)
@@ -68,9 +75,6 @@ void 	Complete(std::string &hash)
 	hash = endHash;
 	doHash = false;
 
-	delete []sha_hash;
-	delete sha_ctx;
-
 	return;
 }
 

libretroshare/src/pqi/pqistreamer.cc

@@ -104,6 +104,10 @@ pqistreamer::~pqistreamer()
 	  delete bio;
 	}
 
+	/* clean up serialiser */
+	if (rsSerialiser)
+		delete rsSerialiser;
+
 	// clean up outgoing. (cntrl packets)
 	while(out_pkt.size() > 0)
 	{

libretroshare/src/rsserver/p3face-file.cc

@@ -102,6 +102,7 @@ int     RsServer::UpdateAllTransfers()
 		ti.downloadStatus = (*it) -> state;
 		transfers.push_back(ti);
 
+		delete (*it); 
 	}
 
         iface.setChanged(RsIface::Transfer);

libretroshare/src/services/p3ranking.cc

@@ -459,6 +459,7 @@ void p3Ranking::addRankMsg(RsRankLinkMsg *msg)
 	}
 	else
 	{
+		delete msg;
 #ifdef RANK_DEBUG
 		std::cerr << "p3Ranking::addRankMsg() Old Comment ignoring";
 		std::cerr << std::endl;