From cd433e82fd7763d7eb76c9f03305a5d06b01a8d4 Mon Sep 17 00:00:00 2001 From: csoler Date: Thu, 4 Aug 2016 22:33:45 +0200 Subject: [PATCH] fixed bug causing uninitialised memory read in reputation changing --- libretroshare/src/services/p3idservice.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libretroshare/src/services/p3idservice.cc b/libretroshare/src/services/p3idservice.cc index 450e410f5..be8f8ba54 100644 --- a/libretroshare/src/services/p3idservice.cc +++ b/libretroshare/src/services/p3idservice.cc @@ -548,7 +548,7 @@ bool p3IdService::getIdDetails(const RsGxsId &id, RsIdentityDetails &details) // This step is needed, because p3GxsReputation does not know all identities, and might not have any data for // the ones in the contact list. So we change them on demand. - if((details.mFlags & RS_IDENTITY_FLAGS_IS_A_CONTACT) && rsReputations->nodeAutoPositiveOpinionForContacts()) + if(mContacts.find(id) != mContacts.end() && rsReputations->nodeAutoPositiveOpinionForContacts()) rsReputations->setOwnOpinion(id,RsReputations::OPINION_POSITIVE) ; details = data.details;