From c9a92bc58a84160981d07677adf2643540aeb3a3 Mon Sep 17 00:00:00 2001
From: csoler <csoler@users.sourceforge.net>
Date: Thu, 28 Jan 2021 21:14:43 +0100
Subject: [PATCH] added last seen display info in circles to help debugging
 auto-cleaning of circles

---
 libretroshare/src/gxs/rsgenexchange.cc         |  7 ++++++-
 libretroshare/src/gxs/rsgenexchange.h          |  2 +-
 libretroshare/src/retroshare/rsgxsifacetypes.h |  7 ++++---
 libretroshare/src/services/p3gxscircles.cc     | 14 ++++++++++++++
 libretroshare/src/services/p3gxscircles.h      |  1 +
 retroshare-gui/src/gui/Identity/IdDialog.cpp   |  7 ++++++-
 6 files changed, 32 insertions(+), 6 deletions(-)

diff --git a/libretroshare/src/gxs/rsgenexchange.cc b/libretroshare/src/gxs/rsgenexchange.cc
index af0e83fc3..4439f4807 100644
--- a/libretroshare/src/gxs/rsgenexchange.cc
+++ b/libretroshare/src/gxs/rsgenexchange.cc
@@ -1379,7 +1379,12 @@ bool RsGenExchange::getGroupMeta(const uint32_t &token, std::list<RsGroupMetaDat
 		{
 			m.mPop= 0 ;
 			m.mVisibleMsgCount = 0 ;
-		}
+        }
+
+        // We could save this in the net service, but it's a bit more than that since some services have
+        // specific usage footprints for their groups.
+
+        m.mLastSeen = (IS_GROUP_SUBSCRIBED(gMeta.mSubscribeFlags)) ? time(nullptr) : service_getLastGroupUsageTs(gMeta.mGroupId);
 
 		groupInfo.push_back(m);
 	}
diff --git a/libretroshare/src/gxs/rsgenexchange.h b/libretroshare/src/gxs/rsgenexchange.h
index 9551cc652..ed190ff56 100644
--- a/libretroshare/src/gxs/rsgenexchange.h
+++ b/libretroshare/src/gxs/rsgenexchange.h
@@ -666,7 +666,7 @@ protected:
      * 			that the group is always in use.
      */
     virtual bool service_checkIfGroupIsStillUsed(const RsGxsGrpMetaData& /* meta */) { return true; }	// see RsGenExchange
-
+    virtual rstime_t service_getLastGroupUsageTs(const RsGxsGroupId&) { return 0; }
 public:
 
     /*!
diff --git a/libretroshare/src/retroshare/rsgxsifacetypes.h b/libretroshare/src/retroshare/rsgxsifacetypes.h
index dbd071987..0f78b3738 100644
--- a/libretroshare/src/retroshare/rsgxsifacetypes.h
+++ b/libretroshare/src/retroshare/rsgxsifacetypes.h
@@ -88,9 +88,10 @@ struct RsGroupMetaData : RsSerializable
 
     uint32_t    mSubscribeFlags;
 
-    uint32_t    mPop; 			// Popularity = number of friend subscribers
-    uint32_t    mVisibleMsgCount; 	// Max messages reported by friends
-    rstime_t      mLastPost; 		// Timestamp for last message. Not used yet.
+    uint32_t    mPop; 			   // Popularity = number of friend subscribers
+    uint32_t    mVisibleMsgCount;  // Max messages reported by friends
+    rstime_t    mLastPost; 		   // Timestamp for last message. Not used yet.
+    rstime_t    mLastSeen; 		   // Last time the group was advertised by friends.
 
     uint32_t    mGroupStatus;
 
diff --git a/libretroshare/src/services/p3gxscircles.cc b/libretroshare/src/services/p3gxscircles.cc
index 24bc7c096..60c264321 100644
--- a/libretroshare/src/services/p3gxscircles.cc
+++ b/libretroshare/src/services/p3gxscircles.cc
@@ -1700,6 +1700,20 @@ bool p3GxsCircles::locked_checkCircleCacheForAutoSubscribe(RsGxsCircleCache& cac
     return true;
 }
 
+rstime_t p3GxsCircles::service_getLastGroupUsageTs(const RsGxsGroupId& gid)
+{
+    rstime_t now = time(nullptr);
+
+    RS_STACK_MUTEX(mKnownCirclesMtx);
+
+    auto it = mKnownCircles.find(gid);
+    bool unknown_posted = (it == mKnownCircles.end());
+
+    if(unknown_posted)
+        return now;
+    else
+        return it->second;
+}
 bool p3GxsCircles::service_checkIfGroupIsStillUsed(const RsGxsGrpMetaData& meta)
 {
 #ifdef GXSFORUMS_CHANNELS
diff --git a/libretroshare/src/services/p3gxscircles.h b/libretroshare/src/services/p3gxscircles.h
index 8bdce3756..2fb2429ee 100644
--- a/libretroshare/src/services/p3gxscircles.h
+++ b/libretroshare/src/services/p3gxscircles.h
@@ -290,6 +290,7 @@ public:
 	virtual void updateGroup(uint32_t &token, RsGxsCircleGroup &group) override;
 
 	virtual bool service_checkIfGroupIsStillUsed(const RsGxsGrpMetaData& meta) override;
+    virtual rstime_t service_getLastGroupUsageTs(const RsGxsGroupId&) override;
 
 	/* membership management for external circles */
 
diff --git a/retroshare-gui/src/gui/Identity/IdDialog.cpp b/retroshare-gui/src/gui/Identity/IdDialog.cpp
index bffed9508..4e319860b 100644
--- a/retroshare-gui/src/gui/Identity/IdDialog.cpp
+++ b/retroshare-gui/src/gui/Identity/IdDialog.cpp
@@ -695,7 +695,12 @@ void IdDialog::loadCircles(const std::list<RsGroupMetaData>& groupInfo)
 		if(am_I_subscribed)
 			tooltip += tr("subscribed (Receive/forward membership requests from others and invite list).") ;
 		else
-			tooltip += tr("unsubscribed (Only receive invite list).") ;
+        {
+            if(vit->mLastSeen>0)
+                tooltip += tr("unsubscribed (Only receive invite list). Last seen: %1 days ago.").arg( (time(nullptr)-vit->mLastSeen)/86400 );
+            else
+                tooltip += tr("unsubscribed (Only receive invite list).");
+        }
 
 		tooltip += "\n"+tr("Your status: ") ;