Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-01-15 01:17:16 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #1397 from G10h4ck/htofix_rsGetHostByName_v0.6.5

Browse Source 
Fix DNS resolution for hostnames that has also AAAA record
This commit is contained in:
G10h4ck 2018-11-09 11:09:21 +01:00 committed by GitHub
commit c073cc425d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
libretroshare/src/util/rsnet.cc
View File

@ -31,6 +31,8 @@
#include <netdb.h> #include <netdb.h>
#endif #endif
#include <cstring>
/* enforce LITTLE_ENDIAN on Windows */ /* enforce LITTLE_ENDIAN on Windows */
#ifdef WINDOWS_SYS #ifdef WINDOWS_SYS
#define BYTE_ORDER 1234 #define BYTE_ORDER 1234
@ -76,55 +78,25 @@ void sockaddr_clear(struct sockaddr_in *addr)
bool rsGetHostByName(const std::string& hostname, in_addr& returned_addr) bool rsGetHostByName(const std::string& hostname, in_addr& returned_addr)
{ {
addrinfo *info = NULL; addrinfo hint; memset(&hint, 0, sizeof(hint));
int res = getaddrinfo(hostname.c_str(),NULL,NULL,&info) ; hint.ai_family = AF_INET;
addrinfo* info = nullptr;
int res = getaddrinfo(hostname.c_str(), nullptr, &hint, &info);
bool ok = true; bool ok = true;
if(res > 0 || info == NULL || info->ai_addr == NULL) if(res > 0 || !info || !info->ai_addr)
{ {
std::cerr << "(EE) getaddrinfo returned error " << res << " on string \"" << hostname << "\"" << std::endl; std::cerr << __PRETTY_FUNCTION__ << "(EE) getaddrinfo returned error "
returned_addr.s_addr = 0 ; << res << " on string \"" << hostname << "\"" << std::endl;
ok = false; returned_addr.s_addr = 0;
} ok = false;
else }
returned_addr.s_addr = ((sockaddr_in*)info->ai_addr)->sin_addr.s_addr ; else
returned_addr.s_addr = ((sockaddr_in*)info->ai_addr)->sin_addr.s_addr;
if(info) if(info) freeaddrinfo(info);
freeaddrinfo(info) ;
#ifdef DEPRECATED_TO_REMOVE return ok;
#if defined(WINDOWS_SYS) || defined(__APPLE__) || defined(__HAIKU__)
hostent *result = gethostbyname(hostname.c_str()) ;
#else
RsTemporaryMemory mem(8192) ;
if(!mem)
{
std::cerr << __PRETTY_FUNCTION__ << ": Cannot allocate memory!" << std::endl;
return false; // Do something.
}
int error = 0;
struct hostent pHost;
struct hostent *result;
if(gethostbyname_r(hostname.c_str(), &pHost, (char*)(unsigned char*)mem, mem.size(), &result, &error) != 0)
{
std::cerr << __PRETTY_FUNCTION__ << ": cannot call gethostname_r. Internal error reported. Check buffer size." << std::endl;
return false ;
}
#endif
if(!result)
{
std::cerr << __PRETTY_FUNCTION__ << ": gethostname returned null result." << std::endl;
return false ;
}
// Use contents of result.
returned_addr.s_addr = *(unsigned long*) (result->h_addr);
#endif
return ok;
} }
bool isValidNet(const struct in_addr *addr) bool isValidNet(const struct in_addr *addr)