- Removed not used members from RsGenExchange and p3IdService

- Fixed memory leaks in p3PostBase

git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7425 b45a01b8-16f6-495d-af2f-9b41ad6348cc

libretroshare/src/gxs/rsgenexchange.h

@@ -526,30 +526,30 @@ protected:
      * Ownership of item passes to this rsgenexchange \n
      * @param token
      * @param grpItem
-     */
-    void publishGroup(uint32_t& token, RsGxsGrpItem* grpItem);
-
-    /*!
-     * Updates an existing group item \n
-     * This will induce a related change message \n
+     */
+    void publishGroup(uint32_t& token, RsGxsGrpItem* grpItem);
+
+    /*!
+     * Updates an existing group item \n
+     * This will induce a related change message \n
      * Ownership of item passes to this rsgenexchange \n
      * @param token
      * @param grpItem
-     */
-    void updateGroup(uint32_t& token, RsGxsGrpItem* grpItem);
-
-    /*!
-     * Deletes an existing group item \n
-     * This will induce a related change message \n
-     * Ownership of item passes to this rsgenexchange \n
-     * @param token
-     * @param grpItem
-     */
-    void deleteGroup(uint32_t& token, RsGxsGrpItem* grpItem);
-
-public:
-    /*!
-     * Enables publication of a message item \n
+     */
+    void updateGroup(uint32_t& token, RsGxsGrpItem* grpItem);
+
+    /*!
+     * Deletes an existing group item \n
+     * This will induce a related change message \n
+     * Ownership of item passes to this rsgenexchange \n
+     * @param token
+     * @param grpItem
+     */
+    void deleteGroup(uint32_t& token, RsGxsGrpItem* grpItem);
+
+public:
+    /*!
+     * Enables publication of a message item \n
      * Setting mOrigMsgId meta member to blank \n
      * leads to this msg being an original msg \n
      * if mOrigMsgId is not blank the msgId then this msg is \n
@@ -659,14 +659,14 @@ private:
     void processRecvdGroups();
 
     void publishGrps();
-
-    void processGroupUpdatePublish();
-
-		void processGroupDelete();
-
-    void publishMsgs();
-
-    /*!
+
+    void processGroupUpdatePublish();
+
+		void processGroupDelete();
+
+    void publishMsgs();
+
+    /*!
      * processes msg local meta changes
      */
     void processMsgMetaChanges();
@@ -863,7 +863,6 @@ private:
 
 private:
 
-    std::vector<RsGxsNotify*> mChanges;
     std::vector<RsGxsGroupChange*> mGroupChange;
     std::vector<RsGxsMsgChange*> mMsgChange;
 
@@ -874,11 +873,11 @@ private:
 private:
 
     std::vector<GroupUpdate> mGroupUpdates, mPeersGroupUpdate;
-
-    std::vector<GroupUpdatePublish> mGroupUpdatePublish;
-
-		std::vector<GroupDeletePublish> mGroupDeletePublish;
-
-};
-
-#endif // RSGENEXCHANGE_H
+
+    std::vector<GroupUpdatePublish> mGroupUpdatePublish;
+
+		std::vector<GroupDeletePublish> mGroupDeletePublish;
+
+};
+
+#endif // RSGENEXCHANGE_H

libretroshare/src/services/p3idservice.h

@@ -476,9 +476,6 @@ std::string genRandomId(int len = 20);
  * Other Data that is protected by the Mutex.
  */
 
-	std::vector<RsGxsGroupChange*> mGroupChange;
-	std::vector<RsGxsMsgChange*> mMsgChange;
-
 	private:
 
 	std::map<uint32_t, std::set<RsGxsGroupId> > mIdsPendingCache;

libretroshare/src/services/p3postbase.cc

@@ -534,6 +534,10 @@ void p3PostBase::background_loadMsgs(const uint32_t &token, bool unprocessed)
 		changes.push_back(msgChanges);
 	 	receiveHelperChanges(changes);
 	}
+	else
+	{
+		delete(msgChanges);
+	}
 
 	/* request the summary info from the parents */
 	uint32_t token_b;
@@ -669,6 +673,10 @@ void p3PostBase::background_updateVoteCounts(const uint32_t &token)
 		changes.push_back(msgChanges);
 	 	receiveHelperChanges(changes);
 	}
+	else
+	{
+		delete(msgChanges);
+	}
 
 	// DONE!.
 	background_cleanup();