Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-05-13 11:32:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

optim: changed postfixed ++ into prefix++ for non trivial operators, replaced test on std::list::size() by std::list::empty() (Patch from Phenom, modified)

Browse source 
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7627 b45a01b8-16f6-495d-af2f-9b41ad6348cc
This commit is contained in:
csoler 2014-10-21 22:33:02 +00:00
parent 491a655889
commit b593a918a0
99 changed files with 571 additions and 571 deletions
Download patch file Download diff file Expand all files Collapse all files

30
retroshare-gui/src/gui/gxsforums/GxsForumThreadWidget.cpp
View file

@ -379,17 +379,17 @@ void GxsForumThreadWidget::threadListCustomPopupMenu(QPoint /*point*/)
QList<QTreeWidgetItem*> rowsUnread;
int nCount = getSelectedMsgCount(&rows, &rowsRead, &rowsUnread);
if (rowsUnread.size() == 0) {
if (rowsUnread.isEmpty()) {
markMsgAsRead->setDisabled(true);
}
if (rowsRead.size() == 0) {
if (rowsRead.isEmpty()) {
markMsgAsUnread->setDisabled(true);
}
bool hasUnreadChildren = false;
bool hasReadChildren = false;
int rowCount = rows.count();
for (int i = 0; i < rowCount; i++) {
for (int i = 0; i < rowCount; ++i) {
if (hasUnreadChildren || rows[i]->data(COLUMN_THREAD_DATA, ROLE_THREAD_UNREADCHILDREN).toBool()) {
hasUnreadChildren = true;
}
@ -523,7 +523,7 @@ void GxsForumThreadWidget::forumMsgReadStatusChanged(const QString &forumId, con
QTreeWidgetItemIterator itemIterator(ui->threadTreeWidget);
QTreeWidgetItem *item = NULL;
while ((item = *itemIterator) != NULL) {
itemIterator++;
++itemIterator;
if (item->data(COLUMN_THREAD_DATA, ROLE_THREAD_MSGID).toString() == msgId) {
// update status
@ -616,7 +616,7 @@ void GxsForumThreadWidget::calculateUnreadCount()
QTreeWidgetItemIterator itemIterator(ui->threadTreeWidget);
QTreeWidgetItem *item = NULL;
while ((item = *itemIterator) != NULL) {
itemIterator++;
++itemIterator;
uint32_t status = item->data(COLUMN_THREAD_DATA, ROLE_THREAD_STATUS).toUInt();
if (IS_MSG_UNREAD(status)) {
@ -665,7 +665,7 @@ void GxsForumThreadWidget::calculateIconsAndFonts(QTreeWidgetItem *item /*= NULL
static void cleanupItems (QList<QTreeWidgetItem *> &items)
{
QList<QTreeWidgetItem *>::iterator item;
for (item = items.begin (); item != items.end (); item++) {
for (item = items.begin (); item != items.end (); ++item) {
if (*item) {
delete (*item);
}
@ -727,7 +727,7 @@ void GxsForumThreadWidget::fillThreadFinished()
QTreeWidgetItemIterator itemIterator(ui->threadTreeWidget);
QTreeWidgetItem *item = NULL;
while ((item = *itemIterator) != NULL) {
itemIterator++;
++itemIterator;
if (item->data(COLUMN_THREAD_DATA, ROLE_THREAD_MSGID).toString().toStdString() == thread->mFocusMsgId) {
ui->threadTreeWidget->setCurrentItem(item);
@ -1003,7 +1003,7 @@ void GxsForumThreadWidget::fillThreads(QList<QTreeWidgetItem *> &threadList, boo
}
}
if (found >= 0) {
index++;
++index;
} else {
delete(ui->threadTreeWidget->takeTopLevelItem(index));
}
@ -1083,7 +1083,7 @@ void GxsForumThreadWidget::fillChildren(QTreeWidgetItem *parentItem, QTreeWidget
}
}
if (found >= 0) {
index++;
++index;
} else {
delete(parentItem->takeChild (index));
}
@ -1312,7 +1312,7 @@ void GxsForumThreadWidget::nextUnreadMessage()
QTreeWidgetItem *item;
while ((item = *itemIterator) != NULL) {
itemIterator++;
++itemIterator;
if (item == currentItem) {
continue;
@ -1360,7 +1360,7 @@ int GxsForumThreadWidget::getSelectedMsgCount(QList<QTreeWidgetItem*> *rows, QLi
if (rowsUnread) rowsUnread->clear();
QList<QTreeWidgetItem*> selectedItems = ui->threadTreeWidget->selectedItems();
for(QList<QTreeWidgetItem*>::iterator it = selectedItems.begin(); it != selectedItems.end(); it++) {
for(QList<QTreeWidgetItem*>::iterator it = selectedItems.begin(); it != selectedItems.end(); ++it) {
if (rows) rows->append(*it);
if (rowsRead || rowsUnread) {
uint32_t status = (*it)->data(COLUMN_THREAD_DATA, ROLE_THREAD_STATUS).toUInt();
@ -1423,7 +1423,7 @@ void GxsForumThreadWidget::setMsgReadStatus(QList<QTreeWidgetItem*> &rows, bool
mInMsgAsReadUnread = false;
if (changedItems.size()) {
for (std::list<QTreeWidgetItem*>::iterator it = changedItems.begin(); it != changedItems.end(); it++) {
for (std::list<QTreeWidgetItem*>::iterator it = changedItems.begin(); it != changedItems.end(); ++it) {
calculateIconsAndFonts(*it);
}
//#TODO updateMessageSummaryList(mForumId);
@ -1441,7 +1441,7 @@ void GxsForumThreadWidget::markMsgAsReadUnread (bool read, bool children, bool f
QList<QTreeWidgetItem*> rows;
if (forum) {
int itemCount = ui->threadTreeWidget->topLevelItemCount();
for (int item = 0; item < itemCount; item++) {
for (int item = 0; item < itemCount; ++item) {
rows.push_back(ui->threadTreeWidget->topLevelItem(item));
}
} else {
@ -1462,7 +1462,7 @@ void GxsForumThreadWidget::markMsgAsReadUnread (bool read, bool children, bool f
allRows.append(row);
}
for (int i = 0; i < row->childCount(); i++) {
for (int i = 0; i < row->childCount(); ++i) {
/* add child to main list and let the main loop do the work */
rows.append(row->child(i));
}
@ -1680,7 +1680,7 @@ bool GxsForumThreadWidget::filterItem(QTreeWidgetItem *item, const QString &text
int count = item->childCount();
for (int nIndex = 0; nIndex < count; ++nIndex) {
if (filterItem(item->child(nIndex), text, filterColumn)) {
visibleChildCount++;
++visibleChildCount;
}
}