- Split majority of p3posted into p3postbase.cc - so that it can be reused by other services.

- Fixed iterator overflow into rsgxsupdateitems.cc
 - Fixed Mutex deadlock in pqiperson.cc
 - Removed old code.
 - Fixed lots of compile warnings - mainly wrong variable ordering in constructors.




git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.6-initdev@7044 b45a01b8-16f6-495d-af2f-9b41ad6348cc

libretroshare/src/pqi/pqiperson.cc

@@ -151,7 +151,7 @@ int	pqiperson::tick()
 				out += " No Heartbeat & No Packets -> assume dead. calling pqissl::reset()";
 				pqioutput(PQL_WARNING, pqipersonzone, out);
 	            	
-				this->reset();
+				this->reset_locked();
 			}
 	
 		}
@@ -384,6 +384,11 @@ int 	pqiperson::reset()
 {
 	RsStackMutex stack(mPersonMtx); /**** LOCK MUTEX ****/
 
+	return reset_locked();
+}
+
+int 	pqiperson::reset_locked()
+{
 	pqioutput(PQL_WARNING, pqipersonzone, "pqiperson::reset() resetting all pqiconnect for Id: " + PeerId());
 
 	std::map<uint32_t, pqiconnect *>::iterator it;