- Split majority of p3posted into p3postbase.cc - so that it can be reused by other services.

- Fixed iterator overflow into rsgxsupdateitems.cc
 - Fixed Mutex deadlock in pqiperson.cc
 - Removed old code.
 - Fixed lots of compile warnings - mainly wrong variable ordering in constructors.




git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.6-initdev@7044 b45a01b8-16f6-495d-af2f-9b41ad6348cc

libretroshare/src/gxs/rsgxsdataaccess.h

@@ -436,11 +436,13 @@ private:
 private:
 
     RsGeneralDataService* mDataStore;
+
+    RsMutex mDataMutex; /* protecting below */
+
     uint32_t mNextToken;
     std::map<uint32_t, uint32_t> mPublicToken;
     std::map<uint32_t, GxsRequest*> mRequests;
 
-    RsMutex mDataMutex;
 
 
 };

libretroshare/src/gxs/rsgxsnetservice.cc

@@ -1646,10 +1646,13 @@ void RsGxsNetService::locked_genReqGrpTransaction(NxsTransaction* tr)
 		RsNxsSyncGrpItem*& grpSyncItem = *llit;
 		const std::string& grpId = grpSyncItem->grpId;
 		metaIter = grpMetaMap.find(grpId);
-		bool haveItem = metaIter != grpMetaMap.end();
+		bool haveItem = false;
 		bool latestVersion = false;
-
-		latestVersion = grpSyncItem->publishTs > metaIter->second->mPublishTs;
+		if (metaIter != grpMetaMap.end())
+		{
+			haveItem = true;
+			latestVersion = grpSyncItem->publishTs > metaIter->second->mPublishTs;
+		}
 
 		if(!haveItem || (haveItem && latestVersion) ){
 

libretroshare/src/gxs/rsgxsutil.h

@@ -143,7 +143,7 @@ class GroupUpdatePublish
 {
 public:
         GroupUpdatePublish(RsGxsGrpItem* item, RsGxsGroupUpdateMeta updateMeta, uint32_t token)
-            : grpItem(item),  mToken(token), mUpdateMeta(updateMeta) {}
+            : grpItem(item), mUpdateMeta(updateMeta), mToken(token) {}
 	RsGxsGrpItem* grpItem;
         RsGxsGroupUpdateMeta mUpdateMeta;
 	uint32_t mToken;