Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-06-07 14:12:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed formula to compute score based on up/dn votes in comments

Browse source
This commit is contained in:
csoler 2017-11-02 22:20:43 +01:00
parent 42c720fe6e
commit aa4c2090cf
1 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

22
libretroshare/src/services/p3gxscommon.cc
View file

@ -394,18 +394,28 @@ bool p3GxsCommentService::getGxsRelatedComments(const uint32_t &token, std::vect
double p3GxsCommentService::calculateBestScore(int upVotes, int downVotes) double p3GxsCommentService::calculateBestScore(int upVotes, int downVotes)
{ {
static float z = 1.0;
float score; float score;
int n = upVotes - downVotes; int n = upVotes + downVotes;
if(n==0) if(n==0)
{
score = 0.0; score = 0.0;
}
else else
{ {
float phat = upVotes; // See https://github.com/reddit/reddit/blob/master/r2/r2/lib/db/_sorts.pyx#L45 for the source of this nice formula.
score = sqrt(phat+z*z/(2*n)-z*((phat*(1-phat)+z*z/(4*n))/n))/(1+z*z/n); // http://www.evanmiller.org/how-not-to-sort-by-average-rating.html for the mathematical explanation.
float p = upVotes/n;
float z = 1.281551565545 ;
float left = p + 1/(2*n)*z*z ;
float right = z*sqrt(p*(1-p)/n + z*z/(4*n*n)) ;
float under = 1+1/n*z*z ;
score = (left - right)/under ;
//static float z = 1.0;
//score = sqrt(phat+z*z/(2*n)-z*((phat*(1-phat)+z*z/(4*n))/n))/(1+z*z/n);
} }
return score; return score;
} }