Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2024-10-01 02:35:48 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix memory leak in getLocalAddresses

Browse Source
This commit is contained in:
Gio 2015-12-30 22:47:51 +01:00
parent 7486d546d4
commit 9c24203082
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
libretroshare/src/pqi/pqinetwork.cc
View File

@ -306,11 +306,10 @@ bool getLocalAddresses(std::list<sockaddr_storage> & addrs)
IP_ADAPTER_UNICAST_ADDRESS* address; IP_ADAPTER_UNICAST_ADDRESS* address;
for ( address = adapter->FirstUnicastAddress; address; address = address->Next) for ( address = adapter->FirstUnicastAddress; address; address = address->Next)
{ {
sockaddr_storage * tmp = new sockaddr_storage; sockaddr_storage tmp;
sockaddr_storage_clear(*tmp); sockaddr_storage_clear(tmp);
if (sockaddr_storage_copyip(* tmp, * reinterpret_cast<sockaddr_storage*>(address->Address.lpSockaddr))) if (sockaddr_storage_copyip(tmp, * reinterpret_cast<sockaddr_storage*>(address->Address.lpSockaddr)))
addrs.push_back(*tmp); addrs.push_back(tmp);
else delete tmp;
} }
} }
free(adapter_addresses); free(adapter_addresses);
@ -320,11 +319,10 @@ bool getLocalAddresses(std::list<sockaddr_storage> & addrs)
for ( ifa = ifsaddrs; ifa; ifa = ifa->ifa_next ) for ( ifa = ifsaddrs; ifa; ifa = ifa->ifa_next )
if ( ifa->ifa_addr && (ifa->ifa_flags & IFF_UP) ) if ( ifa->ifa_addr && (ifa->ifa_flags & IFF_UP) )
{ {
sockaddr_storage * tmp = new sockaddr_storage; sockaddr_storage tmp;
sockaddr_storage_clear(*tmp); sockaddr_storage_clear(tmp);
if (sockaddr_storage_copyip(* tmp, * reinterpret_cast<sockaddr_storage*>(ifa->ifa_addr))) if (sockaddr_storage_copyip(tmp, * reinterpret_cast<sockaddr_storage*>(ifa->ifa_addr)))
addrs.push_back(*tmp); addrs.push_back(tmp);
else delete tmp;
} }
freeifaddrs(ifsaddrs); freeifaddrs(ifsaddrs);
#endif // WINDOWS_SYS #endif // WINDOWS_SYS