Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-05-20 15:00:36 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix crash if JSON object deserialization

Browse source 
In case an object was expected while another type was got RsSerializable
JSON deserialization code was crashing, this commit solve the crash in
this not so corner case
This commit is contained in:
Gioacchino Mazzurco 2019-01-10 19:06:35 +01:00
parent 993f1e8ada
commit 97633ec8db
No known key found for this signature in database
GPG key ID: A1FBCA3872E87051
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
libretroshare/src/serialiser/rstypeserializer.h
View file

@ -753,6 +753,16 @@ struct RsTypeSerializer
rapidjson::Value& v = jDoc[mName];
if(!v.IsObject())
{
std::cerr << __PRETTY_FUNCTION__ << " \"" << memberName
<< "\" has wrong type in JSON, object expected, got:"
<< std::endl << jDoc << std::endl << std::endl;
print_stacktrace();
ctx.mOk = false;
break;
}
RsGenericSerializer::SerializeContext lCtx(nullptr, 0, ctx.mFlags);
lCtx.mJson.SetObject() = v; // Beware of move semantic!!