Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-01-13 16:39:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixed potential buffer overrun (reported by GuessWho)

Browse Source
This commit is contained in:
Cyril Soler 2015-10-03 10:46:36 -04:00
parent 7fa687a037
commit 9158ed64ef
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libretroshare/src/util/extaddrfinder.cc
View File

@ -104,12 +104,18 @@ static void getPage(const std::string& server_name,std::string& page)
#endif #endif
// envoi // envoi
sprintf( request, if(snprintf( request,
1024,
"GET / HTTP/1.0\r\n" "GET / HTTP/1.0\r\n"
"Host: %s:%d\r\n" "Host: %s:%d\r\n"
"Connection: Close\r\n" "Connection: Close\r\n"
"\r\n", "\r\n",
server_name.c_str(), 80); server_name.c_str(), 80) > 1020)
{
std::cerr << "ExtAddrFinder: buffer overrun. The server name \"" << server_name << "\" is too long. This is quite unexpected." << std::endl;
unix_close(sockfd);
return ;
}
if(send(sockfd,request,strlen(request),0)== -1) if(send(sockfd,request,strlen(request),0)== -1)
{ {