Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-05-11 02:25:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix CppCheck in UPnPBase.h

Browse source 
/libretroshare/src/upnp/UPnPBase.cpp:62: warning:
Cppcheck(funcArgOrderDifferent): Function 'CUPnPPortMapping' argument
order different: declaration 'in_port, ex_port, protocol, enabled,
description' definition 'ex_port, in_port, protocol, enabled,
description'
/libretroshare/src/upnp/UPnPBase.h:109: warning:
Cppcheck(noExplicitConstructor): Class 'CUPnPLib' has a constructor with
1 argument that is not explicit.
/libretroshare/src/upnp/UPnPBase.h:577: warning:
Cppcheck(noExplicitConstructor): Class 'CUPnPControlPoint' has a
constructor with 1 argument that is not explicit.
This commit is contained in:
Phenom 2017-07-30 14:41:13 +02:00 • committed by csoler
parent 2933861691
commit 72b917de37
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
libretroshare/src/upnp/UPnPBase.h
View file

@ -66,8 +66,8 @@ private:
public: public:
CUPnPPortMapping( CUPnPPortMapping(
int in_port = 0,
int ex_port = 0, int ex_port = 0,
int in_port = 0,
const std::string &protocol = stdEmptyString, const std::string &protocol = stdEmptyString,
bool enabled = false, bool enabled = false,
const std::string &description = stdEmptyString); const std::string &description = stdEmptyString);
@ -106,7 +106,7 @@ public:
CUPnPControlPoint &m_ctrlPoint; CUPnPControlPoint &m_ctrlPoint;
public: public:
CUPnPLib(CUPnPControlPoint &ctrlPoint); explicit CUPnPLib(CUPnPControlPoint &ctrlPoint);
~CUPnPLib() {} ~CUPnPLib() {}
// Convenience function so we don't have to write explicit calls // Convenience function so we don't have to write explicit calls
@ -574,7 +574,7 @@ public:
CUPnPService *m_WanService; CUPnPService *m_WanService;
std::string m_getStateVariableLastResult; std::string m_getStateVariableLastResult;
static CUPnPControlPoint *s_CtrlPoint; static CUPnPControlPoint *s_CtrlPoint;
CUPnPControlPoint(unsigned short udpPort); explicit CUPnPControlPoint(unsigned short udpPort);
~CUPnPControlPoint(); ~CUPnPControlPoint();
char* getInternalIpAddress(); char* getInternalIpAddress();
std::string getExternalAddress(); std::string getExternalAddress();