From 71a8dba487a15b44c6f04ce9e1e7fc63f8b9498a Mon Sep 17 00:00:00 2001 From: electron128 Date: Wed, 18 Mar 2015 13:36:38 +0000 Subject: [PATCH] GxsGroupDialog: allow to create groups without author git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8044 b45a01b8-16f6-495d-af2f-9b41ad6348cc --- TODO.txt | 4 ++-- retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp | 12 +++--------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/TODO.txt b/TODO.txt index 124eeb717..49b55a315 100644 --- a/TODO.txt +++ b/TODO.txt @@ -9,7 +9,7 @@ Legend: Level | What ------------------------------------------------------------------------------------------------------------------- Posted: -E [ ] it's not possible to create a Posted thread without a Owner. +E [X] it's not possible to create a Posted thread without a Owner. Bug? If not, then remove "No signature" from selection box E [ ] Show an info page for unsubscribed posted threads (same as forums) E [X] Links in Posted cannot be clicked. @@ -17,7 +17,7 @@ M [ ] Fix the counting of unread messages in Posted. Now it's wrong. E [X] Make the GUI of Posted more sexy: more compact items, remove unecessary text, use consistent icons,... Forums -E [ ] it's not possible to create a Forum thread without a Owner. +E [X] it's not possible to create a Forum thread without a Owner. Bug? If not, then remove "No signature" from selection box [X] the tooltip over GXS ids should show the avatar on the left side. [X] fix data race between GXS ID default icons diff --git a/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp b/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp index c5f7d9ddf..8f65a0a99 100644 --- a/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp +++ b/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp @@ -500,15 +500,9 @@ bool GxsGroupDialog::prepareGroupMetaData(RsGroupMetaData &meta) std::cerr << "GxsGroupDialog::prepareGroupMetaData()"; std::cerr << std::endl; - switch (ui.idChooser->getChosenId(meta.mAuthorId)) { - case GxsIdChooser::KnowId: - case GxsIdChooser::UnKnowId: - break; - case GxsIdChooser::NoId: - case GxsIdChooser::None: - default: - return false; - }//switch (ui.idChooser->getChosenId(meta.mAuthorId)) + // here would be the place to check for empty author id + // but GXS_SERV::GRP_OPTION_AUTHEN_AUTHOR_SIGN is currently not used by any service + ui.idChooser->getChosenId(meta.mAuthorId); QString name = getName(); uint32_t flags = GXS_SERV::FLAG_PRIVACY_PUBLIC;