From 6a18e242bb7f97c541cb1204b319913212ea2792 Mon Sep 17 00:00:00 2001
From: csoler <csoler@users.sourceforge.net>
Date: Sat, 11 May 2019 22:25:02 +0200
Subject: [PATCH] added compile option to use sanitizer and already fixed a few
 misalignment errors with it

---
 libbitdht/src/bitdht/bdmsgs.cc                |  5 +++--
 libretroshare/src/file_sharing/p3filelists.cc |  5 ++++-
 libretroshare/src/pqi/p3linkmgr.cc            | 22 ++++++++++++-------
 libretroshare/src/retroshare/rsgxschannels.h  |  2 ++
 libretroshare/src/util/smallobject.h          |  2 +-
 retroshare-gui/src/retroshare-gui.pro         |  4 ++++
 retroshare-nogui/src/retroshare-nogui.pro     |  3 +++
 retroshare.pri                                |  4 ++++
 8 files changed, 35 insertions(+), 12 deletions(-)

diff --git a/libbitdht/src/bitdht/bdmsgs.cc b/libbitdht/src/bitdht/bdmsgs.cc
index 1af0c9814..07114dbab 100644
--- a/libbitdht/src/bitdht/bdmsgs.cc
+++ b/libbitdht/src/bitdht/bdmsgs.cc
@@ -827,9 +827,10 @@ int decodeCompactPeerId(struct sockaddr_in *addr, char *enc, int len)
 
 	memset(addr, 0, sizeof(struct sockaddr_in));
 
-	uint32_t *ip = (uint32_t *) (enc);
+	//uint32_t *ip = (uint32_t *) (enc);
 	uint16_t *port = (uint16_t *) (&enc[4]);
-	addr->sin_addr.s_addr = (*ip); 
+
+    memcpy(& addr->sin_addr.s_addr, enc, sizeof(in_addr_t));  // aligned version of  "addr->sin_addr.s_addr = (*ip); "
 	addr->sin_port = (*port); 
 	addr->sin_family = AF_INET;
 
diff --git a/libretroshare/src/file_sharing/p3filelists.cc b/libretroshare/src/file_sharing/p3filelists.cc
index ff825f691..abaf05560 100644
--- a/libretroshare/src/file_sharing/p3filelists.cc
+++ b/libretroshare/src/file_sharing/p3filelists.cc
@@ -1945,7 +1945,10 @@ p3FileDatabase::DirSyncRequestId p3FileDatabase::makeDirSyncReqId(const RsPeerId
     // This is kind of arbitrary. The important thing is that the same ID needs to be generated every time for a given (peer_id,entry index) pair, in a way
     // that cannot be brute-forced or reverse-engineered, which explains the random bias and the usage of the hash, that is itself random.
 
-    uint64_t r = random_bias ^ *((uint64_t*)tmp.toByteArray()) ;
+    uint64_t tmp2 ;
+    memcpy(&tmp2,tmp.toByteArray(),sizeof(uint64_t));
+
+    uint64_t r = random_bias ^ tmp2;
 
 #ifdef DEBUG_P3FILELISTS
     std::cerr << "Creating ID " << std::hex << r << std::dec << " from peer id " << peer_id << " and hash " << hash << std::endl;
diff --git a/libretroshare/src/pqi/p3linkmgr.cc b/libretroshare/src/pqi/p3linkmgr.cc
index 13796d350..bcef2eed4 100644
--- a/libretroshare/src/pqi/p3linkmgr.cc
+++ b/libretroshare/src/pqi/p3linkmgr.cc
@@ -101,14 +101,20 @@ peerAddrInfo::peerAddrInfo()
 }
 
 peerConnectState::peerConnectState()
-	: connecttype(0),
-	 lastavailable(0),
-         lastattempt(0),
-         name(""),
-         state(0), actions(0),
-	 source(0), 
-	 inConnAttempt(0), 
-	 wasDeniedConnection(false), deniedTS(false), deniedInConnAttempt(false)
+	: dhtVisible(false),
+      connecttype(0),
+      actAsServer(false),
+      lastavailable(0),
+      lastattempt(0),
+      name(""),
+      state(0),
+      actions(0),
+      linkType(0),
+      source(0),
+      inConnAttempt(false),
+      wasDeniedConnection(false),
+      deniedTS(0),
+      deniedInConnAttempt(false)
 {
 }
 
diff --git a/libretroshare/src/retroshare/rsgxschannels.h b/libretroshare/src/retroshare/rsgxschannels.h
index 9ff20cd11..655d87ff2 100644
--- a/libretroshare/src/retroshare/rsgxschannels.h
+++ b/libretroshare/src/retroshare/rsgxschannels.h
@@ -47,6 +47,8 @@ extern RsGxsChannels* rsGxsChannels;
 
 struct RsGxsChannelGroup : RsSerializable
 {
+    RsGxsChannelGroup() : mAutoDownload(false) {}
+
 	RsGroupMetaData mMeta;
 	std::string mDescription;
 	RsGxsImage mImage;
diff --git a/libretroshare/src/util/smallobject.h b/libretroshare/src/util/smallobject.h
index 2f3ac592c..452037ac6 100644
--- a/libretroshare/src/util/smallobject.h
+++ b/libretroshare/src/util/smallobject.h
@@ -61,7 +61,7 @@ namespace RsMemoryManagement
 			
 			inline bool chunkOwnsPointer(const Chunk& c,void *p) const 
 			{ 
-				return p >= c._data && (static_cast<unsigned char *>(p)-c._data)/_blockSize < _numBlocks ; 
+				return intptr_t(p) >= intptr_t(c._data) && (intptr_t(static_cast<unsigned char *>(p))-intptr_t(c._data))/intptr_t(_blockSize)< intptr_t( _numBlocks );
 			}
 
             void printStatistics() const ;
diff --git a/retroshare-gui/src/retroshare-gui.pro b/retroshare-gui/src/retroshare-gui.pro
index 70050a727..a40d29047 100644
--- a/retroshare-gui/src/retroshare-gui.pro
+++ b/retroshare-gui/src/retroshare-gui.pro
@@ -92,6 +92,10 @@ linux-* {
 	DEFINES *= HAVE_XSS # for idle time, libx screensaver extensions
 }
 
+rs_sanitize {
+	LIBS *= -lasan -lubsan
+}
+
 unix {
 	target.path = "$${BIN_DIR}"
 	INSTALLS += target
diff --git a/retroshare-nogui/src/retroshare-nogui.pro b/retroshare-nogui/src/retroshare-nogui.pro
index 8758f36c5..698a4c58e 100644
--- a/retroshare-nogui/src/retroshare-nogui.pro
+++ b/retroshare-nogui/src/retroshare-nogui.pro
@@ -58,6 +58,9 @@ linux-g++-64 {
 	OBJECTS_DIR = temp/linux-g++-64/obj
 }
 
+rs_sanitize {
+	LIBS *= -lasan -lubsan
+}
 #################### Cross compilation for windows under Linux ###################
 
 win32-x-g++ {
diff --git a/retroshare.pri b/retroshare.pri
index 2d8130084..6cb2b3d21 100644
--- a/retroshare.pri
+++ b/retroshare.pri
@@ -461,6 +461,10 @@ rs_onlyhiddennode {
     message("QMAKE: You have enabled only hidden node.")
 }
 
+rs_sanitize {
+	QMAKE_CXXFLAGS *= -fsanitize=address -fsanitize=bounds -fsanitize=undefined
+}
+
 no_rs_deprecatedwarning {
     QMAKE_CXXFLAGS += -Wno-deprecated
     QMAKE_CXXFLAGS += -Wno-deprecated-declarations