Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2024-10-01 02:35:48 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixed core dump issue where AuthSSL::VerifySignBin() is called with NULL parameters. Still, this should not happen.

Browse Source 
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@1624 b45a01b8-16f6-495d-af2f-9b41ad6348cc
This commit is contained in:
csoler 2009-09-09 11:22:44 +00:00
parent 3b3c7c7ba4
commit 64a06fd0bb
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libretroshare/src/pqi/authssl.cc
View File

@ -1217,6 +1217,10 @@ bool AuthSSL::VerifySignBin(std::string pid,
} }
EVP_PKEY *peerkey = peer->certificate->cert_info->key->pkey; EVP_PKEY *peerkey = peer->certificate->cert_info->key->pkey;
if(peerkey == NULL)
return false ;
EVP_MD_CTX *mdctx = EVP_MD_CTX_create(); EVP_MD_CTX *mdctx = EVP_MD_CTX_create();
if (0 == EVP_VerifyInit(mdctx, EVP_sha1())) if (0 == EVP_VerifyInit(mdctx, EVP_sha1()))
@ -1235,6 +1239,12 @@ bool AuthSSL::VerifySignBin(std::string pid,
return false; return false;
} }
if(signlen == 0 || sign == NULL)
{
EVP_MD_CTX_destroy(mdctx);
return false ;
}
if (0 == EVP_VerifyFinal(mdctx, sign, signlen, peerkey)) if (0 == EVP_VerifyFinal(mdctx, sign, signlen, peerkey))
{ {
std::cerr << "EVP_VerifyFinal Failure!" << std::endl; std::cerr << "EVP_VerifyFinal Failure!" << std::endl;