Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-06-07 14:12:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix CppCheck in rsettings.cpp

Browse source 
/retroshare-gui/src/gui/settings/rsettings.cpp:43: warning:
Cppcheck(passedByValue): Function parameter 'fileName' should be passed
by reference.
This commit is contained in:
Phenom 2017-08-13 20:44:34 +02:00 • committed by csoler
parent 5554f4a739
commit 589e61ff67
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
retroshare-gui/src/gui/settings/rsettings.cpp
View file

@ -40,7 +40,7 @@ RSettings::RSettings(const QString settingsGroup)
beginGroup(settingsGroup); beginGroup(settingsGroup);
} }
RSettings::RSettings(std::string fileName, const QString settingsGroup) RSettings::RSettings(const std::string &fileName, const QString settingsGroup)
: QSettings(QString::fromStdString(fileName), QSettings::IniFormat) : QSettings(QString::fromStdString(fileName), QSettings::IniFormat)
{ {
m_bValid = true; m_bValid = true;

2
retroshare-gui/src/gui/settings/rsettings.h
View file

@ -40,7 +40,7 @@ public:
/** Default constructor. The optional parameter <b>group</b> can be used to /** Default constructor. The optional parameter <b>group</b> can be used to
* set a prefix that will be prepended to keys specified to RSettings in * set a prefix that will be prepended to keys specified to RSettings in
* value() and setValue(). */ * value() and setValue(). */
RSettings(std::string fileName, const QString group = QString()); RSettings(const std::string &fileName, const QString group = QString());
/** Resets all settings. */ /** Resets all settings. */
static void reset(); static void reset();