From 4124585b558444c7998d4ce088496031e5b52018 Mon Sep 17 00:00:00 2001 From: csoler Date: Sat, 29 Feb 2020 12:14:37 +0100 Subject: [PATCH] removed unused print methods in some RsItems since now print is handled by serializer --- libretroshare/src/chat/rschatitems.h | 2 -- libretroshare/src/gxstrans/p3gxstransitems.h | 2 -- libretroshare/src/rsitems/rsnxsitems.cc | 3 --- libretroshare/src/rsitems/rsnxsitems.h | 1 - plugins/FeedReader/services/rsFeedReaderItems.cc | 5 ----- .../libretroshare/gxs/gen_exchange/rsdummyservices.h | 2 -- 6 files changed, 15 deletions(-) diff --git a/libretroshare/src/chat/rschatitems.h b/libretroshare/src/chat/rschatitems.h index 244be60b2..c08b35231 100644 --- a/libretroshare/src/chat/rschatitems.h +++ b/libretroshare/src/chat/rschatitems.h @@ -99,8 +99,6 @@ class RsChatItem: public RsItem } virtual ~RsChatItem() {} - virtual std::ostream& print(std::ostream &out, uint16_t /*indent*/ = 0) { return out; } // derived from RsItem, but should be removed - virtual void clear() {} }; diff --git a/libretroshare/src/gxstrans/p3gxstransitems.h b/libretroshare/src/gxstrans/p3gxstransitems.h index cc7322844..f2cab3cfe 100644 --- a/libretroshare/src/gxstrans/p3gxstransitems.h +++ b/libretroshare/src/gxstrans/p3gxstransitems.h @@ -181,8 +181,6 @@ public: {} void clear() {} - std::ostream &print(std::ostream &out, uint16_t /*indent = 0*/) - { return out; } }; class RsGxsTransSerializer; diff --git a/libretroshare/src/rsitems/rsnxsitems.cc b/libretroshare/src/rsitems/rsnxsitems.cc index ab596a99b..7331bbaf5 100644 --- a/libretroshare/src/rsitems/rsnxsitems.cc +++ b/libretroshare/src/rsitems/rsnxsitems.cc @@ -173,9 +173,6 @@ void RsNxsMsg::clear() meta.TlvClear(); } -std::ostream&RsNxsMsg::print(std::ostream& out, uint16_t /*indent*/) -{ return out; } - void RsNxsGrp::clear() { grpId.clear(); diff --git a/libretroshare/src/rsitems/rsnxsitems.h b/libretroshare/src/rsitems/rsnxsitems.h index 56920a058..269f9c49a 100644 --- a/libretroshare/src/rsitems/rsnxsitems.h +++ b/libretroshare/src/rsitems/rsnxsitems.h @@ -378,7 +378,6 @@ struct RsNxsMsg : RsNxsItem RsGenericSerializer::SerializeContext& ctx ); virtual void clear(); - virtual std::ostream &print(std::ostream& out, uint16_t indent); uint8_t pos; /// used for splitting up msg uint8_t count; /// number of split up messages diff --git a/plugins/FeedReader/services/rsFeedReaderItems.cc b/plugins/FeedReader/services/rsFeedReaderItems.cc index 538f8ff93..a88abad17 100644 --- a/plugins/FeedReader/services/rsFeedReaderItems.cc +++ b/plugins/FeedReader/services/rsFeedReaderItems.cc @@ -60,11 +60,6 @@ void RsFeedReaderFeed::clear() content.clear(); } -std::ostream &RsFeedReaderFeed::print(std::ostream &out, uint16_t /*indent*/) -{ - return out; -} - uint32_t RsFeedReaderSerialiser::sizeFeed(RsFeedReaderFeed *item) { uint32_t s = 8; /* header */ diff --git a/tests/unittests/libretroshare/gxs/gen_exchange/rsdummyservices.h b/tests/unittests/libretroshare/gxs/gen_exchange/rsdummyservices.h index a4f09ca1c..f4fd05bac 100644 --- a/tests/unittests/libretroshare/gxs/gen_exchange/rsdummyservices.h +++ b/tests/unittests/libretroshare/gxs/gen_exchange/rsdummyservices.h @@ -64,7 +64,6 @@ public: std::string msgData; - std::ostream &print(std::ostream &out, uint16_t /*indent*/ = 0){ return out; } void clear() { msgData.clear(); } }; @@ -79,7 +78,6 @@ public: std::string grpData; void clear() { grpData.clear(); } - std::ostream &print(std::ostream &out, uint16_t /*indent*/ = 0){ return out; } };