Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-03-19 13:36:03 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

updated TODO(circles), removed useless context menu, added tooltips for circle distribution options

Browse Source
This commit is contained in:
csoler 2016-03-09 20:53:49 -05:00
parent 4eebe24ee2
commit 3fc6f6b2db
3 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
TODO.circles.txt
View File

@ -6,7 +6,8 @@ GUI
[X] make GUI update when creating a circle
[ ] handle the display of encrypted forums/channels/etc when we do not have the keys
[ ] disable posting to circles for which we do not have the rights
[ ] group "show details" should be made up to date for rstrinction options
[ ] warn about creating a circle without one of your ids in it
[ ] group "show details" should be made up to date for restrinction options
[ ] allow to share circles publish rights
Tests
@ -17,16 +18,16 @@ Tests
[-] test #004: peers subscribed to encrypted circles shouldn't keep asking for the data if they cannot decrypt
[X] test #005: peers can be added/removed from circles, and the circles update between friends
[ ] test #006: peers subscribed to encrypted circles who recently got added to the circle should get the data
[ ] test #007: peers outside shouldn't be able to post (or posts shouldn't propagate)
[ ] test #007: peers outside a circle shouldn't be able to post (or posts shouldn't propagate)
Backend
[X] add debug output later RS_NXS_DEBUG_7 in rsgxsnetservice.cc for the crypto layer
Bugs
[X] Peers cannot be removed from a circle
[ ] Context menu should not allow to edit non admin circles
[X] Context menu should not allow to edit non admin circles
[ ] Editing circles make them subscribed, even non admin ones.
[ ] Disable autosync for circles (in rsinit.cc)
[ ] Add explicit circle sync request for all grps restricted to a circle (same as IDs)
[X] Disable autosync for circles (in rsinit.cc)
[-] Add explicit circle sync request for all grps restricted to a circle (same as IDs)

17
retroshare-gui/src/gui/Circles/CreateCircleDialog.ui
View File

@ -6,7 +6,7 @@
<rect>
<x>0</x>
<y>0</y>
<width>681</width>
<width>881</width>
<height>515</height>
</rect>
</property>
@ -266,7 +266,11 @@
</widget>
</item>
<item>
<widget class="GxsIdChooser" name="idChooser"/>
<widget class="GxsIdChooser" name="idChooser">
<property name="toolTip">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;The creator of a circle does not need to be known. It is however useful for public circles so that people know to whom to send a request for membership.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
</widget>
</item>
</layout>
</item>
@ -300,6 +304,9 @@
</item>
<item>
<widget class="QRadioButton" name="radioButton_Public">
<property name="toolTip">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Publicly distributed circles are visible to your friends, which will get to know the circle data (Creator, members, etc)&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
<property name="text">
<string>Public</string>
</property>
@ -307,6 +314,9 @@
</item>
<item>
<widget class="QRadioButton" name="radioButton_Self">
<property name="toolTip">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Self-restricted circles (the very existance of the circle, and its actual content) are only visible to the members of these circles. In practice the circle uses itself to limit its own distribution. &lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
<property name="text">
<string>Self-Restricted</string>
</property>
@ -314,6 +324,9 @@
</item>
<item>
<widget class="QRadioButton" name="radioButton_Restricted">
<property name="toolTip">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Circles can be restricted to the members of another circle. Only the members of that second circle will be allowed to see the new circle and its content (list of members, etc).&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
<property name="text">
<string>Restricted to:</string>
</property>

3
retroshare-gui/src/gui/Identity/IdDialog.cpp
View File

@ -387,6 +387,8 @@ void IdDialog::editExistingCircle()
void IdDialog::CircleListCustomPopupMenu( QPoint )
{
// (cyril) Removed this because we have a edit button already.
#ifdef SUSPENDED
QMenu contextMnu( this );
QTreeWidgetItem *item = ui->treeWidget_membership->currentItem();
@ -397,6 +399,7 @@ void IdDialog::CircleListCustomPopupMenu( QPoint )
}
contextMnu.exec(QCursor::pos());
#endif
}
static void set_item_background(QTreeWidgetItem *item, uint32_t type)