From 3c583f67244397d7ce31a62941bcab25ac79166f Mon Sep 17 00:00:00 2001 From: csoler Date: Wed, 12 Apr 2023 23:11:45 +0200 Subject: [PATCH] fixed crash due to calling a method in board item after deletion --- retroshare-gui/src/gui/feeds/BoardsCommentsItem.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/retroshare-gui/src/gui/feeds/BoardsCommentsItem.cpp b/retroshare-gui/src/gui/feeds/BoardsCommentsItem.cpp index 02af1afc3..684b85e54 100644 --- a/retroshare-gui/src/gui/feeds/BoardsCommentsItem.cpp +++ b/retroshare-gui/src/gui/feeds/BoardsCommentsItem.cpp @@ -287,14 +287,13 @@ void BaseBoardsCommentsItem::readToggled(bool checked) return; } + setReadStatus(false, checked); // Can't call this inside an async call since the widget may be destroyed afterwards! + // So we do it right away. + RsThread::async( [this,checked]() { RsGxsGrpMsgIdPair msgPair = std::make_pair(groupId(), messageId()); rsPosted->setCommentReadStatus(msgPair, !checked); - - RsQThreadUtils::postToObject( [this,checked]() { - setReadStatus(false, checked); - } ); }); }