From 350a3da3592c992d2c4adb26e3a8201f3e902f12 Mon Sep 17 00:00:00 2001 From: csoler Date: Mon, 1 Dec 2025 22:33:19 +0100 Subject: [PATCH] added comment about plugin confirmation GUI code --- retroshare-gui/src/gui/RsGUIEventManager.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/retroshare-gui/src/gui/RsGUIEventManager.cpp b/retroshare-gui/src/gui/RsGUIEventManager.cpp index 7ff3cff8c..82d66e799 100644 --- a/retroshare-gui/src/gui/RsGUIEventManager.cpp +++ b/retroshare-gui/src/gui/RsGUIEventManager.cpp @@ -174,6 +174,9 @@ bool RsGUIEventManager::GUI_askForPassword(const std::string& title, const std:: bool RsGUIEventManager::GUI_askForPluginConfirmation(const std::string& plugin_file_name, const RsFileHash& plugin_file_hash, bool first_time) { // By default, when no information is known about plugins, just dont load them. They will be enabled from the GUI by the user. + // Note: the code below is not running in the Qt thread, which is likely to cause a crash. If needed, we should use + // the same mechanism than GUI_askForPassword. As far as testing goes, it seems that because there is no other window running + // at the time plugin confirmation is required, this is not a problem for Qt. if(first_time) return false ;