Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-09-21 05:14:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

removed unused method for OutQueue statistics; improved BW curve display; fixed a few display bugs

Browse source
This commit is contained in:
csoler 2015-07-17 22:13:31 +02:00 • committed by cave beat
parent bdad800509
commit 2a47095599
18 changed files with 153 additions and 109 deletions
Download patch file Download diff file Expand all files Collapse all files

114
retroshare-gui/src/gui/statistics/BWGraph.cpp
View file

@ -1,6 +1,9 @@
#include "BWGraph.h"
#include <time.h>
#include <math.h>
#include "retroshare/rsservicecontrol.h"
#include "retroshare/rspeers.h"
//#define BWGRAPH_DEBUG 1
@ -23,20 +26,35 @@ void BWGraphSource::update()
thc.time_stamp = getTime() ;
mTrafficHistory.push_back(thc) ;
std::set<RsPeerId> fds ;
// add visible friends/services
for(std::list<RSTrafficClue>::const_iterator it(thc.out_rstcl.begin());it!=thc.out_rstcl.end();++it)
{
mVisibleFriends.insert(it->peer_id) ;
fds.insert(it->peer_id) ;
mVisibleServices.insert(it->service_id) ;
}
for(std::list<RSTrafficClue>::const_iterator it(thc.in_rstcl.begin());it!=thc.in_rstcl.end();++it)
{
mVisibleFriends.insert(it->peer_id) ;
fds.insert(it->peer_id) ;
mVisibleServices.insert(it->service_id) ;
}
for(std::set<RsPeerId>::const_iterator it(fds.begin());it!=fds.end();++it)
{
std::string& s(mVisibleFriends[*it]) ;
if(s.empty())
{
RsPeerDetails pd ;
rsPeers->getPeerDetails(*it,pd) ;
s = pd.name + " (" + pd.location + ")" ;
}
}
#ifdef BWGRAPH_DEBUG
std::cerr << " visible friends: " << std::dec << mVisibleFriends.size() << std::endl;
std::cerr << " visible service: " << std::dec << mVisibleServices.size() << std::endl;
@ -49,12 +67,25 @@ void BWGraphSource::update()
qint64 ms = getTime() ;
std::set<std::string> unused_vals ;
for(std::map<std::string,std::list<std::pair<qint64,float> > >::const_iterator it=_points.begin();it!=_points.end();++it)
unused_vals.insert(it->first) ;
for(std::map<std::string,float>::iterator it=vals.begin();it!=vals.end();++it)
{
std::list<std::pair<qint64,float> >& lst(_points[it->first]) ;
if(!lst.empty() && fabsf(lst.back().first - ms) > _update_period_msecs*1.2 )
{
lst.push_back(std::make_pair(lst.back().first,0)) ;
lst.push_back(std::make_pair( ms,0)) ;
}
lst.push_back(std::make_pair(ms,it->second)) ;
unused_vals.erase(it->first) ;
for(std::list<std::pair<qint64,float> >::iterator it2=lst.begin();it2!=lst.end();)
if( ms - (*it2).first > _time_limit_msecs)
{
@ -65,6 +96,11 @@ void BWGraphSource::update()
break ;
}
// make sure that all values are fed.
for(std::set<std::string>::const_iterator it(unused_vals.begin());it!=unused_vals.end();++it)
_points[*it].push_back(std::make_pair(ms,0)) ;
// remove empty lists
for(std::map<std::string,std::list<std::pair<qint64,float> > >::iterator it=_points.begin();it!=_points.end();)
@ -122,7 +158,7 @@ void BWGraphSource::convertTrafficClueToValues(const std::list<RSTrafficClue>& l
for(uint32_t i=0;i<256;++i)
if(clue_per_sub_id[i].count > 0)
vals[QString::number(i,16).toStdString()] = (_current_unit == UNIT_KILOBYTES)?(clue_per_sub_id[i].size/1000.0f):(clue_per_sub_id[i].count) ;
vals["item #"+QString::number(i,16).toStdString()] = (_current_unit == UNIT_KILOBYTES)?(clue_per_sub_id[i].size):(clue_per_sub_id[i].count) ;
}
break ;
@ -135,7 +171,7 @@ void BWGraphSource::convertTrafficClueToValues(const std::list<RSTrafficClue>& l
clue_per_id[it->service_id] += *it ;
for(std::map<uint16_t,RSTrafficClue>::const_iterator it(clue_per_id.begin());it!=clue_per_id.end();++it)
vals[QString::number(it->first,16).toStdString()] = (_current_unit == UNIT_KILOBYTES)?(it->second.size/1000.0f):(it->second.count) ;
vals[mServiceInfoMap[it->first].mServiceName] = (_current_unit == UNIT_KILOBYTES)?(it->second.size):(it->second.count) ;
}
break ;
case GRAPH_TYPE_SUM: // single friend, sum services => one curve
@ -147,7 +183,7 @@ void BWGraphSource::convertTrafficClueToValues(const std::list<RSTrafficClue>& l
if(it->peer_id == _current_selected_friend)
total += *it ;
vals[_current_selected_friend_name] = (_current_unit == UNIT_KILOBYTES)?(total.size/1000.0f):(total.count) ;
vals[visibleFriendName(_current_selected_friend)] = (_current_unit == UNIT_KILOBYTES)?(total.size):(total.count) ;
}
}
break ;
@ -164,7 +200,7 @@ void BWGraphSource::convertTrafficClueToValues(const std::list<RSTrafficClue>& l
clue_per_peer_id[it->peer_id] += *it ;
for(std::map<RsPeerId,RSTrafficClue>::const_iterator it(clue_per_peer_id.begin());it!=clue_per_peer_id.end();++it)
vals[it->first.toStdString()] = (_current_unit == UNIT_KILOBYTES)?(it->second.size/1000.0f):(it->second.count) ;
vals[visibleFriendName(it->first)] = (_current_unit == UNIT_KILOBYTES)?(it->second.size):(it->second.count) ;
}
break ;
@ -178,7 +214,7 @@ void BWGraphSource::convertTrafficClueToValues(const std::list<RSTrafficClue>& l
clue_per_peer_id[it->peer_id] += *it;
for(std::map<RsPeerId,RSTrafficClue>::const_iterator it(clue_per_peer_id.begin());it!=clue_per_peer_id.end();++it)
vals[it->first.toStdString()] = (_current_unit == UNIT_KILOBYTES)?(it->second.size/1000.0f):(it->second.count) ;
vals[visibleFriendName(it->first)] = (_current_unit == UNIT_KILOBYTES)?(it->second.size):(it->second.count) ;
}
break ;
}
@ -197,7 +233,7 @@ void BWGraphSource::convertTrafficClueToValues(const std::list<RSTrafficClue>& l
for(uint32_t i=0;i<256;++i)
if(clue_per_sub_id[i].count > 0)
vals[QString::number(i,16).toStdString()] = (_current_unit == UNIT_KILOBYTES)?(clue_per_sub_id[i].size/1000.0f):(clue_per_sub_id[i].count) ;
vals["item #"+QString::number(i,16).toStdString()] = (_current_unit == UNIT_KILOBYTES)?(clue_per_sub_id[i].size):(clue_per_sub_id[i].count) ;
}
break ;
@ -209,7 +245,7 @@ void BWGraphSource::convertTrafficClueToValues(const std::list<RSTrafficClue>& l
clue_per_service[it->service_id] += *it;
for(std::map<uint16_t,RSTrafficClue>::const_iterator it(clue_per_service.begin());it!=clue_per_service.end();++it)
vals[QString::number(it->first,16).toStdString()] = (_current_unit == UNIT_KILOBYTES)?(it->second.size/1000.0f):(it->second.count) ;
vals[mServiceInfoMap[it->first].mServiceName] = (_current_unit == UNIT_KILOBYTES)?(it->second.size):(it->second.count) ;
}
break ;
@ -220,7 +256,7 @@ void BWGraphSource::convertTrafficClueToValues(const std::list<RSTrafficClue>& l
for(std::list<RSTrafficClue>::const_iterator it(lst.begin());it!=lst.end();++it)
total += *it;
vals[QString("Total").toStdString()] = (_current_unit == UNIT_KILOBYTES)?(total.size/1000.0f):(total.count) ;
vals[QString("Total").toStdString()] = (_current_unit == UNIT_KILOBYTES)?(total.size):(total.count) ;
}
break ;
}
@ -228,6 +264,16 @@ void BWGraphSource::convertTrafficClueToValues(const std::list<RSTrafficClue>& l
}
}
std::string BWGraphSource::visibleFriendName(const RsPeerId& pid) const
{
std::map<RsPeerId,std::string>::const_iterator it = mVisibleFriends.find(pid) ;
if(it != mVisibleFriends.end())
return it->second;
else
return std::string("[unknown]") ;
}
BWGraphSource::BWGraphSource()
: RSGraphSource()
{
@ -243,6 +289,11 @@ BWGraphSource::BWGraphSource()
_current_unit = UNIT_KILOBYTES;
_current_direction = DIRECTION_UP;
RsPeerServiceInfo rspsi ;
rsServiceControl->getOwnServices(rspsi) ;
for(std::map<uint32_t,RsServiceInfo>::const_iterator it(rspsi.mServiceList.begin());it!=rspsi.mServiceList.end();++it)
mServiceInfoMap[ (it->first >> 8) & 0xffff ] = it->second ;
}
void BWGraphSource::getValues(std::map<std::string,float>& values) const
@ -259,6 +310,27 @@ void BWGraphSource::getValues(std::map<std::string,float>& values) const
QString BWGraphSource::unitName() const { return (_current_unit == UNIT_KILOBYTES)?tr("KB/s"):QString(); }
//QString BWGraphSource::displayName(int i) const
//{
// int n=0;
// for(std::map<std::string,std::list<std::pair<qint64,float> > >::const_iterator it = _points.begin();it!=_points.end() ;++it)
// if(n++ == i)
// {
// // find out what is displayed
//
// if(_service_graph_type == GRAPH_TYPE_SINGLE )
// if(_friend_graph_type != GRAPH_TYPE_ALL)
// return QString::fromStdString(it->first) ;// sub item
// else
// return QString::fromStdString(mVisibleFriends[RsPeerId(it->first)]) ;// peer id item
// else
//
//
// }
//
// return QString("[error]");
//}
QString BWGraphSource::displayValue(float v) const
{
if(_current_unit == UNIT_KILOBYTES)
@ -285,10 +357,7 @@ QString BWGraphSource::displayValue(float v) const
QString BWGraphSource::legend(int i,float v) const
{
if(i==0)
return RSGraphSource::legend(i,v) + " Total: " + niceNumber(_total_recv) ;
else
return RSGraphSource::legend(i,v) + " Total: " + niceNumber(_total_sent) ;
return RSGraphSource::legend(i,v) ;//+ " Total: " + niceNumber(_total_recv) ;
}
QString BWGraphSource::niceNumber(float v) const
{
@ -304,7 +373,9 @@ QString BWGraphSource::niceNumber(float v) const
void BWGraphSource::setSelector(int selector_type,int graph_type,const std::string& selector_client_string)
{
#ifdef BWGRAPH_DEBUG
std::cerr << "Setting Graph Source selector to " << selector_type << " - " << graph_type << " - " << selector_client_string << std::endl;
#endif
bool changed = false ;
@ -382,27 +453,42 @@ void BWGraphSource::setDirection(int dir)
}
void BWGraphSource::recomputeCurrentCurves()
{
#ifdef BWGRAPH_DEBUG
std::cerr << "BWGraphSource: recomputing current curves." << std::endl;
#endif
_points.clear() ;
// now, convert data to current curve points.
std::set<std::string> used_values_ref ;
for(std::list<TrafficHistoryChunk>::const_iterator it(mTrafficHistory.begin());it!=mTrafficHistory.end();++it)
{
std::map<std::string,float> vals ;
qint64 ms = (*it).time_stamp ;
std::set<std::string> unused_values = used_values_ref ;
if(_current_direction==DIRECTION_UP)
convertTrafficClueToValues((*it).out_rstcl,vals) ;
else
convertTrafficClueToValues((*it).in_rstcl,vals) ;
for(std::map<std::string,float>::iterator it2=vals.begin();it2!=vals.end();++it2)
{
_points[it2->first].push_back(std::make_pair(ms,it2->second)) ;
used_values_ref.insert(it2->first) ;
unused_values.erase(it2->first) ;
}
for(std::set<std::string>::const_iterator it(unused_values.begin());it!=unused_values.end();++it)
_points[*it].push_back(std::make_pair(ms,0)) ;
}
#ifdef BWGRAPH_DEBUG
std::cerr << " points() contains " << _points.size() << " curves." << std::endl;
#endif
}
BWGraph::BWGraph(QWidget *parent) : RSGraphWidget(parent)

12
retroshare-gui/src/gui/statistics/BWGraph.h
View file

@ -1,6 +1,7 @@
#pragma once
#include "retroshare/rsconfig.h"
#include "retroshare/rsservicecontrol.h"
#include <gui/common/RSGraphWidget.h>
class BWGraphSource: public RSGraphSource
@ -24,6 +25,7 @@ public:
virtual void getValues(std::map<std::string,float>& values) const;
virtual QString displayValue(float v) const;
// virtual QString displayName(int i) const;
virtual QString legend(int i,float v) const;
virtual void update();
QString unitName() const ;
@ -39,12 +41,13 @@ public:
int friendGraphType() const { return _friend_graph_type ;}
int serviceGraphType() const { return _service_graph_type ;}
const std::set<RsPeerId>& visibleFriends() const { return mVisibleFriends; }
const std::map<RsPeerId,std::string>& visibleFriends() const { return mVisibleFriends; }
const std::set<uint16_t>& visibleServices() const { return mVisibleServices; }
protected:
void convertTrafficClueToValues(const std::list<RSTrafficClue> &lst, std::map<std::string, float> &vals) const;
void recomputeCurrentCurves() ;
std::string visibleFriendName(const RsPeerId &pid) const ;
private:
QString niceNumber(float v) const;
@ -56,15 +59,16 @@ private:
int _service_graph_type ;
RsPeerId _current_selected_friend ;
std::string _current_selected_friend_name ;
uint16_t _current_selected_service ;
int _current_unit ;
int _current_direction ;
std::list<TrafficHistoryChunk> mTrafficHistory ;
std::set<RsPeerId> mVisibleFriends ;
std::map<RsPeerId,std::string> mVisibleFriends ;
std::set<uint16_t> mVisibleServices ;
mutable std::map<uint16_t,RsServiceInfo> mServiceInfoMap ;
};
class BWGraph: public RSGraphWidget
@ -74,7 +78,7 @@ class BWGraph: public RSGraphWidget
BWGraphSource *source() ;
const std::set<RsPeerId>& visibleFriends() const { return _local_source->visibleFriends(); }
const std::map<RsPeerId,std::string>& visibleFriends() const { return _local_source->visibleFriends(); }
const std::set<uint16_t>& visibleServices() const { return _local_source->visibleServices(); }
protected:
BWGraphSource *_local_source ;

32
retroshare-gui/src/gui/statistics/BandwidthStatsWidget.cpp
View file

@ -2,6 +2,7 @@
#include <QTimer>
#include "retroshare/rspeers.h"
#include "retroshare/rsservicecontrol.h"
#include "util/RsProtectedTimer.h"
#include "retroshare-gui/RsAutoUpdatePage.h"
#include "BandwidthStatsWidget.h"
@ -52,23 +53,23 @@ void BandwidthStatsWidget::updateComboBoxes()
// Setup button/combobox info
uint32_t indx = 2 ;
RsPeerDetails details ;
//RsPeerDetails details ;
RsPeerId current_friend_id(ui.friend_CB->itemData(ui.friend_CB->currentIndex()).toString().toStdString()) ;
for(std::set<RsPeerId>::const_iterator it(ui.bwgraph_BW->visibleFriends().begin());it!=ui.bwgraph_BW->visibleFriends().end();++it)
for(std::map<RsPeerId,std::string>::const_iterator it(ui.bwgraph_BW->visibleFriends().begin());it!=ui.bwgraph_BW->visibleFriends().end();++it)
{
if( (*it).toStdString() != ui.friend_CB->itemData(indx).toString().toStdString())
if( it->first.toStdString() != ui.friend_CB->itemData(indx).toString().toStdString())
{
std::cerr << " friends: " << *it << " not in combo at place " << indx << ". Adding it." << std::endl;
std::cerr << " friends: " << it->first << " not in combo at place " << indx << ". Adding it." << std::endl;
QString name = "[Unknown]" ;
QString name = QString::fromUtf8(it->second.c_str()) ;
QVariant data ;
if(rsPeers->getPeerDetails(*it,details))
{
name = QString::fromUtf8(details.name.c_str())+" ("+QString::fromUtf8(details.location.c_str())+")" ;
data = QVariant(QString::fromStdString( (*it).toStdString())) ;
}
//if(rsPeers->getPeerDetails(*it,details))
//{
// name = QString::fromUtf8(details.name.c_str())+" ("+QString::fromUtf8(details.location.c_str())+")" ;
data = QVariant(QString::fromStdString( (it->first).toStdString())) ;
//}
if(ui.friend_CB->count() <= indx)
ui.friend_CB->addItem(name,data) ;
@ -78,7 +79,7 @@ void BandwidthStatsWidget::updateComboBoxes()
ui.friend_CB->setItemData(indx,data) ;
}
if(current_friend_id == *it && ui.friend_CB->currentIndex() != indx)
if(current_friend_id == it->first && ui.friend_CB->currentIndex() != indx)
ui.friend_CB->setCurrentIndex(indx) ;
}
++indx ;
@ -92,6 +93,9 @@ void BandwidthStatsWidget::updateComboBoxes()
// now one entry per service
RsPeerServiceInfo service_info_map ;
rsServiceControl->getOwnServices(service_info_map) ;
indx = 2 ;
uint16_t current_service_id = ui.service_CB->itemData(ui.service_CB->currentIndex()).toInt() ;
@ -99,13 +103,13 @@ void BandwidthStatsWidget::updateComboBoxes()
{
if(*it != ui.service_CB->itemData(indx).toInt())
{
std::cerr << " services: " << std::hex << *it << std::dec << " not in combo at place " << indx << ". Adding it." << std::endl;
QString sname = QString::fromUtf8(service_info_map.mServiceList[ ((*it)<<8) + 0x02000000].mServiceName.c_str()) ;
if(ui.service_CB->count() <= indx)
ui.service_CB->addItem(QString::number(*it,16),QVariant(*it)) ;
ui.service_CB->addItem(sname + " (0x"+QString::number(*it,16)+")",QVariant(*it)) ;
else
{
ui.service_CB->setItemText(indx,QString::number(*it,16)) ;
ui.service_CB->setItemText(indx,sname + " (0x"+QString::number(*it,16)+")") ;
ui.service_CB->setItemData(indx,QVariant(*it)) ;
}

5
retroshare-gui/src/gui/statistics/BwCtrlWindow.cpp
View file

@ -220,11 +220,6 @@ void BwCtrlWindow::updateDisplay()
}
updateBandwidth();
OutQueueStatistics stats ;
rsConfig->getOutQueueStatistics(stats) ;
//_outqueue_stats_W->updateStatistics(stats) ;
}
void BwCtrlWindow::updateBandwidth()

2
retroshare-gui/src/gui/statistics/OutQueueStatistics.cpp
View file

@ -35,7 +35,7 @@ static QString serviceName(uint16_t s)
case /* RS_SERVICE_TYPE_BWCTRL */ 0x0021: return QString("BdwCtrl") ;
case /* RS_SERVICE_TYPE_BANLIST */ 0x0101: return QString("BanList") ;
case /* RS_SERVICE_TYPE_STATUS */ 0x0102: return QString("Status") ;
case /* RS_SERVICE_TYPE_NXS */ 0x0200: return QString("Nxs") ;
case /* RS_SERVICE_TYPE_NXS */ 0x0200: return QString("Nxs") ;
case /* RS_SERVICE_GXS_TYPE_GXSID */ 0x0211: return QString("Gxs Ids") ;
case /* RS_SERVICE_GXS_TYPE_PHOTO */ 0x0212: return QString("Gxs Photo") ;
case /* RS_SERVICE_GXS_TYPE_WIKI */ 0x0213: return QString("Gxs Wiki") ;